Synchronet Git Commit Log

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Write the global sound (WAV) file settings in sbbs_write_ini().

Modified Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore sbbsctrl.str output file.

Added Files:


src/sbbs3/ctrl/SoundCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/SoundCfgDlgUnit.h
diff

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/FtpCfgDlgUnit.h
diff

src/sbbs3/ctrl/MailCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/MailCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/MailCfgDlgUnit.h
diff

src/sbbs3/ctrl/PropertiesDlgUnit.cpp
diff

src/sbbs3/ctrl/PropertiesDlgUnit.dfm
diff

src/sbbs3/ctrl/PropertiesDlgUnit.h
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.h
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.h
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.dfm
diff

src/sbbs3/ctrl/WebCfgDlgUnit.h
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/ctrl/sbbsctrl.cpp
diff

src/sbbs3/ctrl/sbbsctrl.res
diff

Move all common sound (WAV) file configuration to its own dialog

Increment the version in the project file to v3.19a.

Added Files:


src/sbbs3/ctrl/.gitignore
diff

Ignore more C++Builder artifact files.

Modified Files:


src/sbbs3/ctrl/MainFormUnit.dfm
diff

Disable ChangeDir functionality of SaveDialog

This would cause all relative file paths to fail after exporting
settings to .ini file in another directory. Long time bug.

Modified Files:


src/sbbs3/ctrl/FtpCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/ServicesCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp
diff

src/sbbs3/ctrl/WebCfgDlgUnit.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/login.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.h
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

src/sbbs3/startup.h
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.h
diff

src/sbbs3/xtrn_sec.cpp
diff

Update sound (WAV) file play-on-event support in Windows build

A "hack attempt" sound file is now supported in the Terminal Server, Mail
Server,  and Services.

"login" and "logoff" sound files are now supported in the Terminal Server, FTP
Server, Web Server, Mail Server, and Services.
This enhancement fixes Issue #157

The following sound files may now be configured in the [Global] section of the
ctrl/sbbs.ini file, if desired to set the default sound files for all
servers/services in on place:
- AnswerSound
- LoginSound
- LogoutSound
- HangupSound
- HackAttemptSound

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Fix typo in previous commit.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/services.c
diff

src/sbbs3/services.h
diff

Allow an alternate "services.ini" filename to be specified in sbbs.ini

Set sbbs.ini [services] iniFileName to something other than services.ini to
override the default filename. The automatic/optional hostname decoration of
the filename is still supported.

Addresses request #238.

Modified Files:


exec/hatchit.js
diff

Added "Replaces" keyword support for Al (TRMB)

Made some other cosmetic improvements/fixes.

Modified Files:


ctrl/text.dat
diff

Added FiUploadedTo string.

Modified Files:


src/uifc/uifc32.c
diff

Support WIN_ORG and WIN_BOT modes in uifc.input

Modified Files:


src/sbbs3/file.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Display list of file recipients ("Uploaded to") when relevant

for the user-to-user file transfer directory

Modified Files:


exec/load/filebase.js
diff

Replace the guts of OldFileBase to make it v3.19 compatible

This appears to be enough to make hatchit.js work again and file
listings in webv4 (not sure beyond that).

This file is now just an unnecessary shim and should go away when
the consumers (hatchit and webv4) no longer need it.

I did not "port" support for the file properties:
- base
- ext
- datoffset
- opencount
- misc
- altpath

They don't appear to be needed.

Modified Files:


exec/dupefind.js
diff

Update command-line parsing (e.g. double-dash support) and help output

Modified Files:


exec/addfiles.js
diff

Make --help work and copy the option parsing logic from filelist.js

Modified Files:


text/menu/transfer.msg
diff

Restore the /U and /D (user-to-user file transfer) commands

Modified Files:


exec/filelist.js
diff

Optionally include newest-file-in-archive date/time and other features

Modified Files:


ctrl/text.dat
diff

Restore user-to-user file transfer related strings.

More use of the "conditional newline" (^A?) code rather than hard-coded
CRLFCRLFs.

Modified Files:


src/sbbs3/execfile.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

Restore the user-to-user file transfer feature

I forget who it was that said they were still using this feature in v3.18, but
here you go, it's working again (the /D and /U commands). I'm not migrating any
file sender/recipient info from v3.18, so only files added after upgrading to
this will be downloadable from the "user" directory (if you have one).

Something that I never implemented before but noticed is missing is the removal
(or dereferencing) of user-to-user files that were sent from/to a user that is
then deleted. So that's still a TODO item.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix the file update support a bit.

This is still broken (errors when updating existing files) and is still planned
for deprecation.

Modified Files:


src/sbbs3/getmail.c
diff

Don't log a file removal error if the file doesn't exist.

Modified Files:


exec/str_cmds.js
diff

Fix TypeError: file_area.lib_list[i].dir is undefined

dir is not a property of lib_list[], appears to be a typo.

Also, in the "lib" scope commands, j was not defined.

The offline_dir property appears to have been deprecated (no longer
enumerable) years ago, in favor of the dir/dir_list[].is_offline
property, so use that property instead for skipping offline dirs.
Reported by xbit (XBITBBS)

Also, make sure the ;upload and other lib/all search commands are
abortable with Ctrl-C.

Modified Files:


src/sbbs3/addfiles.c
diff

Fix some crashes on multi-line description import stuff

Even though this is going to be removed / deprecated.

Modified Files:


src/xpdev/str_list.c
diff

if strListFind() is passed a NULL 'str' value, return -1 (not found)

Return int value for "string not found" rather than crash/segfault. Seems the
better option.

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Fix QWK/BLT-* copy issue (regression since v3.18)

Reported by Daryl Stout (TBOLT)

Modified Files:


src/sbbs3/userdat.c
diff

Don't compare array against NULL

Addresses CID 319116 and 319090

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Refactor putuserrec()

This started with a Coverity issue (CID 33230) which got me looking at this
function and wondering: why is str2 being NUL-terminated here? Why is the
length of str2 to be calculated on successive lines? What is with this
(long)((long)((long)((long)) typecast?

This was some of the oldest code in Synchronet (along with a lot of the other
functions in this file). I tried to keep as much intact as possible while still
improving the logic and readability.

Modified Files:


src/sbbs3/postmsg.cpp
diff

Debug the "thread_back field missing" error

Some QWKnet vote messages are failing:
evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line
1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote
thread_back field missing

Catch this problem a little higher up (in votemsg()) and log the message's
reply-IDs to help determine what's the root-cause here. Don't bother calling
smb_addvote() if thread_back is 0.

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/un_rep.cpp
diff

Add/use P_REMOTE print-mode flag to bputs()

Do nothing if online != ON_REMOTE. Eliminates some if(online == ON_REMOTE)
clauses.

Modified Files:


src/sbbs3/js_internal.c
diff

Delete one-shot events before running the callback.

If a callback deletes the one-shot event that invoked it, the
event pointer in the caller would be to free()d memory with
hilarious results.

Modified Files:


exec/presence-service.js
diff

Hack the planet.

Added Files:


exec/presence-service.js
diff

Serves "presence" data about local and remote users.

Upon connecting, a client will be sent a list of who's online on
the local BBS as well as other systems (if you and they are set
up for instant messaging). Updates will be sent for subsequent
events (logon, update, logoff).

Mostly intended for use by local consumers; you probably don't
need to open any ports for this.

Nothing uses this at the moment and you do not need to add it
to your config. Eventually it'll bring interBBS presence and
messaging back to webv4 and probably introduce a fancier textmode
imsg module.

Modified Files:


src/sbbs3/js_filebase.c
diff

Check return value of JS_ValueToInt32()

CID 331092

Modified Files:


src/sbbs3/scansubs.cpp
diff

Don't pass uninitialized string to scanposts()

CID 319108

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix some memory leaks

Modified Files:


exec/fseditor.js
diff

Do not use js.report_error()

Properly throw an error instead.

Modified Files:


exec/load/file_size.js
diff

Use Math.round() for sizes > 1024 and < 1024000

Modified Files:


install/GNUmakefile
diff

Copy upgrade_to_v319 to exec dir upon install. <shrug>

Fixes issue #252.

Added Files:


3rdp/build/js-allow-python3.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Disable configure test for python2.[567]

Just don't check the python version at all.  If your python is older
than 2.5, you're already having other issues.

Modified Files:


exec/load/file_size.js
diff

Revert back to whole numbers only for the comma-formatted K output

but round-up non-zero values to 1K.

Modified Files:


exec/filelist.js
diff

Add configurable size formatting, filename formatting, ext-description offset

Modified Files:


exec/loadfonts.js
diff

Accolades

Modified Files:


exec/loadfonts.js
diff

Updated documentation section 1.1a01

Modified Files:


exec/loadfonts.js
diff

Added some documentation.
Appended very important trailing linefeed.

Modified Files:


src/sbbs3/js_filebase.c
diff

Add format_name() method to format a filename for display

It's a wrapper for filedat.c -> format_filename() which can truncate and pad a
filename for display purposes.

Modified Files:


src/xpdev/sockwrap.c
diff

Add more detail to socket_check() comment

Modified Files:


src/xpdev/sockwrap.c
diff

Finally document socket_check() behaviour.

Tweak the poll() implementation to match.

Should fix #248

Modified Files:


exec/load/file_size.js
diff

When bytes is falsey and size is > 0 but < 1000*1024 don't return "0K"

Instead, return the fractional size in KB's with 2 digits of precision.

Fixed up some of the variable names.

Modified Files:


exec/filelist.js
diff

Pretty much a complete re-write and still a work-in-progress, but useful

The biggest difference is that you can combine all files from multiple dirs
into a single sorted list and you can sort on any property (field) value.

The byte/credit format is very customizeable, the output format is completely
customizeable.

By default, just the filenames are output, but either use '-ext' or one or
more '-v' values to add more fields. Use -p=list to specify a comma-separated
list of properties to print.

Modified Files:


src/sbbs3/js_internal.c
diff

Fix sizeof() target.

Modified Files:


src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

When a callback event is handled, get remote_addr

Prevents weird issues with getting remote address.

Modified Files:


src/sbbs3/filedat.c
diff

Sorted loadfiles() results were corrupted when detail was < normal

When only reading the index (detail = file_detail_index), smb_getfile() just
sets the file->name convenience pointer to point to the name in the index. Then
when loadfiles() would sort the list, these pointers would not be adjusted (so
they would point to the wrong names) resulting in a corrupted file list (e.g.
name/size mismatches and no logical sort order).

The solution is to call smb_getfile() on each file *after* the read index
records have been sorted.

This also means that the sort-by-name routines needed to always sort using the
index name and not the convenience pointer (which is NULL in this case).

While fixing this, I noticed there was no bounds checking in the loadfiles()
and loadfilenames() read-loops, so if the indexes happened to be longer than
the total_files value from the status header, a buffer under-alloc/overflow
would occur and a likely crash as a result. So stop reading the index when the
expected maximum number of index records have been read.

Modified Files:


webv4/root/api/events.ssjs
diff

Content-Type not Content-type; delay 1000 ms between event source scans.

Modified Files:


exec/dupefind.js
diff

Use the new file_size_str() usage for prettier sizes-in-bytes

Modified Files:


exec/addfiles.js
diff

Replace print() with writeln()

Modified Files:


exec/load/file_size.js
diff

Add optional/better format to file_size_str() by passing a precision as 3rd arg

Returns a floating-point formatted size estimate more in-line with my
preference (e.g. 17.0G instead of 17,000M).

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix hash() method broken in commit bc4f24f5 - file needs the dir num

Modified Files:


exec/imapservice.js
diff

Some more fixes...

Fix bseen calculation and saving
Only save seen data after all repsonses have been sent
Stop processing when the socket has been closed

Added Files:


exec/dupefind.js
diff

A duplicate file finder for Synchronet v3.19 - replaces native DUPEFIND

Can find duplicate files in your file bases by name and/or hash sum - fast!
Can output simple text or JSON format.
Run 'jsexec dupefind' to search just for duplicate files by hash (SHA-1)
or run 'jsexec dupefind -help' for the various usage options.

Modified Files:


src/sbbs3/js_filebase.c
diff

Don't expand empty from, tags, desc properties unless detail=MAX

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix missing paren warnings.

Modified Files:


src/sbbs3/scfglib2.c
diff

Don't pretend that user-to-user file transfers are working (they don't)

So just always assume that no "user" directory has been configured. At least
for now while I ponder whether this is a feature worth restoring and if so,
how.

Modified Files:


src/sbbs3/services.c
diff

Include user alias in logged JS error/warning messages

Modified Files:


src/sbbs3/js_filebase.c
diff

Include all properties in getter when detail is MAX

Adds from/tags/desc/extdesc properties, even when absent or blank.

When parsing a file object, set the from, desc, tags and cost properties only
if they already have been set or the new values is non-blank/0.

Modified Files:


src/sbbs3/js_system.c
diff

src/xpdev/genwrap.c
diff

Fix msclock() and xp_timer() to be monotonic on *nix

Previously, these both used gettimeofday() which is both expensive
to call, and not monotonic.

This fixes system.clock_ticks in JS and various internal bits. for
when the UTC wall clock jumps.

While we're here, fix the documention of system.clock_ticks

Modified Files:


exec/tickit.js
diff

Use -debug command-line option if you want the <area> using ... address log

For Nelgin, to reduce log spam.

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

Clarity around QWK Conference Names

Modified Files:


src/sbbs3/jsexec.c
diff

Typos in help

Modified Files:


src/sbbs3/dupefind.c
diff

Fix heap corruption (under malloc) - crashed on Linux-x64

Modified Files:


src/sbbs3/js_socket.c
diff

Fix some bugs around sock.on('write'...) and sock.clearOn()

Modified Files:


src/sbbs3/sockopts.c
diff

Only set IPV6_ONLY if it's #defined.

Modified Files:


exec/load/dns.js
diff

Fixes for async lookups

- Add a unique number to event names for each request
  Prevents responses from being acepted by multiple queries
- Don't set Socket.dnsObject for synchronous lookups
- OPcode of 2 is used for status replies (ie: NXDOMAIN)
- Be more careful construct result array in request()

Modified Files:


src/sbbs3/sockopts.c
diff

JSDOOR isn't defined here.

Modified Files:


src/sbbs3/sexyz.c
diff

Address GCC 9.3.0 warnings:

warning: format not a string literal and no format arguments

Modified Files:


exec/load/dns.js
diff

Only the async query needs the timeout now, so move it back in.

Also, have handle_response() return errors.

Modified Files:


exec/load/dns.js
diff

Use this, not ctx in handlers.

Modified Files:


src/sbbs3/telgate.cpp
diff

src/xpdev/gen_defs.h
diff

Allow SAFECAT to work on uchar arrays

Caught by CID 331001

The use of SAFECAT() with a typecast to a pointer is not going to work as
expected. This change broke line-based telnet-gateway functionality
(unconfirmed, but pretty obvious).

Modified Files:


src/sbbs3/services.c
diff

Set fds to NULL before recycle.

Likely the cause of the crash that killed cvs.synchro.net last night

Modified Files:


exec/imapservice.js
diff

Fix last commit... there are bits that aren't Seen that are saved

Modified Files:


exec/imapservice.js
diff

Guard against Seen being undefined when saving config.

Modified Files:


src/sbbs3/main.cpp
diff

EVN MR!

Modified Files:


src/sbbs3/main.cpp
diff

MOAR!

Modified Files:


src/sbbs3/main.cpp
diff

Spaces -> Tabs

Tabs are the shit.

Modified Files:


src/sbbs3/js_msg_area.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add area_tag property to msg_area.sub[]

For easier use of the auto-generated echo-tags in JS.
And a helper function sub_area_tag(), now used in SCFG too.

Added Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Modified Files:


exec/ircd.js
diff

IRCd 1.9

Added Files:


exec/load/ircd/channel.js
diff

exec/load/ircd/config.js
diff

exec/load/ircd/core.js
diff

exec/load/ircd/server.js
diff

exec/load/ircd/unregistered.js
diff

exec/load/ircd/user.js
diff

Modified Files:


exec/ircd.js
diff

Merge branch 'deuce-says-so' into 'master'

First IRCd 1.9 changes

See merge request main/sbbs!125

Modified Files:


src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

Make the callback stuff 3.19

Modified Files:


src/sbbs3/js_internal.c
diff

Keep running the event loop while the run queue is not empty

Previously, timed or polled callbacks were required to keep the
event loop running.

Modified Files:


exec/load/array.js
diff

Update array.js formatting

Autoformatted via prettier with settings below, this is so additional polyfill
matches can be used to match formatting in future PRs for polyfills, as well as
full formatting tooling for .js files.

```yaml
tabWidth: 4
useTabs: true
singleQuote: true
trailingComma: "es5"
```

Modified Files:


exec/load/array.js
diff

Merge branch 'format-array-polyfills' into 'master'

Update array.js formatting

See merge request main/sbbs!120

Modified Files:


src/sbbs3/exec.cpp
diff

Have js_execfile() save/restore callbacks

This should allow callbacks to not interfere between (say) shells
and doors.

Modified Files:


exec/addfiles.js
diff

Add option (-delete) to delete the list file after import

Like the -d option for ADDFILES.

For Al (TRMB)

Modified Files:


src/sbbs3/js_internal.c
diff

Clarify that dispatchEvent() adds to the end of the run queue

Modified Files:


src/sbbs3/js_internal.c
diff

Add js.setImmediate(callback[, thisObj)

I haven't added a clearImmediate() because there's currently no way
of manipulating the run queue, and I can't come up with a reason
someone would actually need it.

Modified Files:


src/sbbs3/js_internal.c
diff

Fix event listener removal

Was terribly broken.

Modified Files:


exec/load/dns.js
diff

Change default failures to 3 and timeout to 5sec

Also, check that the opcode and response flag are correct when
parsing responses.

When handling a resolve call, ensure no errors occured.

Modified Files:


src/conio/ansi_cio.c
diff

src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/conio/cterm.c
diff

src/conio/cterm.h
diff

src/conio/mouse.c
diff

src/encode/base64.h
diff

src/encode/lzh.c
diff

src/encode/lzh.h
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/js_cryptcert.h
diff

src/sbbs3/js_cryptcon.h
diff

src/sbbs3/ringbuf.c
diff

src/sbbs3/websrvr.h
diff

src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

src/uifc/uifcx.c
diff

src/xpdev/datewrap.h
diff

src/xpdev/dirwrap.h
diff

src/xpdev/eventwrap.h
diff

src/xpdev/filewrap.h
diff

src/xpdev/genwrap.h
diff

src/xpdev/link_list.h
diff

src/xpdev/msg_queue.h
diff

src/xpdev/multisock.h
diff

src/xpdev/netwrap.h
diff

src/xpdev/semfile.h
diff

src/xpdev/semwrap.h
diff

src/xpdev/threadwrap.h
diff

src/xpdev/wrapdll.h
diff

src/xpdev/xp_dl.h
diff

src/xpdev/xpbeep.c
diff

src/xpdev/xpbeep.h
diff

src/xpdev/xpdatetime.h
diff

src/xpdev/xpmap.h
diff

src/xpdev/xpprintf.h
diff

The great DLLCALL purge of 2021 - part 2

Modified Files:


src/sbbs3/chksmb.c
diff

src/sbbs3/data.cpp
diff

src/sbbs3/date_str.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getmail.c
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_client.c
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_cryptcert.c
diff

src/sbbs3/js_cryptcon.c
diff

src/sbbs3/js_cryptkeyset.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_rtpool.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_sprintf.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/ntsvcs.c
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/services.c
diff

src/sbbs3/sockopts.c
diff

src/sbbs3/ssl.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/datewrap.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/genwrap.c
diff

src/xpdev/ini_file.c
diff

src/xpdev/link_list.c
diff

src/xpdev/msg_queue.c
diff

src/xpdev/multisock.c
diff

src/xpdev/netwrap.c
diff

src/xpdev/semfile.c
diff

src/xpdev/semwrap.c
diff

src/xpdev/threadwrap.c
diff

src/xpdev/xp_dl.c
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpmap.c
diff

src/xpdev/xpprintf.c
diff

The great DLLCALL purge of 2021

This macro has expanded to nothing for a while now and even before, the usage
was misguided and unnecessary as explained in this video:
https://www.youtube.com/watch?v=cjotPqQxxAY

Modified Files:


src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

Fix errors with callback-based connect()

Non-poll used the wrong value for calculating the high socket (which
is ignored on Win32, the only non-poll() user), and the socket was
being set in the wrong union member.

Modified Files:


src/xpdev/sockwrap.h
diff

Add nfds_t required by poll(), and add note describing Win32 bug

Modified Files:


src/sbbs3/str.cpp
diff

This strcpy() needs to remain as was (caught be GCC).

Modified Files:


src/sbbs3/filedat.c
diff

If error is NULL, insure maxerrlen is 0.

Hopefully this will eliminate the "Dereference after null check" warnings by
Coverity (e.g. CID 330993).

Modified Files:


src/sbbs3/js_archive.c
diff

Insure outdir is never NULL

CID 319037

Modified Files:


src/sbbs3/js_com.c
diff

Handle filelength() returning negative value

CID 33260

Modified Files:


src/sbbs3/js_console.cpp
diff

Remove logically dead code

CID 174335

Modified Files:


src/sbbs3/js_cryptcert.c
diff

Remove structurally dead code (copy pasta?)

CID 174455

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Don't use mode without checking if NULL first

CID 319598

Modified Files:


src/sbbs3/js_cryptkeyset.c
diff

Remove structurally dead code

CID 174483

Modified Files:


src/sbbs3/js_file.c
diff

Fix some printf argument types

CID 319023 319065 319134

Modified Files:


src/sbbs3/js_filebase.c
diff

Alt paths aren't supported/used any longer

Fixes CID 330973

Modified Files:


src/sbbs3/js_filebase.c
diff

dirnum is unsigned, so do not check for negative

CID 330990

Modified Files:


src/sbbs3/js_socket.c
diff

printf fmt/argument type mismatches

CID 319085 319089 319135 319142

Modified Files:


src/sbbs3/js_system.c
diff

client.addr is now an array not pointer

CID 319143

Modified Files:


src/sbbs3/js_uifc.c
diff

Remove logically dead code

PROP_CHANGES already handled in if() condition
CID 33176

Modified Files:


src/sbbs3/main.cpp
diff

ftell() can return negative, deal

CID 33232

Modified Files:


src/sbbs3/node.c
diff

Address logically dead code

This is so old/bad. CID 33179.

Modified Files:


src/sbbs3/postmsg.cpp
diff

mod_ar is no longer a pointer, it's an array

CID 319077

Modified Files:


src/sbbs3/qwk.cpp
diff

The QWK reset sub ptr command would never work

Caught by Coverity-scan CID 33178

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

strcat() -> SAFECAT()

CID 174491

Modified Files:


src/sbbs3/str.cpp
diff

strcpy -> SAFECOPY

CID 33568

Modified Files:


src/sbbs3/str.cpp
diff

read_ar is no longer a ptr, it's an array

CID 319112

Modified Files:


exec/load/dns.js
diff

Use a single class, and pass in a synchronous flag.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix unsigned int compare to negative - caught by Coverity-scan

Modified Files:


src/sbbs3/js_file.c
diff

printf usage issue caught by Coverity.

Modified Files:


src/sbbs3/js_filebase.c
diff

Fix memory leaks caught by Coverity.

Modified Files:


src/sbbs3/js_msg_area.c
diff

mod_ar is not a pointer, it's an array.

Modified Files:


src/sbbs3/js_socket.c
diff

Fix resource leaks caught by Coverity-scan

CID 330950 and 319020

Modified Files:


src/sbbs3/js_system.c
diff

Fix dead code issues reported by Coverity-scan

Modified Files:


src/sbbs3/qwk.cpp
diff

Fix incorrect buf size argument caught by Coverity-scan

Modified Files:


src/sbbs3/sbbsecho.c
diff

Use SAFECAT() instead of strcat() for more safety.

Modified Files:


src/sbbs3/services.c
diff

Fix UDP buffer memory leak when max clients reached

Caught by Coverity-scan CID 330055

Modified Files:


src/sbbs3/upgrade_to_v319.c
diff

Address Coverity-reported issues

The use of uninitialized smb.retry_time was worst offender, but not expected to
cause any actual issues.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix resource leak in ssjs_send_headers()

IdArray returned by JS_Enumerate() was never freed.

Caught by Coverity-scan, CID 319627.

Modified Files:


src/sbbs3/xtrn.cpp
diff

Fix use of uninitialized local variable (err_pipe[]) on *nix

And other weirdness around EX_NOLOG mode checks.
Addresses Coverity-scan CID 330048.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix socket descriptor leak in fastcgi_connect()

Found by Coverity-scan (CID 330051)

@Deuce should review this.

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-code: CONTINUE

CONTINUE is like GETKEY except it'll set the display-abort flag if 'N' or 'Q'
are typed.

Make the WAIT:<n> argument 10ths of a second (instead of milliseconds) to be
more consistent with DELAY:<n>.

Modified Files:


src/sbbs3/sbbs.h
diff

Specify default kmode values for getkey() and inkey()

Modified Files:


src/sbbs3/atcodes.cpp
diff

New @-codes: GETKEY and WAIT:<milliseconds>

GETKEY waits indefinitely for any key press by the user (resolves issue #245).
WAIT:<n> waits for up to n-milliseconds for a key press and then continues on.

For both cases, the key pressed is not echoed or acted upon in any way.
Ctrl-keys could be handled by global or built-in ctrl-key handlers, so those
would be the exception.

Modified Files:


docs/newfilebase.txt
diff

Finish the incomplete thought in the Sorting section

Modified Files:


src/sbbs3/scfg/scfgsub.c
diff

Allow the disabling of @-code expansion in sysop-posted msgs

And make it the default for newly created sub-boards.

Modified Files:


src/syncterm/uncrustify.cfg
diff

Fix single-line if stuff

Added Files:


3rdp/win32.release/libarchive/bin/archive.dll
diff

3rdp/win32.release/libarchive/bin/archive.lib
diff

3rdp/win32.release/libarchive/include/archive.h
diff

3rdp/win32.release/libarchive/include/archive_entry.h
diff

3rdp/win32.release/libarchive/libarchive.props
diff

3rdp/win32.release/zlib/bin/zlib1.dll
diff

3rdp/win32.release/zlib/include/zconf.h
diff

3rdp/win32.release/zlib/include/zlib.h
diff

docs/newfilebase.txt
diff

exec/addfiles.js
diff

exec/archive.js
diff

exec/filelist.js
diff

exec/hashfile.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/updatefiles.js
diff

src/hash/sha1.c
diff

src/hash/sha1.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

Modified Files:


3rdp/build/Common.gmake
diff

ctrl/file.cnf
diff

ctrl/text.dat
diff

exec/default.src
diff

exec/jsdocs.js
diff

exec/load/avatar_lib.js
diff

exec/load/fidocfg.js
diff

exec/load/sbbslist_lib.js
diff

exec/load/text.js
diff

exec/pcboard.src
diff

exec/sbbslist.js
diff

exec/simple.src
diff

exec/tickit.js
diff

exec/update.js
diff

exec/wildcat.src
diff

src/hash/crc16.c
diff

src/hash/crc16.h
diff

src/hash/crc32.c
diff

src/hash/crc32.h
diff

src/hash/md5.c
diff

src/hash/md5.h
diff

src/hash/objects.mk
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/allusers.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

src/sbbs3/data.cpp
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.c
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

src/sbbs3/objects.mk
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/release.bat
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/sbbs4defs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/services.c
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/targets.mk
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/v4upgrade.c
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smblib.vcxproj
diff

src/smblib/smbstr.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

src/xpdev/gen_defs.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

text/menu/sysxfer.asc
diff

text/menu/transfer.msg
diff

Removed Files:



src/sbbs3/sortdir.cpp
diff

A poll() failure with EINTR does not mean a socket is closed.

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

Added Files:


3rdp/win32.release/libarchive/bin/archive.dll
diff

3rdp/win32.release/libarchive/bin/archive.lib
diff

3rdp/win32.release/libarchive/include/archive.h
diff

3rdp/win32.release/libarchive/include/archive_entry.h
diff

3rdp/win32.release/libarchive/libarchive.props
diff

3rdp/win32.release/zlib/bin/zlib1.dll
diff

3rdp/win32.release/zlib/include/zconf.h
diff

3rdp/win32.release/zlib/include/zlib.h
diff

docs/newfilebase.txt
diff

exec/addfiles.js
diff

exec/archive.js
diff

exec/filelist.js
diff

exec/hashfile.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/updatefiles.js
diff

src/hash/sha1.c
diff

src/hash/sha1.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/upgrade_to_v319.vcxproj
diff

Modified Files:


3rdp/build/Common.gmake
diff

ctrl/file.cnf
diff

ctrl/text.dat
diff

exec/default.src
diff

exec/jsdocs.js
diff

exec/load/avatar_lib.js
diff

exec/load/fidocfg.js
diff

exec/load/sbbslist_lib.js
diff

exec/load/text.js
diff

exec/pcboard.src
diff

exec/sbbslist.js
diff

exec/simple.src
diff

exec/tickit.js
diff

exec/update.js
diff

exec/wildcat.src
diff

src/hash/crc16.c
diff

src/hash/crc16.h
diff

src/hash/crc32.c
diff

src/hash/crc32.h
diff

src/hash/md5.c
diff

src/hash/md5.h
diff

src/hash/objects.mk
diff

src/sbbs3/GNUmakefile
diff

src/sbbs3/addfiles.c
diff

src/sbbs3/addfiles.vcxproj
diff

src/sbbs3/allusers.c
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chksmb.c
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/ctrl/AboutBoxFormUnit.dfm
diff

src/sbbs3/ctrl/MainFormUnit.cpp
diff

src/sbbs3/ctrl/sbbsctrl.bpr
diff

src/sbbs3/dat_rec.c
diff

src/sbbs3/dat_rec.h
diff

src/sbbs3/data.cpp
diff

src/sbbs3/delfiles.c
diff

src/sbbs3/delfiles.vcxproj
diff

src/sbbs3/download.cpp
diff

src/sbbs3/dupefind.c
diff

src/sbbs3/dupefind.vcxproj
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/execmisc.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/filelist.c
diff

src/sbbs3/filelist.vcxproj
diff

src/sbbs3/fixsmb.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

src/sbbs3/ftpsrvr.vcxproj
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/load_cfg.h
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mailsrvr.vcxproj
diff

src/sbbs3/main.cpp
diff

src/sbbs3/makeuser.vcxproj
diff

src/sbbs3/msg_id.c
diff

src/sbbs3/msgdate.c
diff

src/sbbs3/msgdate.h
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/node.c
diff

src/sbbs3/nodedefs.h
diff

src/sbbs3/objects.mk
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwknodes.c
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/release.bat
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs.vcxproj
diff

src/sbbs3/sbbs3.sln
diff

src/sbbs3/sbbs4defs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.vcxproj
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfg.vcxproj
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/scfgsave.h
diff

src/sbbs3/services.c
diff

src/sbbs3/services.vcxproj
diff

src/sbbs3/sexyz.vcxproj
diff

src/sbbs3/slog.c
diff

src/sbbs3/smbactiv.c
diff

src/sbbs3/smbutil.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

src/sbbs3/targets.mk
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

src/sbbs3/unbaja.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/v4upgrade.c
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/websrvr.vcxproj
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbdump.c
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smblib.vcxproj
diff

src/smblib/smbstr.c
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

src/xpdev/gen_defs.h
diff

src/xpdev/ini_file.c
diff

src/xpdev/str_list.c
diff

src/xpdev/str_list.h
diff

src/xpdev/xpdatetime.c
diff

src/xpdev/xpdatetime.h
diff

text/menu/sysxfer.asc
diff

text/menu/transfer.msg
diff

Removed Files:



src/sbbs3/sortdir.cpp
diff

Merge branch 'new_file_base' into 'master'

New file base

Closes #241

See merge request main/sbbs!123

Modified Files:


src/syncterm/uncrustify.cfg
diff

Updates

Added Files:


src/syncterm/uncrustify.cfg
diff

Initial pass at uncrustify config for SyncTERM code

Modified Files:


exec/load/dns.js
diff

Add DNS_blocking sub-class for non-event driven lookups

The DNS_blocking class supports the same API as the DNS class, but
does not use events, so any method will complete before returning.
As such, the callback argument is optional.

Modified Files:


src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/sbbs.h
diff

Fix removal of non-timer events

js_callback_t was not being properly retreived.

Modified Files:


src/sbbs3/GNUmakefile
diff

Not sure why jsdoor depended on sbbs

Not having that dependency is the entire point of it.

Modified Files:


exec/load/dns.js
diff

At least test that it compiles.

Sheesh.

Modified Files:


exec/load/dns.js
diff

Add untested parsers for interesting record types

SRV, NAPTR, and URI

Modified Files:


exec/imapservice.js
diff

Ensure line isn't valid is it's not read in parse_string()

Thus appears to have been the root cause of the infinite loop/memory
issue.  Basically, line was never replaced if it didn't match
^{[0-9]+}$ and didn't result in a number when passed to parseInt()
This resulted in an infinite loop that kept pushing zero-length
strings into an array.

Modified Files:


exec/imapservice.js
diff

Improve error message

Modified Files:


exec/imapservice.js
diff

Check for invalid line thing...

Implicated in possible infinite loop/OOM problems.

Modified Files:


xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Version 1.11:  When configured to use all available sub-boards, still don't
allow choosing
a sub-board that has polls disabled.  This fixes an issue where SlyVote was
showing all
available message groups but some could be empty due to having no sub-boards
that allow polls.

Modified Files:


xtrn/slyvote/readme.txt
diff

xtrn/slyvote/slyvote.js
diff

Merge branch '247_slyvote_msggroup_undefined' into 'master'

Fix for #247: Slyvote javascript error pMsgGrps[pGrpIdx] is undefined

See merge request main/sbbs!122

Modified Files:


exec/sbbslist.js
diff

The command prompt is now always on the bottom of the screen
(console.screen_rows).

Modified Files:


exec/sbbslist.js
diff

Merge branch '244_sbbslist_command_prompt_not_always_on_bottom' into 'master'

The command prompt is now always on the bottom of the screen

See merge request main/sbbs!121

Added Files:


exec/load/dns.js
diff

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Initial work on setTimeout()

This appears to work and the event handler *should* work on other
event types already.

Note, this is *nix-only due to the use of poll().  select() will
need to be used for Windows to keep XP compatability.

Added Files:


exec/load/dns.js
diff

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_socket.h
diff

src/sbbs3/js_system.c
diff

src/sbbs3/jsdoor.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Merge branch 'echicken-less-grumpy' into 'master'

Implement support for callback style programming

See merge request main/sbbs!118

Modified Files:


.gitignore
diff

ignore .vscode

Modified Files:


.gitignore
diff

Merge branch 'ignore-vscode' into 'master'

ignore .vscode

See merge request main/sbbs!119

Modified Files:


src/sbbs3/js_socket.c
diff

Fix Socket.connect()

Broken with the poll() update

Modified Files:


src/sbbs3/sockopts.c
diff

Default to IPV6_V6ONLY=1 for jsdoor

Modified Files:


exec/load/typeahead.js
diff

Added 'autoDelete' setting. Probably needs some more work.
If true, and if this is our first input, and if the users types
something that would otherwise have been appended to the default
text, then the default text is deleted first.

Modified Files:


xtrn/go-for/go-for.js
diff

Use new typeahead autoDelete setting.

Modified Files:


xtrn/go-for/go-for.js
diff

xtrn/go-for/help.txt
diff

q from help screen quits help, not the whole program.
o from help screen no longer causes go-for to shit its pants in
dramatic fashion.
s and w are now aliases for tab and ` respectively (item nav).

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix editmsg() always fails bug introduced in commit 0c441424

Another Coverity-issued-fixed-introduced-bug.

Failure to remove a non-existant file is not reason for failure.

Modified Files:


src/uifc/uifc32.c
diff

Have showbuf() clamp width the same way as height...

Basically, assume left is correct, and calculate the correct width
to fill the screen to the esge.

Modified Files:


src/sbbs3/js_uifc.c
diff

Make context defaults for with and height same as no-context ones.

ARE YOU HAPPY NOW CYAN?!?!

Modified Files:


src/build/Common.gmake
diff

os is lower-case.

Fixes *nix builds of Win32 programs.

Modified Files:


src/sbbs3/main.cpp
diff

Fix error in last commit.

Looks like I was partially restoring old code before I stopped.

Modified Files:


src/build/Common.gmake
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/services.c
diff

src/sbbs3/xtrn.cpp
diff

src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

Use new PREFER_POLL define to control poll() usage

Rather than depending on _WIN32 which is silly, make it clear what
exactly is being done and why.

Note that the spy socket stuff and some external stuff on *nix have
had the select() implementation removed.  To support using select()
on !Win32 will require de-refactoring that's not really worth doing.
Instead, just use #error and reference the commit where the old
code can be found.

Modified Files:


src/sbbs3/js_uifc.c
diff

Set a better default window for uifc.showbuf()

Rather than defaulting to zero lines high and the width of the title,
default to the entire screen area.

Modified Files:


src/uifc/uifc32.c
diff

Fix glitch in showbuf window with odd-numbered width

Modified Files:


src/sbbs3/js_uifc.c
diff

Fix showbuf context issues.

Modified Files:


src/sbbs3/mxlookup.c
diff

Fix clang warning

Modified Files:


src/sbbs3/websrvr.c
diff

Remove some unused variables.

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ident.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs_status.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn.cpp
diff

Initial poll() work

Still needs updates in services_thread(), CGI stuff in websrvr.c,
and sbbs_t::external()

Modified Files:


src/sbbs3/execnet.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ident.c
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mxlookup.c
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs_status.c
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/xtrn.cpp
diff

Merge branch 'poll-update' into 'master'

Poll update

See merge request main/sbbs!116

Modified Files:


src/syncterm/syncterm.c
diff

Use kDownloadsFolderType for downloads.

Found by digging through headers... Apple doesn't document this.

Added Files:


3rdp/build/cl-check-before-use.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix macOS build.

Just some more macOS silliness.

Modified Files:


src/syncterm/ooii.c
diff

Guard against pathologically bad OO][ sequences.

Modified Files:


src/syncterm/GNUmakefile
diff

src/syncterm/conn.c
diff

src/syncterm/extdeps.mk
diff

src/syncterm/objects.mk
diff

Fix WITHOUT_CRYPTLIB option.

Modified Files:


src/syncterm/bbslist.c
diff

Fix issue with redrawing BBS list from settings menu

Sometimes the comment wasn't redrawn.
Also, remove configurable mouse actions stuff, not implemented in
13 years, I suspect I'll never do it.

Modified Files:


exec/fseditor.js
diff

Don't use handle_backspace() to handle delete.

While they both delete a character, delete at the end of a line will
move the next line up instead of moving this line up.

Fixes #243

Modified Files:


exec/login.js
diff

Run the "inactive_hangup" option through parseInt()

Just in case it was read as a string (e.g. had a ; comment following the value)

Modified Files:


ctrl/modopts.ini
diff

Remove the comment from the [login] inactive_hangup value

caused it to be represented as JS string rather than number causing an issue
with login.js:
Node 1 terminal not detected, reducing inactivity hang-up timeout to 0 seconds

Modified Files:


xtrn/lord2/cnw/inn.ref
diff

Actually, it was everything *except* Leave that was broken.

Redraw map before returning to startma/startma1

Modified Files:


xtrn/lord2/cnw/inn.ref
diff

Redraw map when you 'Leave' talking to Ma in Greetree inn.

There's likely an ass-ton of these though.

Modified Files:


exec/dorkit/sbbs_input.js
diff

js.terminated does not get set when the user disconnects

Also check bbs.online for sbbs input.

Modified Files:


xtrn/lord/lord.js
diff

Don't enable ctrl keys with dorkit here either.

Modified Files:


xtrn/lord2/lord2.js
diff

Don't enable ctrl-keys for background threads.

Synchronet goes boom.

Modified Files:


exec/load/dorkit.js
diff

Don't set js.terminated mmmkay?

Modified Files:


xtrn/lord2/l2lib.js
diff

Fix a (harmless) user creation error

When a players map is set, it automatically triggers a player record
write.  When a new player is being created, the map is set before
the player is added via @addchar.

This attempted to write record number undefined in the player file,
which threw an exception.  Since exceptions are being caught, logged,
and ignored, this did not cause a problem, but did log an error when
it wasn't necessary.

Modified Files:


xtrn/lord2/l2lib.js
diff

Initialize v variables to zero when creating a new world record.

This should never actually be done though since the map would be
completely empty.

Modified Files:


xtrn/lord2/lord2.js
diff

Do not attempt to list online players who are not on a valid map location

Prevents a who's online list from aborting early when it encounters
and invalid player record.

Modified Files:


src/sbbs3/js_global.c
diff

Properly handle CSI m in html_encode()

Used by gcc in warnings.

Modified Files:


src/syncterm/conn_telnet.c
diff

telnet_interpret() can grow th input buffer by a byte.

If a '\r' is the last thing in the previous receive buffer.

Modified Files:


src/sbbs3/websrvr.c
diff

post_to_file() shouldn't close the file since it didn't open it.

Modified Files:


src/xpdev/sockwrap.c
diff

Properly set buffer size when calling getsockopt()

Modified Files:


src/xpdev/multisock.c
diff

Return an error if calloc() fails allocating pollfd array.

Modified Files:


src/xpdev/sockwrap.c
diff

We still need to peek a byte to tell that recv is done with poll()

Not all implementations set POLLHUP when a TCP socket is half-closed.

Modified Files:


src/xpdev/sockwrap.c
diff

Fix poll()-based socket_check() implementation

Was returning disconnected when it wasn't at times.

Modified Files:


src/xpdev/multisock.c
diff

Fix memory leaks and logic errors in multisock accept()

This likely unbreaks the things.

Modified Files:


3rdp/build/cl-poll-not-select.patch
diff

Fix logic error in cl poll patch

Modified Files:


src/xpdev/multisock.c
diff

Fix bad listening socket detection in multisock

A socket isn't bad just because there was no incoming connections. :D

Modified Files:


src/xpdev/multisock.c
diff

Properly use poll_timeout in xpms_accept()

Added Files:


3rdp/build/cl-poll-not-select.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Patch Cryptlib to use poll() on non-Windows systems

Modified Files:


src/xpdev/sockwrap.c
diff

A poll() failure with EINTR does not mean a socket is closed.

This won't impact Synchronet as it has a separate signal handling
thread, but we still need to behave properly for processes that
don't.  I'm also saying that ENOMEM does not indicate a disconnection,
though it may be better to pretend it was disconnected...

Modified Files:


src/xpdev/multisock.c
diff

src/xpdev/sockwrap.c
diff

Stop using select() in *nix for xpdev stuff.

Modified Files:


src/syncterm/conn.c
diff

Check for writability on non-blocking connect(), not read

Modified Files:


src/syncterm/conn.c
diff

Stop using select() in SyncTERM completely.

Modified Files:


src/syncterm/rlogin.c
diff

src/syncterm/ssh.c
diff

src/xpdev/sockwrap.c
diff

src/xpdev/sockwrap.h
diff

Add three new socket status functions:

socket_readable() returns TRUE if recv() will not block if called
on the specified socket.

socket_writable() returns TRUE if send() will not block if called
on the specified socket.

socket_recvdone() returns TRUE if all data has been recv()ed an
the socket is closed.

"will not block" includes "will return an error".

This matches the three main use-cases for select() of a single socket
in Synchronet.

Use them in the SyncTERM RLogin stuff so they can be tested easily.

Added Files:


3rdp/build/cl-mingw-add-m32.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

src/build/Common.gmake
diff

src/conio/GNUmakefile
diff

src/syncterm/GNUmakefile
diff

src/syncterm/syncterm.c
diff

Add support for MinGW-w64

MinGW32 is getting long in the tooth and is missing a lot of modern
Windows features as well as having broken headers.  Most people will
be using MinGW-w64 at this point, so add support for it.  Once I
ensure SyncTERM works properly with it, MinGW32 support will be
discontinued.

I suspect this will impact exactly zero people since the reason this
exists is to build the Win32 versions of SyncTERM on FreeBSD.

Changes:
- Explicitly request 32-bit Windows output
- Detect the string "mingw32" anywhere in the hardware description
- Explicitly link with libuuid
- Add a terrible hack to syncterm.c to block wincrypt.h

Modified Files:


src/conio/cterm.c
diff

Ensure cleared block in in scrolling region

Do not clear at the current X/Y on scroll (derp)

Modified Files:


src/conio/cterm.c
diff

Fix error on scroll with left/right margins

Scrolling would clear the line to the end of the screen, not the
end of the scrolling region.

Sorry echicken.

Modified Files:


src/sbbs3/websrvr.c
diff

Track the active client "highwater mark" (highest number of concurrent clients)

Could be useful for knowing if you need to increase MaxClients for typical
usage.

Modified Files:


exec/load/fido_syscfg.js
diff

Refactor the get_pw() and get_ticpw() methods

First look for a linked node matching the node address string as passed,
then look for a match using the normalized address (removing .0 and @domain).
The "ALL" wildcard should not be used for password lookups.

This should fix reported issue 240.

Modified Files:


src/xpdev/multisock.c
diff

Revert last commit that used poll()

Borland hates it.

Modified Files:


src/xpdev/multisock.c
diff

src/xpdev/sockwrap.h
diff

First attempt to use poll()

There has been a sighting of Synchronet exceeding FD_SETSIZE sockets.
This means select() is of less use and we need to start migrating to
either poll() or platform-specific methods to achieve the same end.

This commit is mostly to check that poll() builds on Win32 and that
it actually works.

Modified Files:


xtrn/lord2/lord2.js
diff

Declare the 't' variable used for word-wrap.

Hopefully fixes crash in lord when composing a message and using
word-wrap.

Modified Files:


src/xpdev/xpbeep.c
diff

Fix race condition when handle is opened by playing a sample.

Caused a SyncTERM hang if it played a FG beep.

Modified Files:


src/conio/sdl_con.c
diff

Fix AltGr with SDL2

This is pretty insane since SDL2 completely ignores the keysym value
of the X11 keyboard event, so here's what we do...

1) When there's a keypress that includes right-alt, store the sym/mod
2) When we get text input, if it's the same as we would get if ALT
   wasn't pressed for the last keydown, parse through the mapping
   (ie: handle ALT keys)
3) If it's different, use that (gets AltGr modified value)

I get that AltGr is hard in a cross-platform way, but just pretending
it doesn't exist at all for key input is a very weird choice.

Modified Files:


src/syncterm/term.c
diff

Better comment conformance in key parsing

There's a comment saying we set key=0 when we consume it... do so
in a couple cases where it wasn't done.

Range check the key before sending to the remote.

This should not actually do anything different, but in the future
if things are changed at least the comments won't be misleading.

Modified Files:


text/menu/main.msg
diff

Put back the space that got removed from the first heading line.

Modified Files:


src/sbbs3/postmsg.cpp
diff

Move the tags prompt to *before* the locking of the message base

Thanks Mr. Executive Chicken esq. for the telephone call and bug report.

Modified Files:


exec/load/smbdefs.js
diff

Define SMB_TAGS_MAXLEN for maximum total tags length per message

Modified Files:


exec/load/smbdefs.js
diff

Max that SMB_TAGS_MAXLEN

Modified Files:


src/sbbs3/echocfg.c
diff

src/sbbs3/rechocfg.c
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/sbbsecho.h
diff

Build log rotation into SBBSecho, bump version to 3.14

2 new configuration params: MaxLogSize (default: 10M) and MaxLogsKept (10)

Modified Files:


src/xpdev/xpbeep.c
diff

Fix the single-threaded build:

error: ‘handle_mutex’ undeclared

Modified Files:


text/menu/main.msg
diff

Fix indentation problem introduced in previous commit.

Modified Files:


text/menu/main.msg
diff

Remove trailing newline (not using GitLab edit file this time).

Modified Files:


text/menu/main.msg
diff

Revert "Remove trailing newline"

This reverts commit f6c2bc3337b0855cf0f17bf1cb4ab158dda8bfae.

Modified Files:


src/xpdev/xpbeep.c
diff

Remove debug crap.

Modified Files:


src/xpdev/xpbeep.c
diff

Fix bug in last commit (extra parameter)

Modified Files:


src/xpdev/xpbeep.c
diff

When trying to open pulse, play a millisecond of silence

This allows the playback thread to open the device and errors to
be checked.  Otherwise, the first sound won't play.

Modified Files:


text/menu/main.msg
diff

Remove trailing newline

Modified Files:


exec/imapservice.js
diff

Fix two isses with IMAP service...

1) user.number immediately after login() remains zero, but changes
   "sometime" after.  Avoid using user.number right after login()
   call to generate filename.  All data/user/0000.imap files can
   be deleted after this change.
2) Saving Seen data would modify the object storing it when binary
   seen values were used.  Use JSON.parse(JSON.stringify() to make
   a copy before saving and restore it afterward.  Should fix issue
   reported by nickshanks1 over IRC.

Modified Files:


text/menu/main.msg
diff

Add L command to main menu (replacing the never-used Z command)

Addresses issue #239

Modified Files:


src/syncterm/bbslist.c
diff

Fix menu draw when returning to dialing list from comment

Also note the spectacularily poorly named WIN_REDRAW and WIN_NODRAW
flags.  WIN_REDRAW indicates that this *is* a redraw of the menu,
which indicates that you don't need to redraw the menu (because it's
already correct on screen).  Weird, but not insane... WIN_NODRAW on
the other hand indicates this is *not* a redraw, and that the window
is incorrect on screen and you therefore *must* redraw the menu.

That is to say:
WIN_REDRAW prevents the window from being redrawn
WIN_NODRAW forces the window to be redrawn

Modified Files:


src/xpdev/xpbeep.c
diff

Do what was likely intended by 8b6b7b7c

The previous attempt completely disabled pulse audio.

Modified Files:


src/xpdev/xpbeep.c
diff

Re-enable PulseAudio, ensure the handle is set to NULL on close.

Modified Files:


src/xpdev/xpbeep.c
diff

Fix ALSA output on Linux

It seems that the "real" ALSA will actually silently fail if you
try to clear errors when no errors have occured.  The FreeBSD
emulation of ALSA does not have this insane requirement, so this
went unnoticed for the 1.1 release.

I suspect that this actually fixes SF bug 24, because ALSA is
preferred over pulseaudio.

Modified Files:


xtrn/lord2/lord2.js
diff

Add filename and line number to exception catch log messages.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/bbslist.h
diff

First cut at adding a comment field to listings.

The jury is still out on some details...
1) If you press ESC while editing the comment, it currently cancels
   the edit.  Would people expect ESC to exit the program instead?
2) The format/colours of the displayed comment... right now it's
   using the UIFC background colours, and not draing a border or
   window.
3) Just how long should the comment field be, and how should it be
   edited.

Modified Files:


src/conio/sdl_con.c
diff

Special-case TAB so "backtab" works properly.

Modified Files:


src/sbbs3/js_socket.c
diff

Close Socket on unhandled TLS errors

While errors on transmit seem to be handled well, errors on receive
do not, especially through js_recv_line() which has been seen to
trigger a large number (hundreds) of ECONNRESET errors.  To prevent
this, simply close the socket when an otherwise unhandled error
occurs.

Almost certainly fixes that issue, but the underlying cause is still
undetermined.  The calling script (imapservice.js) was checking
Socket.is_connected after each recv_line() call, so if the socket
was actually reset, it would be expected to only call it once.

An alternative would be to explicitly handle the error that is
seen (CRYPT_ERROR_PARAM1), but let's try a generic fix first and see
of anything breaks because of it.  Most likely issue would be an
inability to recv() data after calling shutdown(), but I don't think
many people do that except to move the TIME_WAIT to where they want
it.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/websrvr.c
diff

Limit sends in terminal and web servers to 8k as well.

It fixed an issue in js_socket.c, no reason to expect better
behaviour with TLS.  This may fix SZ YModem-G transfers on
cvs.synchro.net...

Modified Files:


exec/load/mime.js
diff

Work around exception on spammy mail...

Don't include the obsolete unstructured regex in abs.unstrctured,
and use the abnf.unstructured for parsing headers.

This fixes an issue seen running the IMAP server on gratuitously
spammy messages.

Modified Files:


src/uifc/uifc32.c
diff

Small fixes for ugetstr()

- Backtab also exits with K_TABEXIT when the string is selected
- Backspace scrolls the text to the left of the cursor to the right
  if the left of the input is not the start of the string.

Modified Files:


exec/imapservice.js
diff

Rename variable for consistency.

Modified Files:


src/uifc/uifc32.c
diff

Allow showbuf buffers to be placed up against the status line.

Modified Files:


exec/imapservice.js
diff

Don't overwrite the base global with the index base when reading config

This falls squarely into the "How did that ever work?" category.

Modified Files:


exec/load/logonlist_lib.js
diff

Insure there's always a logon.jsonl file before calling file_backup() in maint

Fix for Altere's logons yesterday list that isn't rotating out because nobody
logged on today.

Modified Files:


src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

src/syncterm/window.c
diff

Add a "fake mode" for output drivers that can't change screen size

Previously, the height was left the same, and the width was set to
the next-lowest "standard" size.  Now the cterm window is set to
the size of the requested mode and both top/bottom and side bars
are added to make the virtual screen the same as the requested one.

Using the "current" mode still retains the old behaviour.

Closes SF request 11

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

Don't allow ALT-Direction to work when maximized

With maximized windows, unexpected behaviour occured when the program
resized itself, then the window manager minimized/restored the window
Should address SF bugs #18 and #13

Added Files:


3rdp/build/cl-allow-none-auth.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

src/syncterm/bbslist.c
diff

src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/ssh.c
diff

src/syncterm/st_crypt.c
diff

src/syncterm/st_crypt.h
diff

src/syncterm/term.c
diff

Add support for the SSH "none" auth method.

This is used by some BBSs to enable encryption without needing to
integrate the BBS user base into their SSH server (and presumably
so they don't need to run multiple SSH servers).  All users log in
with the same username (ie: "bbs") and no password is requested or
required.

Once the BBS starts, it prompts for the BBS user name and password
as normal.

In SyncTERM, the user/password/syspass fields are redefined as
SSHuser/BBSuser/BBSpassword and they are moved around when you
change the connection type.  This means that if you change a listing
that has a syspass to SSH (no auth) and back, the syspass is lost.

I'm not sure if I plan to fix this or not.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbscon.c
diff

src/sbbs3/startup.h
diff

Add NO_TELNET option to terminal server.

Added Files:


3rdp/build/js-Wno-misleading-indentation.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix indentation warning from Clang in JS header

It would be fine if this only warned while building JS, we're used
to ignoring that, but this bugger warns while building Synchronet
stuff.

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/ripper.h
diff

src/syncterm/term.c
diff

Suspend RIP processing for file transfers

Modified Files:


3rdp/build/GNUmakefile
diff

Disable tracejit on OSs it's not supported on.

Only supported on FreeBSD, Linux, Solaris, OS/2, GNU, Cygwin, and Darwin
Should allow OpenBSD to build JS engine.

Added Files:


3rdp/build/cl-openbsd-threads.patch
diff

3rdp/build/cl-random-openbsd.patch
diff

3rdp/build/cl-uint64_t-redefine.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Add some more patches to make OpenBSD 6.8 build

Not yet tested, so more patches may be incoming.

Modified Files:


exec/fido-nodelist-browser.js
diff

Comment out previous change pending fixes to nodelist firstline parsing in
ftn_nodelist.js.

Modified Files:


exec/fido-nodelist-browser.js
diff

Show domain & date information in top bar when domain tree expanded.

Modified Files:


src/syncterm/bbslist.c
diff

Move log options into a separate menu and fix overflows

There are too many options now to fit in an 80x25 screen, so group
all the log options into a separate sub-menu.

While we're here, notice that we're writing paths up to MAX_PATH
into an 80-character buffer and fix that.

Modified Files:


src/syncterm/bbslist.c
diff

Make log level selection a menu like every other non-binary option.

Modified Files:


src/syncterm/bbslist.c
diff

Change default connection type from RLogin to SSH because it's 2021 dammit.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

DOSCmd is only on FreeBSD and DOSEmu is only on Linux.

Do not get/set these values on other OSs.  Fixes a segfault caused
by default_dosemuconf_path being undefined on FreeBSD, but would
also happen on any other *nix platform (ie: OpenBSD, etc).

Modified Files:


src/syncterm/term.c
diff

Work around broken sz

Some broken protocol drivers (like sz) don't send a YModem terminate
at the end of a batch (or maybe just after a single file?) so SyncTERM
ends up trying to fall back from G to CRC-16 to 8-bit before ending.

This detects when the last known file was received, and if the YModem
header that follows is not correct, aborts the transfer.

Modified Files:


src/sbbs3/main.cpp
diff

Revert the last changes.

Something weird is happening to the cryptlib session when SZ sends
a lot of data... no real clues left.

Modified Files:


src/sbbs3/main.cpp
diff

Changing timeout didn't help.  Use PopData of zero bytes to rekey...

This issue may actually be a rekey issue, to clear this, we need
to call cryptPopData(), but we can pop zero bytes.

In this case, re-try the flush.

Modified Files:


src/sbbs3/main.cpp
diff

Increase flush write timeout for SSH.

During YModem-G transfers, the previous 5-second timeout was
exceeded.

Modified Files:


src/syncterm/term.c
diff

Revert last change... YModem is supposed to send a termination block.

Modified Files:


src/syncterm/ripper.c
diff

Add comments for all the things.

Just copied out of the documentation.

Modified Files:


src/syncterm/term.c
diff

In XModem/YModem, when total_files reaches zero, stop downloading.

Modified Files:


ctrl/services.ini
diff

Add IMAPS service example configuration, disabled by default

Added Files:


src/syncterm/telnets.c
diff

src/syncterm/telnets.h
diff

Modified Files:


src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_telnet.c
diff

src/syncterm/conn_telnet.h
diff

src/syncterm/objects.mk
diff

src/syncterm/ssh.c
diff

src/syncterm/ssh.h
diff

Add support for telnets (Telnet over SSL)

It's not clear if this is working properly or not since the only
BBS I know of that supports telnets (fido.beholderbbs.org) doesn't
seem to do any telnet "stuff".

Modified Files:


src/syncterm/conn.c
diff

src/syncterm/conn_pty.c
diff

src/syncterm/modem.c
diff

src/syncterm/rlogin.c
diff

src/syncterm/ssh.c
diff

Use a separate status for thread exited than thread not started

Should fix SF #45 since it appears the input thread started then
exited before SyncTERM realized the connection was successful.

Modified Files:


src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

src/syncterm/conn_telnet.c
diff

src/syncterm/conn_telnet.h
diff

src/syncterm/rlogin.c
diff

src/syncterm/rlogin.h
diff

src/syncterm/telnet_io.c
diff

src/syncterm/telnet_io.h
diff

Move telnet expansion/parsing into conn layer

In preperation for telnets support, make conn support TX/RX parsers.
Make telnet use those new hooks, and remove unused and ambiguous bits
of the conn API (conn_recv(), conn_peek()).

Modified Files:


src/syncterm/syncterm.c
diff

Disable ALPHA splash screen.

All the major bugs I'm aware of are fixed (though RIP is still
incomplete)

Modified Files:


src/conio/sdl_con.c
diff

Fix SF #44 problem keypad non-numbers

Make an exception for all keypad stuff.

Modified Files:


src/conio/bitmap_con.c
diff

Fix SF bug #40

Cursor update issue, cursor was only redrawn on a blink status change.
This will redraw the cursor any time the cursor moves now.

Modified Files:


src/syncterm/ripper.c
diff

Don't make parse_rip() do anything when RIP is disabled.

Should fix file transfer issues.
(SF bug #38)

Modified Files:


exec/load/newsutil.js
diff

Do the FTN CHRS kludge to MIME charset translation for CP866->koi8-r

for Al (TRMB) and his Russian users, requested via DOVE-Net.

Do an FTN "ASCII 1" -> "US-ASCII" translation of the CHRS->charset too.

Added Files:


3rdp/build/js-volatile-outside-functions.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Don't use "asm volatile" outside of functions.

Clang 11 throws an error if you do.

Modified Files:


src/syncterm/term.c
diff

Remove some backslashes from the ends of lines...

Presumably these were part of macros once and never cleaned up?

Modified Files:


src/conio/ciolib.c
diff

src/conio/ciolib.h
diff

src/sbbs3/js_conio.c
diff

src/uifc/uifc32.c
diff

We can't pollute the namespace with curses everywhere.

Just rename ESCDELAY member to escdelay.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Fix error removing INPUT.MSG introduced in Commit 0c441424

remove() is expected to fail in this scenario sometimes depending
on how writemsg() is used - in the error case, the user was trying
to edit his .plan file with the ;plan command:
term Node 10 <Deuce> !ERROR 11 (Resource temporarily unavailable) in
writemsg.cpp line 1232 (editfile) removing "/sbbs/node10/temp/INPUT.MSG"
access=0

Thanks for the bug report!

Modified Files:


src/conio/ciolib.h
diff

include curs_fix from ciolib.h to fix openSUSE

Apparently, the ncurses in openSUSE Leap-15.2 has the following:
Since we have a struct member named ESCDELAY, we can't actually set
it at all when this macro is defined.

The three possibilities to deal with this are:
1) Rename the ESCDELAY member.
   Likely the best option long-term, but I don't want to find everything
   and update it at this time.
2) Avoid using the ESCDELAY member #ifdef ESCDELAY
   Which makes it not work in the exact set of circumstances it makes
   sense in.
3) #include curs_fix.h from ciolib.h
   This actually renames the ESCDELAY member to _nc_ESCDELAY, but you
   won't be able to actually notice this.

Modified Files:


src/conio/cterm.c
diff

Fix issue with ATASCII delete/insert character.

Before the Unicode support was added, displaying a NUL would clear
the cell, but now it is translated.  For ATASCII, this results in
a heart character being displayed instead of an empty cell when
inserting or deleting characters.

Fixes bug #28 on Sourceforge.

Modified Files:


src/syncterm/term.c
diff

Handle the new value of CIO_KEY_QUIT better.

The low byte is no longer zero.

Modified Files:


3rdp/build/terminal-params.patch
diff

Fix SSH height/width parameters set get works as well as set.

Modified Files:


src/sbbs3/pktdump.c
diff

Fix issue display AREA keywords at beginning of body text

or any lines that were only terminated with carriage-return (\r)
since these are treated rather-oddly by the FTN software as a
line-ending and line-feeds are to be ignored. So transfer \r to \n
on output and ignore the \n's in the body text.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Add the missing curly braces from previous commit.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Read the Let's Encrypt ACME host name from the letsyncrypt.ini file.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Fix typo in last commit, reported by MobileCoz via IRC... Thanks!

Modified Files:


exec/letsyncrypt.js
diff

If the service host is changed, the old private key is invalid.

Just delete the old private key and create a new one for the new
host.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Update letsyncrypt.key as well as the SSL/SSH keys when syspass is changed.

Currently, this is hard-coding the name of the key, which should
be read from the letsyncrypt.ini file in case someone is using an
ACME v2 service that is not provided by letsyncrypt.org.

Modified Files:


xtrn/lord2/lord2.js
diff

Some cleanup

Remove obsolete comments, and remove an extraneous savetime call.

Modified Files:


webv4/pages/003-games.xjs
diff

If 'code' query param exists, is a valid xtrn code, and user can access, then
jump right into it after the page loads. (Requested by Mortifis.)

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

Set the default event error log level to LOG_ERR (not LOG_EMERG)

Modified Files:


src/xpdev/ini_file.c
diff

De-duplicate the lists returned by iniGet/ReadSectionList()

I noticed a duplicate area name (AGN_MODS) in a filefix %LIST response
from my FidoNet hub that's running TickIt/TickFix, and I thought to myself:
Self, that shouldn't be possible. But alas, if one does have duplicate
sections in a .ini file (e.g. tickit.ini), the iniGet/ReadSectionList()
function would indeed return duplicate items in the list. Since the second
section with the same name is not actually accessible, it shouldn't be counted
as a valid section and thus not returned as part of the section list. Section
names are not case sensitive, so the names are compared case-insensitively for
de-duplication purposes too.

Modified Files:


xtrn/lord2/l2lib.js
diff

xtrn/lord2/lord2.js
diff

Save time in player.lastsaved every time.

This allows timing out the battle bit.  If the game/BBS crashes
while you're in battle, you should now only need to wait two times
the idle timeout (ie: 2 * 5 minutes) before you can get back in.

Modified Files:


xtrn/knk/knk.js
diff

xtrn/lord/lord.js
diff

Basic CONNECTION_CLOSED key handling in LORD and KnK

Modified Files:


exec/load/dorkit.js
diff

xtrn/lord2/l2cfg.js
diff

xtrn/lord2/l2lib.js
diff

xtrn/lord2/lord2.js
diff

xtrn/lord2/map.dat
diff

Disconnect Commit #2

- In dorkit, start the timer if keyboard is invoked and
  dk.connection.active is false.
- In LORD2, check for a CONNECTION_CLOSED key after getkey() where
  appropriate.
- Also in LORD2, allow the busy flag to suspend pending timeouts.