Synchronet Git Commit Log

This is a log of the 500 most recent pushes to the master branch of the Synchronet Git repository.
If you want to view more pushes/commits, you can by passing ?<number> in URL.
  1. Deucе
    Thu Mar 28 2024 06:45:54 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.txt diff
    When ANSI Music is enabled, CSI M with parameters is still delete line

  2. Deucе
    Thu Mar 28 2024 06:45:54 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    Whoops, forgot to add the rest of the entry options.

  3. Deucе
    Thu Mar 28 2024 06:08:46 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Update help for connected BBS list editing.

  4. Deucе
    Thu Mar 28 2024 06:09:02 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    Finish documenting the rest of the Directory list features. Only two major chunks left... settings and connected mode!

  5. Deucе
    Thu Mar 28 2024 06:27:03 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Fix help text.

  6. Deucе
    Thu Mar 28 2024 06:27:57 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/cterm.c diff
    When ANSI Music is enabled, CSI M with parameters is still delete line

  7. Eric Oulashin
    Tue Mar 26 2024 19:02:07 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ?

  8. Rob Swindell
    Tue Mar 26 2024 19:46:12 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/gttrivia/gttrivia.js diff
    xtrn/gttrivia/readme.txt diff
    xtrn/gttrivia/revision_history.txt diff
    Merge branch 'good_time_trivia_sysop_screen_fix_and_help_during_play' into 'master' Good Time Trivia: Formatting fix for sysop menu when the server scores file is missing. Allow showing help when playing a game by entering ? See merge request main/sbbs!429

  9. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Initialize telnet options when passed -h option (withouth -l) As requested by Fzf (FQBBS): When SVDM uses an inherited socket (the -h option) no telnet negotiations are done. As a result, the connection is assumed to be in ASCII mode and server side CR characters are translated to CR/LF. Since most programs are already transmitting a CR/LF this gets translated to CR/LF/LF with the expected results. When using an external socket in telnet mode, could SVDM set the telnet.local_option and telnet.remote_option variables as so: A. Assume both remote and local have already suppressed GA and set the two options accordingly B. Set the remote telnet echo option to off and set the local telnet echo to follow the ServerEcho option from the .INI file C. Set both remote and local BINARY_TX options to follow the ServerBinary option from the .INI file

  10. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.c diff
    Add 2 new .ini settings: MainLoopDelay and SocketSelectTimeout (default: 0) - MainLoopDelay - in milliseconds Set this to a non-zero value to add some CPU yielding to the main loop - SocketSelectTimeout - in milliseconds Set this to a non-zero value to add some CPU yielding while waiting for receive data from the TCP socket These are 2 knobs created for Fzf (FQBBS) to "to reduce the CPU usage". Their default values are currently 0, so you'll need to set these to non-zero values to play with each of them and see their inpact on CPU utilization and responsiveness. I'd suggest starting with low values (e.g. 1) and experimeting from there. Incremented version to 0.5

  11. Rob Swindell (on Windows 11)
    Mon Mar 25 2024 16:29:36 GMT-0700 (PDT)
    Modified Files:
    

    src/vdmodem/vdmodem.vcxproj diff
    Build release Win32 binaries without SSE exentions for more CPU compatibility

  12. Deucе
    Sun Mar 24 2024 23:24:05 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Hopefully the cache got deleted by that last build and we can re-enable.

  13. Deucе
    Sun Mar 24 2024 23:13:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Temporarily disable the js configure cache. The last commit changed the environment, so we need to regenerate the config cache.

  14. Deucе
    Sun Mar 24 2024 23:07:19 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Use cc, not gcc for --build detection

  15. Deucе
    Sun Mar 24 2024 23:07:19 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-support-mingw-cross.patch diff
    3rdp/win32.release/nspr/include/nspr/md/_aix32.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_aix64.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_bsdi.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_darwin.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_freebsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_hpux32.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_hpux64.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_linux.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_netbsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_nto.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_openbsd.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_os2.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_qnx.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_riscos.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_scoos.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_solaris.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_unixware.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_unixware7.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_win95.cfg diff
    3rdp/win32.release/nspr/include/nspr/md/_winnt.cfg diff
    3rdp/win32.release/nspr/include/nspr/nspr.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/pralarm.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/probslet.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/protypes.h diff
    3rdp/win32.release/nspr/include/nspr/obsolete/prsem.h diff
    3rdp/win32.release/nspr/include/nspr/plarena.h diff
    3rdp/win32.release/nspr/include/nspr/plarenas.h diff
    3rdp/win32.release/nspr/include/nspr/plbase64.h diff
    3rdp/win32.release/nspr/include/nspr/plerror.h diff
    3rdp/win32.release/nspr/include/nspr/plgetopt.h diff
    3rdp/win32.release/nspr/include/nspr/plhash.h diff
    3rdp/win32.release/nspr/include/nspr/plstr.h diff
    3rdp/win32.release/nspr/include/nspr/pratom.h diff
    3rdp/win32.release/nspr/include/nspr/prbit.h diff
    3rdp/win32.release/nspr/include/nspr/prclist.h diff
    3rdp/win32.release/nspr/include/nspr/prcmon.h diff
    3rdp/win32.release/nspr/include/nspr/prcountr.h diff
    3rdp/win32.release/nspr/include/nspr/prcpucfg.h diff
    3rdp/win32.release/nspr/include/nspr/prcvar.h diff
    3rdp/win32.release/nspr/include/nspr/prdtoa.h diff
    3rdp/win32.release/nspr/include/nspr/prenv.h diff
    3rdp/win32.release/nspr/include/nspr/prerr.h diff
    3rdp/win32.release/nspr/include/nspr/prerror.h diff
    3rdp/win32.release/nspr/include/nspr/prinet.h diff
    3rdp/win32.release/nspr/include/nspr/prinit.h diff
    3rdp/win32.release/nspr/include/nspr/prinrval.h diff
    3rdp/win32.release/nspr/include/nspr/prio.h diff
    3rdp/win32.release/nspr/include/nspr/pripcsem.h diff
    3rdp/win32.release/nspr/include/nspr/private/pprio.h diff
    3rdp/win32.release/nspr/include/nspr/private/pprthred.h diff
    3rdp/win32.release/nspr/include/nspr/private/prpriv.h diff
    3rdp/win32.release/nspr/include/nspr/prlink.h diff
    3rdp/win32.release/nspr/include/nspr/prlock.h diff
    3rdp/win32.release/nspr/include/nspr/prlog.h diff
    3rdp/win32.release/nspr/include/nspr/prlong.h diff
    3rdp/win32.release/nspr/include/nspr/prmem.h diff
    3rdp/win32.release/nspr/include/nspr/prmon.h diff
    3rdp/win32.release/nspr/include/nspr/prmwait.h diff
    3rdp/win32.release/nspr/include/nspr/prnetdb.h diff
    3rdp/win32.release/nspr/include/nspr/prolock.h diff
    3rdp/win32.release/nspr/include/nspr/prpdce.h diff
    3rdp/win32.release/nspr/include/nspr/prprf.h diff
    3rdp/win32.release/nspr/include/nspr/prproces.h diff
    3rdp/win32.release/nspr/include/nspr/prrng.h diff
    3rdp/win32.release/nspr/include/nspr/prrwlock.h diff
    3rdp/win32.release/nspr/include/nspr/prshm.h diff
    3rdp/win32.release/nspr/include/nspr/prshma.h diff
    3rdp/win32.release/nspr/include/nspr/prsystem.h diff
    3rdp/win32.release/nspr/include/nspr/prthread.h diff
    3rdp/win32.release/nspr/include/nspr/prtime.h diff
    3rdp/win32.release/nspr/include/nspr/prtpool.h diff
    3rdp/win32.release/nspr/include/nspr/prtrace.h diff
    3rdp/win32.release/nspr/include/nspr/prtypes.h diff
    3rdp/win32.release/nspr/include/nspr/prvrsion.h diff
    3rdp/win32.release/nspr/include/nspr/prwin16.h diff
    3rdp/win32.release/nspr/lib/libnspr4.a diff
    3rdp/win32.release/nspr/lib/libnspr4_s.a diff
    3rdp/win32.release/nspr/lib/libplc4.a diff
    3rdp/win32.release/nspr/lib/libplc4_s.a diff
    3rdp/win32.release/nspr/lib/libplds4.a diff
    3rdp/win32.release/nspr/lib/libplds4_s.a diff
    3rdp/win32.release/nspr/lib/nspr4.dll diff
    3rdp/win32.release/nspr/lib/plc4.dll diff
    3rdp/win32.release/nspr/lib/plds4.dll diff
    3rdp/win64.release/nspr/lib/libnspr4.a diff
    3rdp/win64.release/nspr/lib/libnspr4_s.a diff
    3rdp/win64.release/nspr/lib/libplc4.a diff
    3rdp/win64.release/nspr/lib/libplc4_s.a diff
    3rdp/win64.release/nspr/lib/libplds4.a diff
    3rdp/win64.release/nspr/lib/libplds4_s.a diff
    3rdp/win64.release/nspr/lib/nspr4.dll diff
    3rdp/win64.release/nspr/lib/plc4.dll diff
    3rdp/win64.release/nspr/lib/plds4.dll diff
    Modified Files:

    3rdp/build/Common.gmake diff
    3rdp/build/GNUmakefile diff
    3rdp/build/js-disable-shell.patch diff
    src/build/Common.gmake diff
    src/sbbs3/sbbs.h diff
    Initial work on cross-building sbbs with mingw The big remaining issue is defining *_EXPORTS where needed, which looks rough from a quick glance.

  16. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 18:51:34 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/scfg/scfgnode.c diff
    Remove the "7-bit only" node option The way this option worked was, if enabled (and it was off by default), bit 7 of all character input *before* successful logon would be stripped and bit 7 from all character input of terminals configured as US-ASCII (only) would be stripped after logon. Instead, always strip bit 7 (the 8th bit) of each input character from US-ASCII (only) terminals. Other detected/configured terminals (CP437, UTF-8, PETSCII) won't have bit 7 stripped (ever) since that's likely not a necessary or nice thing to do. There's now no different handling of pre/post logon in this regard. If there's a need to strip parity bits from character input from client terminals that support CP437, UTF-8, or PETSCII, then we'll re-add this feature in but it shouldn't be a per-node setting in that case.

  17. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 19:26:00 GMT-0700 (PDT)
    Modified Files:
    

    exec/upgrade_to_v320.js diff
    src/sbbs3/getkey.cpp diff
    src/sbbs3/scfg/scfgnode.c diff
    src/sbbs3/scfg/scfgsys.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/scfgsave.c diff
    Move "spinning cursor at pause prompt" from node to system config From SCFG->Nodes ... Toggle Options to SCFG->System->Toggle Options And from a bit flag in node_misc to its own bool member of scfg_t.

  18. Rob Swindell (on ChromeOS)
    Sun Mar 24 2024 19:35:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgnode.c diff
    Simplify the node config menu, eliminating Toggles/Advanced Options menus There's only one toggle left (Leave node file open) and not very many advanced options. Unfortuantely, can't easily do the cool left-right cycle through nodes since each node file has to be saved/loaded, but still, easier to visualize any differences between node configs with all the settings on one menu.

  19. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 17:58:20 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Remove obsolete note comment about genwrap.h

  20. Deucе
    Sun Mar 24 2024 16:53:01 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Removed Files:

    3rdp/build/js-always-define-spew.patch diff
    The problem with Bullseye was the 64-bit kernel. The configure script was using uname -m as the build platform, but Bullseye on RPi uses a 64-bit kernel (aarch64 uname -m) with a 32-bit userland (arm gcc build host), which resulted in a lot of bad decsions around JIT stuff. With this change, we explicitly pass the build/host/target values as taken from the compilers in question, which fixes the issue for Bullseye (But may break mingw32? Well we'll see how the pipes go).

  21. Deucе
    Sun Mar 24 2024 15:44:45 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Grow another 4-byte string.

  22. Deucе
    Sun Mar 24 2024 15:41:11 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_file.c diff
    Increase size of file mode string so it's not 4 bytes. 4-bytes is how bit a 32-bit pointer is.

  23. Deucе
    Sun Mar 24 2024 15:17:47 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-always-define-spew.patch diff
    3rdp/build/js-config.guess-libffi.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    Add a couple more patches that appear to enable libmozjs on Raspian This works on Buster at least... update the other config.guess file the same as the top-level one, and always define JaegerSpew() so the JIT stuff isn't broken.

  24. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 01:48:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/AboutBoxFormUnit.dfm diff
    Increment copyright year from 2022 to 2024

  25. Rob Swindell (on Windows 11)
    Sun Mar 24 2024 01:48:48 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/sbbsctrl.bpr diff
    Increment copyright year to 2024

  26. Rob Swindell (on Debian Linux)
    Sun Mar 24 2024 01:45:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsdefs.h diff
    Increment copyright year from 2022 to 2024 Yeah, it's getting about that time...

  27. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 22:03:36 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Auto-detect/correct filename case from file lists Addresses issue reported by Dumas Walker (CAPCITY2) and kk4qbn (KK4QBN) whereby the list contains filenames in the wrong case.

  28. Deucе
    Sat Mar 23 2024 21:24:14 GMT-0700 (PDT)
    Added Files:
    

    exec/load/syncterm_cache.js diff
    Simple untested script to upload a file to the SyncTERM cache. As I said, untested.

  29. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:15:43 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/chat.cpp diff
    Fix CID 33725: Use after close

  30. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:19:00 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/readsauce.c diff
    Fix CID 174408 Unchecked return value from library (fseek)

  31. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:12:59 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix typo in previous commit to this file

  32. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:18:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    More save string copy operations using strlcpy and SAFECOPY Resoles (at least) CID 488305

  33. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:21:43 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/datewrap.c diff
    Fix CID 487672: Dereference null return value gmtime_r() can return NULL

  34. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:32:50 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Use volatile keyword to (maybe) fix CID 488122: Data race condition Ideally, I'd use atomic_bool instead, but we're using an older WinSDK for Win7 compatibility and so... can't. Perhaps an xpdev 'protected_bool_t' should be created.

  35. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:47:28 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    src/sbbs3/sbbs.h diff
    Add/use sbbs_t::fremove() to remove files with logged error on failure This should resolve CID 487088: Unchecked return value from library as well as add some more instrumentation upon unexpected failures removing files. Consider: do some callers of this function need to know the success status (return bool)? That then starts to get into the some callers check and some don't situation (Coverity issue). For now, this is a void function. Also, all remove failures are logged as errors. Consider possibly passing a log level and calling lprintf() instead of errormsg(). errormsg() displays a notice to the user, which maybe we don't want.

  36. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:57:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_bbs.cpp diff
    Fix CID 486181: Resource leak (RESOURCE_LEAK) A couple of error paths in expand_atcodes() method could leak heap memory.

  37. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 17:05:09 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    Fix CID 479078: Resource leak (RESOURCE_LEAK) Passing an unparseable integer to console.editfile() could leak heap memory

  38. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 15:42:29 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Insure buf is null-terminated in getzpt(), resoving CID 488308

  39. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 16:07:54 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sauce.c diff
    SAFECOPY (now using strlcpy) requires the source is terminated ... so use strncpy() and TERMINATE() here (instead of SAFECOPY) to resolve newly reported Coverity issues. There may be other places where we're using SAFECOPY() with an unterminated source string that would've been fine before we switched SAFECOPY from using strncpy to strlcpy. So we should reconsider that change.

  40. Deucе
    Sat Mar 23 2024 10:57:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/syncterm-bounce.js diff
    Re-format b64 encoded images strings so you can see the code. The ppm (image) of course is 24bpp, and the pbm (mask) is 1bpp, so the line lengths are different.

  41. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:34:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ars_defs.h diff
    Comment header clean-up (to re-trigger pipeline) No functional change

  42. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:26:01 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ident.h diff
    Non-functional change (header cleanup) to trigger pipeline

  43. Rob Swindell (on Debian Linux)
    Sat Mar 23 2024 01:08:59 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Enable ccache in Linux builds

  44. Deucе
    Sat Mar 23 2024 00:19:15 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Put EXTRA_FILENAME in the filename

  45. Rob Swindell (on Windows 11)
    Sat Mar 23 2024 00:09:55 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Change spaces to tabs in new strlcpy()

  46. Deucе
    Sat Mar 23 2024 00:05:25 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Attempt to fix corruption issue on FreeBSD. Both sbbs-noskeeters and sbbs-build create sbbs-build.tgz Hopefully this fixes it and doesn't just break it worser.

  47. Deucе
    Fri Mar 22 2024 23:43:21 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/x_cio.c diff
    include genwrap for strlcpy()

  48. Deucе
    Fri Mar 22 2024 23:34:07 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/x_cio.c diff
    src/xpdev/gen_defs.h diff
    Use use strlcpy() in x_cio.c without the wrapper. Reverts gen_defs/genwrap craziness.

  49. Deucе
    Fri Mar 22 2024 23:10:52 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    include genwrap.h at the end of gen_defs.h for strlcpy()/strlcat(). This whole library is starting to get crufty and could use a room at a hackathon.

  50. Deucе
    Fri Mar 22 2024 23:02:40 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    After creating the file in /tmp/gitlab-runner, make it read-only. This should hopefully surface whatever is corrupting the file.

  51. Deucе
    Fri Mar 22 2024 22:51:10 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Oh yeah, can't use wildcards since it's in quotes.

  52. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 22:49:51 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Resolve recently introduced warnings about const char* to char* conversion C++ <sigh> We don't need a .ini section separator anyway.

  53. Deucе
    Fri Mar 22 2024 22:44:30 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Put the job ID in the tarball filename. This should help debug if multiple jobs are writing the same archives.

  54. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 22:04:50 GMT-0700 (PDT)
    Removed Files:
    

    src/sbbs3/v4upgrade.c diff
    src/sbbs3/v4upgrade.vcxproj diff
    Remove the v4upgrade code/project Just about everything in here has been implemented in v3.20 already

  55. Rob Swindell (on Windows 11)
    Fri Mar 22 2024 21:27:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Replace (and auto-upgrade) ctrl/time.dab with time.ini This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future. Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away. After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab

  56. Rob Swindell (on Windows 11)
    Fri Mar 22 2024 21:27:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Convert (and auto-upgrade) ctrl/qnet.dab to ctrl/time.ini as well I suppose this should've been part of the previous commit. Again, this is almost verbatim what v4upgrade.c did (though never actually used).

  57. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 21:00:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ver.cpp diff
    Fix typo in http URL (colon, not semicolon)

  58. Eric Oulashin
    Fri Mar 22 2024 19:19:18 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI()

  59. Rob Swindell
    Fri Mar 22 2024 19:52:08 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_descLines_undefined_fix' into 'master' DDFileLister: (Hopefully) Fix for descLines being undefined in getFileInfoLineArrayForTraditionalUI() See merge request main/sbbs!428

  60. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 12:24:09 GMT-0700 (PDT)
    Modified Files:
    

    exec/addfiles.js diff
    Add better error reporting when listfile can't be found on disk For Dumas Walker (CAPCITY2)

  61. Deucе
    Fri Mar 22 2024 11:52:39 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Stop interlacing preprocessor stuff.

  62. Deucе
    Fri Mar 22 2024 11:50:35 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Borland expects ()

  63. Deucе
    Fri Mar 22 2024 11:48:16 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    static_assert() only available with C11 and higher.

  64. Rob Swindell (on Debian Linux)
    Fri Mar 22 2024 11:47:21 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Fix stale comment about XSAFECOPY (now uses strlcpy, not strncpy)

  65. Deucе
    Fri Mar 22 2024 11:40:31 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Use static_assert() macro instead of _Static_assert keyword More compatible with C++ that way.

  66. Deucе
    Fri Mar 22 2024 11:37:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sauce.c diff
    Remove gratuitous use of comma operator.

  67. Deucе
    Fri Mar 22 2024 11:37:35 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    Use strlcpy() for X?SAFECOPY() macros. Also, for DEBUG builds, add a static assertion that sizeof(dst) != sizeof(void*) to catch the most common breakage.

  68. Deucе
    Fri Mar 22 2024 11:30:53 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Fix issue in last commit Need to update the parameter names as well.

  69. Deucе
    Fri Mar 22 2024 11:17:41 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/gen_defs.h diff
    src/xpdev/genwrap.c diff
    Use strlcpy() for SAFECOPY() and XSAFECOPY() macros. While we're here, Update strlcpy() to slightly more optimal FreeBSD-13.3 version.

  70. Deucе
    Fri Mar 22 2024 10:59:15 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Cpoy/paste strlcat() from FreeBSD 13.3-RELEASE

  71. Deucе
    Fri Mar 22 2024 02:15:06 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/ripper.c diff
    Use safer string things... We really need strlcpy()/strlcat() wrappers in xpdev.

  72. Deucе
    Thu Mar 21 2024 23:38:05 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Now unbreak!

  73. Deucе
    Thu Mar 21 2024 23:33:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Break stuff to test things.

  74. Deucе
    Thu Mar 21 2024 23:24:35 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Instead of converting failures to warnings, run cleanup "always"

  75. Rob Swindell (on Windows 11)
    Thu Mar 21 2024 21:56:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    ftp_remove() returns a bool (not an int) now, so do the right thing

  76. Deucе
    Thu Mar 21 2024 17:24:32 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We need an empty dependencies list, or it will download all the artifacts before deleting temp files. :(

  77. Deucе
    Thu Mar 21 2024 17:12:36 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We can't make cleanup use needs since some platforms don't run tests.

  78. Deucе
    Thu Mar 21 2024 17:09:48 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Fix cleanup needs

  79. Deucе
    Thu Mar 21 2024 17:08:49 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Don't group cleanup either, and don't make it wait.

  80. Deucе
    Thu Mar 21 2024 17:07:04 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Stop grouping the js-testsuite

  81. Deucе
    Thu Mar 21 2024 17:01:44 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Re-enable Darwin Also, allow tests to run as soon as jsdoor is done, and don't use the artifact file, use the local copy instead.

  82. Deucе
    Thu Mar 21 2024 16:56:52 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Disable Darwin build just to see how fast it could be...

  83. Deucе
    Thu Mar 21 2024 16:49:25 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    OpenBSD requires -xzf, fix gtk* extractions

  84. Deucе
    Thu Mar 21 2024 16:36:58 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Everyone has to clean up.

  85. Deucе
    Thu Mar 21 2024 16:34:21 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    A couple more tipoes.

  86. Deucе
    Thu Mar 21 2024 16:31:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Fix typo

  87. Deucе
    Thu Mar 21 2024 16:23:56 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Just slap intermediate results in /tmp/gitlab-runner and call it good

  88. Deucе
    Wed Mar 20 2024 21:49:07 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Nope, that won't work either.

  89. Deucе
    Wed Mar 20 2024 21:36:00 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    More cache fun

  90. Deucе
    Wed Mar 20 2024 21:32:39 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    More cache fiddling. Only on freebsd-amd64 now though... no need to leave stuff laying everywhere.

  91. Deucе
    Wed Mar 20 2024 21:23:24 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Turns out, we can't cleanup caches like that. :(

  92. Deucе
    Wed Mar 20 2024 21:12:26 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Use dependencies, not needs so cleanup runs at end.

  93. Deucе
    Wed Mar 20 2024 21:03:13 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    paths, not files

  94. Deucе
    Wed Mar 20 2024 21:02:11 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Stage, not state

  95. Deucе
    Wed Mar 20 2024 20:59:27 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Experiment for the caches... hoping this doesn't leave an empty zip file laying aorund.

  96. Rob Swindell (on Windows 11)
    Wed Mar 20 2024 20:31:35 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Reduce log severity of QWK-packet removal error log message to WARNING This allows each call to ftp_remote() to specify the log level for any remove failure. All others file-removal failures will continue to log at ERROR level. I get this particular (harmless) error a lot, so just reducing to warning: ftp ... !ERROR 13 (Permission denied) (line 860) removing file: path/to/*.qwk

  97. Deucе
    Wed Mar 20 2024 17:27:04 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We need the .o files to avoid rebuilding in jsdoor target.

  98. Deucе
    Wed Mar 20 2024 16:40:42 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Create a new jsdoor job that depends on sbbs-build. This basically just moves the download of sbbs-build from the test phase to the build phase, so shouldn't result in any speedup.

  99. Deucе
    Wed Mar 20 2024 12:00:03 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Noskeeters need to extend sbbs-build, not sbbs

  100. Deucе
    Wed Mar 20 2024 11:55:53 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Split sbbs into sbbs-build that compiles and sbbs that just combines. This will allow sbbs-build to run in parallel with scfg etc.

  101. Deucе
    Wed Mar 20 2024 11:44:15 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Remove date calls. About ten seconds in extract/patch, two minutes in build.

  102. Deucе
    Wed Mar 20 2024 11:42:00 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Explicitly don't need anything for "root" jobs.

  103. Deucе
    Wed Mar 20 2024 11:27:00 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/cl-fixed-fixed-seed.patch diff
    diff -u, not diff -i :(

  104. Deucе
    Wed Mar 20 2024 11:25:29 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/cl-fixed-fixed-seed.patch diff
    Modified Files:

    .gitlab-ci-unix.yml diff
    3rdp/build/GNUmakefile diff
    Use a fixed fixed seed for CI

  105. Deucе
    Wed Mar 20 2024 11:15:49 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Print the date, not the literal string "date" :(

  106. Deucе
    Wed Mar 20 2024 11:11:27 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Slap some date calls in to profile the pipes.

  107. Deucе
    Wed Mar 20 2024 10:01:29 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Cache the ffi cache.

  108. Deucе
    Wed Mar 20 2024 09:59:21 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-keep-ffi-cache.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Make the ffi cache the same as sm cache but with ".ffi" on the end Allows caching in gitlab.

  109. Deucе
    Wed Mar 20 2024 09:38:49 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    We can't pass on command-line since we want to change it.

  110. Deucе
    Wed Mar 20 2024 09:20:02 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Spell cache-file correctly.

  111. Deucе
    Wed Mar 20 2024 09:10:18 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Attempt to cache the autoconf cache.

  112. Deucе
    Wed Mar 20 2024 02:35:53 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    And finally, ccache raspian.

  113. Deucе
    Wed Mar 20 2024 02:19:44 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    And ccache the rest of alumitron.

  114. Deucе
    Wed Mar 20 2024 01:54:09 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Enable ccache for NetBSD and OpenBSD as well.

  115. Deucе
    Wed Mar 20 2024 01:10:48 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    We need to add RELEASE=1 if we specify build flags manually.

  116. Deucе
    Wed Mar 20 2024 00:44:51 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/GNUmakefile diff
    Use XPDEV_CFLAGS when building. Fixes at least an snprintf() issue on macOS, and likely many other things. It's actually surprising this builds without it to be honest.

  117. Deucе
    Wed Mar 20 2024 01:02:43 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/cl-quote-cc.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    Enable ccache for Darwin. This may or may not actually work, and will certainly need a few runs to build up the cache first.

  118. Deucе
    Tue Mar 19 2024 22:55:06 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    3rdp/build/js-darwin-configure.patch diff
    src/sbbs3/GNUmakefile diff
    Support MacPorts locations as well. Search in both /usr/local (Homebrew) and /opt/local (MacPorts) for libraries. Also, have the name of GNU make be an in option in CI so we can use the Apple-provided make.

  119. Deucе
    Tue Mar 19 2024 11:56:40 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Remove space.

  120. Deucе
    Tue Mar 19 2024 11:54:52 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Most seds apparently don't support -I

  121. Deucе
    Tue Mar 19 2024 11:33:57 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-macosx-minver.patch diff
    src/build/Common.gmake diff
    Default to building for the current macOS version, fix 3rdp Now if you don't specify MIN_MAC_OSX_VERSION, it will use the "current" version of macOS as the target. "Current" is defined as X.0 where the major version (X) is greater than 10 and X.Y when major version is 10. This allows building for a specific target, but uses the newest libraries if you don't specify.

  122. Deucе
    Tue Mar 19 2024 10:59:57 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-macosx-minver.patch diff
    src/build/Common.gmake diff
    Bump the default min supported mac version to 12.0 For Synchronet "stuff", we can trivially change this, but some work needs to be done to enable Spidermonkey and Cryptlib to pick up the chosen value. JS should be fairly simple since it's a configure argument. Cryptlib is a bit trickier since it's in a patch.

  123. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/ctrl/WebCfgDlgUnit.cpp diff
    Bugfix: Log->Base Filename edit box wasn't populated or read ... so the [web] HttpLogFile setting in sbbs.ini couldn't be set using this dialog. Been broken all this time.

  124. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    Fix logic to add the "partially" prefix to download notification messages The file_t struct may not have the size of the file pre-poulated, so we needed to call getfilesize() here.

  125. Rob Swindell (on Windows 11)
    Mon Mar 18 2024 21:21:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix a bunch of false "File sent" logs (and uploader-notifications) Web browsers tend start a download and then immediately close the socket (so now send_failed will be true), while on a secondary socket, do a range download of the same file. So log the range requests/completions and don't log successful file sends when the send was terminated due to a send failure. We still count very small (e.g. 2 byte) ranges as successful file transfers and notify the uploader (of a partial download), so we should fix those issues still. But at least now, there's a whole lot less "noise" created from HTTP[S} file downloads via browser.

  126. Deucе
    Mon Mar 18 2024 20:29:37 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    jsdoor and jsexec both depend on ciolib (and likely others)

  127. Deucе
    Mon Mar 18 2024 20:53:48 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ciolib.c diff
    Don't bother starting the SDL thread just to shut it down. Fixes issue closing SyncTERM in curses mode on macOS.

  128. Deucе
    Mon Mar 18 2024 11:52:49 GMT-0700 (PDT)
    Modified Files:
    

    exec/dorkit/screen.js diff
    Support ignoring CSI n commands. Fixes issue reported from CCO BBS.

  129. Deucе
    Sun Mar 17 2024 21:48:26 GMT-0700 (PDT)
    Added Files:
    

    src/syncterm/DarwinWrappers.h diff
    src/syncterm/DarwinWrappers.m diff
    Modified Files:

    src/build/Common.gmake diff
    src/syncterm/GNUmakefile diff
    src/syncterm/syncterm.c diff
    Add Objective-C wrappers file for Darwin. The native OS calls are ObjC, and the C/C++ APIs are being deprecated, so we need something along these lines. For now, I'm just moving the path "stuff" in there since that's the bulk of the deprecation warnings in building SyncTERM.

  130. Deucе
    Sun Mar 17 2024 15:17:31 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    src/conio/sdl_con.c diff
    Some more macOS fixes... 1) Use static SDL since it's required by both conio and XPDev 2) Since the SDL thread will always run, any attempt to shut down the SDL thread calls exit(0). Not exactly what we want to return, but at least this makes it not hang waiting for the impossible.

  131. Deucе
    Sun Mar 17 2024 15:48:26 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/sdl_con.c diff
    Fix up exit codes on macOS The issue was that the various semaphores and mutexes weren't being initialized at all when sdl_initconio() wasn't called... so starting the event thread and telling it to stop would access uncreated semaphores and mutexes. Split out the init, and be sure to call it before exiting.

  132. Deucе
    Sun Mar 17 2024 14:30:43 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Revert last change reaper is explicitly disabled here.

  133. Deucе
    Sun Mar 17 2024 14:29:20 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Call exit() from exit_sdl_con if ciolib_reaper is enabled and SDL is not initialized.

  134. Deucе
    Sun Mar 17 2024 13:21:22 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    YAML Fixups

  135. Deucе
    Sun Mar 17 2024 13:04:01 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    src/conio/Common.gmake diff
    src/xpdev/Common.gmake diff
    Apparently -framework is a link flag, not a compile one

  136. Deucе
    Sun Mar 17 2024 12:50:05 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Disable jsdoor separate target and build in sbbs3 target JSDoor only compiles one file that isn't shared with the sbbs3 target, so there's no need to build them all twice.

  137. Deucе
    Sun Mar 17 2024 12:29:15 GMT-0700 (PDT)
    Modified Files:
    

    src/conio/sdl_con.c diff
    Do not attempt to clean up SDL unless it was initialized. Should fix js test suite on darwin.

  138. Deucе
    Sun Mar 17 2024 04:28:42 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Argh! Put xpdev libs in the wrong lib!

  139. Deucе
    Sun Mar 17 2024 03:57:18 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Whoops, missed this bit of the macOS patch

  140. Deucе
    Sun Mar 17 2024 03:22:16 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    We can't use version scripts on Darwin.

  141. Deucе
    Sun Mar 17 2024 02:46:11 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Darwin is not a cross-platform build (though the M1 build would be)

  142. Deucе
    Sun Mar 17 2024 02:15:20 GMT-0700 (PDT)
    Added Files:
    

    3rdp/build/js-darwin-configure.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    src/sbbs3/GNUmakefile diff
    src/xpdev/genwrap.h diff
    Fix builds for macOS It builds and appears to run... not actually tested.

  143. Nigel Reed
    Sun Mar 17 2024 02:07:12 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/ircd.ini diff
    ircdcfg would not provide a valid irc.ini file

  144. Rob Swindell
    Sun Mar 17 2024 02:07:13 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/ircd.ini diff
    Merge branch 'fix_template_ircd_ini_for_ircdcfg' into 'master' ircdcfg would not provide a valid irc.ini file See merge request main/sbbs!426

  145. Deucе
    Sun Mar 17 2024 01:34:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Don't use the non-standard third parameter to main for enivronment Use the standard `extern char **environ' instead. Fixes an issue with macOS. Also, check that env is not NULL in js_init.

  146. Deucе
    Sun Mar 17 2024 00:57:14 GMT-0700 (PDT)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    All mac hardware that supports 10.9 also supports 10.11 No real purpose to keeping the default min version at 10.9.

  147. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:26:49 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fixsmb.c diff
    Increment version to fixsmb to v3.20

  148. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:33:33 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Resolve a couple GCC warnings of impossible conditions

  149. Rob Swindell (on Debian Linux)
    Sun Mar 17 2024 00:34:10 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/qwk.cpp diff
    src/sbbs3/un_qwk.cpp diff
    src/sbbs3/un_rep.cpp diff
    Replace some sprintf calls with snprintf ... much more still to do, I'm sure.

  150. Deucе
    Sun Mar 17 2024 00:24:59 GMT-0700 (PDT)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Add a few more PLATFORM_DESC values

  151. Deucе
    Sun Mar 17 2024 00:00:02 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    We need macOS 10.9 for std::atomic

  152. Deucе
    Sun Mar 17 2024 00:04:52 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Make Windows hack Windows-only We need _CIOLIB_main on macOS... at least until the curses stuff works.

  153. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 23:03:52 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/slyvote/slyvote.js diff
    Update netattr flag naming to match smbdefs.js Eliminate some never-defined/used flags (copied from smb.html?)

  154. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:12:51 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/smbdefs.js diff
    White-space fix-ups

  155. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:20:43 GMT-0700 (PDT)
    Modified Files:
    

    exec/emailfiles.js diff
    exec/imapservice.js diff
    exec/load/smbdefs.js diff
    exec/msglist.js diff
    exec/notransit.js diff
    Do the SMB msghdr netattr MSG_* -> NETMSG_* conversion dance Sorry Nightfox, this might break your scripts

  156. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 22:03:32 GMT-0700 (PDT)
    Added Files:
    

    exec/type.js diff
    Modified Files:

    exec/GNUmakefile diff
    Removed Files:

    exec/cntnodes.src diff
    exec/default.src diff
    exec/dir.src diff
    exec/file_io.src diff
    exec/html.src diff
    exec/lbshell.src diff
    exec/menushel.src diff
    exec/noyesbar.src diff
    exec/qnet-ftp.src diff
    exec/socktest.src diff
    exec/type.src diff
    exec/yesnobar.src diff
    Remove old/deprecated Baja mods (replaced with JS or just obsoleted) e.g. stubs for JS command shells, examples of how to do file I/O, socket I/O and such in Baja (which you really shouldn't). Added type.js to replace type.src/bin

  157. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 20:34:30 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/shell_lib.js diff
    Fix user-to-user download function The JS file_area.user_dir is an object (not documented in jsobjs.html!) and bbs.list_file_info() method expects the directory number (not object) as the first argument. Reported by Jas Hud.

  158. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:02:04 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/chksmb.c diff
    src/sbbs3/fixsmb.c diff
    src/sbbs3/getmsg.cpp diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/netmail.cpp diff
    src/sbbs3/sbbsecho.c diff
    src/smblib/smbdefs.h diff
    src/smblib/smbstr.c diff
    Rename SMB message header 'netattr' bit flags to NETMSG_* This resolves the conflict with MSG_HOLD definition in socket.h on MacOS: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/socket.h And hey... [NET]MSG_HOLD isn't actually used anywhere? What's up with that.

  159. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:03:46 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/pack_qwk.cpp diff
    Add "MSGID" to QWK DOOR.ID file This is a "newer" QWK control message supported by Synchronet (for like 20 years now), so it's been missing from the DOOR.ID file all this time and no one noticed. <shrug>

  160. Rob Swindell (on Windows 11)
    Sat Mar 16 2024 20:09:39 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag ... when exporting from SMB to .msg ("stored message") file

  161. Deucе
    Sat Mar 16 2024 19:23:14 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Add missing endif

  162. Deucе
    Sat Mar 16 2024 19:15:15 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Use Homebrew libarchive

  163. Rob Swindell (on Debian Linux)
    Sat Mar 16 2024 18:50:57 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/ircd/core.js diff
    IPs listed in dnsbl_exmempt.cfg are exempt from RBL lookups

  164. Deucе
    Sat Mar 16 2024 18:43:22 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/conio/Common.gmake diff
    src/xpdev/Common.gmake diff
    Fix xpdev and conio builds, disable JS for macOS for now

  165. Deucе
    Sat Mar 16 2024 17:43:13 GMT-0700 (PDT)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add macOS runner

  166. Rob Swindell (on ChromeOS)
    Sat Mar 16 2024 15:43:17 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsub.c diff
    Don't copy/use the Access Requirements of the template sub for newly-added subs We don't clone the Access Requirements from the template sub-board when clonig (intentionally), similarly we shouldn't copy the Access Requirements of the template sub-board when creating/adding/importing new sub-boards either. This should fix issue #736 even though the title and description of the issue is misleading.

  167. Deucе
    Thu Mar 14 2024 16:35:00 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Don't double-space between file locations. Don't want to have to scroll here.

  168. Deucе
    Thu Mar 14 2024 16:19:27 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Fix random upper-case Letter.

  169. Deucе
    Thu Mar 14 2024 16:16:07 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Add upgrade check and "help" text. It basically says "You should move files from where they are to where they should be".

  170. Deucе
    Thu Mar 14 2024 11:32:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/uedit/uedit.c diff
    Make uedit somewhat friendlier to screen readers. Support -iD Use a , instead of CP437 verticla bar as separator. Also fixes bug with active user list.

  171. Deucе
    Thu Mar 14 2024 10:50:39 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Fix windows build

  172. Deucе
    Thu Mar 14 2024 10:46:38 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Move list into .config on *nix Per https://wiki.debian.org/XDGBaseDirectorySpecification, CONFIG should be fairly small files that you would want to maintain in a VCS... the list makes sense here.

  173. Deucе
    Thu Mar 14 2024 10:24:26 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/term.c diff
    Remove unused variable.

  174. Deucе
    Thu Mar 14 2024 10:24:47 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Show SSH keys file path as well.

  175. Deucе
    Thu Mar 14 2024 10:25:03 GMT-0700 (PDT)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Use XDG paths, clean up code Instead of ~/.syncterm, use paths as specified in the XDG Base Directory Specification https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html This should really have something that notifies a user everything moved and instructs them on where each thing should be placed to keep data from older versions.

  176. Rob Swindell (on Debian Linux)
    Wed Mar 13 2024 23:02:19 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Display command shell name along with internal code for new user values Also make it more clear in the online help that some of the new user values are also applied to Guest (G-restricted) account logons.

  177. Eric Oulashin
    Wed Mar 13 2024 20:52:29 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/version_history.txt diff
    DDFileAreaChooser: Fix for the directory item counts

  178. Rob Swindell
    Wed Mar 13 2024 22:40:46 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/readme.txt diff
    xtrn/DDAreaChoosers/version_history.txt diff
    Merge branch 'dd_file_area_chooser_item_count_fix' into 'master' DDFileAreaChooser: Fix for the directory item counts See merge request main/sbbs!425

  179. Eric Oulashin
    Tue Mar 12 2024 15:04:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed)

  180. Rob Swindell
    Tue Mar 12 2024 15:04:11 GMT-0700 (PDT)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_hdr_line_refresh_fix' into 'master' DDFileLister: List header line refresh fix - Right border characters were shifted left 1 char (noticeable when the batch add success dialog closed) See merge request main/sbbs!424

  181. Deucе
    Tue Mar 12 2024 14:33:48 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Disable LTO for now... it appears LTO is more strict with object ordering.

  182. Deucе
    Tue Mar 12 2024 14:12:07 GMT-0700 (PDT)
    Modified Files:
    

    src/build/Common.gmake diff
    Enable LTO unless NO_LTO is defined... We may want to set NO_LTO for the pipeline...

  183. Rob Swindell (on Debian Linux)
    Tue Mar 12 2024 14:00:40 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/fixsmb.c diff
    Don't hash messages with invalid message numbers It's better to have deleted messages without a hash than to hash invalid message numbers. This can be used to address a (renumbered?) message base that Kirkman shared with me with "Invalid Message number" chksmb warnings from hash entries with message numbers > than the base's last_msg.

  184. Deucе
    Tue Mar 12 2024 13:10:00 GMT-0700 (PDT)
    Modified Files:
    

    src/uifc/uifc32.c diff
    Remove non-ASCII char comments. These were originally non-ASCII char literals.

  185. Eric Oulashin
    Tue Mar 12 2024 09:55:29 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js

  186. Rob Swindell
    Tue Mar 12 2024 11:55:29 GMT-0700 (PDT)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_lightbar_menu_substrWithAttr_1_too_long_and_ddfilelister_fix' into 'master' substrWithAttrCodes() fix (string was too long by 1 char; in dd_lightbar_menu.js); a couple of small corresponding updates in ddfilelister.js See merge request main/sbbs!423

  187. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 22:10:30 GMT-0700 (PDT)
    Added Files:
    

    ctrl/text.fr.ini diff
    New French (I'm sure badly translated) language file, a beginning I hope

  188. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 22:10:30 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Add FREE translation (6 chars or fewer is desired) So KOSTEN means "cost" in German, sort of the opposite of FREE. Maybe "!KOST" would get the point across?

  189. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 22:07:19 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Remove obsolete MUTE options

  190. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 22:08:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Actually use the new FREE text.dat string in file listings

  191. Rob Swindell (on Windows 11)
    Mon Mar 11 2024 19:39:02 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/sbbsexec.c diff
    Statically initialize uart to COM1 details, don't rely on VDDInitialize call Older versions of Windows don't (always?) call VDDInitialize(), so we need to statically initialize the uart struct. This should address the problem reported by Fzf (FQBBS) via DOVE-Net: ... When using the included SBBSEXEC.DLL, the UART emulation defaults to base address 0x000 and interrupt 0x0. The lockups do not occur when this is left as-is but none of the UART emulation does anything. Setting a ComPort in a [UART] section of SVDM.INI or SBBSEXEC.INI does change the I/O address and IRQ to an expected value. But this isn't necessary. The mere existence of one of those two INI files, even if empty, sets the UART to the expected default of 0x3F8/IRQ4. The debug entry is always as follows when left without any INI file: [180] SBBS: Virtualizing UART (0x0, IRQ 0) This bug appears to be caused by commit 3ba5aa8d7a663 (1 year ago), where uart was no longer statically-initialzed and relied on VDDInitialize() to be called to copy default_uart to the uart struct.

  192. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:18:31 GMT-0700 (PDT)
    Removed Files:
    

    install/checkout.bat diff
    This file isn't used/useful (no CVS repo anymore, per Nelgin's wishes)

  193. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:19:41 GMT-0700 (PDT)
    Removed Files:
    

    exec/classic_shell.js diff
    This file has been replaced by default.js and lib_shell.js And is now a good example of how to write a Synchronet command shell in JS, though classic_shell.js served its purpose.

  194. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 18:23:06 GMT-0700 (PDT)
    Removed Files:
    

    install/sbbs_src.exclude diff
    install/sbbs_src.lst diff
    install/tarlibs.sh diff
    install/tarsrc.sh diff
    Cruft removal Not sure when the last time these files were used, but it couldn't have been recent.

  195. Rob Swindell (on Debian Linux)
    Mon Mar 11 2024 14:06:28 GMT-0700 (PDT)
    Modified Files:
    

    exec/user_settings.js diff
    Don't allow terminal columns and rows to be set to -1 Range check return value of console.getnum(), as is done in useredit.cpp. The user hitting ^C at eithe of the terminal columns or rows prompts would set that value -1.

  196. Rob Swindell (on Debian Linux)
    Sun Mar 10 2024 16:48:36 GMT-0700 (PDT)
    Modified Files:
    

    ctrl/text.dat diff
    New/changed file-related text strings (see previous commit/merge)

  197. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/smblib/smbdefs.h diff
    src/xpdev/gen_defs.h diff
    Eliminate old macro-wrappers for malloc/free/realloc Artifacts from the 16-bit DOS days where we needed the large or huge "memory model" to allocate > 64KB of memory.

  198. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/listfile.cpp diff
    Removing files via batch flag prompt, don't try to remove cdt for free files

  199. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/file.cpp diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    More details from text.dat strings when removing files or credits Don't display "FREE" in file listings for 0 byte files. When removefcdt() is called for an unknown file uploader, use the new UnknownUploader text.dat string to display the username and filename. When prompting to remove credits, include the username from which to remove the credits. These usability improvements came from watching Deuce struggle to remove malicious uploaded-files and credits from (presumably Guest) user. I should watch sysops manage their BBSes more often.

  200. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Update help text for loadable modules

  201. Rob Swindell (on Windows 11)
    Sun Mar 10 2024 14:52:22 GMT-0700 (PDT)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Update "SendMail Support" menu option and help title

  202. Deucе
    Fri Mar 08 2024 21:38:17 GMT-0800 (PST)
    Modified Files:
    

    exec/lbshell.js diff
    Fix longstanding TODO to get files in a directory. This is likely also broken classic_shell.js, but nobody should ever open that file anymore.

  203. Eric Oulashin
    Fri Mar 08 2024 20:35:01 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen.

  204. Rob Swindell
    Fri Mar 08 2024 20:51:20 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_loadable_module_desc_search_and_ctrl_c_help_screen' into 'master' DDFileLister: Description search as loadable module now works. Added mention of Ctrl-C to the help screen. See merge request main/sbbs!422

  205. Deucе
    Fri Mar 08 2024 20:23:40 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    This will be at least 1.2 Also, it's SyncTERM Cyan, not Syncterm.

  206. Deucе
    Fri Mar 08 2024 09:36:51 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_state setting outside of the ssh mutexes. Doesn't hurt anything where they were, but Coverity kinda reverse suggested it.

  207. Deucе
    Thu Mar 07 2024 21:19:03 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    src/syncterm/bbslist.c diff
    Some menu/help cleanup More documentation of stuff.

  208. Eric Oulashin
    Thu Mar 07 2024 20:51:56 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases

  209. Rob Swindell
    Thu Mar 07 2024 20:51:56 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_DrawPartial_right_edge_fix' into 'master' DDLightbarMenu: Fix in DrawPartial() for an edge case where it was missing the last character of the menu/menu items in some cases See merge request main/sbbs!421

  210. Deucе
    Thu Mar 07 2024 20:19:16 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Manual.txt diff
    More manual noodling.

  211. Deucе
    Thu Mar 07 2024 19:39:55 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Default SFTP Public Key to false. It causes connections to Mystic BBSs to fail, and assumes the server is running OpenSSH (or Synchronet, which is purposefully compatible with OpenSSH). I love the feature, but it's not good enough for on-by-default. After 1.2 is released, and I do a proper sftp client, I'll likely remove the option anyway, and just have a way to upload it on demand.

  212. Deucе
    Thu Mar 07 2024 13:57:28 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_server.c diff
    Fix warning in mingw32 builds about vasprintf()

  213. Deucе
    Thu Mar 07 2024 13:47:05 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_client.c diff
    src/syncterm/ssh.c diff
    Split SFTP client cleanup into to functions. sftp_finish() which ends the communication, disables further commands, and can explicitly be called more than once, and sftp_end() which frees the state. This prevents a race around sftp_finish() calls and sftpc_*() calls which is likely responsibe for various weirdness in SSH connections, and should fix ticket 135.

  214. Deucе
    Thu Mar 07 2024 12:10:46 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_client.c diff
    src/syncterm/ssh.c diff
    Add sftpc_get_err() function and make the sftp client struct hidden This eliminates the hack of using ssh_mutex to protect members of sftp_state (which has its own mutex). This doesn't fix the problem of sftp_state itself though.

  215. Deucе
    Thu Mar 07 2024 11:44:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Fix LOR ion error path.

  216. Deucе
    Thu Mar 07 2024 11:44:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Fix double-unlock and add code for impoosible situation

  217. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:03:53 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    src/sbbs3/targets.mk diff
    Zero-pad (instead of space-pad) the day of month in GIT_DATE This is not consistent with __DATE__ macro expansion, but I like it better Heck, now that we're not really logging the build date much of anywhere, we could go with any other more sensible date format here.

  218. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:05:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/msg_id.c diff
    Include just date in the program-ID (as before) the switch for build->Git date

  219. Rob Swindell (on Debian Linux)
    Thu Mar 07 2024 00:06:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ver.cpp diff
    Restore the additional space before the SMBLIB version

  220. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 23:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Don't use echo to create git_hash.h, collapses multiple spaces Wasn't sufficiently quoting, but we don't need to use echo in the first place Will reconsider using %e instead of %d later

  221. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:12:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    New @-code: GIT_DATE

  222. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:54:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/jsexec.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/msg_id.c diff
    src/sbbs3/sbbscon.c diff
    src/sbbs3/sbbsecho.c diff
    src/sbbs3/sbbsexec.c diff
    src/sbbs3/services.c diff
    src/sbbs3/sexyz.c diff
    src/sbbs3/smbutil.c diff
    src/sbbs3/ver.cpp diff
    src/sbbs3/websrvr.c diff
    Report/log the Git commit date/time, not the build date/time The Git commit date/time is more useful information.

  223. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 22:06:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_system.c diff
    Add system.git_date proprety (string)

  224. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:30:25 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    Use double-quotes for Windows cmd.exe compatibilty

  225. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:25:43 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    We need to double-up the percents in batch lingo

  226. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 17:35:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/GNUmakefile diff
    Kind of sort of fix xptime build (needs math lib now) There's some GNU make sorcery still needed here to address build errors (though it does generate a working executable): /usr/bin/ld: cannot find gcc.linux.x64.obj.debug: file format not recognized /usr/bin/ld: cannot find gcc.linux.x64.lib.debug: file format not recognized /usr/bin/ld: cannot find gcc.linux.x64.exe.debug: file format not recognized

  227. Rob Swindell (on Debian Linux)
    Wed Mar 06 2024 18:12:44 GMT-0800 (PST)
    Modified Files:
    

    src/build/gitinfo.bat diff
    src/sbbs3/targets.mk diff
    src/sbbs3/ver.cpp diff
    src/sbbs3/ver.h diff
    Define GIT_DATE in git_hash.h and git_date in ver.cpp Display the date of last git commit used in this bulid as part of git branch and hash information. This helps to inform how up-to/out-of date the current running build is, regardless of the build date/time.

  228. Deucе
    Wed Mar 06 2024 10:07:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Remove (now) unused variable.

  229. Eric Oulashin
    Tue Mar 05 2024 18:33:55 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    DDFileLister: Removed unnecessary comments & stuff

  230. Rob Swindell
    Tue Mar 05 2024 20:17:00 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    Merge branch 'dd_file_lister_remove_unnecessary_comments_and_stuff' into 'master' DDFileLister: Removed unnecessary comments & stuff See merge request main/sbbs!420

  231. Rob Swindell (on Debian Linux)
    Tue Mar 05 2024 15:33:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/bat_xfer.cpp diff
    Fix warning about impossible condition.

  232. Rob Swindell (on Debian Linux)
    Tue Mar 05 2024 15:34:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_uifc.c diff
    Make uifc.input.CTX and uifc.showbuf.CTX constructors match assumptions/docs This one has caught me up before, for the CTX constructors didn't actually accept any initial property values (as arguments). mlong even documented it this way at https://wiki.synchro.net/ref:uifc#javascript_interface And construted his input.CTXs this way (using all 0 values, which were ignored) in his xtrnmenucfg.js

  233. Deucе
    Tue Mar 05 2024 11:58:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Don't return an error when reading /.. POSIX requires a .. directory in the root of a filesystem, and some SFTP clients (at least Filezilla and WinSCP) assume it's there even if the remote doesn't list it. Per POSIX, /. and /.. are the same directory.

  234. Deucе
    Tue Mar 05 2024 11:45:44 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    src/conio/win32gdi.c diff
    src/conio/x_events.c diff
    Fix for SourceForge issue 134 Translation from mouse coordinates to screen coordinates had issues with internal vs. external scaling and for when there are gutters (ie: black bars) on the edges. This change snaps all gutter clicks to the nearest position inside the window instead of discarding them, and ensures the calculations are correct regardless of scaling mode. Win32GDI mode was not tested, the only change there was to stop ignoring mouse positions in the gutters.

  235. Deucе
    Mon Mar 04 2024 21:15:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp.h diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_str.c diff
    Do lprint() pointer instead of lprintf() pointer. This doesn't make anything better or worse for the C API, but doing variadic pointer things in C++ is fraught.

  236. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 20:43:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Put the 2 SFTP related options next to each other (duh)

  237. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 20:36:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Add the SSH "ANYAUTH" toggle option If the sysop wants their login module to always execute for SSH connections, set to this "Any" rather than the default ("Valid Key or Username").

  238. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:11:45 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    For name ints/enums, allow the value to be longer than the name This allows me to shorten "Informational" to "Info" and "Debugging" to "Debug" and be backward compatible with existing .ini files. I think "Info" and "Debug" are universally known and take up less space (e.g. in SCFG).

  239. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:17:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    Add helper functions for returning lib, grp, dir, and sub short names

  240. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:18:45 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/file.cpp diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/upload.cpp diff
    Add 2 additional arguments to FileAlreadyOnline text.dat string ... the library and directory (short) names Making it more obvious *where* the referenced file has already been uploaded.

  241. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:19:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/email.cpp diff
    src/sbbs3/netmail.cpp diff
    FileAlreadyThere is used as a printf-format elsewehre, do the same here The stock text.dat FileAlreadyOnline string doesn't actually contain a '%s', but if it did, it would've worked as intended in some cases, and broken badly in others. Now fixed for if/when we do actually include the filenaeme (%s) in that string.

  242. Rob Swindell (on Windows 11)
    Mon Mar 04 2024 18:22:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Combine First / Last Node settings on a single option: Serving Nodes And make the PETSCII ports more aligned with the other protocol ports visually. If set to 0, say "<disabled>".

  243. Rob Swindell (on Debian Linux)
    Mon Mar 04 2024 00:12:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Disable the broken textgen running rule by default Should only be run on official sbbs builds anyway

  244. Rob Swindell (on ChromeOS)
    Mon Mar 04 2024 00:02:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/wordwrap.c diff
    src/sbbs3/wordwrap.h diff
    BOOL->bool conversion

  245. Rob Swindell (on ChromeOS)
    Mon Mar 04 2024 00:03:48 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    src/sbbs3/msgtoqwk.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/pack_qwk.cpp diff
    src/sbbs3/qwk.cpp diff
    src/sbbs3/qwk.h diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/targets.mk diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    Add "word-wrap" option for QWK packet creation Some BBS programs (e.g. Synchronet v2) or possibly old offline message readers don't deal well with long-line messages. So add a per-user option to word/line wrap message text. Addresses issue (feature request) #428 Thanks for the reminder fusion @ CFBBS!

  246. Deucе
    Sun Mar 03 2024 19:08:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    "Fix" impossible warning.

  247. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 18:28:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Clear any mouse hot-spots before executing external program from exec_xtrn() As Nelgin pointed out, mouse hot-spots were still active when running external programs (door games) - so clear any active hot-spots before running external programs. This could possibly be done in external() instead, but this sufficient for now. I wouldn't want a menu that EXEC's something (via @-code) to lose all its hot-spots as a result.

  248. Rob Swindell (on Debian Linux)
    Sun Mar 03 2024 14:28:48 GMT-0800 (PST)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    Add SYS_MOUSE_HOT definition

  249. Rob Swindell (on ChromeOS)
    Sun Mar 03 2024 14:15:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Fix some new warnings about unused variable: 'enabled'

  250. Rob Swindell (on ChromeOS)
    Sun Mar 03 2024 14:15:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgsys.c diff
    New toggle option (SCFG->System->Toggles->Mouse Hot-spots in Menus/Prompts) This is for sysops that never want mouse hot-spots in their BBS menus and prompts (e.g. Kirkman, possibly Deuce) - set to "No". Setting to "No" also disables the function of the JS console.add_hotspot() method. Perhaps it should not. <shrug> Setting to "No" does not disable the terminal mouse support question when users are setting their terminal defaults. Perhaps it should. This option should default to enabled (sysops that depend on mouse hot-spots should double check) - it's enabled in new/stock installs.

  251. Deucе
    Sun Mar 03 2024 10:33:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Fix issue when third SSH authentication attempt succeeds Because the session is activated on the *next* time through the loop, if the third attempt to authenticate (including public key) fails, it would leave the session inactive and fail to log in with a confusing error about an obsolete cryptlib. On success, decrement ssh_failed to ensure another pass through the loop. Also, add more debug logging around the auth so you can clearly see each failure, and log client_socket each time so it's clearly grouped.

  252. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 02:46:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    src/sbbs3/websrvr.h diff
    Add NO_HTTP option to web server, for a HTTPS-only web server

  253. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 04:04:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsys.c diff
    Update help text to refer to SCFG->Servers instead of sbbs.ini as reference.

  254. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 04:05:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Move a bunch of protocol support enable/disable and TCP ports to sub-menus ... declutter a bit more of the menus. Also added the new option to disable HTTP support in the web server.

  255. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 01:48:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Change Telnet, SSH, RLogin Support menus to "... Support" instead of "Server" And center the sub-menus.

  256. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 23:53:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp diff
    Clean up comment header block

  257. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 00:52:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.cpp diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.dfm diff
    src/sbbs3/ctrl/TelnetCfgDlgUnit.h diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/scfg/scfgsrvr.c diff
    src/sbbs3/startup.h diff
    Add configurable SFTP session inactivity timer (default: 5 minutes) Allow SFTP support to be enabled/configured in SCFG->Servers and SBBSCTRL->Terminal->Configure. SFTP session inactivity applies to 'H' exempt users too (intentionally).

  258. Rob Swindell (on Windows 11)
    Sun Mar 03 2024 00:55:53 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Set default MaxSessionInactivity to 10 minutes and max SFTP inactivity to 5m

  259. Deucе
    Sat Mar 02 2024 23:06:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Add a function to convert file attributes to a string. And use it in the open() args log.

  260. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:57:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/download.cpp diff
    src/sbbs3/upload.cpp diff
    When logging file transfers, log the file size too (in bytes)

  261. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:58:00 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Re-arrange the [BBS] Options comments, add missing NO_TELNET option

  262. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:58:41 GMT-0800 (PST)
    Modified Files:
    

    docs/v320_new.txt diff
    New stuff documented

  263. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 22:24:38 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_server.c diff
    Fix typo in log message. I use a code editor with a spell checker. <shrug>

  264. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 21:19:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Open files in binary mode This explains the extra calls to record_transfer() on Windows SFTP server I do wonder if we should be usign sopen() or nopen() here instead though.

  265. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 21:12:17 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Include "up/downloaded" in log message for non-filebase-file transfers

  266. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 20:43:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsrvr.c diff
    Put SSH, Telnet, and RLogin settings in their own sub-menus of Terminal Server This makes the Terminal Server settings menu a bit less cluttered. And now we can add more SSH settings (like SFTP, Any Auth).

  267. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 19:37:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/sftp.cpp diff
    Add some log lines for SFTP logins, non-filebase file transfers Q for Deuce: record_transfer() is being called multiple times for non-filebase file transfers, resulting in duplicate log messages. This doesn't happen for filebase file transfer (downloads, anyway).

  268. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:38:52 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Add "Private" translation

  269. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:39:12 GMT-0800 (PST)
    Modified Files:
    

    exec/xtrn_sec.js diff
    Don't try to center on terminals < 80 columns wide

  270. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:37:49 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.dat diff
    Add NodeConnectionSFTP

  271. Rob Swindell (on Debian Linux)
    Sat Mar 02 2024 18:36:38 GMT-0800 (PST)
    Modified Files:
    

    exec/load/nodedefs.js diff
    exec/load/presence_lib.js diff
    exec/load/text.js diff
    Add support for SFTP node status

  272. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 18:23:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/getnode.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/node.c diff
    src/sbbs3/nodedefs.h diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/text.h diff
    src/sbbs3/text_defaults.c diff
    src/sbbs3/text_id.c diff
    src/sbbs3/userdat.c diff
    Address the SFTP logon issues (timeout waiting for keypress, node status, etc) For SFTP sessions, there's no shell/terminal, so no need to run command shells (with their input timeouts, etc.). Reflect the node connection as "via sftp" in the node status. Handle node interruption signal. Probably more to do here with node status/actions (e.g. it'd be nice to set the action to "uploading or "downloading" when appropriate).

  273. Deucе
    Sat Mar 02 2024 17:03:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Make the implied cast explicit rather than change the behaviour.

  274. Deucе
    Sat Mar 02 2024 16:59:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix static casts. These functions take a uint32_t, not a time32_t (which is an int32_t).

  275. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:30:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    Don't update the user's new file scan date/time if it was never set Every SFTP login/off would reset the user's new-file-scan date to Jan-1-1970

  276. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:27:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Resolve some MSVC and GCC warnings with static casts

  277. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 16:12:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_msgbase.c diff
    More use of JS_ValueToECMAUint32 in place of JS_ValueToInt32 To support the full 32-bit range for things like dates/times, and message numbers (!). This should fix issue #732 Though dates beyond Feb 7 2106 are definitely going to still be an issue. I'll definitley look into solving that by the the 2100.

  278. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:34:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    TRUE -> true

  279. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:37:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    client_on() still accepts a BOOL (not bool), so TRUE (not true) is correct

  280. Rob Swindell (on Windows 11)
    Sat Mar 02 2024 15:45:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Initialize sbbs_t::client and call client_on() as expected for logins See sbbs_t::logon() for example Note: the client.protocol is still "SSH" here (not "SFTP"). Perhaps that should be changed? Does any client actually support simultaneous "SSH" and "SFTP" sessions over the same socket?

  281. Deucе
    Sat Mar 02 2024 13:15:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix memory leak in sftp_opendir() Found by Coverity.

  282. Deucе
    Fri Mar 01 2024 22:41:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix array overrun and asprintf() usage, with other warnings. The array overrun crashed Win32, the asprintf() usage imacts glibc and the other warnings are impossible (an exception would have been thrown).

  283. Deucе
    Fri Mar 01 2024 22:10:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp.h diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    Call the lprtinf() callback for all "errors" sent. This includes the "OK" error, and numerous other normal errors, so most of them are logged as LOG_DEBUG.

  284. Deucе
    Fri Mar 01 2024 21:41:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/sftp.cpp diff
    Fix sftp_resolve_path() to return '/' instead of empty string Also fail early if parsing underruns root.

  285. Deucе
    Fri Mar 01 2024 20:58:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Don't use _fullpath() to resolve paths... This Win32 function behaves differently on Win32 than *nix, and does not do what we want. Instead, copy the important bits from xpdev, and resolve a TODO.

  286. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 19:08:54 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Update with new CRYPTLIB_PATCHES value Oops, missed this with the cl32.dll commit.

  287. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 19:06:19 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs3.sln diff
    Add sftp library to sbbs3 MSVC solution I'm not clear on why MSBuild can build the solution without this but the IDE cannot (results in sftp.lib not found, unresolved SFTP symbols, etc.).

  288. Rob Swindell (on Windows 11)
    Fri Mar 01 2024 18:34:43 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    Newest patched Cryptlib 3.4.7 MSVC-build for Win32 <Deuce> Ok, Win32 will need a new cryptlib with these latest patches. Deuceth commandeth, Robeth doeth

  289. Deucе
    Fri Mar 01 2024 16:37:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Fix bug found by Coverity. If a filename failed to be added for a readdir response, it would have just skipped that file and continued with the files around it rather than reporting an error.

  290. Deucе
    Fri Mar 01 2024 13:22:24 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Remove /vfiles and use a dash instead of a big solidus.

  291. Eric Oulashin
    Fri Mar 01 2024 09:10:55 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode)

  292. Rob Swindell
    Fri Mar 01 2024 13:09:23 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_write_item_check_ANSI_before_gotoxy' into 'master' DDLightbarMenu: When writing an item with UTF-8 text, check ANSI support before moving the cursor (and this is important if the menu is being used in non-lightbar mode) See merge request main/sbbs!419

  293. Deucе
    Fri Mar 01 2024 09:02:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Use dir.sname instead of code in the (disabled) /fls tree.

  294. Deucе
    Thu Feb 29 2024 18:53:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Whopps, need <stdexcept> to throw that...

  295. Deucе
    Thu Feb 29 2024 17:18:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/sftp.cpp diff
    Add support for /vfiles in sftp The /vfiles root uses the configured virtual paths as in the FTP and web servers. These paths should be shorter than the ones used in /files, and also have the benefit of translating slashes so users will not need to type a Big Solidus if they're trying to type long lib or dir names.

  296. Deucе
    Thu Feb 29 2024 15:21:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    When responding to an sftp readdir command, send up to 25 files This should speed up directory listings over higher latency links by approximately 25×. You're welcome nelgin.

  297. Deucе
    Thu Feb 29 2024 12:26:41 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Use Big Solidus instead of Division Slash to replace Solidus

  298. Deucе
    Thu Feb 29 2024 12:05:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    Fix a lock derp in the pervious commit, and another lock break in answer()

  299. Deucе
    Thu Feb 29 2024 11:49:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Unlock ssh_mutex before calling sftps_recv() This should fix the sftp hangs... While FreeBSD will return EDEADLOCK when a mutex would deadlock, Linux will do what I ask and deadlock. Since we're not checking the return value of pthread_mutex_lock(), this would go completely unnoticed on FreeBSD, resulting in the mutex being unlocked early and all sorts of unprotected accesses would happen, potentially doing crazy things. On Linux it just deadlocks, and taking a peek at the thread backtraces makes the problem obvious. So, point to Linux for making life more correct for people who do incorrect things (locking without checking the return value). I'd also like to thank nelgin, for sticking with me on this issue and being my gdb puppet. And really, this commit should be shared by all the contributors who... 𝆺𝅥𝅮𝆺𝅥𝅮𝆹𝅥𝅯𝆹𝅥𝅯

  300. Deucе
    Thu Feb 29 2024 09:52:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Allow init_sftp() to safely be called twice. This prevents the case where input_thread() accepts the sftp connection and calls init_sftp(), then answer() does the same thing, clobbering the previous state.

  301. Eric Oulashin
    Thu Feb 29 2024 01:53:20 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text

  302. Rob Swindell
    Thu Feb 29 2024 01:53:20 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_item_write_UTF8_alignment_fix' into 'master' DDLightbarMenu: Fix for text & text column alighment issues with UTF-8 text See merge request main/sbbs!417

  303. Eric Oulashin
    Wed Feb 28 2024 21:34:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions.

  304. Rob Swindell
    Thu Feb 29 2024 01:33:03 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_add_batch_DL_desc_fix_and_extd_desc_refresh_fix' into 'master' DD File Lister: Fix for possibly no file description when adding to the batch DL queue. Also, fix for file description screen refresh (off by one column) for extended descriptions. See merge request main/sbbs!418

  305. Deucе
    Wed Feb 28 2024 20:33:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Not all snprintf()s terminate.

  306. Deucе
    Wed Feb 28 2024 20:44:03 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_server.c diff
    Plug some leaks.

  307. Deucе
    Wed Feb 28 2024 20:49:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_server.c diff
    Some locking cleanups

  308. Deucе
    Wed Feb 28 2024 20:55:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    Heh, fix /files/ check.

  309. Deucе
    Wed Feb 28 2024 15:28:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Prevent the input thread from closing channel that has a session, but does not yet have a session type. Also, fix what appears to be a fairly blatant memory leak.

  310. Deucе
    Wed Feb 28 2024 11:00:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Early-out of the channel type loop for channel errors. If there's an error setting the channel or getting the channel type, give up on the session immediately.

  311. Deucе
    Wed Feb 28 2024 08:51:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Guard against answer() being called before the first channel is created. In this case, just accept whatever we get info on as the "first" one. Likely fixes #728

  312. Rob Swindell (on Debian Linux)
    Tue Feb 27 2024 23:10:14 GMT-0800 (PST)
    Modified Files:
    

    exec/msglist.js diff
    Search forward/backward by subjet without "re:"/"re: " prefix The search seems to be backward by default (at least when listing a sub-board), so should look into that. But at least now you can find replies that include a "re:" prefix easily. Searching by thread should be added too.

  313. Deucе
    Tue Feb 27 2024 20:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-allow-none-auth-svr.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    Add a patch to allow the server to accept the "none" auth method. If the SSH_ANYAUTH option is set, the server will accept the "none" authentication method, and not even suggest the client send a password or public key. The client must still send a user ID, but we just ignore it completely and don't even log it.

  314. Deucе
    Tue Feb 27 2024 20:26:16 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/startup.h diff
    Add SSH_ANYAUTH option. This blindly accepts whatever authentication the remote offers, but does not log into the BBS, dropping the user at the login prompt instead. Closes #726 You're welcome Keyop.

  315. Deucе
    Tue Feb 27 2024 20:20:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Attempt to fix error nelgin reported with ssh session timeouts

  316. Deucе
    Tue Feb 27 2024 14:56:47 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Document the new ALLOW_SFTP option.

  317. Deucе
    Tue Feb 27 2024 14:55:26 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Only log that we're waiting for channel type the first time. The other 500 times are implied.

  318. Deucе
    Tue Feb 27 2024 14:52:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sftp.cpp diff
    src/sftp/sftp_client.c diff
    Fix warnings reported by nelgin. The reason the comparison was changed to <= 0 is to do an explcit check that eliminates negative numbers rather than the implicit ones with the greater-than checks.

  319. Deucе
    Tue Feb 27 2024 14:42:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Name structs to attempt to silence warnings from GCC. It seems that GCC is concerned that we can't create a sftp_dirdescriptor_t or sftp_filedescriptor_t?

  320. Deucе
    Tue Feb 27 2024 12:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-channel-select-both.patch diff
    3rdp/build/cl-fix-shell-exec-types.patch diff
    3rdp/build/cl-ssh-eof-half-close.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/sbbsctrl.bpr diff
    src/sbbs3/js_uifc.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs.vcxproj diff
    src/sbbs3/sbbscon.vcxproj diff
    src/sbbs3/sftp.cpp diff
    src/sbbs3/startup.h diff
    src/sftp/sftp.h diff
    src/sftp/sftp.props diff
    src/sftp/sftp_attr.c diff
    src/sftp/sftp_client.c diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_static.h diff
    src/sftp/sftp_str.c diff
    Removed Files:

    src/sbbs3/sftp.h diff
    Add initial support for SFTP

  321. Rob Swindell
    Tue Feb 27 2024 12:54:24 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-channel-select-both.patch diff
    3rdp/build/cl-fix-shell-exec-types.patch diff
    3rdp/build/cl-ssh-eof-half-close.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/GNUmakefile diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ctrl/sbbsctrl.bpr diff
    src/sbbs3/js_uifc.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/objects.mk diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs.vcxproj diff
    src/sbbs3/sbbscon.vcxproj diff
    src/sbbs3/sftp.cpp diff
    src/sbbs3/startup.h diff
    src/sftp/sftp.h diff
    src/sftp/sftp.props diff
    src/sftp/sftp_attr.c diff
    src/sftp/sftp_client.c diff
    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/sftp/sftp_static.h diff
    src/sftp/sftp_str.c diff
    Removed Files:

    src/sbbs3/sftp.h diff
    Merge branch 'sftp-server' into 'master' Add initial support for SFTP See merge request main/sbbs!415

  322. Eric Oulashin
    Tue Feb 27 2024 09:06:21 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening)

  323. Rob Swindell
    Tue Feb 27 2024 12:52:12 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    Merge branch 'SlyEdit_DCT_quote_win_bottom_border_fix' into 'master' SlyEdit DCT: Fix so that the quote window bottom border is drawn the full width, not 2 characters short (not sure why this started happening) See merge request main/sbbs!416

  324. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:19:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    Don't send NodeLoggedOn message to any nodes if user isn't being logged-on If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user). Reported by Nelgin.

  325. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:00:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_internal.c diff
    Update docs for js.auto_terminate to clarify: disconnection will trigger too User disconnection will trigger auto-terminate (eventually) as well. But only in the terminal server.

  326. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 23:06:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    Change "On two nodes" to "On more than one node", since it's possible it's > 2

  327. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 20:00:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    Fix commit 78dc9470 - wasn't complete For some reason, I committed test code that commented-out the actual call to js_IsTerminated() which avoided the unnecessary error log message. I guess I was testing to confirm the change actually worked. <shrug>

  328. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 22:39:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    sbbs_t::incom() should return NOINP immediately if/when socket disconnected JS console.inkey() and friends use this as the underlying function to get input from the TCP socket. This might address issue #725 Hoping Nelgin will let us know.

  329. Rob Swindell (on Windows 11)
    Mon Feb 26 2024 19:47:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logout.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    Don't send NodeLoggedOff msgs to other nodes if kicked before logon completed Address this problem report: <nelgin> Right but I'm getting a lot of "logged off" without ever having a "logged on" <nelgin> Node 3: Keyop logged off 02/26/24 18:35:45 <nelgin> Node 5: Keyop logged off 02/26/24 18:36:39 <nelgin> There was never a login, so there can't be a logoff. <nelgin> That would break the time-warp continium. <nelgin> time-space whatever :) This could happen when non-G-exempt user was kicked before logon completed due to already being logged onto another node. This change should fix that.

  330. Rob Swindell (on Debian Linux)
    Mon Feb 26 2024 17:51:45 GMT-0800 (PST)
    Modified Files:
    

    exec/archive.js diff
    Insure that archive content listing starts a new line ... when run from the BBS (terminal server)

  331. Rob Swindell (on Debian Linux)
    Mon Feb 26 2024 17:52:22 GMT-0800 (PST)
    Modified Files:
    

    exec/load/avatar_lib.js diff
    Use the common ini formatting for writing avatar data (just a cosmetic change)

  332. Rob Swindell (on Windows 11)
    Sun Feb 25 2024 18:04:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logfile.cpp diff
    Don't log errno value and description as part of ERROR log msg, when 0 If errno is 0, it's definitely no proividing anything of value here. Of course, sometimes errno might be non-zero and still be unrelated to the error message. <shrug> For Nelgin: !ERROR 0 (Success) in exec.cpp line 644 (js_execfile) compiling "something.js" access=0 <nelgin> I don't quite get why a successful execution is logged as an error

  333. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 20:33:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    Increase ini key values to max length Resolve build warning about unused var

  334. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:30:07 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Don't log an error if spy socket write return EPIPE (expected) Also, resove a new gcc warning about signed/unsigned compares.

  335. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:17:34 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    Normalize fullwidth chars to 2-chars (ASCII char, followed by space)

  336. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 20:18:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/umonitor/spyon.c diff
    src/sbbs3/umonitor/spyon.h diff
    src/sbbs3/umonitor/umonitor.c diff
    Support UTF-8 and PETSCII terminal spying Converts UTF-8 output to CP437 equivalent (cterm doesn't yet support UTF-8). Fixes issue #717 (more or less). The terminal dimensions are also read from the node*/terminal.ini file, but aren't applied to the cterm runtime (though maybe they can/should be, probably requires a cterm re-init).

  337. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 17:31:49 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.h diff
    Telnet commands haven't been sent to node-spy ring buffers for years now ... so no need to parse/strip them here.

  338. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 14:54:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Log a warning if failed to write to spy ring buffer

  339. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 14:54:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    Increase size of spy ring buffer from 10K to 100K bytes This eliviates the issue of partial/corrupted UTF-8 sequences when spying on a node serving a UTF-8 terminal.

  340. Eric Oulashin
    Sat Feb 24 2024 13:11:03 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    SlyEdit DCT: Use Math.floor() to create an actual number instead of toFixed(0) like I was in some very old parts of the code. This fixes some cursor position calculations (for the current time, particularly).

  341. Rob Swindell
    Sat Feb 24 2024 13:11:03 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_DCTStuff.js diff
    Merge branch 'SlyEdit_DCT_Math_floor_instead_of_toFixed' into 'master' SlyEdit DCT: Use Math.floor() to create an actual number instead of toFixed(0) like I was in some very old parts of the code. This fixes some cursor position calculations (for the current time, particularly). See merge request main/sbbs!414

  342. Deucе
    Sat Feb 24 2024 11:41:33 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Latest SDL2 only supports macOS 10.7 and above.

  343. Deucе
    Sat Feb 24 2024 10:15:55 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Re-generate patch

  344. Deucе
    Sat Feb 24 2024 08:45:30 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    src/xpdev/dirwrap.h diff
    Looks like that worked... intptr_t the rest.

  345. Deucе
    Sat Feb 24 2024 08:39:32 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Fix glob() for Win64 _fintfirst() is declared in the Mingw-w64 headers as an intptr_t, which tracks. Can't find _findfirst on MSDN, so that's good enough for me... let's see what the pipeline says.

  346. Deucе
    Sat Feb 24 2024 08:32:32 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Remove the mingw32 builds mingw32 has been dead for years, and is missing huge swaths of the Windows APIs. strerror_s() was the straw that broke the camels back here, but there's a lot of hackery for it. I'm not going to go through and actually remove the build support yet since I may want to do the 1.2 SyncTERM release with it (though likely not), but it's not long for this world.

  347. Deucе
    Sat Feb 24 2024 07:07:21 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    Don't imply the callbacks need to be protected by the mutex.

  348. Deucе
    Sat Feb 24 2024 07:07:21 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Expand comment

  349. Nigel Reed
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added NEW-ENVIRON. Note the variable is NEW_ENVIRON

  350. Rob Swindell
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_new_environ_to_telnet_lib' into 'master' Added NEW-ENVIRON. Note the variable is NEW_ENVIRON See merge request main/sbbs!413

  351. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 02:30:22 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Borland C needs the strlcpy definition too The definition of vsnprintf as _vsnprintf didn't seem to hurt the build (as well, for Borland)

  352. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 02:05:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Insure all builds of safe_strerror() write the string to the passed buf The GNU_SOURCE build of this function was (sometimes?) just returning the string and not actually copying it to the passed buf. This is consistent with the GNU manpage on strerror_r(): "This may be either a pointer to a string that the function stores in buf ..." but was inconsistent with all the other build types of this function. Also updated to use strlcpy and write the problematic error number to the default string (if unknown).

  353. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:13:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    Remove new/unused variable: of

  354. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:14:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    src/sbbs3/js_socket.h diff
    Report getaddrinfo() failure result in Socket.error and error_str (not errno) As Nelgin pointed out, a Socket.connect() failure for reasons of address/host lookup failure would report a stale/nonsense Socket.error/error_str value. This change required us to query/store the socket API/getaddrinfo error string at the time of failure (for the Socket.error_str property value) rather than converting from number to string at the time the property is read. This does mean that sometimes Socket.error is a errno value and sometimes its a getaddrinfo (EAI_*) error value. Since the EAI_* values are negative, it should be obvious which is which.

  355. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 00:29:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/NodeFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.h diff
    Support UTF-8 translation to CP437 and non 80x25 terminals Reads the new(ish) node*/terminal.ini file when it's changed to determine the connected-client's terminal type/dimensions. Now reports the terminal details in the spy form title/caption and if it's UTF-8, does a real-time translation to CP437 (since F. Piette's terminal lib only supports CP437). There is a bug here where if the data read from the RingBuffer is a partial UTF-8 sequence, it isn't decoded correctly. Fix that later (?) if it actually bugs anyone. There's no PETSCII conversion/support added here. I expect to someday replace this entirely (likely with something that uses cterm), so didn't want to invest too much time into this. But at least now spying on non-traditional ANSI-BBS clients isn't so terrible to look at.

  356. Deuce
    Fri Feb 23 2024 21:57:58 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    We need to call uifcbail() after calling show_bbslist()

  357. Deuce
    Fri Feb 23 2024 18:27:29 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/syncterm/ssh.c diff
    Fix some especially silly Coverity "issues" These are regarding initializing variables at the same time as the mutex. Harmless.

  358. Nigel Reed
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added MSP, MXP, MSDP and a few other protocols

  359. Rob Swindell
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_mud_protocols_to_telnet_lib' into 'master' Added MSP, MXP, MSDP and a few other protocols See merge request main/sbbs!412

  360. Deuce
    Fri Feb 23 2024 06:43:47 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    We don't need headerBufferUsed... it's already tracked readHeaderFixed() already assumes the same header pointer will be passed in next call if the read is incomplete.

  361. Deuce
    Fri Feb 23 2024 06:31:30 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't just drop out the bottom of the function on timeout. If we don't get one of the commands we're waiting for, close the socket and exit instead of returning with the appearance of having received one.

  362. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:39:41 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't hang if/when nick is rejected Change wait_for() to no longer loop indefinitely. If nick is rejected (e.g. begins with number), prepend '_' to it. Increment version number to 1.62 Fixes issue #723

  363. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:12:51 GMT-0800 (PST)
    Modified Files:
    

    exec/privatemsg.js diff
    exec/sbbsimsg.js diff
    Some localization support (e.g. 'Q'uit translation to another language) What I haven't really worked out is what if the translated word mnemonic is a duplicate of another, valid command key.

  364. Deucе
    Thu Feb 22 2024 20:57:09 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-sbbs-id-string.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Add "(SBBS)" to the SSH ID string. We've patched this thing enough to have a different identifier.

  365. Deucе
    Thu Feb 22 2024 19:04:40 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-do-debug.patch diff
    Make debug a bit less noisy.

  366. Deucе
    Thu Feb 22 2024 19:04:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Instead of keying on the packet being received, key on buffer empty. This should work exactly the same, but is more correct. It's possible that in the future, packet data could be added to the buffer after receiveBufPos, and we could know that no more is required.

  367. Deucе
    Thu Feb 22 2024 19:06:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Catch when cryptFlushData() says the channel is closed. Also, fix an unlikely race condition. This, combined with the cryptlib patches, fixes various weird SSH hangs resulting from partial reads of the SSH packet headers... a rare event that's very hard to trigger. Special thanks to MeaTLoTioN for reporting this, and running a BBS that manages to trigger it reliably. Check out The Quantum Wormhole and say thanks!

  368. Deucе
    Thu Feb 22 2024 19:09:46 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Read SSH packet headers into a fixed buffer in the session info Previously, it was read into a local variable, and in the case of a partial read, everything would go to hell and SSH would hang. "Luckily" this was very hard to trigger.

  369. Deucе
    Thu Feb 22 2024 19:40:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    sftp_channel is always -1 here.

  370. Deucе
    Thu Feb 22 2024 19:41:05 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-service-type-for-channel.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    When the server allows us to open a new channel, use the right type. By default, Cryptlib uses the type of whatever channel happens to be currently selected, so if the server has sent some data, that will be shell. Instead, look up the new channel and use that type info. Ugh.

  371. Deucе
    Thu Feb 22 2024 07:03:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Keep pointers to dll_handle around to solence Coverity issues.

  372. Deucе
    Thu Feb 22 2024 06:55:39 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/datewrap.c diff
    Attempt to silence Coverity warnings about time32_t.

  373. Deucе
    Thu Feb 22 2024 06:31:37 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Use default instead of enum value in warning suppression. This will hopefully keep both Coverity and compilers happy.

  374. Deucе
    Thu Feb 22 2024 06:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Remove do-nothings that Coverity complains do nothing.

  375. Deucе
    Thu Feb 22 2024 06:46:07 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Avoid pasing NULL to strto*() functions. Whill this is perfectly legal and is not a problem, Coverity complains.

  376. Deucе
    Thu Feb 22 2024 06:46:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use SAFECOPY() for no reason. Since old is a strdup() of list->comment, it's known that it will fit, but Coverity doesn't know that.

  377. Deucе
    Thu Feb 22 2024 06:49:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Remove need_copy variable when it won't be used. Fixes Coverity issue.

  378. Deucе
    Thu Feb 22 2024 06:03:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    src/syncterm/term.h diff
    Use shared code for sending login information. The option from the menu (ALT-Z/CTRL-S) was copy/pasted years ago and never updated while the keyboard shortcut (ALT-L) was updated quite a bit. This extracts the ALT-L code into a function and calls it from the menu.

  379. Deucе
    Thu Feb 22 2024 05:35:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix some weirdness around window sizing. This should fix the recent issue when a larger or smaller version is painted inside the window after resize, as well as fix ALT-→ when the current size is not an integer multiple.

  380. Deucе
    Wed Feb 21 2024 12:58:36 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Lower flush count to 3. This is my happy place on the desktop system running xfce4... any higher, and it interferes with how I manage my windows. Hopefully, this value convers the initialization portion perfectly on all systems (hah!).

  381. Deuce
    Wed Feb 21 2024 12:14:50 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Count flushes to disable resize hack. Instead of strictly using "first resize", also count flushes and assume the hack isn't needed after five. Experimentation on my ChromeBook shows 3 to be sufficient, so I'm sing five for now. Odds are that this will still mess with tiling WMs, but I don't use one, so I don't mind yet. I expect this will be better, but likely still not great.

  382. Deucе
    Wed Feb 21 2024 10:53:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Always base scaling on size, and alwayse resize xim. Fixes issue with possible corrupt display when "weird" scaling changes occured.

  383. Deucе
    Wed Feb 21 2024 09:57:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Bugfix and more paranoia in ini*SString() functions. Bugfis: Be sure to terminate value if returning deflt. Paranoia: Terminate value if iniGetString() returns NULL I think the only way to trigger the paranoia is to pass NULL as the default when reading a key that's not present.

  384. Deuce
    Wed Feb 21 2024 09:29:46 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Only count it as the "first resize" if it's not from SendEvent()

  385. Deucе
    Wed Feb 21 2024 09:13:19 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    First attempt to fix "black bars" startup issue. The first time we receive a MapNotify or ConfigureNotify that sets the width and height, resize the window instead of accepting the current window size.

  386. Deucе
    Wed Feb 21 2024 07:46:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Pass user_t as pointer. Silly to pass a 728-byte object as a parameter.

  387. Deucе
    Wed Feb 21 2024 07:23:07 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/conn.c diff
    src/syncterm/conn.h diff
    It appears that in Win64, SOCKET is a long long. No more using the standard int type and having it work. Thanks Microsoft.

  388. Deucе
    Wed Feb 21 2024 07:20:09 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/load.c diff
    Remove apparently unused errno declaration.

  389. Deucе
    Wed Feb 21 2024 07:17:25 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    On Win64, COM_HANDLE is bigger than a long. Use strtoll() to parse number (except when _BORLANDC_ of course)

  390. Deucе
    Wed Feb 21 2024 07:08:45 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    On Win64, HFILE and HANDLE are quite different, use CreateFile() OpenFile() returns HFILE and is sus, CreateFile() is more complex, but returns a HANDLE (and is what MSDN suggests I use).

  391. Deucе
    Wed Feb 21 2024 06:36:18 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.c diff
    Fix warning on Win64 build

  392. Deucе
    Wed Feb 21 2024 06:30:09 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Cast away warning... This is why I returned ret. :D

  393. Deucе
    Wed Feb 21 2024 06:06:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    More input thread cleanup. There was an errant lock in there.

  394. Deucе
    Wed Feb 21 2024 05:42:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    And now Coverity gets into the false warning game. Fix incorrect Coverity issue that speculates this may return fval.

  395. Rob Swindell (on Debian Linux)
    Tue Feb 20 2024 23:54:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Allow UTF-8 sequences in message subjects (passing K_UTF8 to getstr) This was the behavior for all string input in SBBS until recently (Commit 55ccda6294f82506), with this change, an exception is being made for message subjects, but the vast majority of other string input is still limited to single-byte (i.e. US-ASCII or CP437) characters. This should fix issue #720

  396. Deuce
    Tue Feb 20 2024 21:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Use max when we have it, only restore size/scaling in fullscreen mode

  397. Deucе
    Tue Feb 20 2024 20:14:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    src/syncterm/COMPILING diff
    Unlock vstatlock for map_window()

  398. Deucе
    Tue Feb 20 2024 19:21:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/Common.gmake diff
    Find libarchive in 3rdp

  399. Deucе
    Tue Feb 20 2024 19:03:48 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/sdl2/bin/SDL2.dll diff
    3rdp/win64.release/sdl2/bin/sdl2-config diff
    3rdp/win64.release/sdl2/include/SDL2/SDL.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_atomic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_audio.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_bits.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_blendmode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_clipboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_config.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_cpuinfo.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_egl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_endian.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_error.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_events.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_filesystem.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gamecontroller.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gesture.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_guid.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_haptic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hidapi.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hints.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_joystick.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keyboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keycode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_loadso.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_locale.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_main.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_messagebox.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_metal.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_misc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mouse.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mutex.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_name.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl_glext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2ext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_khrplatform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_pixels.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_power.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_quit.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rect.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_render.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_revision.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rwops.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_scancode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_sensor.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_shape.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_stdinc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_surface.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_system.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_syswm.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_common.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_compare.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_crc32.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_font.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_fuzzer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_harness.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_images.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_md5.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_memory.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_random.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_thread.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_timer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_touch.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_types.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_version.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_video.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_vulkan.h diff
    3rdp/win64.release/sdl2/include/SDL2/begin_code.h diff
    3rdp/win64.release/sdl2/include/SDL2/close_code.h diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config-version.cmake diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config.cmake diff
    3rdp/win64.release/sdl2/lib/libSDL2.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.dll.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.la diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.a diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.la diff
    3rdp/win64.release/sdl2/lib/libSDL2main.a diff
    3rdp/win64.release/sdl2/lib/libSDL2main.la diff
    3rdp/win64.release/sdl2/lib/pkgconfig/sdl2.pc diff
    3rdp/win64.release/sdl2/share/aclocal/sdl2.m4 diff
    Add SDL2 for Win64

  400. Deucе
    Tue Feb 20 2024 19:00:02 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/libarchive/bin/archive.dll diff
    3rdp/win64.release/libarchive/include/archive.h diff
    3rdp/win64.release/libarchive/include/archive_entry.h diff
    3rdp/win64.release/libarchive/lib/archive.lib diff
    3rdp/win64.release/libarchive/lib/archive_static.lib diff
    Add win64 libarchive

  401. Deucе
    Tue Feb 20 2024 18:43:27 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    src/sbbs3/GNUmakefile diff
    src/sexpots/GNUmakefile diff
    src/xpdev/strwrap.h diff
    Various fixes for 64-bit support

  402. Deucе
    Tue Feb 20 2024 18:34:56 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-add-win64.patch diff
    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    src/conio/Common.gmake diff
    src/conio/GNUmakefile diff
    src/syncterm/GNUmakefile diff
    src/xpdev/Common.gmake diff
    src/xpdev/GNUmakefile diff
    Add support for building 64-bit binaries using mingw32-w64

  403. Deucе
    Tue Feb 20 2024 16:37:41 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    mingw32-w64 does not include ultoa()

  404. Deucе
    Tue Feb 20 2024 16:35:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Unhack mingw32 hack for mingw32-w64

  405. Deucе
    Tue Feb 20 2024 16:24:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add mingw32-w64 build

  406. Deucе
    Tue Feb 20 2024 16:19:34 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Fix (incorrect) warning from gcc12

  407. Deucе
    Tue Feb 20 2024 16:05:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Finish fixing ini*SString(). The first fix was to copy the right value, the second fix was to ensure zero-length strings are terminated.

  408. Deucе
    Tue Feb 20 2024 15:56:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Partial fix of iniGetSString() and iniReadSString()

  409. Deucе
    Tue Feb 20 2024 15:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio_win32.c diff
    src/conio/win32cio.c diff
    src/syncterm/syncterm.c diff
    src/xpdev/dirwrap.c diff
    src/xpdev/sockwrap.c diff
    Be explicit in more ANSI/Wide functions. Also, fix macro name collision with GetDiskFreeSpaceEx

  410. Deucе
    Tue Feb 20 2024 15:11:02 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Fix mingw32 some more.

  411. Deucе
    Tue Feb 20 2024 15:01:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Fix inverted logic for Mingw32.

  412. Deucе
    Tue Feb 20 2024 14:43:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Whoops, these are for all !_WIN32 and some _WIN32

  413. Deucе
    Tue Feb 20 2024 14:31:28 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Some fixups to allow mingw-w64 to be used where mingw32 is currently working.

  414. Deucе
    Tue Feb 20 2024 05:56:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move an sftp_state check inside mutex to silence Coverity. There's still outstanding issues in Coverity around sftp_state and sftp_channel that need some deep thought, but this one is trivial.

  415. Deucе
    Tue Feb 20 2024 05:07:52 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniGetSString() that takes the size of the buffer

  416. Deucе
    Tue Feb 20 2024 05:10:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use new iniGetSString() for syncterm.lst Prevents buffer overlow with manually edited or corrupted files.

  417. Deucе
    Tue Feb 20 2024 05:21:35 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniReadSString() as well.

  418. Deucе
    Tue Feb 20 2024 05:21:52 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/fonts.c diff
    src/syncterm/syncterm.c diff
    And use iniReadSString() where appropriate in SyncTERM.

  419. Deucе
    Mon Feb 19 2024 16:26:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Call map_window() to update size hints when resizing the window. This way, WMs that enforce aspect ratio etc, won't get potentially block the update.

  420. Deucе
    Mon Feb 19 2024 10:59:31 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/ssh.c diff
    Fix SSH fingerprinting. A hex nybble is not 8 bits, and C strings need to be termianted.

  421. Deucе
    Mon Feb 19 2024 10:11:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Likely fix a bunch of Coverity warnings. This is a very crazy lock/unlock pattern... an extra assignment makes it easier to follow the logic.

  422. Deucе
    Mon Feb 19 2024 09:59:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Expand ssh_mutex over the flushes. This should also resolve a conspiracy Coverity has about two input threads running at the same time.

  423. Deucе
    Mon Feb 19 2024 08:08:49 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Win32 API calls are __stdcall

  424. Deucе
    Mon Feb 19 2024 07:47:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    More fencepost errors in the other direction... This is likely what make the old broken values appear to work.

  425. Deucе
    Mon Feb 19 2024 06:50:08 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    There is something horribly wrong with what sscanf(x, "%2hhx", &cptr) does when compiled with mingw32. Use "anything else" to convert hex to char.

  426. Deucе
    Mon Feb 19 2024 06:06:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/Common.gmake diff
    Use NEED_BITMAP for no fonts, not X11 | SDL Fixes crash when built without X11 or SDL, but with GDI (not default)

  427. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 23:30:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    Display warning dialog when changing cmdshell or xtrn editor's internal codes Changing a command shell or an external editor's internal code will revert the preference of any user's that have selected that shell or editor as their default/preference. A sysop may not realize this, so warn them with lots of detail in the help text if they need it. See issue #721 for details. Also updated the help text for command shell internal codes since it still only mentioned Baja/.bin modules.

  428. Deucе
    Sun Feb 18 2024 18:11:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdlfuncs.c diff
    src/conio/win32gdi.c diff
    Some cleanup, make SDL hyper turbo DPI aware as well.

  429. Deucе
    Sun Feb 18 2024 17:38:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Fix doorway mode. CSI=255h was not entering doorway mode anymore.

  430. Deucе
    Sun Feb 18 2024 14:43:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Fix pervasive fencepost error calculating width and height. Basically everywhere was off by one. Also, fix the get dpi size thingie to correct for window decorations. We never actually use the result of this, but Windows might for outline dragging or something... you can never know.

  431. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 13:01:35 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbsecho.ini diff
    Update lha command-line to match current *nix and Windows releases of lha The extraction destination directory must be specified with the 'w=' option. As Fernando Toledo (@Ragnarok) pointed out: https://gitlab.synchro.net/main/sbbs/-/issues/524#note_4867

  432. Deucе
    Sun Feb 18 2024 12:14:01 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    AdjustWindowRect() can't be used for "High DPI" So do more terrible hackery.

  433. Deucе
    Sun Feb 18 2024 09:46:41 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.rc diff
    Use the last field of the version for release type

  434. Deucе
    Sun Feb 18 2024 09:44:44 GMT-0800 (PST)
    Added Files:
    

    src/syncterm/syncterm.rc diff
    Modified Files:

    src/syncterm/GNUmakefile diff
    Add version info resource.

  435. Deucе
    Sun Feb 18 2024 08:21:51 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.rc diff
    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    None of that worked, use #ifdef __GNUC__ on the manifest. This means ciolib utilities built with MSVC won't have the right manifest information, but the documentation is terrible and I can't figure it out.

  436. Deucе
    Sun Feb 18 2024 08:10:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.props diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    That didn't work, shotgun it into the props files.

  437. Deucе
    Sun Feb 18 2024 08:02:42 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Move no manifest from lib to rc. Looks like this was where it messed up first.

  438. Deucе
    Sun Feb 18 2024 07:52:34 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Slap some more tags in interesting-looking places.

  439. Deucе
    Sun Feb 18 2024 07:44:33 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    Hack up some props.

  440. Deucе
    Sun Feb 18 2024 07:30:05 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.manifest diff
    Apparently the MSVC builds also specify trustInfo in manifest. It appears they just set the default values, so try that out.

  441. Deucе
    Sun Feb 18 2024 07:12:37 GMT-0800 (PST)
    Added Files:
    

    src/conio/ciolib.manifest diff
    Modified Files:

    src/conio/GNUmakefile diff
    src/conio/ciolib.rc diff
    src/conio/win32gdi.c diff
    src/syncterm/GNUmakefile diff
    As it turns out, setting high DPI awareness in the process fails. Presumably, "something" is setting it earlier so it can't be set again because reasons. To work around this, add a manifest to ciolib library that asserts the binary is DPI aware and requests Windows not do GDI scaling. Not sure if manifest .o files in a lib are linked in by things, but SyncTERM pulls the .o out and explicitly links it, so this should fix SyncTERM at least.

  442. Deucе
    Sun Feb 18 2024 05:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Support the third (now preferred) method of setting DPI awareness. We will now try SetProcessDpiAwarenessContext() first, then SetProcessDpiAwareness() second, and finally SetProcessDPIAware() [sic]. Also, "handle" the WM_DPICHANGED event. This may solve problems initializing SyncTERM on systems with two displays that have different DPI settings.

  443. Eric Oulashin
    Sat Feb 17 2024 21:50:33 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js.

  444. Rob Swindell
    Sat Feb 17 2024 22:00:32 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    Merge branch 'slyedit_isPrintableChar_UTF8' into 'master' SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js. See merge request main/sbbs!411

  445. Deucе
    Sat Feb 17 2024 18:18:27 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/CHANGES diff
    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    Show mouse state in status bar, add ALT-O to toggle remote mouse. This allows easy copy/paste without scrollback hacks on BBSs that insist on taking over the mouse just so you can move the mouse and click a character rather than press one key because it's 3l337..

  446. Deucе
    Sat Feb 17 2024 12:16:12 GMT-0800 (PST)
    Modified Files:
    

    xtrn/sbj/GNUmakefile diff
    Depend on .o file and link it. When using $^, all the auto-dependencies are included in the link command-line, which includes sbj.c and all the .h files, causing the link to fail if dependencies exist.

  447. Deucе
    Sat Feb 17 2024 12:01:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_state inside ssh_mutex. This won't matter now since only one thread ever touches it, but when cool stuff happens, it could.

  448. Deucе
    Sat Feb 17 2024 11:45:14 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_channel under the ssh_mutex completely.

  449. Deucе
    Sat Feb 17 2024 11:37:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Remove crufty code that effectively never does anything.

  450. Deucе
    Sat Feb 17 2024 11:26:39 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/syncterm.c diff
    src/syncterm/syncterm.h diff
    src/syncterm/term.c diff
    Store scrollback position before clearing screen at end. This allows ALT-B from dialing directory to show the last seen thing, not the extra blank screen added to the end. Doesn't fix anything, but a huge QoL improvement for people who use ALT-B after disconnecting.

  451. Deucе
    Sat Feb 17 2024 10:35:47 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    For SDL mode, ensure rect matches vstat as well.

  452. Deucе
    Sat Feb 17 2024 10:17:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Ensure the rectangle we're scaling to the screen matches the screen size.

  453. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 22:30:01 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Latest patched cryptlib v3.4.7 for Win32 built with MSVC

  454. Deucе
    Fri Feb 16 2024 21:36:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Make ALT-F4 map to CIO_KEY_QUIT in GDI mode. Fixes issue 124 on Sourceforge.

  455. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:14:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Log the auto-detected character set (e.g. UTF-8, CP437, PETSCII, or US-ASCII)

  456. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:15:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    New console property: unicode_zerowidth (either 0 or 1) The column-width of UNICODE 'zero-width' character is now autodetected. This property allows one to use/change this autodetected width (normally 0 or 1).

  457. Eric Oulashin
    Fri Feb 16 2024 13:00:56 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out.

  458. Rob Swindell
    Fri Feb 16 2024 13:10:59 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_check_settings_fix' into 'master' DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out. See merge request main/sbbs!410

  459. Eric Oulashin
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80"

  460. Rob Swindell
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    Merge branch 'slyedit_settings_UTF8_supported' into 'master' xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80" See merge request main/sbbs!408

  461. Eric Oulashin
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu.

  462. Rob Swindell
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_UTF8_header_items' into 'master' SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu. See merge request main/sbbs!407

  463. Deucе
    Fri Feb 16 2024 10:21:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Info.plist diff
    Add magic value that may allow using internal GPU on macOS.

  464. Deucе
    Fri Feb 16 2024 10:00:23 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Lower timeouts when closing SSH session. Reduces the time after a forced hangup that you need to wait before returning to the main menu.

  465. Deucе
    Fri Feb 16 2024 02:03:30 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/global/random.js diff
    random() has returned the same result four times in a row at least three times since we enabled the test suite. The odds of that happening *should* be one in a million, but NetBSD managed to fail this time (don't remember previous times, and not sure how to find them). For now, I'll just change this so there's a one in a trillion chance.

  466. Deucе
    Fri Feb 16 2024 01:51:28 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Move saved_scaling inside vstatlock. This shouldn't be necessary, but Coverity thinks it's a good idea, and it's simple enough to do without hurting anything.

  467. Deucе
    Fri Feb 16 2024 01:48:27 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    src/conio/win32gdi.c diff
    src/conio/x_events.c diff
    Don't allow ciolib_initial_scaling to be less than 1.0 even if you do math to get there.

  468. Deucе
    Fri Feb 16 2024 01:19:25 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix warning.

  469. Deucе
    Fri Feb 16 2024 01:10:49 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Use strtoull() converting a string to a size_t Except on Borland, which presumably doesn't have strtoull().

  470. Deucе
    Fri Feb 16 2024 01:16:12 GMT-0800 (PST)
    Modified Files:
    

    src/conio/curs_cio.c diff
    src/syncterm/ssh.c diff
    Fix obvious errors found by Coverity. A couple were actually serious, most were unimportant.

  471. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:01:43 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    Fix GCC warning about enum cases not covered in switch

  472. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:02:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/readmsgs.cpp diff
    Add missing #include of utf8.h

  473. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:02:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Use the do/while(0) trick to eliminate warnings w/use of SAEFCOPY_UTF8

  474. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str_util.c diff
    Fixed some lingering FALSE->false conversions

  475. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Lower severity of "Response file path is NULL" log msg from CRIT to WARNING This is not a completely unexpected thing to happen during ungraceful termination

  476. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Use fnopen() for auto-retry when opening dnsbl_exempt.cfg for append

  477. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 22:52:40 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/atcodes.cpp diff
    src/sbbs3/con_hi.cpp diff
    src/sbbs3/con_out.cpp diff
    src/sbbs3/email.cpp diff
    src/sbbs3/getstr.cpp diff
    src/sbbs3/js_global.c diff
    src/sbbs3/postmsg.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    src/xpdev/unicode.c diff
    src/xpdev/unicode.h diff
    UTF-8 improvements Don't corrupt UTF-8 strings with SAFECOPY() (use new SAFECOPY_UTF8). Some terminals (notably, Windows Terminal) display zero width UNICODE chars as a single column-wide space. <sigh> Auto-detect the zero-width "width" (1 or 0) of the terminal during connection and UTF-8 auto-detection. getstr() works a lot better now with UTF-8 strings with wide chars (e.g. emojis), but likely much more to do.

  478. Eric Oulashin
    Thu Feb 15 2024 20:52:48 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: quotes.txt is now in the correct case for the user's editor. "terminalSupportsUTF8 not defined" error eliminated.

  479. Rob Swindell
    Thu Feb 15 2024 21:50:06 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_quotes_txt_case_and_terminalSupportsUTF8_error_fix' into 'master' DDMsgReader: quotes.txt is now in the correct case for the user's editor. "terminalSupportsUTF8 not defined" error eliminated. See merge request main/sbbs!406

  480. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:21:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    src/xpdev/unicode_defs.h diff
    Better unicode character display-width calculation (in columns) Tested with Windows Terminal Version: 1.18.10301.0 and all codepoints between 0x100 and 0x1FFFF, this change reduces the width mismatches from > 8000 to 349. The "Zero width" mismatches are probably the most important/glaring and will need to be addressed next (since some terminals don't move the cursor for zero width chars, and some do).

  481. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:24:53 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    Create utf8_strlcpy() which does a "safe" truncated-string copy (doesn't leave a partial UTF-8 sequence at the end of the destination string). This calls memcpy() for every char, which may not be performant, but I didn't (yet) do any profiling. Hence, no premature optimization either.

  482. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:29:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/textgen.vcxproj diff
    Clean up some empty/unnecessary tags

  483. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:30:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/textgen.c diff
    Don't #include sbbs.h since that includes text.h, which is generated by this Which means that every time textgen was built, it was immediately out of date (and requiring a rebuild).

  484. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:32:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    Log the problem codepoint when reporting error in utf8_encode()

  485. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:36:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Fix bug in previous commit to this file I'm surprised this didn't create a warning somewhere: treating char* as a bool!

  486. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 19:24:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    If the quotes.txt file doesn't exist with the right case, try any case (but prefer the proper/configured case, based on config in SCFG). Works around a problem where DDMsgReader always creates QUOTES.TXT (never quotes.txt), but SBBS tries to read in the file with the case it expects. This wouldn't be a problem on case-insensitive file systems (Windows). Resolves the writemsg.cpp error reported by Nelgin

  487. Eric Oulashin
    Thu Feb 15 2024 15:58:35 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Something has gone wrong with the display of borders.. Reverting back to what I know was a good version of dd_lightbar_menu.js (none of the recent changes are significant).

  488. Rob Swindell
    Thu Feb 15 2024 16:25:26 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_revert_to_last_good' into 'master' DDLightbarMenu: Something has gone wrong with the display of borders.. Reverting back to what I know was a good version of dd_lightbar_menu.js (none of the recent changes are significant). See merge request main/sbbs!405

  489. Deucе
    Thu Feb 15 2024 15:35:38 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Re-enabled use of strtold() for long doubles... it is likely ubiquitous now (except for Borland of course, which doesn't count)

  490. Deucе
    Thu Feb 15 2024 15:29:17 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.h diff
    For reasons lost to history, commit 8b95d6 (18 years ago) disabled long long when compiled with MSVC. Re-enable it.

  491. Deucе
    Thu Feb 15 2024 15:02:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ripper.c diff
    Move fiddling with rip.x_max and rip.y_max out of the vstat mutex. Apparently, fiddling with them in there "strongly implies" to Coverity that vstatlock needs to be held to access them, and it's good form to have the lock held for the least span possible.

  492. Deucе
    Thu Feb 15 2024 13:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/link_list.c diff
    Don't hold a mutex while it's destroyed. Found by Coverity. If there's actually another thread using the list when the refcount hits zero, you're going to have a bad time regardless of the lock. Coverity has been pointing this out for a while, but we've been ignoring it as a false positive.

  493. Deucе
    Thu Feb 15 2024 12:15:54 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/syncterm/term.c diff
    src/xpdev/xpprintf.c diff
    "Fix" low-hanging fruit Coverity issues.

  494. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 11:59:33 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    Default FSEditor config: UTF-8 enabled, Auto-Quote: None, Native: yes

  495. Deucе
    Wed Feb 14 2024 22:17:34 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    Some cleanup, no functional change.

  496. Deucе
    Wed Feb 14 2024 21:38:07 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix pasting in X11 mode... pastebuf should be UTF-8, not ISO-Latin1.

  497. Deucе
    Wed Feb 14 2024 21:38:07 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/newifc_nongen.c diff
    src/newifc/newifc_nongen_after.c diff
    src/newifc/root_window.c diff
    Some more fixins.

  498. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 11:36:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Remove line that was commented-out 14 years ago Commit d1182efc

  499. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 13:19:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/services.c diff
    src/sbbs3/websrvr.c diff
    Recycling servers reverts back to graceful (waiting for clients to disconnect) Commit 63d0772d was initially to address server termination (sisue #236), but expanded in scope to include server recycling (e.g. due to semaphore/config file touch) and that turns out to not be what most sysops want. If you want an immediate/ungraceful recycle, do a restart (shutdown/stop and then start) instead. Immediate/ungraceful server shutdown/termination is still in effect however. No change to the "server pause" feature either, so combining pause with recycle would be effective to prevent *new* client connections while waiting for existing clients to disconnect and allow a recycle to happen.

  500. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 13:49:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_client.c diff
    src/sbbs3/js_system.c diff
    Fix href anchor links in JSDOCS

  501. Rob Swindell (on ChromeOS)
    Wed Feb 14 2024 00:27:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Simplify the child thread wait loop in cleanup()

  502. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 23:35:55 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Set javascript callback "terminated" flag to true when recycling (or terminating) the server. This will allow background JS threads to terminate when recycling, so the server doesn't just hang indefinitelyi when recycling. Add more logging in cleanup() when waiting for children threads to terminate. Also, eliminate the global 'terminate' variable, answering the question: Can this be changed to a if(ws_set!=NULL) check instead? Yes, yes it can.

  503. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 22:41:57 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/newuser.cpp diff
    src/sbbs3/userdat.c diff
    Detect and reject invalid birthdates during new user registration e.g. month and day reversed

  504. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:19:50 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Just a few [JS] text translations, as examples

  505. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:09:59 GMT-0800 (PST)
    Modified Files:
    

    exec/filescancfg.js diff
    exec/msgscancfg.js diff
    Give the scripts the gettext() treatment For easier customization/localization

  506. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:10:40 GMT-0800 (PST)
    Modified Files:
    

    exec/addfiles.js diff
    Fix typo in help text

  507. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 20:34:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Improvements to UTF-8 capable external editor support 1. Add an 8th line to MSGINF (for SlyEdit): the character set expected (either "CP437", the default, or "UTF-8") based on the SCFG configuration 2. Don't apply "Soft-CR" (0x8D) stripping/expansion for UTF-8 editors

  508. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 20:36:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    The "Soft-CR" strip/expansion feature is N/A for UTF-8 editors Updated help text for "Support UTF-8 Encoding" for external editors.

  509. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 18:07:07 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Apparently Borland actually used 'enum text_modes' in conio.h. Follow suit. *This* is the way. Oops.

  510. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 18:03:04 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    Change enum text_modes (plural) to enum text_mode (singular) This is the way.

  511. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 17:51:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Need to include ciolib.h for enum text_mode definition

  512. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 17:42:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Make the default text (video) mode "LCD 80x25" (42), square pixel 80x25 mode This was the auto/default mode before commit c9cf87da If you really want the VGA aspect ratio, use the '-v41' option.

  513. Eric Oulashin
    Tue Feb 13 2024 13:49:03 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Revert the text item width fill that was committed yesterday, as it seems to write too much in some cases

  514. Rob Swindell
    Tue Feb 13 2024 15:19:43 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_draw_item_fill_revert' into 'master' DDLightbarMenu: Revert the text item width fill that was committed yesterday, as it seems to write too much in some cases See merge request main/sbbs!404

  515. Deucе
    Tue Feb 13 2024 15:11:24 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/newifc_nongen_after.c diff
    src/newifc/root_window.c diff
    Add a dirty bit. dirty = true propogates up, dirty = false propogates down.

  516. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 22:16:12 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Re-enable the SyncTERM-MSVC build job

  517. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 22:07:34 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    include ssh.h to fix MSVC warning about undefined init_crypt

  518. Eric Oulashin
    Mon Feb 12 2024 21:49:58 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    SlyEdit: UTF-8 support in the displayed header and when quoting text and when quoting message text. This also includes a dd_lightbar_menu.js update

  519. Rob Swindell
    Mon Feb 12 2024 21:49:58 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    Merge branch 'SlyEdit_UTF8_in_header_and_quoting' into 'master' SlyEdit: UTF-8 support in the displayed header and when quoting text and when quoting message text. This also includes a dd_lightbar_menu.js update See merge request main/sbbs!403

  520. Deucе
    Mon Feb 12 2024 21:46:58 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/syncterm/CMakeLists.txt diff
    src/syncterm/GNUmakefile diff
    src/syncterm/SyncTERM.vcxproj diff
    src/syncterm/extdeps.mk diff
    src/syncterm/ssh.c diff
    src/syncterm/ssh.h diff
    src/syncterm/syncterm.c diff
    src/syncterm/telnets.c diff
    Removed Files:

    src/syncterm/st_crypt.c diff
    src/syncterm/st_crypt.h diff
    Remove dlopen support. Since we're modifying cryptlib anyway, we can't just dlopen any old cryptlib library. Require linking with the lib. This will break the MSVC build, so disable that for now.

  521. Deucе
    Mon Feb 12 2024 20:36:00 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/st_crypt.h diff
    Nope, can't use C_RET either.

  522. Deucе
    Mon Feb 12 2024 20:09:01 GMT-0800 (PST)
    Added Files:
    

    src/newifc/newifc_nongen_after.c diff
    src/newifc/sizer_cell.c diff
    Modified Files:

    src/newifc/GNUmakefile diff
    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Checkpoint

  523. Deucе
    Mon Feb 12 2024 20:09:01 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/st_crypt.h diff
    Use C_RET for cryptlib symbols. Given how patched up cryptlib is at this point, this is all likely to go away and just use the static lib in the nearish future.

  524. Deucе
    Mon Feb 12 2024 20:23:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    If call to GetAttributeString() fails, we have a lot worse problems than err_len containing garbage. Handle the error and mention we didn't get the message. While we're here, check the return value of malloc().

  525. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 19:10:21 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Zero-Iniitalize err_len If call to GetAttributeString() fails, err_len can contain garbage.

  526. Deucе
    Mon Feb 12 2024 14:53:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Don't use i for loop index since it's signed.

  527. Deucе
    Mon Feb 12 2024 14:40:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/conn_pty.c diff
    Initialize c_cc in SyncTERM as well.

  528. Deucе
    Mon Feb 12 2024 14:26:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Explicitly initialize c_cc to _POSIX_VDISABLE since we can't know that we're setting all the values anymore. :(

  529. Deucе
    Mon Feb 12 2024 13:56:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Since on at least Debian 12.4, the ttydefaults array is completely wrong, do c_cc the stupid (but POSIXly correct) way with a billion supporting.

  530. Rob Swindell (on Debian Linux)
    Mon Feb 12 2024 10:49:37 GMT-0800 (PST)
    Modified Files:
    

    exec/user_settings.js diff
    Enable raw input mode when prompting for backspace key Since the user we're editing here is not a pointer to the current user, changing the USER_SWAP_DELETE settings before this prompt doesn't prevent the DEL->BS translation from happening. Raw input mode does. Without this change, it would appear the user's backspace key would toggle between sending either ^H or DEL for the backspace key (for terminals that actually send DEL).

  531. Deucе
    Mon Feb 12 2024 10:33:40 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    When backspace sends delete, send CSI 3 ~ for delete.

  532. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 10:27:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Resolve warning: enumeration value ‘FILE_SORT_NATURAL’ not handled in switch

  533. Eric Oulashin
    Mon Feb 12 2024 09:47:30 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    SlyEdit readme: Removed extraneous description about UTF-8 support and left it as a simple blurb

  534. Rob Swindell
    Mon Feb 12 2024 10:24:44 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    Merge branch 'slyedit_readme_UTF8_update' into 'master' SlyEdit readme: Removed extraneous description about UTF-8 support and left it as a simple blurb See merge request main/sbbs!401

  535. Deucе
    Mon Feb 12 2024 10:18:59 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    Actually fall-through like the comment says.

  536. Deucе
    Mon Feb 12 2024 10:12:15 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    src/conio/cterm.h diff
    src/conio/cterm.txt diff
    src/syncterm/term.c diff
    Add support for DECBKM.

  537. Deucе
    Mon Feb 12 2024 09:41:20 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/test.js diff
    More fixins to get error message.

  538. Deucе
    Mon Feb 12 2024 09:33:35 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/chatfuncs.c diff
    Ugh, indentation with spaces. Monster.

  539. Deucе
    Mon Feb 12 2024 09:29:57 GMT-0800 (PST)
    Modified Files:
    

    xtrn/tbd/reroll.c diff
    Fix warning. This line has always been there and never done anything.

  540. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_mqtt.c diff
    Fix heap corruption in Windows builds This bug caused crashes in the Windows build of sbbs when using the ;spy sysop command with MQTT enabled. Memory that is allocated in one DLL (e.g. sbbs.dll) must be freed in that same DLL (e.g. sbbs.dll, not mosquitto.dll). mosquitto_message_free() here frees the msg pointer, but we didn't allocate it in mosquitto.dll in the first place, so that's wrong. The proper mosquitto function to use in this case is mosquitto_message_free_contents().

  541. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    docs/v320_new.txt diff
    More new v3.20 stuff

  542. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    node1/node.ini diff
    A couple obsolete keys removed from running SCFG on this

  543. Eric Oulashin
    Sun Feb 11 2024 21:00:10 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much)

  544. Rob Swindell
    Sun Feb 11 2024 21:00:10 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_UTF8_support' into 'master' SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much) See merge request main/sbbs!400

  545. Rob Swindell (on Debian Linux)
    Sun Feb 11 2024 16:54:49 GMT-0800 (PST)
    Modified Files:
    

    exec/mqtt_spy.js diff
    Support spying node being a UTF-8 terminal console.write() converts CP437->UTF-8, so use write_raw() instead since we're already doing the CP437->UTF-8 conversion here. As reported by Keyop.

  546. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 14:38:18 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.vcxproj diff
    Set release project to use MBCS, not UNICODE (UCS-2). Debug project was already set this way.

  547. Deucе
    Sun Feb 11 2024 14:15:28 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Disable a few more warnings... the rest look useful.

  548. Deucе
    Sun Feb 11 2024 14:17:24 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ooii.c diff
    Since xp_play_sample() no longer takes a const buffer, we need to cast all the const buffers before passing them in and rely on runtime crashes to find bugs rather than compile-time errors. Thanks Microsoft. :D

  549. Deucе
    Sun Feb 11 2024 14:11:15 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/mouse.c diff
    src/conio/win32gdi.c diff
    src/sftp/sftp_attr.c diff
    src/syncterm/bbslist.c diff
    src/syncterm/conn.c diff
    src/syncterm/ssh.c diff
    src/syncterm/telnet_io.c diff
    Disable warnings more places.

  550. Deucе
    Sun Feb 11 2024 14:06:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    src/xpdev/xp_dl.c diff
    src/xpdev/xpbeep.c diff
    src/xpdev/xpbeep.h diff
    Resolve more MSVC warnings.

  551. Deucе
    Sun Feb 11 2024 13:56:44 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/conio/cterm.c diff
    src/conio/scale.c diff
    src/conio/sdl_con.c diff
    src/syncterm/ooii.c diff
    src/syncterm/term.c diff
    Disable warnings in more source files.

  552. Deucе
    Sun Feb 11 2024 13:38:03 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Disable MSVC warnings 4244 and 4267. The alternative is to explicitly copy/paste the type everywhere forcing the compiler to do the only thing it could possibly do, and making it painful to change a type later. Honestly, in my opinion, these warnings should just be disabled completely everywhere.

  553. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Fix macro recusion protection for macros 32-63. Found by MSVC

  554. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Fix MSVC warning about defined standard C features.

  555. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Actually remove the const the comment says I can't have.

  556. Deucе
    Sat Feb 10 2024 22:27:53 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.c diff
    Fix misleading comment

  557. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 22:09:55 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    _MSC_VER is the macro name you're looking for there :-)

  558. Deucе
    Sat Feb 10 2024 21:56:01 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    This value is apparently sometimes an enum, sometimes a macro. Just use the raw value and a comment.

  559. Deucе
    Sat Feb 10 2024 21:48:59 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Fix some warnings. We can't use const protection for the sample buffer because the Win32 API takes non-const buffers. For standard implicit conversions, simply disable the warning where it occurs on purpose. It appears that MSVC builds use the equivilent of -Wconversion (which isn't even part of -Wall).

  560. Rob Swindell (on Debian Linux)
    Sat Feb 10 2024 21:34:39 GMT-0800 (PST)
    Modified Files:
    

    exec/filelist.js diff
    Fix issues with file sorting The case-sensitive/insensitive logic was backwards (-i enabled case-sensitive sorting) The re-sorting by name was always occurring when the -sort option was used. Case-insensitive sorting by numeric properties (e.g. size) didn't work right.

  561. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 21:06:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Separate "natural" (no sort) order from "Date ascending" sort order for dirs Since it is possible for someone to change the add/import date of a file after it's been added to the filebase, the natural/unsorted order might not actually be the same as "date ascending", so let the sysop/script-author really re-sort by date ascending if that's what they're trying to do. I think this is addresses the issue that Nightfox and Nelgin were describing in #synchronet.

  562. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 17:12:07 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    nodestatus() print internal code rather than xtrn number, if possible (as a fall back to the full external program name).

  563. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:37:46 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpdev.props diff
    Define HAS_INTTYPES_H (for singled-threaded xpdev) here too

  564. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:38:39 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32cio.c diff
    src/conio/win32gdi.c diff
    Resolve some MSVC warnings by including missing header files

  565. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:39:52 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    Resolve some MSVC warnings

  566. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:41:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mqtt.c diff
    src/sbbs3/putnode.cpp diff
    Resolve off-by-one issue in MQTT node status publishing Make mqtt_putnodedat() use a 1-based node number, like the other putnodedat() functions. The bug (misuse of mqtt_putnodedat) was actually in js_system.c, but fixed the API to match the common expectation.

  567. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:42:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/userdat.c diff
    nodestatus() use the user record's curxtrn internal code rather than aux value ... to determine/print the current external progarm being run. This fixes issue #716

  568. Eric Oulashin
    Sat Feb 10 2024 15:09:30 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD File Lister: New sort option in the config file: PER_DIR_CFG, which has Synchronet sort the file list according to the file directory's configuration

  569. Rob Swindell
    Sat Feb 10 2024 15:09:30 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_sort_according_to_dir_config' into 'master' DD File Lister: New sort option in the config file: PER_DIR_CFG, which has Synchronet sort the file list according to the file directory's configuration See merge request main/sbbs!399

  570. Eric Oulashin
    Sat Feb 10 2024 11:23:31 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: DrawPartial() width check update (previously it wasn't re-drawing the last character of the item text)

  571. Rob Swindell
    Sat Feb 10 2024 13:05:18 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_DrawPartial_width_check_update' into 'master' DDLightbarMenu: DrawPartial() width check update (previously it wasn't re-drawing the last character of the item text) See merge request main/sbbs!398

  572. Deucе
    Fri Feb 09 2024 22:38:06 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/test.js diff
    Log fail_msg, not the out-of-scope e. Hopefully, we'll find out why the random test fails sometimes...

  573. Deucе
    Fri Feb 09 2024 22:26:36 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Final cleanups after wikification

  574. Deucе
    Fri Feb 09 2024 19:12:48 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Some more fixes found from wikifying.

  575. Deucе
    Fri Feb 09 2024 18:35:02 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Fix warnings caused by our patches.

  576. Deucе
    Fri Feb 09 2024 10:35:42 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-read-timeout-every-time.patch diff
    src/sbbs3/websrvr.c diff
    Proper fix for wiki edit failures. The patch that sets the read timeout every time for getData() was flawed, because getData() itself will sometimes set the read timeout for the next call. The patch was intended to ensure that the write timeout never clobbers the read timeout, so now we track if getData() explicitly set the timeout and if it did, we don't reset it.

  577. Deucе
    Fri Feb 09 2024 10:13:16 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Whoops, remove the debug patch again.

  578. Deucе
    Fri Feb 09 2024 10:03:02 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    src/sbbs3/websrvr.c diff
    With TLS, errno isn't set, so logging it is just confusing.

  579. Deucе
    Fri Feb 09 2024 09:05:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Temporary workaround for TLS issue. It appears that if the timing is "just wrong", a large POST can cause TLS to fail. This has shown up as an inability to edit pages in the wiki. This is not a fix however, but simple a workaround until this is root-caused.

  580. Deucе
    Thu Feb 08 2024 23:37:19 GMT-0800 (PST)
    Modified Files:
    

    xtrn/termtest/termtest.js diff
    Add a regression test for bug fixed in previous commit.

  581. Deucе
    Thu Feb 08 2024 23:04:43 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/conio/cterm.c diff
    Fix crash found by vttest. If DL was passed a parameter equal to or greater than the number of lines from the current line to the last line in the region, it would try to move a negative-sized box up, which resulted in a crash. This fixes that three ways: 1) Do not allow moving boxes with negative X/Y sizes 2) In dellines, clamp the lines to the number that could be deleted 3) Don't move lines up of all rest of the lines are being deleted

  582. Deucе
    Thu Feb 08 2024 15:53:49 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Only take the early-out data path required to make SSH channels work for SSH sessions. May fix the issues seen updating wiki pages, may not, but is a less invasive patch either way.

  583. Deucе
    Thu Feb 08 2024 15:50:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Some updates I made while doing a wiki version I can't currently POST.

  584. Deucе
    Thu Feb 08 2024 08:40:25 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Fix memory leak on realloc failure in xp_aprintf_next() The caller of this function must clobber the passed in pointer, and we're returning NULL meaning we would be overwriting the pointer to the allocation.

  585. Deucе
    Thu Feb 08 2024 01:23:49 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Possible fix warning in xpprintf() about using a pointer after free. If this *does* work, it means that potentially a huge chunk of our error checking hasn't actually worked in release builds or builds that use the FORTIFY option.

  586. Rob Swindell (on Debian Linux)
    Thu Feb 08 2024 00:43:57 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Use -Og for fortified debug builds (rather than -O1)

  587. Deucе
    Wed Feb 07 2024 23:55:41 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Allow FORTIFY=1 to work on RELEASE builds too. At some point, we should consider making it default.

  588. Deucе
    Wed Feb 07 2024 23:16:28 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Bow to GCC harder.

  589. Deucе
    Wed Feb 07 2024 23:13:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Add missing =

  590. Deucе
    Wed Feb 07 2024 23:07:33 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Silence gcc warning by using blinking bright-red on red if algo is broken.

  591. Deucе
    Wed Feb 07 2024 22:59:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    asprintf() on Linux does not guarantee to set the ptr to NULL on error.

  592. Rob Swindell (on Debian Linux)
    Wed Feb 07 2024 22:30:50 GMT-0800 (PST)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    src/sbbs3/inkey.cpp diff
    src/sbbs3/sbbsdefs.h diff
    inkey() now returns CP437 characters by default K_CP437 changed to K_UTF8 with the inverted logic. If you have code/script that can handle UTF-8 input, then you need to specify K_UTF8 in calls to inkey, getkey, getstr. Or else, you're going to get a CP437 translated version of any non-ASCII (UNICODE) UTF-8 chars, if there's a mapping available. This only impacts UTF-8 terminals. There are just so many places in Synchronet where UTF-8 input could cause problems, it makes sense to translate UTF-8 to CP437 by default and make true UNICODE/UTF-8 handling the exception. Sorry Nightfox, you'll need to remove the K_CP437 detection/use code you just added to SlyEdit.

  593. Rob Swindell (on Debian Linux)
    Wed Feb 07 2024 22:38:00 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    Pass K_UTF8 mode flag to console.inkey() Since this script supports/expects UTF-8 character sequences for UNICODE characters (not a CP437 translated version of mappable chars).

  594. Deucе
    Wed Feb 07 2024 20:37:17 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Add -MP with -MMD This creates a .PHONY target for each file so that if a header is renamed, the impact will be the files that include it being rebuilt instead of the previous behaviour where the build would simply fail and complain that the file doesn't exist.

  595. Eric Oulashin
    Wed Feb 07 2024 19:09:08 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Support for entering UTF-8/Unicode characters; using K_CP437 to have Synchronet convert to CP437 internally

  596. Rob Swindell
    Wed Feb 07 2024 19:32:01 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_K_CP437_text_input' into 'master' SlyEdit: Support for entering UTF-8/Unicode characters; using K_CP437 to have Synchronet convert to CP437 internally See merge request main/sbbs!397

  597. Deucе
    Wed Feb 07 2024 18:12:07 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Group Windows jobs, delete commented out old Linux jobs.

  598. Deucе
    Wed Feb 07 2024 17:51:32 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Do not use -Werror in CI. We don't want CI to die because someone somewhere upgrade a compiler.

  599. Deucе
    Wed Feb 07 2024 17:29:23 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    We're now warning-free... enable -Werror for CI. NOTE: CI does release builds, which means that -Wall is not enabled. WALL=1 could be added if we want that, but it's likely too soon to take that step.

  600. Deucе
    Wed Feb 07 2024 17:24:33 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    UIFC uses ciolib.

  601. Deucе
    Wed Feb 07 2024 17:25:52 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/uifc/GNUmakefile diff
    UIFC does not need libciolib_mt.a to build.

  602. Deucе
    Wed Feb 07 2024 17:15:59 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Fix backslash alignment when 8-position tabs are used.

  603. Deucе
    Wed Feb 07 2024 17:14:32 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Fix typo.

  604. Deucе
    Wed Feb 07 2024 17:12:54 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    One last attempt... cast the whole thing to uint8_t and take a pointer to an element. No way gcc has a clue about what I'm doing then.

  605. Deucе
    Wed Feb 07 2024 17:09:56 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Revert sftp_pkt.c

  606. Deucе
    Wed Feb 07 2024 17:06:40 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Looks like I just need to live with the warning for now. Maybe I'll figure out how to fix it later.

  607. Deucе
    Wed Feb 07 2024 16:59:45 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Can't put a flexible array member in a union... add another anonymous struct layer.

  608. Deucе
    Wed Feb 07 2024 16:58:24 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Add missing semi-colon.

  609. Deucе
    Wed Feb 07 2024 16:56:39 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_pkt.c diff
    Try an anonymous union containing an anonymouse struct to fix it.

  610. Deucе
    Wed Feb 07 2024 16:50:12 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Get a bit more creative in casting (to shut up gcc)

  611. Deucе
    Wed Feb 07 2024 16:44:30 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Attempt to tell gcc I know what I'm doing with a void* cast

  612. Deucе
    Wed Feb 07 2024 16:46:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/buildfont.c diff
    Fix warning about another incorrect-sized array.

  613. Deucе
    Wed Feb 07 2024 16:30:41 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    If it needs libsbbs, it needs spidermonkey (except for gtkuserlist?)

  614. Deucе
    Wed Feb 07 2024 16:25:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkuserlist/GNUmakefile diff
    Add CRYPT_CFLAGS back in. :(

  615. Deucе
    Wed Feb 07 2024 16:24:31 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    src/sbbs3/gtkuserlist/gtkuserlist.h diff
    Actually, everything but gtkchat appears to link with libsbbs.so

  616. Deucе
    Wed Feb 07 2024 16:19:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkuserlist/GNUmakefile diff
    src/sbbs3/gtkuserlist/gtkuserlist.h diff
    gtkuserlist doesn't need cryptlib

  617. Deucе
    Wed Feb 07 2024 16:14:51 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/chatfuncs.c diff
    src/sbbs3/gtkchat/main.c diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    They all need no cryptlib it seems

  618. Deucе
    Wed Feb 07 2024 16:10:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    Disable cryptlib in sbbs.h as well (but re-enable it)

  619. Deucе
    Wed Feb 07 2024 16:07:45 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Move noskeeters into the freebsd-amd64 group

  620. Deucе
    Wed Feb 07 2024 16:06:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    And no JS here either.

  621. Deucе
    Wed Feb 07 2024 15:53:05 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Update smoketest depend

  622. Deucе
    Wed Feb 07 2024 15:51:52 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/sbbs3/gtkchat/chatfuncs.c diff
    src/sbbs3/gtkchat/main.c diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    Comment-out "classic" Linux builds, "disable Javascript" for sbbs.h in gtk utils

  623. Deucе
    Wed Feb 07 2024 15:47:00 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Add Linux group.

  624. Deucе
    Wed Feb 07 2024 15:37:29 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Group tests by suite, not by OS/Platform

  625. Deucе
    Wed Feb 07 2024 15:30:01 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Put platform in the group name

  626. Deucе
    Wed Feb 07 2024 15:19:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And finally dependencies

  627. Deucе
    Wed Feb 07 2024 15:18:30 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And fix up needs

  628. Deucе
    Wed Feb 07 2024 15:15:22 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    And fix extends

  629. Deucе
    Wed Feb 07 2024 15:14:35 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Attempt using a gitlab feature documented only by regex. :D

  630. Deucе
    Wed Feb 07 2024 14:58:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix off_t printf warning.

  631. Deucе
    Wed Feb 07 2024 14:47:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/services.c diff
    Another time_t printf

  632. Deucе
    Wed Feb 07 2024 14:34:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Oh damn, this is an off_t + size_t + 1... talk about the wild west of types! Both long long and long are reasonable for some mixes of platforms. Just punt, cast the whole thing to int64_t, and forget about it.

  633. Deucе
    Wed Feb 07 2024 14:20:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Aha! XP_PRIsize_t is a *size*, not a *type*.

  634. Deucе
    Wed Feb 07 2024 14:11:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Add missing header?

  635. Deucе
    Wed Feb 07 2024 14:00:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Some more printf formats... mostly off_t but also a size_t and an time_t

  636. Deucе
    Wed Feb 07 2024 13:40:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Mostly time_t printfs, but also an odd bit where it's printing a value that's not an off_t as one.

  637. Deucе
    Wed Feb 07 2024 13:23:08 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Add WALL option.

  638. Deucе
    Wed Feb 07 2024 13:15:25 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/GNUmakefile diff
    SyncTERM doesn't use telnet from a DLL.

  639. Deucе
    Wed Feb 07 2024 13:19:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Another time_t printf

  640. Deucе
    Wed Feb 07 2024 12:56:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/pack_qwk.cpp diff
    Another time_t warning... thanks OpenBSD!

  641. Deucе
    Wed Feb 07 2024 13:01:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sexyz.c diff
    src/syncterm/conn.c diff
    ioctlsocket() type stupidity warning.

  642. Deucе
    Wed Feb 07 2024 13:06:41 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Silence odd warning... I would expect these to be the same type save const, but apparently they're not. *shrug*

  643. Deucе
    Wed Feb 07 2024 12:20:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Another Windows warning about constiness.

  644. Deucе
    Wed Feb 07 2024 12:23:17 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    More time_t printf fun.

  645. Deucе
    Wed Feb 07 2024 11:57:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32cio.c diff
    Fix mingw32 warning... export variable correctly.

  646. Deucе
    Wed Feb 07 2024 11:55:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Underp.

  647. Deucе
    Wed Feb 07 2024 11:53:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    More format specifier correction.

  648. Deucе
    Wed Feb 07 2024 11:50:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Fix raspian warning. &file_count is being passed as a pointer to a size_t.

  649. Deucе
    Wed Feb 07 2024 11:47:49 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/fontutil.c diff
    "Fix" some more warnings. This need to be tested.

AuthorCommitsLatest
Deucе377Thu Mar 28 2024 06:45:54 GMT-0700 (PDT)
Eric Oulashin26Tue Mar 26 2024 19:02:07 GMT-0700 (PDT)
Rob Swindell236Tue Mar 26 2024 19:46:12 GMT-0700 (PDT)
Nigel Reed3Sun Mar 17 2024 02:07:12 GMT-0700 (PDT)
Deuce7Fri Feb 23 2024 21:57:58 GMT-0800 (PST)

For older commits (in CVS), click here

Dynamically generated in 345 milliseconds