Synchronet Git Commit Log

Modified Files:


src/sbbs3/pack_qwk.cpp
diff

Fix FILE (stream) pointer leak in error condition

Fixes CID 451020

Modified Files:


src/sbbs3/ansiterm.cpp
diff

Remove the call to sync() from ansi_getlines()

This was needed back in the v2 days to be sure the escape sequence was sent
*after* an output buffer before might've been cleared by a user's abort/Ctrl-C
action. SYNC/ASYNC called riosync() which called rioctl(TXSYNC) and we have no
equivalent in Synchronet for TCP/IP (modern sbbs). A user's Ctrl-C will clear
all pending I/O, but won't prevent subsequent output from being sent (until
the abort condition is cleared) as used to be the case with serial I/O.

Modified Files:


src/sbbs3/scfglib1.c
diff

Address MSVC warning: conversion from 'double' to 'unsigned int'

... possible loss of data (yeah, yeah, we know)

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add GETDIM @-code to get the current ANSI terminal dimensions (rows and cols)

This code will do nothing if there's no user logged-in or their terminal is
not ANSI or their terminal dimensions (rows and cols) are set to specific
values (not auto-detected). This code does the same thing as calling JS
console.getdimensions(). Since it waits (up to 5 seconds) for a CPR response
from the terminal, this does potentially slow down output, so caveat emptor.

This could be used by a sysop to address issue #529.

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

DD area choosers: Replaced hardcoded high-ascii single line character with a
variable defining it via hex code (for the help screens)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

Merge branch 'dd_area_choosers_horizontal_single_line_ascii_update' into
'master'

DD area choosers: Replaced hardcoded high-ascii single line character with a
variable defining it via hex code (for the help screens)

See merge request main/sbbs!269

Modified Files:


src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

Support duration notation (e.g. 10M for 10 minutes) in "*Inactivity" .ini keys

The recently updated ctrl/sbbs.ini had MaxLoginInactivity = 10M in
the [BBS] section, which was parsed as 10 seconds rather than the
intended 10 minutes. This fixes that issue and also will now store all
of these inactivity values in duration notation. Existing values stored
in seconds will work fine since that is always the assumed/fallback unit
of time in duration keys.

Thanks for the report!

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

DD area chooser fixes for lightbar mode: Numeric input (for file area chooser)
and wording changes on numeric input (for both)

Modified Files:


xtrn/DDAreaChoosers/DDFileAreaChooser.js
diff

xtrn/DDAreaChoosers/DDMsgAreaChooser.js
diff

xtrn/DDAreaChoosers/readme.txt
diff

xtrn/DDAreaChoosers/revision_history.txt
diff

Merge branch 'dd_area_choosers_lightbar_area_numeric_input_fix' into 'master'

DD area chooser fixes for lightbar mode: Numeric input (for file area chooser)
and wording changes on numeric input (for both)

See merge request main/sbbs!268

Modified Files:


exec/load/shell_lib.js
diff

Add missing sync call before xferinfo menu prompt.

Modified Files:


exec/load/shell_lib.js
diff

Fix assignment to undeclared variable j

And use putmsg() for strings that may have @-codes (e.g. ELLIPSIS)

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Add free disk space check against minimum space configured

Disallow uploads when free disk space falls below minimum configured
minimum free disk space.

This fixes issue #535

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Limit uploaded file sizes, accounting for free disk space

The lower of the configured maximum file size (for the FTP server) and
the available disk space minus the configured minimum free disk space
is used as the maximum file size to allow upload. Appended files
are accounted for too.

Modified Files:


exec/default.js
diff

Remove debug command and log-output left in by accident

Modified Files:


exec/load/text.js
diff

Add InactivityAlert

Modified Files:


exec/login.js
diff

Apply inactive_hangup option (for dumb terminals) using max_socket_inactivity

this insures that inactive dumb (bot) connections will be disconnected even
when using a script (e.g. animated pause prompt) that doesn't time-out.

Also, if the connected node is the last node (for this sbbs instance), divide
the socket inactivity timeout value in half.

These changes (along with sbbs v3.20) should help with DOS (denial-of-service,
not MS-DOS) prevention.

Mainly for Krueger.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

A few help text fixups.

Modified Files:


src/xpdev/genwrap.c
diff

Use const doubles for time durations

Instead of copy/pasta. No change in function,.

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/answer.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/startup.h
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Add terminal-client socket inactivity detection/disconnection

- New keys in [BBS] section of sbbs.ini:
  MaxLoginInactivity (default: 10 minutes)
  MaxNewUserInactivity (default: 60 minutes)
  MaxSessionInactivity (default: none/unlimited)
- Each configured external program/door in SCFG can have its own maximum
inactivity setting (or else the session max inactivity is applied)
- moved node-specific sec_hangup to system-wide/shared max_getkey_inactivity
(configured in SCFG->System->Advanced)
- moved node-specific sec_warn (seconds of inactivity before sending warning)
to inactivity_warn (a percentage of elapsed max inactivity before sending
warning), also configured in SCFG->System->Advanced and used for both socket
and getkey inactivity detection
- Renamed JS console.inactivity_hangup to console.max_getkey_inactivity (old
name remains as alias)
- Renamed JS console.timeout to console.last_getkey_activity (old name remains
as alias)
- Removed JS console.inactivity_warning
- Added JS console.max_socket_inactivity (current input_thread inactivity
threshold)
- New text.dat string: InactivityAlert (just contains 3 ^G/BELLs by default)
used for non-visual inactive-user warning

The MaxLoginInactivity setting in particular solves the problem of custom
scripts (e.g. animated pause prompts) that just poll indefinitely for user
input and never time-out  - these will no longer cause nodes to be tied-up with
inactive/bot users at login.

You may ask yourself, how did I get here? No, you may ask yourself: why
configure these socket inactivity max values in sbbs.ini? The reason is
consistency: sbbs.ini is where the MaxInactivity is configured for all the
other TCP servers and services.

This fixes issue #534 for Krueger in #synchronet

Modified Files:


src/sbbs3/js_system.c
diff

Rename system.last* to system.last_*, leaving old names as aliases

... to make property names more consistent (e.g. with bbs.last_node).
The old names (without the underscores) are still usable but won't appear
in JSDOCS (i.e. jsobjs.html).

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add 'first_node' and 'last_node' properties to JS bbs object

This allows scripts (e.g. login.js) to have custom behavior (e.g. shortening
the maximum inactivity timeout) based on how close the current node is to the
configured last node number. There may be other uses too, but for the vast
majority of Synchronet systems, first_node will always be 1 and last_node the
same as system.nodes/lastnode. Ugh, inconsistent naming. :-(

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Added a new configurable text string: scanningMessageText

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_new_scanningSubBoardText' into 'master'

Added a new configurable text string: scanningMessageText

See merge request main/sbbs!267

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Makes use of console.aborted for proper screen updates after the
user quits @ help screen pause. Shows sub-board status during a new message
scan.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_console_aborted_and_newscan_subboard_status' into
'master'

DDMsgReader: Makes use of console.aborted for proper screen updates after the
user quits @ help screen pause. Shows sub-board status during a new message
scan.

See merge request main/sbbs!266

Modified Files:


src/sbbs3/js_archive.c
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_client.c
diff

src/sbbs3/js_com.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msg_area.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_queue.c
diff

src/sbbs3/js_server.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/js_uifc.c
diff

src/sbbs3/js_user.c
diff

src/sbbs3/js_xtrn_area.c
diff

src/sbbs3/jsexec.c
diff

src/sbbs3/main.cpp
diff

Beautify JSDOCS

Mainly capitalization, but some typos and added details. 

Modified Files:


src/sbbs3/js_file.c
diff

Fix JSDOC typo

Modified Files:


src/sbbs3/js_filebase.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_system.c
diff

Fix JSDOC property descriptions

Add some missing descriptions, fix the order of others.

Added Files:


exec/default.js
diff

exec/load/shell_lib.js
diff

Synchronet classic shell ported to JS with helper library: shell_lib.js

This mimics default.src very closely, even the curious clear-screens before
the menu displays only when in non-expert mode (?).

I'll likely be using this to recreate some other command shells.

There's a couple of RIP-specific calls to getlines in default.src that I did
not port over (yet).

This commit fixes issue #526 for Nelgin (and any other JavaScript devs).

Note: this file supercedes default.bin, so beware if you have customized
default.src (and built your own custom default.bin), you'll want to move
those to your mods directory to continue to use them.

Another nail in Baja's coffin.

Modified Files:


exec/tempxfer.js
diff

Handle sub-dirs in the temp directory better

Use rmfiles() to recursively clean the temp dir, if available.

Don't count sub-directories (if somehow created) as files.

Clean the temp dir when exiting this module too.

Modified Files:


src/sbbs3/client.h
diff

Removed unused client_rec structure definition

Modified Files:


src/sbbs3/js_global.c
diff

Fix GCC warning regarding incompatible pointer type

Modified Files:


src/sbbs3/websrvr.c
diff

Include protocol and client IP address in FastCGI send error log msg

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/pack_rep.cpp
diff

src/sbbs3/sbbsecho.c
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Fix issue with DIZ extraction creating subdirs in temp

For archives with directories, the first call to extract_files_from_archive()
from extract_diz() would create sub-directories in the target (temp) directory,
but no files within them.

To correctly solve the original problem identified in commit 59200e33,
introduce/use a new 'recurse' argument to extract_files_from_archive() which
means to recursively apply the file_list filter (if specified). Always pass
'with_path' argument as false to prevent sub-dir creation.

The JS Archive.extract() method now excepts an additional boolean argument
(recurse) following the file list arguments, default is false.

Remove extra whitespace in Archive JSDOC method descriptions to be consistent
with other object/class docs.

Modified Files:


src/sbbs3/putmsg.cpp
diff

Fix typo in comment

Modified Files:


src/sbbs3/getkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/sbbs.h
diff

Enhance pause method flexibility (both C++ and JS)

sbbs_t::pause() and JS console.pause()...
now excepts an optional set_abort argument (default is true) which controls
whether this method will set the global console-output aborted flag
(sys_status&SS_ABORT in C++, console.aborted in JS) when the user hits the Quit
or No key at the pause prompt.

This method now returns a bool: false if the user entered No, Quit, or Ctrl-C
at the pause prompt.

Nothing makes use of either of these new pause() features yet, but its
generally better to not set/rely on global state wherever possible.

Modified Files:


src/xpdev/dirwrap.c
diff

If delfiles() is called with a NULL spec, assume "all files" (*)

Modified Files:


src/sbbs3/js_global.c
diff

Add new global JS function: rmfiles() (remove files)

number rmfiles(directory, spec=*, keep=0)

Removes files and sub-directories, recursively. Use with caution!

Modified Files:


src/sbbs3/putmsg.cpp
diff

Add TRUNCOFF @-code to turn off line truncation (if already turned on)

Modified Files:


src/sbbs3/main.cpp
diff

Fix PETSCII 40/80 column port connections for IPv6

The connected TCP port detection method only worked for IPv4, so automatically
detecting a CBM/PETSCII connection over IPv6 didn't work. Thanks to Deuce's
xp_sockaddr and helper functions, this was an easy change.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Add back a (different) typecast to eliminate MSVC warning

Modified Files:


src/sbbs3/putmsg.cpp
diff

Add TRUNCATE @-code to enable line truncation when too wide for user's terminal

Modified Files:


exec/msgscancfg.js
diff

Better to just break this loop than to call exit()

exit()ing from a load()ed script can cause the parent script to terminate and
we don't want that.

Modified Files:


src/sbbs3/services.c
diff

Fix a couple of potential NULL-pointer deferences in js_initcx() failure cases

service_client->client is NULL in these failure/error cases, so get the
protocol string from the service_client->service (which is not NULL) instead.

Modified Files:


src/sbbs3/sbbs_ini.c
diff

Remove extraneous ulong typedef

Added Files:


exec/filescancfg.js
diff

Modified Files:


exec/default.src
diff

exec/wwiv.src
diff

New file transfer configuration sub menu script

To replace some copy/pasta in *.src (and later *.js shells)

Modified Files:


src/xpdev/genwrap.c
diff

Fix mysterious double overflow issue in parse_byte_count()

It's possible that some values (e.g. "16384P") exceed the storage (count of
bytes) of a 64-bit integer, and such values were causing floating point
exceptions when running sbbsctrl.exe, e.g.
Faulting application name: sbbsctrl.exe, version: 3.20.0.0, time stamp:
0x00000000
Faulting module name: gdi32full.dll, version: 10.0.19041.2604, time stamp:
0x2b5302d5
Exception code: 0xc0000090

but interesting (and perhaps a clue), not with sbbs.exe.

Anyway, this added range checking, limiting the maximum value to INT64_MAX
(after division by unit, though there was no division-unit in the problem
case, the "min_dspace" value parsing in scfglib2.c). Using conditional/ternary
return statement had the same floating point exception occurrences, so this
if-statement shouldn't be removed/changed/optimized!

I suspect this has something to do with mix of Borland and MSVC run-time libs
and perhaps different expectations or setups with regards to floating point
exceptions. I did notice that when stepping through read_file_cfg(), I would
get different return values for the same call to iniGetBytes() depending on
whether it was initiated from sbbsctrl.exe (built with C++Builder) or
sbbs.dll (built with MSVC).

Thanks to Codefenix for providing the sample file.ini file that demonstrated
the issue. This problem would've been very hard to root-cause otherwise!

Modified Files:


src/sbbs3/js_bbs.cpp
diff

bbs.logoff() now returns a boolean: false if log-off was denied

Previously, there was no good way for the caller to determine if the\
user opted (when prompted) to actually log-off or not.

Modified Files:


src/sbbs3/userdat.c
diff

More strict login-by-user-number support (parsing logic)

Before now, if the sysop enabled login-by-user-number and the specified login
ID *started* with a decimal digit, it'd be treated as a user number and
converted to a 32-bit integer. This could result in weird stuff, like this
error I got today:
SMTP ... !ERROR -2 getting data on user (7000401005.gc7gg@synchro.net)

7,000,401,005 is clearly greater than the number of users in my user base
on Vert, but since 7B is > 2.1B (0x7fffffff), the number would be parsed as
a *negative* integer value and thus less than the total number of users in my
userbase.

An obvious solution would be to just turn of login-by-user-number, and for
most systems, I suggest doing that (a system is less secure with it enabled).

However, I want to leave the option for sysops (at least for now) and don't
want this weird behavior so, a login by user number now requires that the
entire login ID is just decimal numbers, nothing else, and the number is
parsed as an unsigned integer. So yes, roll-over can happen for very high
numbers (>4.2B), but in no instance will the number be parsed as negative and
thus lead to an invalid user record look-up attempt.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

Introduce sbbs_t::sync() method that does what the old SYNC/ASYNC macros do

But... as rightful member of sbbs_t, thus useful from other scopes.

Should get rid of all use of SYNC/ASYNC now then.

Modified Files:


src/sbbs3/execmsg.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbsdefs.h
diff

Fix 30+ year old typo on SCAN_CONT (continuous) macro name

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfunc.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/viewfile.cpp
diff

src/sbbs3/writemsg.cpp
diff

Replace SYNC and ASYNC macros with calls to sbbs_t::sync()

Does exactly the same thing, no change in behavior and unlikely there's any
change in performance.

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/sbbsdefs.h
diff

Replace use of SAVELINE/RESTORELINE with sbbs_t method calls

That's all these macros were doing anyway, so no change.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

CRLF macro now calls sbbs_t::newline()

No change in behavior.
Eventually would like to get rid of all the CRLF (and CLS) macro usage.

Modified Files:


exec/load/sbbsdefs.js
diff

Fix 30+ year old typo copy/pasted from sbbsdefs.h

It's SCAN_CONT (for continuous). <sigh>

Leave SCAN_CONST alias for backwards-compatibility, but deprecated.

Modified Files:


exec/newuser_signup.js
diff

Add a notice clarify that this script is not actually used by anything

and suggestions how to achieve what the reader/sysop is wanting.

Modified Files:


exec/rlogin.js
diff

Re-write to allow options in any order, more control over all behavior

Previously, in order to just specify the terminal-type string, the sysop
would also have to pass new values for the tg-mode, client-name and
server-name, which was not very friendly. We still support the old syntax
where order of arguments matters, but also a new better syntax for options
(which may now come before or after the required address[:port] argument):

-c <client-name> (default: user alias)
-s <server-name> (default: user real name)
-t <terminal-type> (e.g. "xtrn=doorcode" to auto-exec door on server)
-T <connect-timeout-seconds> (default: 10 seconds)
-m <telnet-gateway-mode> (Number or TG_* vars OR'd together, default: 0)
-p send current user alias and password as server and client-name values
-q don't display banner or pause prompt displayed (quiet)
-P don't pause for user key-press
-C don't clear screen after successful session

For arguments that take a value (e.g. -c, -s, -t, -T, -m), the value may
immediately follow the option letter (e.g. "-cMyName") or be specified
in the following argument (e.g. "-c MyName"). Multiple options cannot be
stuck together in the same option (e.g. use '-C -P' instead of '-CP').

If the RLogin server is a Synchronet BBS, you probably want to specify the
'-p' option which will send the current user's alias and password in the
RLogin connection parameters that Synchronet expects them.

The sysop now has better control over the output (banner, screen-clearing)
and the pause prompt that was previously hard-coded.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

[telnet|rlogin]_gate now returns bool (false if failed to connect)

Previously, there was no real way to tell if the call to telnet_gate() or
rlogin_gate() was successful (e.g. to display or an error message to the user),
though there were error/warning messages logged for the sysop. Equivalent JS
bbs object methods now return Boolean too.

Include ":port" part of address argument to bbs.[telnet|rlogin]_gate methods in
JSDOCS.

Removed a bunch of extraneous (copy-pasted?) JS_SET_RVAL() calls from
js_bbs.cpp. This just makes the code a little easier to grok.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fixes for time zone alignment and key help for the message list.
Should fix #531

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_531_timezone_and_key_help_alignment' into 'master'

DDMsgReader: Fixes for time zone alignment and key help for the message list.
Should fix #531

Closes #531

See merge request main/sbbs!265

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/modem.c
diff

A couple fixes for NORTS mode

1) In the BBS list, show flow control, not TCP port
2) Properly ignore DCD

Modified Files:


exec/addfiles.js
diff

Fix typo in help output

Modified Files:


src/sbbs3/data_ovl.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

Add sbbs_t::reinit_msg_ptrs() - eliminates some copy/pasta

Clarify the JS bbs.reinit_msg_ptrs() method description a bit.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add JS bbs methods: save_msg_scan() and reload_msg_scan()

These methods aren't normally needed (msg scan config/ptrs are
automatically loaded upon logon and saved upon logoff), but for users
(e.g. sysops) that can be logged-in concurrently or experimenting with
scans, these methods can be useful and I plan to expose in a loadable
module next.

Added Files:


exec/msgscancfg.js
diff

Modified Files:


exec/default.src
diff

exec/major.src
diff

exec/renegade.src
diff

exec/sdos.src
diff

exec/simple.src
diff

exec/wildcat.src
diff

exec/wwiv.src
diff

text/menu/maincfg.msg
diff

New module: msgscancfg.js to replace copy/pasta msg config menu in *.src

Also added 2 new menu options:
R - re-load msg scan config & pointers
W - save msg scan config & pointers

Leaving the menu file named "maincfg.msg" even though that's a pretty
badly named file - should rename that file at some point, but keep 8.3
format for DOS (e.g. TheDraw, AcidDraw) compatibility.
mscancfg.msg maybe? Ah, the fun of abbreviating things to 8 chars again.

Modified Files:


exec/addfiles.js
diff

Add support for an optional description character offset (number) arg

If all descriptions start a fixed offset and the default parsing
logic (regex) isn't working for the sysop, they can specify the exact
error offset to use for the beginning of each file's description. This
offset is only used for the initial line of the description, not the
continuation lines, but perhaps that could be done if needed.

This is an attempt to address issue #530

I first attempted to use "Lookbehind Assertions" in the regex, but
didn't have any success and decided the brute force method that the
old addfiles utility used might be as simpler solution and provide an
effective work-around for more potential issues with auto-detecting
the beginning of the useful file description.

I also added descriptions of the optional arguments to the help output.

Modified Files:


ctrl/text.dat
diff

exec/load/text.js
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/text.h
diff

src/sbbs3/text_defaults.c
diff

Add text.dat string: NewUserValEmailSubj

This fixes issue #62

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_user.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/userfields.h
diff

Add user_t.mail (in JS, user.mail_settings) to remember mail preferences

Right now, the only preference is reverse mail listings (oldest first
or newest first). These settings are only used when reading "your mail",
not any other kind of mail reading.

bbs.read_mail() now returns the user-adjusted loadmail_mode value and
this allows us to determine the user's preferences and save them after
this function/method is called. A readmail_mod can now return a number
(other than 0) and that will be used as the return value of this method.

sbbs_t::readmail() now does the adjustment of the passed lm_mode before
calling any installed readmail_mod, so if for example, deleted message
viewing is enabled by the sysop, those LM_* flags might be set now in
the argument to the readmail_mod, wherase they never would before.

There is not yet any way for the sysop to set a new user's default
mail_settings, they'll just default to 0 for now.

email_sec.js will get some adjustments to use/store the
user.mail_settings next.

Modified Files:


exec/email_sec.js
diff

Use/store the new user.mail_settings property

to track the user's preference for reverse-ordering when listing/reading
mail messages. The Un-read mail command still just always uses reverse
ordering.

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/chk_ar.cpp
diff

src/sbbs3/filedat.c
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

Add/use user_available_credits() helper function

Handles integer overflow in the summing of user's credits and remaining daily
free credits.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Fix missing 'autohang' argument in call to protocol()

Caught by a GCC warning.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add CPS @-code which is used to display the current download CPS

In a minute, this CPS value will be of more use since it'll be reflective of
the user's actual download rate (in characters/bytes per second) instead of
just some randomly-chosen numeric constant.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/sbbs.h
diff

Dynamically recalculate the user's download rate (in CPS)

Upon successful download of a file, recalculate and store the user's download
CPS (characters/bytes per second), mainly for subsequent transfer time
estimates.

Modified Files:


src/sbbs3/upload.cpp
diff

Since protocol() now calculates elapsed time, use that

Modified Files:


src/sbbs3/email.cpp
diff

Use proper 64-bit function for converting an off_t to comma-separated 

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

DDMsgReader: When forwarding a message, now prepends the subject with "Fwd: "
before editing the subject.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

Merge branch 'ddmsgreader_forward_subj_prepend' into 'master'

DDMsgReader: When forwarding a message, now prepends the subject with "Fwd: "
before editing the subject.

See merge request main/sbbs!264

Modified Files:


exec/init-fidonet.ini
diff

Fix Zone 1 filegate.net BACKBONE.NA link

Not sure when this changed, but Thearcadeguy let me know it was a broken link.

Modified Files:


exec/userlist.js
diff

When sorting by logon date, display most recent first

Modified Files:


src/sbbs3/js_user.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userfields.h
diff

Introduced user download_cps property

Will track the user's last succsesful file-download transfer rate
in characters (bytes) per second.

I'm not calculating or storing this rate yet, but will be soon. This
will make the file download ETAs more realistic and no longer
hard-coded to 3000 cps (which now defaults to 10000 cps, to keep up
with the times).

New field added to user.tab placed adjacent to the other File xfer stats,
which means the leech attempt counter (likely always 0) was moved to the end
of the user record.

Modified Files:


src/sbbs3/userdat.c
diff

The NoAccess* text.dat strings are not appropriate 'reason' codes

These text.dat strings require an argument (and normally used with the NOACCESS
@-code which uses the noaccess_str and noaccess_val member variables), so not
appropriate to use as a reason code here. Use more generic (no argument)
text.dat item numbers instead.

Modified Files:


src/sbbs3/putnode.cpp
diff

src/sbbs3/sbbs.h
diff

Create sbbs_t::putnode_downloading()

Migrated from sbbs_t::start_batch_download(), this just calculates the ETA (of
transfer completion) and writes to the node's aux field in the proper format.

Modified Files:


src/sbbs3/filedat.c
diff

Avoid possible divide-by-zero in gettimetodl()

Default to 100000 (cps) if passed a rate_cps argument value of 0.

Modified Files:


src/sbbs3/listfile.cpp
diff

Use the new putnode_downloading()  function

Eliminate some copy/pasta.

Modified Files:


src/sbbs3/logon.cpp
diff

Remove defunct files from batch download queue during logon

If a user doesn't have access to download a file that's in their batch queue,
remove it without saying anything to the user (but log a notice-level message
about it) during logon. Files that no longer exist in the filebase are treated
the same way.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Better access enforcement to files in batch download queues

If a file gets added to a batch download queue that a user doesn't have
download-access to (at the time of batch download), deal with that gracefully
and consistently.

start_batch_download():
- Now checks current user access to download the file in both single-file and
batch modes
- Now performs credit-check in single-file mode (wasn't doing so previously)
- totalsize of multi-file batch download queue is now calculated again
(apparently removed/broken in the new filebase conversion of v3.19), so
download ETA should be calculated more accurately (?) again
- Use gettimetodl() to calculate each file's download time for multi-file
downloads
- Using new putnode_download() method to write node downloading "action" and
ETA-in-aux fields
- The node status wasn't being updated at all before start of download in
single-file mode - fixed

create_batchdn_lst() :
- Checks each file still downloadable by the user and if not, removes from the
queue (and the generated list file).
- Performs credit check and removes files that exceed available user credit
- returns true only when 1 or more files is added to the batch download list
file

addtobatdl()
- Removed redundant 'D' restriction check - this is handled by
can_user_download() check already.
- Use the 'reason' out parameter from can_user_download() to determine which
error string to display (not always CantDownloadFromDir).

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Don't prepend "Fwd: " to forwarded messages

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'ddmsgreader_forward_dont_prepend_fwd' into 'master'

DDMsgReader: Don't prepend "Fwd: " to forwarded messages

See merge request main/sbbs!263

Added Files:


xtrn/ddfilelister.js
diff

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Now allows downloading a single selected file with the D key

Added Files:


xtrn/ddfilelister.js
diff

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_download_single_with_d' into 'master'

ddfilelister: Now allows downloading a single selected file with the D key

See merge request main/sbbs!261

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: When forwarding a message, the subject can now be edited before
sending the message

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'ddmsgreader_forward_edit_subject' into 'master'

DDMsgReader: When forwarding a message, the subject can now be edited before
sending the message

Closes #528

See merge request main/sbbs!262

Modified Files:


src/smblib/smbstr.c
diff

Better automatic network address type detection

smb_netaddr_type():
- if passed NULL or a string that begins with whitespace, now returns NET_NONE.
- if passed a string that begins with '@', now returns NET_UNKNOWN.
- if the user.name portion of an otherwise value Internet email address
  contains a space, now returns NET_NONE.

smb_get_net_type_by_addr()
- if passed a string that begins with '@', now returns NET_UNKNOWN.
- if passed a string with space following '@', will now return NET_UNKNOWN.
- if passed a string without a dot following '@', will never return
NET_INTERNET.

Unrelated change: Add the missing FILE attribute to smb_msgattrstr()

Added Files:


exec/bench/nettype.js
diff

A set of tests for the global netaddr_type() method

Modified Files:


src/sbbs3/js_global.c
diff

netaddr_type() now returns NET_NONE when passed null or undefined

... instead of undefined, to match what the documentation already stated.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix false FORGED mail header 'FROM' field detection/rejection

Pretty much any From field that contains an '@' in the username portion
was subject to comparison to the full email address, but clearly some of
these rejected emails were not forge attempts:

'Chris @ StubHub' vs 'events@mail.stubhub.com'
'Eric S. Raymond (@esr)' vs 'gitlab@mg.gitlab.com'

Fixed by requiring that the sender name is actually a well-formed Internet
email address using smb_netaddr_type(), which was also recently improved to
be more accurate.

Unrelated change: include reverse-path (email address for bounces) in
ILLEGALLY-LONG body and header line log messages (usually SPAM from what
I can tell).

Modified Files:


src/sbbs3/mqtt.c
diff

Re-publish the server error_count topic in mqtt_startup()

Fixes a stale non-zero error_count retained topic.

Modified Files:


exec/newuser.js
diff

Fix @-code replacment logic in newuser.msg

Fix 2 issues with commit df799b0a:
1. Need to replace @-code globally, otherwise only the first @-code was
replaced
2. Need to strip the leading and trailing @'s from the code before passing to
bbs.atcode() - fix for issue #527

Modified Files:


src/sbbs3/mailsrvr.c
diff

Handle illegally-long received SMTP lines better

SMTP commands have a shorter limit (510 versus 998) and the body text line
limit needed to account for dot-stuffing. 

Modified Files:


exec/msglist.js
diff

Remove accidentally-committed debug output

And some trailing white-space

Modified Files:


src/sbbs3/mailsrvr.c
diff

Resolve new GCC printf-format warning in new log message text

Modified Files:


src/sbbs3/mailsrvr.c
diff

Reject SMTP session from any client that sends illegally-long lines

Log a warning message and send a "500 Line too long" before disconnecting any
SMTP client that sends lines > 998 characters in length. Technically, we can
handle lines up to 1023 characters, but then we could get out of sync with the
client if it sends exactly 1023 chars and then a new-line char (which we would
interpret as a blank line, separating the message header and body) - so just
punt the client who doesn't obey the rules of the protocol.

Modified Files:


src/sbbs3/makeuser.c
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/userdat.c
diff

Update/use newuserdefaults()

Update newuserdefaults() to use the new sysop-configured Chat and QWK new user
settings/values (commit d1d49e99).

Use newuserdefaults() in newuser.cpp and makeuser.c, eliminating a lot of
copy/pasta.

Modified Files:


src/sbbs3/mailsrvr.c
diff

Resolve new GCC printf-format warning in new log message text

Modified Files:


src/sbbs3/mailsrvr.c
diff

Reject SMTP session from any client that sends illegally-long lines

Log a warning message and send a "500 Line too long" before disconnecting any
SMTP client that sends lines > 998 characters in length. Technically, we can
handle lines up to 1023 characters, but then we could get out of sync with the
client if it sends exactly 1023 chars and then a new-line char (which we would
interpret as a blank line, separating the message header and body) - so just
punt the client who doesn't obey the rules of the protocol.

Modified Files:


src/sbbs3/makeuser.c
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/userdat.c
diff

Update/use newuserdefaults()

Update newuserdefaults() to use the new sysop-configured Chat and QWK new user
settings/values (commit d1d49e99).

Use newuserdefaults() in newuser.cpp and makeuser.c, eliminating a lot of
copy/pasta.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

ddfilelister: Now supports being used as a loadable module for Scan Dirs and
List Files (applicable for Synchronet 3.20+)

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'ddfilelister_loadable_module_support' into 'master'

ddfilelister: Now supports being used as a loadable module for Scan Dirs and
List Files (applicable for Synchronet 3.20+)

See merge request main/sbbs!260

Modified Files:


src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Make new user QWK-related and Chat-related settings configurable

Added chat-settings to SCFG->System->New User Values->Toggle Options
Added new menu: SCFG->System->New User Values->QWK Packet Settings

Moved SCFG->System->New User Values->Question Toggles to:
      SCFG->System->New User Prompts...

This fixes issue #11

Modified Files:


exec/xtrnmenu.js
diff

Replace load() of chat_sec.js with call of (new method) bbs.chat_sec()

Added Files:


exec/feedback.src
diff

Modified Files:


exec/default.src
diff

exec/major.src
diff

exec/pcboard.src
diff

exec/renegade.src
diff

exec/sdos.src
diff

exec/simple.src
diff

exec/wildcat.src
diff

exec/wwiv.src
diff

src/sbbs3/chat.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add configurable chat section module, defaults to "chat_sec"

This includes a new JS bbs method: bbs.chat_sec()

And the old command shells written in Baja now call the PCMS
chat_section function, as they used to, rather than hard-coding the
name of the module to execute.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_user.c
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Add/use new helper function is_user_sysop()

Modified Files:


src/sbbs3/email.cpp
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add optional/configurable feedback module

Most sysops didn't know it, but if exec/feedback.* existed, it would be
executed just before any user sent an email to the sysop (user #1),
excluding new user validation requests:
- make this module name configurable and loadable from mods
- support JS module here (exit(1) to abort the feedback)
- invoke for email being sent to *any* sysop (not just user #1)
- don't invoke the module when sending *from* a sysop account

This fixes issue #16

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

GCC 4.8.5 can't initialize a class char-array member with = "" syntax

This fixes issue #525

Thanks to Nelgin for providing the test platform.

Modified Files:


install/GNUmakefile
diff

Fix fatal: not a git repository (or any of the parent directories): .git

Apparently the cwd is changed back after ever command is invoked.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix typo in JSDOC help for batch_clear() method.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add new loadable module for batch file transfer menu

You want to replace the built-in batch file transfer menu with your own
loadable module across all command shells? Now you can.

Modified Files:


install/GNUmakefile
diff

Don't use 'git -C' since apparently older versions of git don't have it

<nelgin> git -C /home/bbs/sbbs/repo remote set-url origin
https://gitlab.synchro.net/main/sbbs.git
<nelgin> Unknown option: -C
<nelgin> using GNUMakefile on CentOS 7

This partially reverts commit 34909899

Modified Files:


src/sbbs3/sbbsdefs.h
diff

Expand user_t.curxtrn from 8 to 16 chars (the new maxlen of int-codes)

Apparently I missed this in commit b1f3fef6.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/uedit/uedit.c
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/useredit/MainFormUnit.cpp
diff

Increase user's hostname field (aka user_t.comp) from 30 to 60 chars

Many dynamically-generated (e.g residential) hostnames are much > 30
chars. And we can now increase user.tab fields fairly arbitrarily, so
let's. :-)

Also rename LEN_COMP to LEN_HOST. Some day I'll change all the user_t
comp references to 'host', but not today.

Modified Files:


src/sbbs3/useredit.cpp
diff

Display more of the user's password

Reversed the order of the pwmod date and the password itself.
The number of chars of the user's password displayed depends on the
terminal width. e.g. on an 80 column terminal, 18 chars will be
displayed. If the user's password is longer than what can be displayed,
this is indicated with a trailing "..". Wider displays (e.g. 132 column)
can display all 40 chars of a user's password.

This fixes issue #442

When passwords aren't displayed (due to sysop configuration), show
"<hidden>" instead of "XXXXXXXX" to make that more clear.

Modified Files:


ctrl/text.dat
diff

Display more of the user's password

Reversed the order of the pwmod date and the password itself.
The number of chars of the user's password displayed depends on the
terminal width. e.g. on an 80 column terminal, 18 chars will be
displayed. If the user's password is longer than what can be displayed,
this is indicated with a trailing "..". Wider displays (e.g. 132 column)
can display all 40 chars of a user's password.

This fixes issue #442

When passwords aren't displayed (due to sysop configuration), show
"<hidden>" instead of "XXXXXXXX" to make that more clear.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Create bbs.batch_clear() method

Pass argument of 'true' to clear upload queue, otherwise download queue
is cleared.

This fixes issue #488

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfglib1.c
diff

Define/use some more sensible defaults for new user Q's, etc.

We don't yet really work with a 0-byte main.ini file, but this gets
us a little closer.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgchat.c
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgsub.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfg/scfgxfr2.c
diff

src/sbbs3/scfg/scfgxtrn.c
diff

Use K_NOSPACE (don't allow spaces) when inputting internal codes

and prefixes, suffixes.

Modified Files:


install/systemd/sbbs.service
diff

Start after network-online instead of just 'network.target'

Added Files:


install/systemd/ircd.service
diff

A sample systemd unit file that can be used to run ircd via jsexec

I'm using this on cvs.synchro.net along with an override.conf file in
/etc/systemd/system/ircd.service.d/

[Service]
ExecStart=
ExecStart=/sbbs/exec/jsexec -A -L7 -hcvs.synchro.net ircd.js -a cvs.synchro.net
LimitCORE=infinity

Modified Files:


exec/load/dns.js
diff

Throw a more helpful exception when no nameservers specified/available

My /etc/resolv.conf was wiped by Network Manager (gee, thanks), so
ircd.js was throwing the following unhelpful exceptions when starting
up:
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to
create any sockets
Feb 25 13:47:51 git jsexec[19108]: !JavaScript : uncaught exception: Unable to
create any sockets

First, instead of throwing a string, throw an Error object so we can
actually know where the exception ocurred. Please, everyone, throw Errors
not Strings.

Second, throw a different more helpful exception if there are no nameservers
specified in the DNS constructor or configured on the system.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text
is word-wrapped for the terminal width

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_wrapping_ctrlc_scans' into 'master'

DDMsgReader: Ctrl-C can now cancel message scans, and message scan status text
is word-wrapped for the terminal width

Closes #522 and #523

See merge request main/sbbs!259

Modified Files:


src/sbbs3/text_defaults.c
diff

Re-color the *DownloadUserMsg strings a little bit

Modified Files:


ctrl/text.dat
diff

Re-color the *DownloadUserMsg strings a little bit

They were too hard for me to read before, being all high intensity.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

Initialize sbbs_t member variables in class definition instead of ctor

Remove the (now) unnecessary explicit initializations (e.g. to zero, blank,
etc.) from the sbbs_t constructor.

Modified Files:


exec/init-fidonet.ini
diff

Fix the fsxNet infopack and direct-echolist download links

Apparently Paul made some changes (nobody reports these things).

Modified Files:


exec/init-fidonet.js
diff

Use Archive() instead of executing 'unzip' to get echolist from infopack

Fixes issue #311

Also clarify "Internet e-mail" address (unrelated)

Modified Files:


exec/init-fidonet.js
diff

Prompt for sysop's valid/working Internet email address

... and use as reply-to address for any Internet-mailed node number
applications.

This fixes issue #456 reported by Nick Andre.

Modified Files:


src/sbbs3/listfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add support for 3 new loadable modules for file scanning/listing/viewing

Configured in SCFG->System->Loadable Modules:
Scan Dirs:      User scans one or more directories for (e.g. new) files
List Files:     User lists files within a file directory
View File Info: User views detailed information on files in a directory

This addresses/fixes feature request #521 for Nightfox

Will need to document the mode argument bit values on the wiki, but
it's the usual suspects: FL_* for scandirs and listfiles and FI_* for
fileinfo. The scandirs_mod will be passed an extra bool (0/1) arg that
indicates whether or not the user is scanning *all* directories.

Test results would be welcome

Modified Files:


xtrn/wttr.in/readme.txt
diff

xtrn/wttr.in/wttr-lib.js
diff

Default view to 1AFn, best fit for 24 rows

Modified Files:


xtrn/wttr.in/wttr.js
diff

Add a blank line before pause

Modified Files:


xtrn/wttr.in/locator.js
diff

Avoid ip info probably not pertaining to this client

Modified Files:


exec/websocketservice.js
diff

Create ip temp file immediately on connect.

Modified Files:


xtrn/wttr.in/wttr-lib.js
diff

xtrn/wttr.in/wttr.js
diff

Allow command line arguments to override modopts values.

Parameter names are -- prefixed, with a space between name and
value. Quotes etc. around values are not handled; use escapes.
We can get fancier with this later if it's necessary.

Example:

?wttr.js --fallback_location Toronto --cache_ttl 0

Modified Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/wttr.js
diff

Allow this to run under jsexec

Modified Files:


xtrn/wttr.in/wttr-lib.js
diff

Skip cache stuff if 0 ttl; keep some methods private.

Modified Files:


xtrn/wttr.in/xterm-colors.js
diff

Keep some methods private for no particular reason.

Modified Files:


xtrn/wttr.in/locator.js
diff

Comments for the future

Modified Files:


xtrn/wttr.in/wttr-lib.js
diff

Use new modopts settings instead of args.

Modified Files:


xtrn/wttr.in/wttr.js
diff

Command line arguments no longer supported, use modopts instead.

See readme.txt for details on modopts.d/wttr.ini.

Modified Files:


xtrn/wttr.in/readme.txt
diff

Notes on config and format

Modified Files:


exec/websocketservice.js
diff

Better cleanup of ipFile

Changed scope of ipFile variable so we can access it in the
finally{} block. Should prevent stale files hanging around if
the service encounters an error.

Modified Files:


exec/websocketservice.js
diff

Write websocket client IP address to temp file.

Scripts running on upstream (terminal) server can find actual
client IP in:

system.temp_path + 'sbbs-ws-' + client.socket.remote_port + '.ip'

Modified Files:


xtrn/wttr.in/locator.js
diff

Read client IP from websocketservice-provided temp file if exists.

Ditch TTYLOC method; no longer needed. (Note: websocketservice's
UTF-8 handling rendered this unusable anyway.)

Remove rlogin/webv4 specific lookup method; no longer needed.

Modified Files:


xtrn/wttr.in/wttr-lib.js
diff

Remove some debug logging.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Change uifcapi_t.kmode to .input_mode, only appy in input() method

Modified Files:


xtrn/wttr.in/locator.js
diff

Use client.ip_address instead of user.ip_address; check if protocol is Telnet
or SSH

Modified Files:


xtrn/wttr.in/locator.js
diff

Fix addrRe

Modified Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/wttr-lib.js
diff

xtrn/wttr.in/wttr.js
diff

More information must be gathered by Keyop.

Therefore, be it resolved:
Whereas more information is required,
Whereas such information cometh from log files,
Whereas this script should spew many messages into the logs,
The script shalt not cache any data for the time being, nor load
any cached data,
The script shall barf much data into the logs for purposes of
troubleshooting.

- King James III on the eve of his coronation, hand on bibble

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add input K_TRIM and K_NOSPACE mode flags

K_TRIM causes leading and trailing whitespace to be trimmed.
K_NOSPACE disallows any whitespace characters to be added to the string.

Previously, trailing whitespace was always trimmed. Now, only do that
if/when K_TRIM is specified.

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add uifcapi_t.kmode that can be used to set global key-input mode flags

e.g. this a way to set the K_TRIM mode globally for all keyboard input

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Use the new UIFC input mode flags to trim spaces where inappropriate

from sysop input, automatically.

Modified Files:


exec/activeuserservice.js
diff

exec/asc_handler.js
diff

exec/avatar_chooser.js
diff

exec/avatars.js
diff

exec/badpasswords.js
diff

exec/bajavascript.js
diff

exec/bulkmail.js
diff

exec/bullseye.js
diff

exec/chat_sec.js
diff

exec/chksetup.js
diff

exec/chkspace.js
diff

exec/classic_shell.js
diff

exec/dyndns.js
diff

exec/echoareas.js
diff

exec/exportcfg.js
diff

exec/finger.js
diff

exec/fingerservice.js
diff

exec/flashpolicyserver.js
diff

exec/freqit.js
diff

exec/fseditor.js
diff

exec/ftn-setup.js
diff

exec/getnewsgrouplist.js
diff

exec/gopherservice.js
diff

exec/hatchit.js
diff

exec/hexdump.js
diff

exec/imapservice.js
diff

exec/init-fidonet.js
diff

exec/init-tickit.js
diff

exec/irc.js
diff

exec/ircmsg.js
diff

exec/json-service.js
diff

exec/lbshell.js
diff

exec/letsyncrypt.js
diff

exec/listgate.js
diff

exec/listserver.js
diff

exec/load/822header.js
diff

exec/load/age.js
diff

exec/load/ansiterm_lib.js
diff

exec/load/array.js
diff

exec/load/avatar_lib.js
diff

exec/login.js
diff

exec/logonlist.js
diff

exec/mailauth.js
diff

exec/mailproc_example.js
diff

exec/makeguest.js
diff

exec/makeuser.js
diff

exec/md5sum.js
diff

exec/msglist.js
diff

exec/msgutil.js
diff

exec/mspservice.js
diff

exec/mudgate.js
diff

exec/newslink.js
diff

exec/nntpservice.js
diff

exec/nodelist.js
diff

exec/postmsg.js
diff

exec/postpoll.js
diff

exec/privatemsg.js
diff

exec/privchat.js
diff

exec/qnet-http.js
diff

exec/qotdservice.js
diff

exec/sauce.js
diff

exec/sbbsecho_upgrade.js
diff

exec/sbbsimsg.js
diff

exec/scanpolls.js
diff

exec/scrubmsgs.js
diff

exec/showavatar.js
diff

exec/showfileavatar.js
diff

exec/showmsgavatar.js
diff

exec/showmsghdr.js
diff

exec/showsixel.js
diff

exec/spamc.js
diff

exec/str_cmds.js
diff

exec/telgate.js
diff

exec/termcapture.js
diff

exec/termsetup.js
diff

exec/tickfix.js
diff

exec/typeasc.js
diff

exec/typehtml.js
diff

exec/unixgate.js
diff

exec/websocket_proxy_service.js
diff

exec/websocketservice.js
diff

exec/wget.js
diff

exec/xjs_handler.js
diff

exec/xtrn-setup.js
diff

exec/xtrn_sec.js
diff

Remove old CVS tags, increment revision/version numbers where used

The details (dates, author, revision numbers) are often stale and
misleading, so start removing them. Where the Revision tag was used
for a version/revision, just bump it by one and use a string constant
instead (Git doesn't provide any similar facility for auto-incrementing
revision numbers).

More remains. Perhaps a commit hook to alert me when committing that I should
clean up as I go rather than try to do this in bulk. <shrug>

Modified Files:


src/sbbs3/mailsrvr.c
diff

Fix corrupted RFC822 msg headers when a header field was > 1024 chars

When sending an SMB message header via SMTP or POP3, some header fields (lines)
could potentially be longer than 1024 and yet sockprintf() was limited to
sending 1024 bytes (actually 1022 plus CRLF). This could result in some
messages not being sent correctly: header field truncated, not CRLR-terminated,
and notably resulting in MIME message contents not being decoded properly in a
message viewer/reader. Example (Content-Type is part of the previous header
field/line):
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?cm9T1Q9G65VC/lKTTqhODKhy5lHT2y6WWMb/WyvJ+EeGEwYmY7ILhzE3yfNM?=
 =?us-ascii?Q?KeFWN9T/PqHBya1plKf/sHgaw0iRmI7Hq+u9Dp4bG8OqdniKQlK+Aa27oXMd?=
 =?us-ascii?Q?Hly6OEYaSu7jbhGGY89LF0gyRVqquqxkaMfpKvG+h4cQnnu4Tl8YAKeE39a2?=
 =?us-ascii?Q?lHW3372ulmb9jvvZU72J2RtZYkuoIr+Wsqhfyuj39wTZ/+C4qKCsYrmTxrki?=
 =?us-ascii?Q?fBZ4gMPzWkrcWAr7zPcXBg8bphJJB8VJFUjQyksA3EG4dtH8+TZeEcNNBmHf?=
 =?us-ascii?Q?oCGnV9wHr9HszzrSkkZ2GGyh3QZLHAVDNe7wDXSy7HJttZugf9kNqKGeaYQL?=
 =?us-ascii?Q?TpljH1aHPe7MiSP9Dmp/xHQ/DWQOZDx5guNS+iMciMt5p5ad+SkQye0hWRhd?=
 =?us-ascii?Q?usHvpllclzIee6lxJ0VSPAzHGlAOhtOolrHdDB2ODjvkEzU7L2Fj2f5x7p9q?=
 =?us-ascii?Q?9d6sUgSz7vZVx8yyR3KPq3jIX0QUnl0xr2Mix9xcmMNcg0yFLPcznqBdLVa8?=
 =?us-ascii?Q?IC7j0+8oy4BjYxr8Z3elxMC2JKq13gPYgR95cwm6hMDiZbMB4EW/J1uJhD/I?=
 =?us-ascii?Q?RIIqTZ+Ywt8nKOfXj6/a9Aauf0wN71QKKA+in7KY9oksIhkUGvWOrtJwkVDL?=
 =?us-ascii?Q?Q2UFrBBJyQHJgumj5Y+bG8FDk/55IfyV9XYEcsdLL4bCF+HX4QPHZCw4P+li?=
 =?us-ascii?Q?bRvN+UxOO8hgXVkgB1q8mNJ62yQuaj0AContent-Type:
multipart/alternative;

boundary="_000_SN6PR07MB454477F4C32C66D48BA0B02187A09SN6PR07MB4544namp_"

Solved by using asprintf() instead of snprintf() for dynamic string formatting
and allocation in one go. Using realloc() to expand the buffer for the
appended/required CRLF.

Modified Files:


xtrn/wttr.in/readme.txt
diff

Fix whoopsie in last doopsie.

Added Files:


xtrn/wttr.in/wttr-lib.js
diff

Modified Files:


xtrn/wttr.in/readme.txt
diff

xtrn/wttr.in/wttr.js
diff

Cache stuff. Rearranged some things. Stuff like that.

Modified Files:


xtrn/wttr.in/readme.txt
diff

xtrn/wttr.in/wttr.js
diff

Treat command line argument as an alternate URL.

This allows for greater flexibility with the options, and the
possibility of querying your own (or some other) wttr server.

Added Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/readme.txt
diff

xtrn/wttr.in/wttr.js
diff

xtrn/wttr.in/xterm-colors.js
diff

wttr.in weather forecast viewer

Added Files:


xtrn/wttr.in/locator.js
diff

xtrn/wttr.in/readme.txt
diff

xtrn/wttr.in/wttr.js
diff

xtrn/wttr.in/xterm-colors.js
diff

Merge branch 'wttr.in' into 'master'

wttr.in weather forecast viewer

See merge request main/sbbs!258

Modified Files:


ctrl/main.ini
diff

Make userlist.js the default user list module

Include some other new key values (migrated from node.ini)

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Reverse the other of the userlist and nodelist modules

User list is more similar to logonlistl and nodelist is more similar
to 'who's online'.

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scfg/scfg.c
diff

Support JavaScript modules as command shells

Yes, finally, you can write a command shell in JS without needing a
.bin "stub" Baja module to execute it.

Fixes issue #504.

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

DDMsgReader: Updated the readme for installation as a loadable module for
Synchronet 3.20+ as of 2023-02-20

Modified Files:


xtrn/DDMsgReader/readme.txt
diff

Merge branch 'dd_msg_reader_sync_320_loadable_module_readme_update' into
'master'

DDMsgReader: Updated the readme for installation as a loadable module for
Synchronet 3.20+ as of 2023-02-20

See merge request main/sbbs!257

Modified Files:


exec/userlist.js
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

src/sbbs3/str.cpp
diff

Add a configurable 'user list' module

Also modifying the existing (sample) userlist.js to mimic the hard-coded
sbbs_t::userlist() function (from str.cpp), suitable as a user list
module. Also added sort-by-laston-date functionality to this module,
thus fixing issue #518.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

All loadable modules can now be configured as full command-lines

Previously, many/most loadable modules were limited to just 8 chars,
so while technically you could include a command-line option with a
very short module name, now all modules can be configured with full
(up to 63 char) command-lines.

Modified Files:


src/sbbs3/js_uifc.c
diff

Fix insufficient 'mode' string length in init() method

Limited to 6 chars, yet some values are as long as 12 chars.

Also, eliminates this warning from RELEASE builds (only) using gcc version
12.2.0 (Debian 12.2.0-14):
js_uifc.c: In function ‘js_uifc_init’:
sbbs.h:230:56: warning: writing 8 bytes into a region of size 7
[-Wstringop-overflow=]
  230 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  609 |                 JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
In file included from sbbs.h:255:
/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:20: note: destination
object of size 7 allocated by ‘__builtin_alloca’
   77 | #define alloca(sz) __builtin_alloca(sz)
      |                    ^~~~~~~~~~~~~~~~~~~~
sbbs.h:228:43: note: in expansion of macro ‘alloca’
  228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) {
\
      |                                           ^~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_uifc.c:609:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  609 |                 JSVALUE_TO_ASTRING(cx, argv[1], mode, 7, NULL);
      |                 ^~~~~~~~~~~~~~~~~~

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/js_console.cpp
diff

Fix (false pos?) warnings in use of JSVALUE_TO_ASTRING only in RELEASE builds

using gcc version 12.2.0 (Debian 12.2.0-14), e.g.

js_console.cpp: In function ‘JSBool js_handle_ctrlkey(JSContext*, uintN,
jsval*)’:
sbbs.h:230:56: warning: writing 8 bytes into a region of size 2
[-Wstringop-overflow=]
  230 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
In file included from sbbs.h:255:
/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: destination
object of size 2 allocated by ‘__builtin_alloca’
   77 | #define alloca(sz) __builtin_alloca(sz)
      |                    ~~~~~~~~~~~~~~~~^~~~
sbbs.h:228:43: note: in expansion of macro ‘alloca’
  228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) {
\
      |                                           ^~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
sbbs.h:230:56: warning: writing 1 byte into a region of size 0
[-Wstringop-overflow=]
  230 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into
destination object of size 2 allocated by ‘__builtin_alloca’
   77 | #define alloca(sz) __builtin_alloca(sz)
      |                    ~~~~~~~~~~~~~~~~^~~~
sbbs.h:228:43: note: in expansion of macro ‘alloca’
  228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) {
\
      |                                           ^~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into
destination object of size 2 allocated by ‘__builtin_alloca’
   77 | #define alloca(sz) __builtin_alloca(sz)
      |                    ~~~~~~~~~~~~~~~~^~~~
sbbs.h:228:43: note: in expansion of macro ‘alloca’
  228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) {
\
      |                                           ^~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
/home/rswindell/sbbs/src/sbbs3/../xpdev/genwrap.h:77:36: note: at offset 2 into
destination object of size [1, 2] allocated by ‘__builtin_alloca’
   77 | #define alloca(sz) __builtin_alloca(sz)
      |                    ~~~~~~~~~~~~~~~~^~~~
sbbs.h:228:43: note: in expansion of macro ‘alloca’
  228 |                         if(((ret)=(char *)alloca((*JSSTSlenptr)+1))) {
\
      |                                           ^~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~
js_console.cpp:670:17: note: in expansion of macro ‘JSVALUE_TO_ASTRING’
  670 |                 JSVALUE_TO_ASTRING(cx, argv[0], keystr, 2, NULL);
      |                 ^~~~~~~~~~~~~~~~~~
sbbs.h:230:56: warning: writing 1 byte into a region of size 0
[-Wstringop-overflow=]
  230 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sbbs.h:242:9: note: in expansion of macro ‘JSSTRING_TO_ASTRING’
  242 |         JSSTRING_TO_ASTRING((cx), JSVTSstr, (ret), (maxsize),
(lenptr)); \
      |         ^~~~~~~~~~~~~~~~~~~

Modified Files:


src/sbbs3/un_rep.cpp
diff

Fix warning about signed/unsigned compare

Modified Files:


src/sbbs3/main.cpp
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Add an 'enabled' property for QWKnet hubs, defaults to true, part 2

Missing part of yesterday's commit, whoops

Modified Files:


ctrl/msgs.ini
diff

src/sbbs3/scfg/scfgnet.c
diff

Add an 'enabled' property for QWKnet hubs, defaults to true

Move the pack and unpack commands to an "Advanced" sub-menu since they
are completely optional now.

Set QWKhub 'VERT' to disabled by default in a new install.

Fixes issue #506

Modified Files:


src/conio/sdlfuncs.c
diff

Resolve GCC warning

warning: passing argument 1 of ‘ra’ discards ‘const’ qualifier from
pointer target type

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

'sysop login' instead of 'sysop logon' in help text

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/str.cpp
diff

src/sbbs3/un_qwk.cpp
diff

src/sbbs3/useredit.cpp
diff

Resolve warnings as a result of last commit

More 'long int' purging.

Modified Files:


src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

find_login_id() will now return 0 if login ID is an invalid user number

If login by number is supported and a client attempts login with an invalid
usernumber, don't log an error, e.g.
mail 3264 SMTPS [46.148.x.x] !ERROR -2 getting data on user (6123)

But rather treat it as an invalid login attempt.

Also change lastuser() and total_users() to return int instead of uint. 2
billion users should be plenty.

Modified Files:


src/sbbs3/chat.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/getnode.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/writemsg.cpp
diff

Eliminate old lread/lwrite/lkbrd wrapper macros

Vestiges of MS-DOS and 16-bit ints and local keyboard access.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Fix help text wrapping issues recently introduced

Make the wizard use the same width (76) as the help screen to help identify
text wrapping issues. Looks a bit better too.

Modified Files:


src/xpdev/ini_file.c
diff

Resolve Borland 'Unreachable code' warning

Warning W8066 .\ini_file.c 416: Unreachable code in function iniRemoveKey

Modified Files:


src/xpdev/filewrap.h
diff

_chsize_s() is only available in MSVC, apparently

Fixes Borland and mingw-GCC  builds.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Add a figlet logo to the wizard welcome page

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Re-word the QWK BBS-ID help text

Modified Files:


src/sbbs3/text_defaults.c
diff

CantDeleteMsg text update

%lu -> %u (part of the great 'long int' purge)

Modified Files:


src/sbbs3/chksmb.c
diff

src/sbbs3/mailsrvr.c
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smbtxt.c
diff

The great 'long int' purge of 2023 part 4

[s]printf format fix-ups

Modified Files:


src/sbbs3/writemsg.cpp
diff

src/smblib/smbadd.c
diff

src/smblib/smballoc.c
diff

src/smblib/smbdefs.h
diff

src/smblib/smbfile.c
diff

src/smblib/smbhash.c
diff

src/smblib/smblib.c
diff

src/smblib/smblib.h
diff

src/smblib/smbtxt.c
diff

src/xpdev/filewrap.h
diff

The great 'long int' purge of 2023 part 3

Likely a part 4 coming next after building with GCC.

Modified Files:


exec/irc.js
diff

Fix irc.js line 750: TypeError: channels.current is undefined

And other potential occurrences of this when not in a channel

Modified Files:


src/sbbs3/newuser.cpp
diff

Lowercase the action/newuser/<protocol> topic

Be consistent with the other action/* topics.

Modified Files:


ctrl/text.dat
diff

Fix the one lingering %l[d|u|x] in this file

Modified Files:


src/sbbs3/logout.cpp
diff

Insure there's at least one space between stats in .lol files

The format string used did not insure there was any space between fields
leading to very hard to parse stats, like this:
User          2  SSH      12:25 12:39  14554  0  0  0  0  0

That's 554 msgs read in 14 minutes online, but well, you see what I'm say'n.

Modified Files:


src/sbbs3/answer.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/ftpsrvr.c
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/logout.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/slog.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/useredit.cpp
diff

src/sbbs3/websrvr.c
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

The great 'long int' purge of 2023 part 2

Mostly [s]printf format fixups

Modified Files:


src/sbbs3/atcodes.cpp
diff

src/sbbs3/cmdshell.h
diff

src/sbbs3/con_hi.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/data.cpp
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/execfile.cpp
diff

src/sbbs3/execmsg.cpp
diff

src/sbbs3/file.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/getmsg.cpp
diff

src/sbbs3/getstr.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/listfile.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/mail.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/msgtoqwk.cpp
diff

src/sbbs3/netmail.cpp
diff

src/sbbs3/pack_qwk.cpp
diff

src/sbbs3/postmsg.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/putmsg.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/qwk.h
diff

src/sbbs3/qwktomsg.cpp
diff

src/sbbs3/readmail.cpp
diff

src/sbbs3/readmsgs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scandirs.cpp
diff

src/sbbs3/scansubs.cpp
diff

src/sbbs3/startup.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/telgate.cpp
diff

src/sbbs3/tmp_xfer.cpp
diff

src/sbbs3/writemsg.cpp
diff

src/sbbs3/xtrn.cpp
diff

src/sbbs3/xtrn_sec.cpp
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

The great 'long int' purge of 2023 part 1

At one time, Synchronet was a 16-bit DOS project, plagued by the 16-bit [u]int,
so long's were used everywhere > 16-bits were known to be needed/wanted (This
is before the days of the standard sized types from stdint.h), and they've
persisted.

But '[u]long int' is 64-bits on *nix 64-bit builds, 32-bits everywhere else
(even 64-bit Windows builds if/when we ever get around to that), so this could
lead to insidious bugs that would only show up on one flavor or the other.
Since [u]int is 32-bits on everything we currently support, we'll use that
instead of [u]long.

This "part 1" because I'm sure there's going to be warnings and errors from the
GCC/Clang builds as a result, which I'll get to next.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/load_cfg.c
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/str.cpp
diff

src/sbbs3/upgrade_to_v319.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Removed about 1500 bytes of unused scfg_t fields (cruft)

modem init strings, alt file paths, PostLink name/number, node-specific
command-lines, etc., many of these haven't been used since SBBS v2.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Use 'logon' instead of 'login' in the config wizard

Modified Files:


exec/tempxfer.js
diff

file_area.min_diskspace is in bytes now, not kilobytes - so deal

Modified Files:


exec/chkspace.js
diff

file_area.min_diskspace is in bytes now, not kilobytes - so deal

Also, use easier to read byte value strings in email and log msgs.

Modified Files:


text/newuser.msg
diff

Add EOL to last line

Modified Files:


src/sbbs3/sbbsecho.c
diff

More consistent 'exact' parameter values to findnodecfg() - e.g. false, not 0

No functional change.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Rework NetMail routing logic to handle point destinations better

With this commmit, the logic is now:

If the NetMail destination is a point and there's no linked-node for it
   and the boss node for this point is not one of our AKAs
   then route to the boss node (no linked-node match needed)
   if the boss node matches a linked-node with a route configuration
   then route to that configured route destination (2-levels of routing
   and thus 2 "Routing NetMail" msgs will be logged in this scenario)

If the NetMail destination is a point and there is a linked-node for it
   then the netmail will not be routed
		unless that linked node has a route configuration

NetMail destined for non-points are treated the same as before this
commit.

No change in the routing of echomail for points.

I think this change fixes issue #520 which can be traced back to commit
45ced2a3b for poindexter FORTRAN (REALITY), 2 years ago almost to the
day, where that change added point->boss routing, but only if the boss
had a matching linked-node configuration (for both echomail and
netmail).

This commit also re-thinks commit ffe69b43623d (for Alterego) which
would not route a point netmail if any our local AKAs matched the
destination address, igorining the point value. I think what was
intended here (I coudln't locate the original enhancmenet request or
issue), was to not route if a local AKA was the *boss* of the point.
And with this commit, that's now how it now works.

As before, "test results appreciated".

Modified Files:


src/uifc/uifc32.c
diff

input() method was off-by-one on the string input x-coordinate w/ WIN_NOBRDR

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Display the system password prompt in the Wizard with no border

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Fix compile error about label and statements from gcc version 10.2.1

Interestingly, gcc version 12.2 and MSVC 2019 had no problem with this code.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

A little cosmetic adjustment to the setup wizard

Added Files:


web/root/fido-nodelist-syncterm.ssjs
diff

Create a simple web service to convert an FTN nodelist to syncterm.lst

Tested with this:
wget --content-disposition --post-file=nodelist.010
http://synchro.net/fido-nodelist-syncterm.ssjs

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Enable backward movement through the setup wizard using ESC

Display a progress bar too.

Modified Files:


exec/fido-nodelist-syncterm.js
diff

Don't use alert() or write() to make this suitable for a web service

Also close the syncterm.lst file so we can read it completely after
load()ing this script.

Modified Files:


exec/sendmail.js
diff

Updated to be suitable as a /usr/bin/mail[x] replacement too

Migrated rcpt() to mailutil.js parse_mail_recipient()

Modified Files:


exec/load/mailutil.js
diff

Moved sendmail.js rcpt() to parse_mail_recipient() here for reuse

Modified Files:


src/sbbs3/ctrl/ConfigWizardUnit.cpp
diff

scfg_t.node_valuser is now scfg_t.valuser

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Cosmetic improvements to the Setup Wizard, especial for > 80 col screens

Modified Files:


src/sbbs3/logout.cpp
diff

Report correct upload/download Kbytes in data/logs/<date>.log files

After the move to 64-bit upload/download byte counts, these integers are
different width than 'long' on 32-bit builds (e.g. Windows), so these numbers
were wrong on all but 64-bit *nix builds.

The change here also uses the cool byte_estimate_to_str() function so that
large byte totals are not expressed in 'K' but rather 'M', 'G', 'T' etc.
suffixes.

The formatting is otherwise consistent with the pre-existing log line format
save for the use of an uppercase suffix now.

Before:
@- 02:19p  T: 12   R:  0   P:  0   E:  0   F:  0   U:  0k 0   D:420k 1
After:
@- 02:07p  T:  0   R:  0   P:  0   E:  0   F:  0   U:  0K 0   D:420K 1

Before:
@- 02:23p  T:  0   R:  0   P:  0   E:  0   F:  0   U:  0k 0   D:1359k 1
After:
@- 02:26p  T:  1   R:  0   P:  0   E:  0   F:  0   U:  0K 0   D:1.3M 1

This fixes issue #519. I'm glad to hear that sysops still use these log files!

Modified Files:


src/uifc/uifc32.c
diff

Fix centering of the showbuf (e.g. help screen) title

I'm not sure what was going on with this addition of 6 when mouse is enabled
(and didn't check for WIN_DYN flag set!), but is wrong. And we need to add 4 to
the title_len when figuring out the centered-offset.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgsys.c
diff

More setup wizard help messages/screens (e.g. Welcome)

Updated System Operator help text.
Fixed line-wrapping in other help text.
Provide the UTC offset string to edit, even when 0.
Make the abort/restart wizard options more clear.
General beautifications of the wizard.

Modified Files:


exec/upgrade_to_v320.js
diff

src/sbbs3/email.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/js_bbs.cpp
diff

src/sbbs3/logfile.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgnode.c
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Move sysop notification settings from node to system level

The validation user (required new user feedback user number) and error
notification/level settings don't make sense under node settings in today's
world where all nodes typically run on the same system and serve the same BBS.

Moved from SCFG->Nodes->... Advanced Options to (new sub-menu)
SCFG->System->Notifications. Likewise, these 3 settings (valuser, erruser,
errlevel) were moved from node*/node.ini to ctrl/main.ini.

If you're already running v3.20a, then you'll want to make sure you set these
in SCFG->System->Notifications how you prefer them as the migration (now
handled in upgrade_to_v320.js) won't have been done for you automatically. The
default is no-new-user-feedback required and no-error-notification user set.

Added a prompt to the SCFG setup wizard to prompt for this setting since it
still is a FAQ.

Other cosmetic changes to SCFG help and setup wizard.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/login.cpp
diff

src/sbbs3/mailsrvr.c
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/services.c
diff

src/sbbs3/websrvr.c
diff

Add MQTT <BBS>/action/login_fail/<protocol> topic support

Publish all login-failures to this new topic.

This commit also includes a few 64-bit free disk space fixes in the FTP server.

Modified Files:


src/sbbs3/zmodem.c
diff

64-bit free disk space fix

Modified Files:


src/sbbs3/sbbsecho.c
diff

Resolve signed/unsigned compare warning with MSVC

Modified Files:


src/xpdev/ini_file.c
diff

src/xpdev/ini_file.h
diff

Add iniGetClampedInt() to return an int key val clamped to a min/max range

Very similar to iniGetIntInRange(), but the default value is only returned
if the key or value is missing.

Modified Files:


src/uifc/uifcx.c
diff

showbuf() definition needs a name for the first arg for MSVC

... but not for GCC or Clang interestingly enough.

Modified Files:


src/sbbs3/ctrl/ConfigWizardUnit.dfm
diff

Fix typo

Modified Files:


src/uifc/uifcx.c
diff

Create a (very simple) showbuf() implementation for the stdio uifc

Modified Files:


src/uifc/uifc32.c
diff

Fix list() width when WIN_NOBRDR is used

The title isn't displayed in this mode, so the title length is 0.

Why is title being strdup()'d here? Something to look into.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Make the Configuration Wizard look cool

This kind of sort of matches the SBBSCTRL Config Wizard flow and set of
settings now.

Pretty neat the stuff you can do with UIFC it turns out.

Also fixed a typo here and there and default to the currently-configured
deleted-message-viewing policy and stuff like that.

Modified Files:


src/sbbs3/xtrn_sec.cpp
diff

Fix "running external" log message format mistake

Introduced in commit 73e5dd9c, reported by Codefenix

Modified Files:


src/sbbs3/js_internal.c
diff

Descriptions of js.exec_file and exec_dir were reversed

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Default Other/non-US timezone to the current configuration selection

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/sbbscon.c
diff

Change the default run/pid file to just 'sbbs.pid' (in the ctrl dir)

Non-root users don't have write access to /var/run by default,
so don't use that as the default location of the pid file.

Modified Files:


src/sbbs3/baja.c
diff

Make !INCLUDE directives filename case-insensitive

Some legacy Baja source files !INCLUDE SBBSDEFS.INC, but the filename is now
sbbsdefs.inc, which does not match on case-sensitive filesystems (e.g. Linux)
e.g.
BBSLISTR.ZIP:!INCLUDE SBBSDEFS.INC
FORSALE1.ZIP:!INCLUDE SBBSDEFS.INC
FWISH10.ZIP:!INCLUDE SBBSDEFS.INC
GUESS20.ZIP:!INCLUDE SBBSDEFS.INC
NU_SYNC.ZIP:!INCLUDE SBBSDEFS.INC
ONELINE1.ZIP:!INCLUDE SBBSDEFS.INC
ni-sbbs.zip:!INCLUDE SBBSDEFS.INC

This issue was reported via DOVE-Net by Rick Smith.

Modified Files:


src/sbbs3/scfg/scfg.c
diff

src/sbbs3/scfg/scfg.h
diff

src/sbbs3/scfg/scfgmsg.c
diff

src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfg/scfgsys.c
diff

Add initial setup wizard (prompts for each of the important cfg settings)

Automatically runs when main.ini new_install=true or the '-w' option is
passed to SCFG.

This doesn't ask all the same questions as the SBBSCTRL Config Wizard, but
it's a good start.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/text_defaults.c
diff

src/sbbs3/upload.cpp
diff

src/xpdev/dirwrap.c
diff

src/xpdev/dirwrap.h
diff

Support larger file systems (>4GB size/space) using uint64_t through-out

getdirsize() is maxed out at size_t, so return that type

Modified Files:


ctrl/text.dat
diff

src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/upload.cpp
diff

Check free disk space when batch-uploading to the blind upload directory

This fixes issue #516

Modified Files:


src/sbbs3/js_file_area.c
diff

src/sbbs3/upload.cpp
diff

min_dspace is now in bytes, not kilobytes, so deal with that

Modified Files:


exec/upgrade_to_v320.js
diff

Insure that the file.ini min_dspace value has been migrated in kilobytes

Modified Files:


src/sbbs3/scfg/scfgxfr1.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

Allow minimum disk space to be any size (not limited to 65535K)

Modified Files:


ctrl/file.ini
diff

Set default minimum free space to 100M bytes

Modified Files:


ctrl/file.ini
diff

Apply up/download credit percentage key name fixes

Following the (now proper) naming introduced in commit 8e6ebec36f942

Modified Files:


src/sbbs3/scfgsave.c
diff

Fix bug where file.ini min_dspace could be set to -1

min_dspace is an *unsigned* short, so saving 65535 (the default) was converting
the signed decimal representation when saving file.ini.

Modified Files:


src/sbbs3/scfglib2.c
diff

src/sbbs3/scfgsave.c
diff

More iniGetShort ->iniGetUShort fixups

Not that most of these values should ever exceed 32767, but might as well

Modified Files:


src/sbbs3/scfg/scfgnet.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

Change qhub_t mode and days to an unsigned 8-bit int

Resolve the QWKnet hub 'days' key in msgs.ini being written as -1

Modified Files:


src/xpdev/ini_file.c
diff

iniSetHexInt[64] write values < 10 in decimal notation

Modified Files:


ctrl/chat.ini
diff

ctrl/file.ini
diff

ctrl/main.ini
diff

ctrl/msgs.ini
diff

ctrl/xtrn.ini
diff

Re-generated stock .ini files using 'scfg -n -f'

When changes are made using SCFG on these files, a 'git diff' is now helpful
and readable to
see what changed.

The order of sections and keys change as a result.

Some extraneous stuff created by upgrade_to_v320.js was removed and some
numeric values change
from hex to decimal encoding.

Modified Files:


src/xpdev/ini_file.c
diff

When writing hex integer values, use "0" rather than "0x0"

upgrade_to_v320.js sets these values to just "0", so let's not thrash on the
format.

Modified Files:


ctrl/main.ini
diff

Fix freecreditperday -> freecdtperday

Resulted from upgrade_to_v320.js typo

Modified Files:


exec/upgrade_to_v320.js
diff

Fix typo: freecdtperday, not freecreditperday

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_user_sysop_fix' into 'master'

SlyEdit: Small fix for sysop checking (didn't catch it in the earlier refactor)

See merge request main/sbbs!256

Modified Files:


exec/SlyEdit_Misc.js
diff

SlyEdit: Small fix for sysop checking (didn't catch it in the earlier refactor)

Modified Files:


exec/SlyEdit_Misc.js
diff

Merge branch 'slyedit_user_sysop_fix' into 'master'

SlyEdit: Small fix for sysop checking (didn't catch it in the earlier refactor)

See merge request main/sbbs!256

Modified Files:


src/sbbs3/scfg/scfg.c
diff

Set the Window title to override the default: "SyncConsole"

This appeared in the ChromeOS taskbar, so now it'll say
"Synchronet Configuration" instead.

Modified Files:


exec/login.js
diff

Use the new (to v3.20) method of checking for login-by-usernumber support

The old NM_NO_NUM flag is unused/deprecated.

Modified Files:


src/sbbs3/file.cpp
diff

Set destination directory in proper file_t instance in movefile()

This fixes the issue (#515) that was introduced 9 months ago
(after the v3.19b release) with commit b1449b273cec4d.

Also:
	movefile() will now log an error message if addfile() fails.
	Fix the message logged when the file is successfully moved.

Modified Files:


src/sbbs3/main.cpp
diff

Fix crash when getting file area web_file_prefix in JSexec

js_init was assuming that startup != NULL

Modified Files:


src/sbbs3/js_msg_area.c
diff

Add 'fidonet_addr' property to msg_area.sub[]

Fixes issue #398

Added Files:


exec/fido-nodelist-syncterm.js
diff

Exports a syncterm.lst file from a FTN nodelist

Paul Hayton (fsxNet admin) had this idea. This seems to do the trick.

It does use the listed IBN (BinkP) address as a fall-back if the INA and ITN
addresses aren't specified, which may not be desireable.
So maybe that should be a command-line option to enable as desired. <shrug>

Added Files:


exec/fido-nodelist-syncterm.js
diff

Exports a syncterm.lst file from a FTN nodelist

Paul Hayton (fsxNet admin) had this idea. This seems to do the trick.

It does use the listed IBN (BinkP) address as a fall-back if the INA and ITN
addresses aren't specified, which may not be desireable.
So maybe that should be a command-line option to enable as desired. <shrug>

Modified Files:


src/conio/sdl_con.c
diff

Fix a couple issues found by Coverity

1) Unreachable return without a lock in sdl_useR_func_ret() (harmless)
2) LOR in handling SDL_USEREVENT
   - vstatlock was obtained inside of win_mutex which should never
     be done... this could (and likely does) result in a deadlock
     when using SDL mode.

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/startup.h
diff

Use configurable default terminal dimensions from sbbs.ini

New (optional) keys in ctrl/sbbs.ini (with defaults):
[BBS]
DefaultTermWidth=80
DefaultTermHeight=24

This fixes issue (feature request) #491

Modified Files:


src/conio/sdl_con.c
diff

Fix a couple issues found by Coverity

1) Unreachable return without a lock in sdl_useR_func_ret() (harmless)
2) LOR in handling SDL_USEREVENT
   - vstatlock was obtained inside of win_mutex which should never
     be done... this could (and likely does) result in a deadlock
     when using SDL mode.

Modified Files:


ctrl/sbbs.ini
diff

src/sbbs3/main.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs_ini.c
diff

src/sbbs3/startup.h
diff

Use configurable default terminal dimensions from sbbs.ini

New (optional) keys in ctrl/sbbs.ini (with defaults):
[BBS]
DefaultTermWidth=80
DefaultTermHeight=24

This fixes issue (feature request) #491

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Update terminology in security-related settings and help screens

Modified Files:


src/sbbs3/con_hi.cpp
diff

src/sbbs3/scfg/scfgsys.c
diff

src/sbbs3/scfgdefs.h
diff

src/sbbs3/scfglib1.c
diff

src/sbbs3/scfgsave.c
diff

Allow configurable system password timeout

The default value is the same as the previously hard-coded value: 15 minutes.

Increase this value to prompt the sysop for the system password less
frequently, decrease for more frequent.

This fixes issue #407.

Modified Files:


src/sbbs3/str.cpp
diff

Fix 30-year-old bug (obvious password patterns) in chkpass()

Off-by-one bug caused the comparison of only the first 3 chars of the proposed
password against "QWE", "ASD", and "!@#" rather than the 4 character pattern
match as intended.

These lines should be removed anyway since this can be easily achieved via
password.can (as intended), but I couldn't help myself but to fix this ancient
bug.

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Overhaul the System Configuration menu - moved all Security Options to submenu

The security-related options were really spread around and this menu was
getting very overloaded (the list of Toggle Options had grown huge), so now
most of the content is actually under the new "Security Options" sub-menu.

This does make a bunch of previous instructions/docs slightly out of sync
(e.g. SCFG->System->Security Level Values should now be
SCFG->System->Security Options->Security Level Values), but I think sysops
will still find stuff just fine.

This re-org will allow me to add more options that I've wanted to but needed
better organization and structuring to do so logically and clearly.

Using the memcmp() trick to detect changes in the configuration.

No new settings/option were added in this commit.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: As a loadable module, now make use of user# parameter for reading
personal email (for the sysop when deleting a user account)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_read_personal_email_usernum_update' into 'master'

DDMsgReader: As a loadable module, now make use of user# parameter for reading
personal email (for the sysop when deleting a user account)

See merge request main/sbbs!254

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Free/zero out the file_t struct *after* sending the MQTT action msg

... not before. This explains why FTP-uploaded actions had a (null) filename.

Modified Files:


exec/str_cmds.js
diff

All UEDIT sysop command to pull up deleted users by alias or number

Requires the latest v3.20a for sytem.matchuserdata() to support deleted and
inactive user record searching.

This is part of the fix for the issue described in issue #513 where the
UEDIT sysop command was falling back (displaying/editing) user #1 because
the sysop-specified user number or alias was not an active user account.

The fallback to display/editing user #1 still happens, but first we try
really hard to find the user that the sysop specified as an argument to
the UEDIT command.

Modified Files:


src/sbbs3/js_system.c
diff

Allow system.matchuserdata() to search deleted user records

Insert an optional boolean argument to enable a search through deleted and
inactive user records (in addition to active user records). This is part of
the solution to the problem described in issue #513 where the UEDIT sysop
command did not go to a specified user (by alias) automatically, presumably
because the user record was marked as deleted.

Modified Files:


src/sbbs3/newuser.cpp
diff

Fix MQTT action/newuser msg topic

Modified Files:


src/sexpots/sexpots.c
diff

[com] Debug will enable transmit debug log output (in addition to receive)

Log the characters themselves of ASCII values (between 32 and 126) for com
debug log messages. Still a separate log message/line for every character
(so very chatty/verbose).

This fixes issue (feature request) #510

Modified Files:


src/sbbs3/writemsg.cpp
diff

Don't save draft messages upon disconnect for Guest or "no one" (user #0)

Fix issue #508

Modified Files:


src/comio/comio_win32.c
diff

That's not a semi-colon!

Modified Files:


src/comio/comio_win32.c
diff

Handle COM10 and above.

https://support.microsoft.com/en-us/topic/howto-specify-serial-ports-larger-tha
n-com9-db9078a5-b7b6-bf00-240f-f749ebfd913e

Obviously, it needs the be \\.\COM12

Modified Files:


src/sexpots/sexpots.c
diff

Fix printf format typo in previous commit

This should fix issue #509

Modified Files:


src/sbbs3/websrvr.c
diff

If the FastCGI address begins with a '.', treat as UNIX Domain Socket as well

<Deuce> So the [previous] change doesn't work with relative paths?

So... support relative UDS paths in this manner (without the "unix:" prefix)

Modified Files:


src/sbbs3/websrvr.c
diff

If the FastCGI address starts with a '/', it's obviously a UNIX domain socket

We don't really need the "unix:" prefix now, but just leave that support in
for backward compatibility.

Modified Files:


src/sexpots/sexpots.c
diff

Add optional debug-level logging of all chars received over COM port/device

Set Debug=true in the [com] section of sexpots.ini to enable this (and you'll
need to be logging debug-level message as well). For Nelgin.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix webserver build on Windows - no UNIX domain socket support

According to
https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/
it is possible, but I think I'm using an WinSDK that's too old, so let's just
not support this feature on Windows just yet. Define UDS_SUPPORT when
supported.

Modified Files:


src/sbbs3/websrvr.c
diff

Add UNIX domain FastCGI support

Resolves a long-standing todo comment and has made wiki.synchro.net page
rendering even faster.

PHP-FPM defaults to creating/listening on UNIX domain sockets.

This resolves gitlab issue #507

Modified Files:


src/sbbs3/websrvr.c
diff

More details in "Failure to send header/request to FastCGI socket" log msg

Elevate the log level back to ERROR (from WARNING), as this is not an expected
condition and the sysop (me) should be alerted right away. This had previously
be lowered (along with some other log messages) from ERROR to WARNING.

When php-fpm is updated (on Debian, anyway), e.g. from 8.1 to 8.2, a new
etc/php configuration (pool.d) directory was used which set me back to a
default www.conf file that uses Unix domain sockets instead of TCP sockets.

Modified Files:


exec/login.js
diff

The bare CR is treated as CRLF on PETSCII, so use Ctrl-A[ instead

We don't do output translation for PETSCII terminals for CR or LF
chars, so this trick is needed, at least currently, for the NN legacy prompt
to be properly over-written/invisible for CBM/PETSCII terminals.

Modified Files:


exec/msglist.js
diff

Fix errant tab in help output

Modified Files:


xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

Updates/fixes to Good Time Trivia questions & answers etc.

Modified Files:


xtrn/gttrivia/qa/general.qa
diff

xtrn/gttrivia/qa/music_movies_and_entertainment.qa
diff

Merge branch 'gttrivia_small_updates' into 'master'

Updates/fixes to Good Time Trivia questions & answers etc.

See merge request main/sbbs!253

Modified Files:


src/sbbs3/filedat.c
diff

If filename_maxlen is 0, don't use it enforce a maximum filename length

This is just extra paranoia now since the reading of file.ini enforces the
value range
8 <-> 65535 now.

Modified Files:


src/sbbs3/scfglib2.c
diff

Insure that the max (uploaded) filename limit is in the range 8-65535
characters

Upgrading fromm v3.19 can result in a setting of filename_maxlen=0 in file.ini,
so let's
put a special check in place to insure this can't happen (thus preventing any
file
uploads). I chose '8' as a kind of arbitrary minimum maximum value (MS-DOS
filenames
maxed out at 12 characters), but at least 0 won't be possibly any longer.

As reported on DOVE-Net by Codefenix and confirmed by xbit.

Modified Files:


CONTRIBUTING.md
diff

Typos and capitalization

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

DDMsgReader: When reading or listing messages, either the DEL or BACKSPACE
key...

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

Merge branch 'dd_msg_reader_delete_backspace' into 'master'

DDMsgReader: When reading or listing messages, either the DEL or BACKSPACE
key...

See merge request main/sbbs!252

Modified Files:


src/sbbs3/inkey.cpp
diff

src/sbbs3/sbbs.h
diff

Move input translation (e.g. for PETSCII) to its own sbbs_t methods

Move kbincom() to an sbbs_t method.

No functional change here, just getting ready to support input translation for
stdio
external programs as an option.

Modified Files:


src/sbbs3/mqtt.c
diff

Don't include number of user's file uploads in action/[upload|download] msgs

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Fix uploader-notification, credit awards, download-counters in FTP downloads

Since v3.19 (the new filebases), when a user FTP-downloaded a file, we failed
to properly find/load that file's record from the filebase (searching for the
file's full path, rather than just the filename), so the code the increments
the file's download counter, notifies the uploader, awards credits, etc. did
not ever execute. This means that FTP-downloads for all files downloaded via
FTP were effectively "free" (and nobody noticed). No error was logged either.

I discovered this while debugging the case of "(null)" filenames in the
action/download MQTT topic messages being published by the FTP server. So
that issue is fixed as part of this commit as well.

Oh, and if this code had executed before, it would have memory-leaked the
file information, so that's fixed too (added call to smb_freefilemem). Ugh.

Modified Files:


src/sbbs3/chat.cpp
diff

Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)

Be sure to let them select a node even when no nodes are technically "in use".
As requested by Nelgin in IRC (what, no gitlab issue?)

Modified Files:


src/sbbs3/main.cpp
diff

Lower severity of "Spy socket ... connected" log message from ERR (?) to INFO

Looks like just a confluence of search/replace errors over the past 19 years,
starting with commit 9ef382e50c6.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Make the "Spy on node" and "Chat with user" node options always available

On the node options popup menu, these options weren't visible/available unless
there was a user logged-in, but they're usable and useful even when there
is not a user logged-in.

Modified Files:


src/sbbs3/umonitor/umonitor.c
diff

Make the chat (F10) work even when user is not logged-in

A sysop can, and may want to, chat with a user before they succesfully login.

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug
function from dd_lightbar_menu.js

Modified Files:


exec/load/dd_lightbar_menu.js
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/DefaultTheme.cfg
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_read_theme_colors_fix' into 'master'

DDMsgReader: Fix for reading colors from the theme file. Also, removed debug
function from dd_lightbar_menu.js

See merge request main/sbbs!251

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: (Hopefully) improved display of certain ANSI messages

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_lister_ansi_improvement' into 'master'

DDMsgReader: (Hopefully) improved display of certain ANSI messages

See merge request main/sbbs!250

Modified Files:


src/sbbs3/mqtt.c
diff

Convert spaces to underscores in MQTT topics 

e.g. "action/hack/smtp login" -> "smtp_login", best practices and all.

Modified Files:


src/sbbs3/websrvr.c
diff

Fix MQTT-published action/login message for web server users

e.g. 20230130T171211-480	0	<unknown user>	76.89.231.66	<no
name>

the user number name actually *are* known at this stage

Modified Files:


src/sbbs3/scfg/scfgsys.c
diff

Remember the Security Level selection upon exit/reenter security levels