Synchronet Git Commit Log

Modified Files:


src/conio/win32cio.c
diff

Deal with more windows console braindeadedness.

The window and the screen buffer are two different things... the
screen buffer must always be the same size as or larger than the
window.  Further, there are times where it's not possible to resize
the windown programatically (new terminal for example).

There still appears to be a stupid bug in what I assume is the
Windows Terminal LCF flag implementation which causes writes to
the beginning of a line that occur after a write to the end of the
previous line to be in the wrong position.  If it's not the LCF flag
(which isn't turned on), it's in their wrapping thing which is extra
irritating since I explocitly turn that off.

Modified Files:


src/conio/ansi_cio.c
diff

Fix ANSI_KEY_PGDN definition.

Likely still not right though.

Modified Files:


src/conio/win32cio.c
diff

Some more Win32 Terminal fixes

Almost there, the main issue remaining is when running from a
command-line, it sometimes "unwraps" lines.

Modified Files:


src/conio/win32cio.c
diff

Keep a local copy of the screen for windows

Because it screws up the display when you resize the window.

Modified Files:


src/sbbs3/js_file_area.c
diff

src/sbbs3/js_msg_area.c
diff

Clarify in docs that grp/sub/lib/dir numbering is zero-based

Modified Files:


exec/load/shell_lib.js
diff

Add misisng parens from previous commit

Modified Files:


exec/load/shell_lib.js
diff

Use 1-based group and lib numbers for optional subs* and dirs* menu files

This was a bug in the conversion from Baja and C++ to JS.

Discovered/reported by vela025

Added Files:


src/sexpots/.gitignore
diff

Git-ignore auto-generated files: git_branch.h and git_hash.h

Modified Files:


exec/init-fidonet.ini
diff

Fix the 404 error retrying Micronet info packet (MININFO.ZIP not mininfo.zip)

I'm not sure if the file was renamed at some point or what, but apparently
it's currently named in ALL CAPS.

Modified Files:


exec/init-fidonet.js
diff

Pass the ctrl directory on the SCFG command-line

Fixes issue were jsexec was used to invoke this script and a ctrl dir
(different than the contents of the SBBSCTRL env var) was passed on the
command-line (i.e. testing purpose). Use the correct ctrl directory.

Create the data/text directory if it doesn't already exist. This dir
is normally created whenever SBBS is run, so it should normally already
exist, but if someone runs this script via jsexec before (ever) running
sbbs, then it's possible the data/text directory does not yet exist.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/telnets.c
diff

src/syncterm/telnets.h
diff

Fix telnets

This was broken when SFTP support was added and wasn't noticed.
Big thanks to Scott Labrecque of ems-bbs.com for noticing!

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/conn.c
diff

Fix telnets port.

Modified Files:


src/conio/win32cio.c
diff

Deal with consile resizing

This doesn't fix the terrible crap Windows does to the contents of
the console yet though (sigh).

Modified Files:


src/conio/win32cio.c
diff

<nelgin> Wont crash if it wont build.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

Make JS bbs.msg_number and smb_curmsg writable

These 2 properties, specifically, could be made writable since
1. smb_t.curmsg is a special element owned by the application, not smblib
2. a special sbbs_t.current_msg_number property could be created/used to
   underlie the bbs.msg_number when there's no open message base (by sbbs).

This might be all that's needed to resolve issue #793

The other bbs.msg_* and bbs.smb_* properties are not so easily made writable,
so hopefully that's not desired.

Modified Files:


src/conio/win32cio.c
diff

Some fixups to not crash and stuff.

Modified Files:


src/conio/win32cio.c
diff

The MSVC builds apparently target some ancient API

So we need to define the Windows API ourselves. :(

Modified Files:


src/conio/win32cio.c
diff

src/syncterm/CHANGES
diff

Fix -iW colors in conio.

SetConsoleScreenBufferInfoEx() can no longer set colors in the
console palette.  Switch to virtual terminal parsing stuff and send
some ANSI to adjust the palette instead.

Modified Files:


src/sbbs3/chksmb.c
diff

Update chksmb usage (msg/file bases have .shd files, not .SHD)

And try to make it clear that multiple bases can be passed on the command-line.

Modified Files:


src/syncterm/CHANGES
diff

Log the changes.

Modified Files:


src/conio/win32cio.c
diff

Attempt to re-enable palette setting on Win32

This was disabled due to mingw32 limitations, and we use mingw64 now

Modified Files:


src/sbbs3/getmsg.cpp
diff

src/sbbs3/sbbs.h
diff

Don't use user's default download protocol for msg attachments

Fix issue #801

Modified Files:


src/syncterm/term.c
diff

Fix some remains of input weirdness...

Now that the conio layer is handling translation of character sets,
the key handler in term.c should only handle terminal related
translations (such as backspace to delete).

This fixes bug 159, but there's still some inconsistency across
the various backends on how they handle C0 control characters and
input characters outside of US-ASCII.

Modified Files:


src/sbbs3/str_util.c
diff

src/sbbs3/str_util.h
diff

Add contains_invalid_attr() - checks string for invalid attr Ctrl-A codes

Other Ctrl-A codes (e.g. ^A\) might be valid, but they're not attribute
control codes, so their existence would cause this function to return true.

Modified Files:


src/sbbs3/getkey.cpp
diff

Expand tildes in mnemonics strings that conain non-attr Ctrl-A codes

Fix for issue #800

Modified Files:


src/conio/scale.c
diff

src/conio/xbr.c
diff

src/syncterm/syncterm.c
diff

Rejigger width iterpolation.

The old code expected the L1 cache to be fairly large, and the
prefetcher to be fairly smart, and did updates by columns to save
some math.  This change performs width interpolation row-by-row
so even the dumbest prefetcher can get it right, and there's no
need to keep the whole source and destination images in the cache.

This may help out older processors when scaling with interpolation
(most commonly used in fullscreen).

It's entirely possible though that this won't be enough and they'll
still need to use "External" scaling.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

IP addresses are logged (most) everywhere else in square brackets

There are still places where it could be logged in <> (if username is not yet
known).

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/atcodes.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/exec.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/prntfile.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/useredit.cpp
diff

Rename sbbs_t::ansi_getlines() to ansi_getdims(), add sbbs_t::getdimensions()

Add JS console.ansi_getdims()

Use sbbs_t::getdimensions() or JS console.getdimensions() to move user
cols/rows values to run-time console values (querying ANSI terminal if
appropriate/supported).

JS console.pushxy(), popxy(), and gotoxy() all return Boolean now.

sbbs_t::getdimensions() and its JS wrapper is now the proper way to propagate
user's cols/rows settings to the run-time console values. This was done
(post-login) only via use of the TERMROWS and TERMCOLS @-codes in
user_settings.js. Weird.

Modified Files:


src/conio/scale.c
diff

src/conio/xbr.c
diff

src/conio/xbr.h
diff

src/syncterm/CHANGES
diff

Remove cases where pointy falls back to blocky.

Modified Files:


src/conio/scale.c
diff

Don't use the C99 restrict keyword because MSVC is apparently still
more than 25 years behind the C standard.

Modified Files:


src/sbbs3/ftpsrvr.c
diff

Attempt to fix issue #799

receive_thread() needs to use the control session correctly for
TLS connections.

Modified Files:


src/conio/scale.c
diff

Decorate some arguments to allow compiler to optimize harder

Modified Files:


src/sbbs3/ftpsrvr.c
diff

src/sbbs3/ftpsrvr.h
diff

Add NO_FTPS [FTP] Option to disable FTPS support when necessary

Ideally, a sysop would never need to disable FTPS support, but as a trouble
shooting measure, it can be helpful.

Modified Files:


ctrl/text.dat
diff

Add a bunch of conditional line continuations for 40 column terminals

Using Ctrl-A\ (\1\\) in a bunch of text strings (especially prompts) to
better accommodate 40 column terminals.

Fixes email/netmail address prompt issue reported by phigan (TACOPRON)
along with a bunch of other cosmetic and input issues with 40col terminals.

Modified Files:


exec/rlogin.js
diff

The P, C, and v options would report 'unrecognized option'

Fix for issue #798

Modified Files:


src/syncterm/updvers.sh
diff

Fix script to update Info.plist properly.

We need -g to do multi-line matching with -p.

Modified Files:


src/conio/sdl_con.c
diff

src/syncterm/CHANGES
diff

Fix macOS mouse position reporting

Under SDL2, with HighDPI enabled, we end up with two coordinate
systems for our window... there's the pixel coordinates which we
draw in, and are available via SDL_GetWindowSizeInPixels(), and
there's the "screen" coordinates, which is an underlying source
size that is scaled from, and is available via SDL_GetWindowSize().

Mouse events are in the screen coordinates, drawing is in pixel
coordinates.  This commit converts mouse event positions to pixel
coordinates before converting further to text coordinates. :(

A specual thanks to u/ten-oh-four for working to track this down
with me, they ran multiple experimental builds and collected logs
which allowed to to be tracked down.

Fixes issue 155

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Seriously, Poly1305 is not HMAC.

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Add a couple commas for the docs.

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Poly1305 isn't HMAC.

Modified Files:


src/sbbs3/js_cryptcon.c
diff

Add new algorithms.

Modified Files:


exec/SlyEdit.js
diff

SlyEdit: Open the quote file in "binary" mode (only applicable on Windows; same
as the fseditor change)

Modified Files:


exec/SlyEdit.js
diff

Merge branch 'slyedit_open_quote_file_in_binary_mode' into 'master'

SlyEdit: Open the quote file in "binary" mode (only applicable on Windows; same
as the fseditor change)

See merge request main/sbbs!462

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

More hacking to make macOS happy...

Allow ALT+Arrow to resize from maximized by calling
SDL_RestoreWindow() first.  This should allow macOS users to escape
the weird window size mess it can start in.  Still no idea what is
actually happening there, but this should at least provide an "out"
now. :(

Modified Files:


src/conio/sdl_con.c
diff

Add call to update_cvstat() in setup_surfaces()

This should ensure that cvstat has the right window size at the start.
I hope.

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

src/syncterm/uifcinit.c
diff

src/syncterm/uifcinit.h
diff

More changes around fullscreen/maximized/etc for SDL

On macOS, fullscreen and maximized are very slightly different, so
don't force one to mean the other.  However, when entering or
leaving fullscreen mode, we need to explicitly make the window
resizable or not.

Also, update the uifc screen title when the mode changes and we're
at one of the main menus... still a bit icky, but likely the best
that can be done (won't update if you toggle fullscreen from a
sub-menu for example).

Modified Files:


src/syncterm/conn.c
diff

src/syncterm/conn.h
diff

Fix warning on 64-bit Windows where a socket isn't an int.

Le sigh for the socket API.

Modified Files:


src/conio/sdl_con.c
diff

Query current fullscreen state on ALT-Enter

Because things get weird sometimes.

Modified Files:


src/conio/sdlfuncs.h
diff

SDL_SetWindowResizable() returns void.

Modified Files:


src/conio/sdl_con.c
diff

Spell SDL_WINDOW_FULLSCREEN correctly.

Also, there's SDL_WINDOW_FULLSCREEN_DESKTOP, so or that in even
though we don't need to due to how it's defined.

Modified Files:


src/conio/sdl_con.c
diff

Basically a revert of 02dce657

This appears to break the mouse position stuff. :(

Modified Files:


exec/load/cterm_lib.js
diff

Make scale_rgb_channel_value() a bit smoother and avoid divide by zero.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/bbslist.c
diff

Increase the width of File Locations window

Decrease height by one to avoid the memo line.

Modified Files:


exec/load/cterm_lib.js
diff

Define cterm_version_supports_copy_buffers (1316)

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Use cterm_lib.js for cterm-specific constants/operations

Update date display format to be less ambiguous (more international).

js.exec_dir is guaranteed to end in a slash, so no need to add one.

Bump version to 3.00.

Modified Files:


exec/load/ansiterm_lib.js
diff

Add mouse reporting modes not supported by SyncTERM

1001, 1004, 1005, 1007, and 1015

Add ability for the set/clear mouse reporting calls to set/clear
'all' modes with a single function call.

Modified Files:


exec/load/ansiterm_lib.js
diff

Allow multiple mouse reporting modes to be set/clear by passing array

This (ever so slightly) optimizes the transmtited ANSI sequences

Modified Files:


exec/load/ansiterm_lib.js
diff

Fix array support in mouse_reporting_modes()

typeof [] returns 'object', not 'array'

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Use ansiterm_lib.js for constructing ANSI mouse reporting set/clear sequences

Code beautification, no functional change other than we're not clearing mouse
mode 1016 since I don't have a definiton for that mode yet.

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Be more aggressive about setting mouse modes.

When starting, turn off all mouse modes, then turn on the ones we
need instead of relying on the console object to do anything in
particular.

On exit, explicitly turn off the two modes we had enabled before
changing the console setting.

Maybe this will fix the SyncTERM bug 153

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/term.c
diff

Fix cache subdirectories on Windows.

Windows appears to treat backslashes and slashes the same when
using the API, but Windows always returns backslashes.  Convert
backslashes to slashes in clean_path() to ensure paths compare the
same regardless of them being specified with backslashes or slashes.

There's still an open question of what to do about paths received
from the remote with backslashes in them, but I suspect that doing
that would actually work on *nix systems and break on Windows systems,
so hopefully whoever does that can fogure out what's going on.

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Ensure graphics are cached successfully.

It appears that cache operations in SyncTERM on Windows does not
currently work with subdirectories for some reason (likely
backslashes).  Ensure that after sending a file to be cached, it
correctly appears in the cache, and fall back to not using graphics.

This will fix the blank board issue in minesweeper with a Windows
SyncTERM and fallback to text mode.

Once SyncTERM is fixed, it should work in graphics mode too.

Modified Files:


src/syncterm/bbslist.c
diff

Don't copy the name to the address.

The DNS lookup can cause delays on some systems.
Fixes bug 154

Modified Files:


src/sbbs3/answer.cpp
diff

Fix indentation of one line.

Modified Files:


src/sbbs3/logfile.cpp
diff

Fix extra line feed (and blank line) when long (> 78 char) strings were logged

to node.log via sbbs_t::log()

Modified Files:


ctrl/mime_types.ini
diff

Add mp4 MIME type mapping

Modified Files:


ctrl/attr.ini
diff

Add line-feed to last line (not strictly required)

Modified Files:


src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Add 21 extra blank lines to the end of the 31-line DOOR.SYS file

Some doors/door kits actually require all 52 lines, but since they
(may) have problems with the values we populate on those additional
21 lines, just write them as blank when a program is configured for
the GAP (original) 31 line DOOR.SYS drop file. I doubt (and hope)
that no programs will care if their are more lines than they expect.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

Fix silliness discovered in conversion to JavaScript

So apparently 23 years ago (almost 24), I made a typo in commit
7731d16dbbcb7 that broke the batch transfer menu for RIP users.

Also elminated silly/unnecessary loop-control variable ('done').

I'm working on a port to JS and noticed these oddities (so far).

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix GCC warning (unused variable) introduced in last commit

Modified Files:


ctrl/services.ini
diff

src/sbbs3/services.c
diff

Add configurable "LoginRequirements" (ARS format) per-service in services.ini

In response to Reddit inquiry in /r/bbs by wts42:
"is there a possibility in sbbs to restrict access to services like IMAP by
level or flag?"

... now there is.

This only works for services that use the JS login() method to authenticate
the user.

If the services server's LoginRequirements are set in the sbbs.ini file, then
*both* sets of requirements must be met to successfully login to a service.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Add missing file to commit 095368c0d7

Not sure how I missed this one, but this file was needed to complete the
'bbs' object changes mentioned in that commit message.

Modified Files:


src/sbbs3/sbbsdefs.h
diff

src/sbbs3/scfg/scfgxtrn.c
diff

src/sbbs3/xtrn_sec.cpp
diff

Add support for 31-line DOOR.SYS file format (alternative to 52-line version)

Removed UTIDOOR.TXT file format: nobody uses this drop file format and we
removed the UTI driver long ago, so this was just an artifact.

If you previously had an external program (door) configured in SCFG to use
the "GAP DOOR.SYS" file format, SBBS will create the same (52 line) format
as before (no change).

But for doors that have compatibilty issues with the 52-line DOOR.SYS file
created by Synchronet (e.g. Thunder cat V3.30), a sysop can now choose "GAP
(original)" for the drop file type and Synchronet will create a 31-line
DOOR.SYS file instead.

Modified Files:


src/syncterm/GNUmakefile
diff

Put the manpage in ${PREFIX}/share regardless of what PREFIX is.

Modified Files:


src/syncterm/PackageInfo.in
diff

Use the pre-installed GPL license

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/DarwinWrappers.m
diff

src/syncterm/syncterm.c
diff

Fix macOS bug where the *first* entry on a new system could not be added

When the code to use URLForDirectory to get paths was written, it
didn't create the paths, so the files in them could not be created
either.

If SyncTERM had ever ran using the old FSFindFolder() method, the
path would already exist, so things would work.

Also, since we're here, use mkpath() instead of MKDIR().

Modified Files:


src/sbbs3/js_user.c
diff

New user properties: batch_upload_list and batch_download_list

For exposing the list path/file for a user's batch up/download lists

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/haiku.rdef
diff

Add the icon art created years ago (in 2012)

Modified Files:


src/syncterm/haiku.rdef
diff

rdef resources need to end in a ;

Modified Files:


src/syncterm/haiku.rdef
diff

src/syncterm/updvers.sh
diff

Whoopse, this was master.

Master is 1.2b

Added Files:


src/syncterm/haiku.rdef
diff

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/updvers.sh
diff

And generate/use the Haiku rdef file

Modified Files:


src/syncterm/PackageInfo.in
diff

src/syncterm/updvers.sh
diff

More Haiku stuff

Added Files:


src/syncterm/PackageInfo.in
diff

Modified Files:


src/syncterm/CMakeLists.txt
diff

Create a .PackageInfo file for Haiku

Modified Files:


exec/load/gettext.js
diff

Add optional friendly-key name argument, pull text from [scriptname.js]

Not all strings make good key names (e.g. those with control characters),
so allow an additional, optional argument to gettext() that allows for
more friendly key names to be used to specify/look-up (some) text strings.

Also, in addition to the global [js] section for these text values, look
(first) in [scriptfilename.js] - this allows more customization on a
per-script basis (e.g. [default.js] can be used to override strings used
in the Synchronet Classic command shell (default.js) but would not effect
if/when those same strings are used in other scripts/shells.

Modified Files:


exec/default.js
diff

Allow more shell prmopt text to be configured vi ctrl/text[.lang].ini file

Using the new load/gettext.js:
A sysop can override these additional strings (that contain Ctrl-A sequences)
now by assigning to the following keys:
- shell_prompt_begin
- shell_prompt_middle
- shell_main_prompt_end
- shell_file_prompt_end

Also, a sysop can now put these keys in the [default.js] section of the file
(rather than [js]) if desired, to avoid conflict with other scripts/shells.

Added for vela025 and their BBC Micro Acron mode 7 language support mod.
There are other strings still hard-coded in default.js and notably, in
load/shell_lib.js that are not (yet) customizable. Let's try this change first.

Modified Files:


src/syncterm/syncterm.c
diff

Get correct Haiku file paths.

It appears the "right" place to put downloads is on the Desktop...
and the OS won't tell you that.

Modified Files:


src/sbbs3/main.cpp
diff

Reset sbbs_t menu path vars (menu_dir and menu_file) before execing cmd shell

I obvserved an issue with Amessyroom's bbs where his custom (JS) shell is
setting bbs.menu_dir but when switching to another stock shell, his menu
files were still being displayed (with mismatching command keys as a result).

bbs.menu_dir (and implicitly, the set_menu_dir Baja function) apparently have
not been used in this way (much) before.

Modified Files:


src/xpdev/CMakeLists.txt
diff

Set PREFER_POLL in CMake as well.

Not just for GMUmakefile anymore!

Modified Files:


src/conio/sdl_con.c
diff

src/syncterm/CHANGES
diff

Quit video subsystem from video thread.

Some SDL targets (like Haiku) have issues doing video calls from
threads other than the video thread.

Added Files:


3rdp/build/cl-haiku-build.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

src/conio/CMakeLists.txt
diff

src/syncterm/CHANGES
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/conn_pty.c
diff

src/xpdev/CMakeLists.txt
diff

src/xpdev/multisock.c
diff

Initial Haiku support.

CMake only, has issues.

Modified Files:


exec/bullseye.js
diff

Pass P_NOERROR to bbs.menu()

... to not log an error when the bullseye.asc file doesn't exist.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Don't use global menu_dir for calls to menu() with path starting with '.'

For scripts that set the global menu_dir (e.g. via JS bbs.menu_dir), let's
not require that all the files moved from text to text/menu (for example).

Problem reported by Amessyroom when using his custom shell and bullseye.js.

Modified Files:


src/syncterm/updvers.sh
diff

Fix Info.plist command-lines

Modified Files:


src/syncterm/CHANGES
diff

Remove duplicated item

Modified Files:


src/syncterm/CHANGES
diff

Mention GDI AltGr fix

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

Only Win32 needs dbghelp.dll

Modified Files:


BUILDING.md
diff

install/GNUmakefile has been renamed to install-sbbs.mk

Modified Files:


src/conio/win32gdi.c
diff

Whoops.

Modified Files:


src/conio/win32gdi.c
diff

src/xpdev/dirwrap.c
diff

Fix a couple interesting-looking MSVC warnings.

Modified Files:


src/syncterm/CMakeLists.txt
diff

Do a Windows build if GDI or SDL is enabled.

Kinda hacky to do it here.

Modified Files:


src/conio/win32gdi.c
diff

Improve input in GDI mode

This may be a fix for bug 150 (which was reported against SDL mode).
Basically, Windows will report AltGr as Alt + Ctrl, so we need to
be able to parse that.

Since we're here, support WM_UNICHAR to avoid the need to have
Windows convert to "ANSI" for us, and allow direct unicode input
(even in "ANSI" mode).

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

A bit more fixups for Windows.

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

src/syncterm/CMakeLists.txt
diff

Fix debug builds, and default to debug.

CMake does weird things if CMAKE_BUILD_TYPE isn't defined and a
multi-whatzit generator is used.

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/FBSD-mingw64.cmake
diff

Use the detected thread library, don't -pthread anything.

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

src/syncterm/CMakeLists.txt
diff

The last few bits to make SyncTERM build for Windows on Windows.

The resulting binary crashes, but at least it builds!

Added Files:


3rdp/build/cl-mingw64-unicode-gibble.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Work around bug in mingw64 headers

NetStatisticsGet() always takes a unicode string, but the header uses
the TEXT() macro to declare the standard types.

Modified Files:


3rdp/build/cl-fix-cpuid-order.patch
diff

Þe olde bug in last commit.

Added Files:


3rdp/build/cl-fix-cbli-incompatible.patch
diff

3rdp/build/cl-fix-cpuid-order.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

More patches and fixes and stuff.

Added Files:


3rdp/build/cl-lowercase-versionhelpers.patch
diff

3rdp/build/cl-mingw64-is-really-new.patch
diff

3rdp/build/cl-mingw64-thread-handles.patch
diff

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/GNUmakefile
diff

Some more patches for mingw64

Modified Files:


3rdp/build/CMakeLists-cl.txt
diff

Don't enable crypto devices, even if we're in Windows.

Removed Files:


install/GNUmakefile
diff

Renamed to install-sbbs.mk

Added Files:


install/install-sbbs.mk
diff

Renamed install/GNUmakefile to install-sbbs.mk

Made 'install' the default target (no longer need to include "target"
on installation command-line). Specify "build" if you want to perform
global build, only (no installation).

This will help resolve confusion and mistake when running 'make install'
in the wrong directory. Also, the installation command-lines and the
re-build command-lines will no be more different and less error-prone.

All documentation that references [install/]GNUmakefile now needs
updating <sigh>.

Modified Files:


exec/default.js
diff

exec/load/shell_lib.js
diff

Replace console.crlf() calls with console.newline()

Modified Files:


exec/user_settings.js
diff

Clean up the default transfer protocol selection

was printing "None (auto-hangup)" in some cases. Wasn't very pretty or clear
to the user what was being asked  (e.g. if they accidentically entered this
selection/prompt).

Setup for localization using gettext.js.

Using console.newline() in place of (now deprecate) console.crlf().

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/sbbs.h
diff

Rename sbbs_t::batch_upload() to process_batch_upload_queue()

That was a badly named function.

Modified Files:


src/sbbs3/scfg/scfgxfr2.c
diff

Update online help (F1 key displayed help text) for directory "Short name"

This text/terminology was pretty out of date.

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/con_out.cpp
diff

src/sbbs3/js_file_area.c
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/newuser.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/str_util.c
diff

src/sbbs3/upload.cpp
diff

src/sbbs3/useredit.cpp
diff

File/batch upload decomp for scripting, unique-password-check fix, Ctrl-AX fix

Created sbbs_t::batch_upload() and JS bbs.batch_upload()
returns true if one or more blind-uploads were received and all files in
the batch upload queue (if any) were received

The Rainbow Ctrl-A codes (x|X) are not valid for message (there's no universal
ANSI equivalent) - so treat as "invalid Ctrl-A codes" for most (message) uses.
e.g. they're stripped when entered into text with the internal message editor.

sbbs_t::chkpass() and JS bbs.good_password() now default to *not* requiring
the password to be substantially different from the user's current password.
This fixes weird issues where a user that just wanted to add more characters
to their current password woudl not be allowed by cause the new password was
"too obvious"
JS bbs.good_password() now accepts an optional second argumnet: forced_unique
which defaults to false.
sbbs_t::chkpass() (JS bbs.good_password()) would always return false if the
provided password was the same as the user's current password, regardless of
the 'unique' parameter value. Now, only reject unchanged password when unique
is true.

sbbs_t::upload() and JS bbs.upload_file() now accept an optional second
argument: 'filename' which when specified, the function won't prmopt for the
user-supplied filename.

New JS property: file_area.max_filename_length

file_area.min_diskspace, settings, and web_vpath_prefix are now read-only.
These properties should not have been writable.

Modified Files:


exec/load/shell_lib.js
diff

upload_file() will now fall-back to blind/batch upload if no filename provided

If the user doesn't type a filename (just hits enter) and there are either
files in the batch upload queue and/or there's an 'Uploads' directory
configured by the sysop, then prompt if they want to start a batch
upload now and do that (using the new bbs.batch_upload() method).

This change requires the latest SBBS v3.20a changes committed in this same
push.

Change made to accomodate users/sysops like Chris Mifsud from Facebook:
"For decades using other bbs software I always just pressed enter without
entering a file name and it goes straight to the zmodem upload and then I
select the file and hit upload no problem."

Since only the default ("Synchronet Classic") command shell currently uses
this library, this change only works when using that command shell. When we
port other shells from Baja to JS (and this lib), they'll get this feature
automatically.

Modified Files:


.gitlab-ci-unix.yml
diff

The syncterm-cmake targets don't need cryptlib to be built first anymore.

Modified Files:


.gitlab-ci-unix.yml
diff

3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/hashpatch.pl
diff

src/syncterm/CMakeLists.txt
diff

Tie cryptlib cmake into syncterm cmake build

There's still some dependency weirdness on Linux, and cryptlib
won't automagically rebuild if the patches change, but it at least
works for an initial build, which is the primary use-case.

None of this has been tested on Windows yet.

Added Files:


3rdp/build/CMakeLists-cl.txt
diff

3rdp/build/CMakeLists.txt
diff

3rdp/build/hashpatch.pl
diff

Start working out how to build cryptlib using cmake.

The tricky part is really extracting the source and applying the
patches THEN configuring cryptlib.

I can do this with ExternalProject, but I'm not sure exactly how
to hook this up yet.

This also requires patch and perl and a supported md5 thing to be
installed in a place CMake will find them, which sill be
challenging for Windows.  If Windows (or compilers for Windows)
have started shipping with git, I can use git apply instead of
patch, but the rest is still kinda fuzzy.

This does at least fix up the terrible serialized build though,
so once I get this working, it will work well with values other
than -j1.

Modified Files:


src/syncterm/CMakeLists.txt
diff

Linux needs libutil for forkpty() too.

Except when it doesn't... it's harmless to link with it then though.

Modified Files:


exec/load/shell_lib.js
diff

Don't display/log an error if text/menu/upload.* doesn't exist

"upload.*" is an optional menu file, so this should've always used the
P_NOERROR flag, but the bug just fixed (in commit b656e19ff) masked this
issue.

Modified Files:


src/sbbs3/prntfile.cpp
diff

Report error when menu() can't find a display file and P_NOERROR not used

This issue was introduced in commit d02fc1a2 (3 years ago), where menu() would
silenty fail (just return false) if no display file matching the supported
menu/display file types/extensions could be found.

Previous to commit d02fc1a2, we would log a NOTICE-level message and display
a "File not found" message to the user (what sbbs_t::printfile() does), but
since d02fc1a2, we no longer even call printfile() when the file doesn't
exist, so no error was logged or message displayed to the user.

Of course, when using the P_NOERROR mode flag, silent failure is expected and
that's still what happens in that case.

Modified Files:


src/syncterm/CHANGES
diff

Ring the changes

Modified Files:


src/xpdev/CMakeLists.txt
diff

Remove spurious brace

Modified Files:


.gitlab-ci-unix.yml
diff

Don't do cross-platform CMake builds.

They're tricky tricky tricky tricky.

Modified Files:


src/conio/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Fix SDL2 linkage for Darwin.

Modified Files:


src/conio/sdl_con.c
diff

Store window size on size change event.

Allows arbitrary sized windows on Darwin... the OS is still scaling
the window contents though rather than allowing us to dynamically
update them.

Modified Files:


.gitlab-ci-unix.yml
diff

Add SyncTERM CMake test build.

So we can be sure it keeps working.

Modified Files:


text/feedback.msg
diff

Update the language to reflect modern times

Modified Files:


src/sbbs3/useredit.cpp
diff

Always reload the edited user record from disk after executing a "usercfg_mod"

Normally, when modifying user fields via JS, the "user modified" node.dab
flag would be set for that user (on all node's that user is logged-into) and
the user record automatically re-read (soon after). But this doesn't work
during newuser registration because the user is not yet "logged-into" a node.

This fixes the issue reported by Nelgin (and observed on amessyroom's BBS)
whereby if a new user resets/changes their external message editor, it would
not take effect for their new user validation email to the sysop (they would
still be using the default new user message editor as configured by the
sysop).

It's possible other new user default changes made (e.g. language) would also
not have taken immediate effect as a result of this bug (now fixed).

Added Files:


src/syncterm/FBSD-mingw64.cmake
diff

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/COMPILING
diff

src/xpdev/CMakeLists.txt
diff

src/xpdev/genwrap.h
diff

Make CMake able to cross-build Win32 binaries on FreeBSD

Modified Files:


xtrn/bublbogl/game.js
diff

remove debug logging bits :|

Modified Files:


xtrn/bublbogl/game.js
diff

show month name in high score list

Modified Files:


xtrn/bublbogl/game.js
diff

xtrn/bublbogl/lobby.bin
diff

added "talk shit" feature

Modified Files:


src/sbbs3/js_global.c
diff

Fix multi-array version of socket_select() when using poll()

Previously, when multiple lists were passed, the "write" parameter
(which can't be changed) was applied to all sockets.  This means
they would always all be poll()ed for read, then checked for the
appropriate flag (read/write/priority)... which effectively meant
that only the first (read) array would work.

Modified Files:


src/sbbs3/js_socket.c
diff

Document the connect() callback thing.

Modified Files:


xtrn/minesweeper/graphics.ppm
diff

xtrn/minesweeper/minesweeper.js
diff

xtrn/minesweeper/selmask.pbm
diff

Play with selection-follows-mouse a bit.

Can't seem to get it reliable using the SBBS mouse parsing... doing
it all myself for now until I decide if it's neat enough.  I'll
need to try it from a remote location to see how the latenct impacts
playability.

Modified Files:


src/syncterm/ooii.c
diff

Replace non-ASCII characters with \xXX escaped ones.

Too many tools are gungo-ho over UTF-8 these days.

Modified Files:


src/conio/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Some CMakeLists.txt cleanup

Remove more of the obsolete stuff.

Modified Files:


src/syncterm/CHANGES
diff

Mention CMake changes

Modified Files:


src/conio/CMakeLists.txt
diff

src/conio/ciolib.c
diff

src/encode/CMakeLists.txt
diff

src/sftp/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Initial stab at making the macOS cmake build work

Modified Files:


src/syncterm/CHANGES
diff

Add NetBSD fix note

Modified Files:


src/conio/CMakeLists.txt
diff

src/conio/curs_cio.c
diff

src/xpdev/CMakeLists.txt
diff

Fixup NetBSD and OpenBSD builds

CMake is now fixed, and a NetBSD extra wait for key on exit with
the system curses is also fixed.

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/syncterm/bbslist.c
diff

src/xpdev/CMakeLists.txt
diff

Make all listed build options optional in CMake builds

PC Speaker can't actually be disabled, so remove it from build options
listing.

Modified Files:


src/build/SynchronetMacros.cmake
diff

Compare project names instead of dirs.

Allows top-level wrapper CMakeLists.txt files to work (as long as
their project name is right).

Added Files:


src/syncterm/CMakeLists.txt.top
diff

Add top-level CMakeLists.txt for SyncTERM

Added Files:


src/sftp/CMakeLists.txt
diff

Add CMakeLists.txt for sftp

Modified Files:


src/conio/CMakeLists.txt
diff

src/syncterm/CMakeLists.txt
diff

src/xpdev/CMakeLists.txt
diff

Fix CMake system for SyncTERM

Modified Files:


src/conio/cterm.adoc
diff

Clarify that you can still set a macro with p2=0 (and p2=1).

Modified Files:


src/conio/bitmap_con.c
diff

src/conio/vidmodes.c
diff

src/syncterm/CHANGES
diff

Fix memory leak in initializing vmem.

Much easier to fix it this way than to figure out why X11 needs to
init it before bitmap_con does.

Modified Files:


src/conio/x_events.c
diff

src/syncterm/CHANGES
diff

Undo part of the previous commit.

All of this code runs in the same thread, races aren't possible.

Modified Files:


src/conio/x_events.c
diff

src/syncterm/CHANGES
diff

Fix a potential race between drawing and discarding last buffer.

If the last is freed while the screen is being updated, and the use
after free bug is not detected, corruption could occur resulting in
bad areas of the screen that persists until the window gets an
expose event again, or the impacted pixels are updated again.

Possibly fixes an issue reported by nelgin via IRC.

Modified Files:


src/conio/win32gdi.c
diff

src/syncterm/CHANGES
diff

Remove cast-to-int in gdi_getscaling

This fixes bug 141, which is currently the last blocker for rc2.

Modified Files:


src/syncterm/CHANGES
diff

Document more changes.

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

More graphical fixes...

Force mouse support in graphics mode even if user disabled
it for the BBS.  It would be nice if mouse support in the menus
was a separate option than "terminal doesn't support mouse",
and we know the terminal supports the mouse when we detect
graphics mode.

Move top/margin/width calculations into separate functions.
For level 1, center the playboard.

Fix an apparent off-by-one drawing the title bar.

Modified Files:


src/sbbs3/js_file.c
diff

File.read() encodes base64, it doesn't decode.

Added Files:


xtrn/minesweeper/graphics.ppm
diff

xtrn/minesweeper/selmask.pbm
diff

Modified Files:


xtrn/minesweeper/minesweeper.js
diff

Initial support for SyncTERM PPM/PBM graphics.

Hidden behind the graphics option for now since there's still
issues... the board is offset in the window, the level 1 board is
framed wrong (since the graphics are always 2 cols), and it doesn't
check the graphical resolution, so if you're in a weird mode, it
can break.

Also, the graphics are uninspired at best... just hacked them up
in Gimp.

Modified Files:


src/xpdev/xpbeep.c
diff

Since we can check at the menu now, we don't need this warning.

Modified Files:


src/syncterm/term.c
diff

Fix SAUCE date properly... avoid writing past the end of the buffer

Modified Files:


src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

Fixups for build changes.

Sneaky hiding extra interesting bits at the end like that. :(

Modified Files:


src/syncterm/bbslist.c
diff

Fix the macro used to detect X11.

NO_X is defined in the ciolib GNUmakefile.  DISABLE_X11 is defined
on Common.gmake.

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/Manual.txt
diff

src/syncterm/bbslist.c
diff

src/xpdev/Common.gmake
diff

src/xpdev/GNUmakefile
diff

src/xpdev/xpbeep.c
diff

Add a "Build Options" menu item.

Useful to check if SyncTERM was built with or without specific
features.

Modified Files:


xtrn/bublbogl/boggle.bin
diff

xtrn/bublbogl/lobby.bin
diff

xtrn/dicewarz/dicewarz.bin
diff

xtrn/dicewarz2/lobby.bin
diff

xtrn/maze/fog.bin
diff

xtrn/maze/lobby.bin
diff

xtrn/synchronetris/lobby.bin
diff

xtrn/uberblox/game.js
diff

xtrn/uberblox/gameend.bin
diff

xtrn/uberblox/lobby.bin
diff

update more ansi (links, names, some column widths, etc)
increase player name width in uberblox lobby

Modified Files:


src/conio/x_events.c
diff

Fix some more warnings when not using optional features.

Modified Files:


src/syncterm/CHANGES
diff

Add note about WM_SETCUSOR fix

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/win32gdi.c
diff

Fix issue 146

Fix return value when handling WM_SETCURSOR.  Returning FALSE
indicating we didn't handle it stopped the cursor from being set
to the size arrow cursors.  Instead, pass it to DefWindowProc().

While we're here, handle WM_SIZING to make it more clear that you
can't change the aspect ratio by dragging.

Added Files:


xtrn/dicewarz/exit.bin
diff

Modified Files:


xtrn/bublbogl/exit.bin
diff

xtrn/dicewarz2/exit.bin
diff

xtrn/maze/exit.bin
diff

xtrn/starstocks/exit.bin
diff

xtrn/synchronetris/exit.bin
diff

xtrn/uberblox/exit.bin
diff

updated exit splash screens with new repository url

Modified Files:


src/conio/x_events.c
diff

Fix warnings in last commit.

Modified Files:


src/conio/x_events.c
diff

Refine last commit...

Add a comment explaining why we do what we do, and verify the aspect
is unchanged as well since we could change only the aspect and need
to set new hints in some cases.

Modified Files:


src/conio/x_events.c
diff

If we're not mapping, only XSetWMNormalHints() if it's different.

Modified Files:


src/conio/x_events.c
diff

Never call XMapWindow() in response to a _NET_FRAME_EXTENTS change

This breaks at least herbstluftwm's focus-follows-mouse, and rustles
Cyan's jimmies.

It's also a terrible idea.

Modified Files:


src/syncterm/term.c
diff

Fix last commit.

Modified Files:


src/syncterm/syncterm.c
diff

Fix bool inversion introduced by 8f7cfadf44

quitting needs to be set to true, not false when quitting. :(

Modified Files:


src/syncterm/term.c
diff

Fix bug generating SAUCE date introduced by commit dcf8c35f9b

Using snprintf() prevents the last character of the date from
being put into the string.

Modified Files:


src/conio/x_events.c
diff

Actually don't call XSetICFocus() at start. :(

Modified Files:


src/syncterm/CHANGES
diff

Update CHANGES for rc2

Modified Files:


src/conio/x_cio.c
diff

src/conio/x_events.c
diff

src/conio/x_events.h
diff

Have the IC focus follow the X11 focus

Basically, If we get a FocusOut, call XUnsetICFocus(), and if we
get a FocusIn, call XSetICFocus().  Since we're doing this, don't
call XSetICFocus() unconditionally at start, wait for the server
to send us the initial FocusIn instead.

The only bit I'm not sure of is if I got the times to ignor
messages right... see here:
https://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html
If you want to check my work.

May fix the focus follows mouse issue reported by Cyan.

Modified Files:


src/syncterm/syncterm.c
diff

Add missing period in "Upgrade detected" help text.

Modified Files:


src/conio/win32gdi.c
diff

Fix reversed mouse wheel on Win32GDI...

From MSDN:
A positive value indicates that the wheel was rotated forward
away from the user; a negative value indicates that the wheel
was rotated backward, toward the user.

Fixes bug 143.

However, this re-opens the confusion around request 75...
nigel and DigitalMan should take a look at this more closely
in rc2 (or an updated nightly).

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/syncterm/Manual.txt
diff

Add "Persistant State" section to manual.

This describes in more detail how the window size is saved and
restored when starting/exiting SyncTERM.

Modified Files:


src/sbbs3/mailsrvr.c
diff

MIME-encode words that contain non-ASCII values in text header fields

(e.g. to, from, subject) ... when transmitting to other hosts (e.g. POP3
clients or other SMTP hosts).

For messages that contain CP437 or UTF-8 chars in these fields and were *not*
imported into the BBS via SMTP or POP3, these header fields would be
transmitted to other hosts with the raw CP437 or UTF-8 chars, thus violating
POP3 and SMTP protocols and likely resulting in garbage displayed in message
readers.

The fix is to encode (using MIME "encoded words", per RFC 2407) where
necessary.

Since moderm mail clients (e.g. Thunderbird) don't see to support CP437
charset in MIME encoded header fields, always translate to UTF-8 first.

We probably should be translating message body text to UTF-8 as well, for
maximum compatibilty with modern mail readers, but this commit doesn't address
body text issues with CP437-encoded content. That'll come later.

Modified Files:


src/syncterm/ripper.c
diff

Fix builds that don't support any graphics.

Modified Files:


src/encode/GNUmakefile
diff

src/hash/GNUmakefile
diff

src/sftp/GNUmakefile
diff

src/smblib/GNUmakefile
diff

src/uifc/GNUmakefile
diff

src/xpdev/GNUmakefile
diff

As it turns out, ciolib isn't special.

We can't update a fat static library using ar on macOS. :(

Modified Files:


src/syncterm/ripper.c
diff

Fix a couple use-after-free bugs in RIP

This likely is the cause of bug 140.

The first one, the LCF flag is copied out of the cterm struct
after cterm_end() is called (which frees the struct).  Copy moved
to before cterm_end().

The second one is trickier... it's executing the commands in a mouse
button, and one of the commands is to delete all the mouse button
commands.  This ends up free()ing the string that's currently being
parsed while it's being parsed.  We now use a strdup() of the string
which we free at the end of the function.

Modified Files:


src/syncterm/ripper.c
diff

src/syncterm/ripper.h
diff

src/syncterm/term.c
diff

src/syncterm/window.c
diff

Fix status bar issue when RIP changes the number of lines.

RIP is currently the only thing that can change the number of lines
in the terminal while connected.  This can actually result in there
being more lines on the screen than the last set video mode supports.

There's a "feature" in SyncTERM text modes (curses, ANSI, and Win32
Console) where if the screen mode is "current", it uses the number
of lines in the terminal, but if it's anything else, it forces the
number of lines to the lines in the mode.

This works great until RIP increases the number of lines beyond the
number in the mode... when this happened, RIP would draw the status
bar at the incorrect location on the screen.

This change no longer sets the max rows in the terminal if the
backend can set individual pixels (required for RIP).  Further, to
avoid a delay before redrawing the status bar after RIP changes the
number of rows, the reinit_screen() function now sets a global to
indicate it was called, and the status bar will always redraw when
it's enabled and the flag is true.

This *may* be related to bug 140, but may not be.

Modified Files:


src/conio/OverhaulNotes.txt
diff

src/conio/win32gdi.c
diff

Fix issue 138

Weird stuff happened when dragging a GDI window between monitors
with different zoom (DPI) settings.  The following changes were
all done to clean up this stuff:

Window position is signed
Do some type casting for warnings
Fix return times of GetDpiFor*() pointers
Fix fallback to GetDpiForSystem() (could never be used)
Handle WM_DPICHANGED correctly
Move some copy/pasted code into a function
Fix return value for WM_GETDPISCALEDSIZE
Fix return value for WM_USER_SETCURSOR

Modified Files:


src/syncterm/CHANGES
diff

src/syncterm/syncterm.c
diff

Enable new reverse_cursor UIFC option for SyncTERM

Thanks DigitalMan!

Modified Files:


src/uifc/uifc.h
diff

src/uifc/uifc32.c
diff

Add uifcapi_t.reverse_cursor (BOOL), default is FALSE

Setting this to TRUE reverses the type of cursor used to indicate insert
versus overwrite mode (solid/block cursor veruss underline/normal cursor).
Deuce probably wants to set this to TRUE for SyncTERM.

Modified Files:


src/syncterm/CHANGES
diff

Mention insert mode change

Modified Files:


src/conio/cterm.txt
diff

cterm.txt is no longer the normative reference for cterm.

Add a link to the new generated HTML document, and mention the .adoc
file so people can find it in the future.

Modified Files:


src/syncterm/syncterm.c
diff

Start UIFC in insert mode.

Per comment on reddit by dialsoft, the lack of an insert key on
laptops can make manipulating the phonebook more difficult.  Since
all the other UIFC functions have an insert alternate, they don't
need any changes now that there's a manual, but for editing a
string, the insert key is the only way to toggle overstrike.

Since the insert mode toggle persists, simply starting in overstrike
mode should be fine.

Maybe some weird control key of function key can be used (though
I guess laptops don't have function keys either anymore).

Modified Files:


src/syncterm/Manual.txt
diff

Manual updates.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And this isn't.

Modified Files:


src/syncterm/CMakeLists.txt
diff

src/syncterm/Info.plist
diff

src/syncterm/Manual.txt
diff

src/syncterm/dpkg-control.in
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.rc
diff

And this is RC1

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/updvers.sh
diff

Put the full version number into Manual.txt

I'll want to generate a version-specific one on release, and want
to ensure it's consistent.

Modified Files:


src/conio/cterm.c
diff

Bump revision.

I need to document when I should do this better.

Modified Files:


src/syncterm/updvers.sh
diff

Add reminder to bump cterm revision on version update.

I guess that could be mostly good enoughish.

Modified Files:


src/conio/cterm.adoc
diff

Add reference to STD-070.

Modified Files:


src/sbbs3/atcodes.cpp
diff

include petdefs.h (needed for PETSCII_UPPERGRFX definiton)

Added Files:


src/conio/ciolib.adoc
diff

Modified Files:


src/syncterm/Manual.txt
diff

Add a user document for ciolib, and add it to SyncTERM manual.

Added Files:


src/conio/cterm.adoc
diff

Modified Files:


src/syncterm/Manual.txt
diff

Include CTerm doc in SyncTERM doc

Modified Files:


src/conio/cterm.c
diff

src/syncterm/CHANGES
diff

src/syncterm/Manual.txt
diff

More doc updates.

Modified Files:


src/sbbs3/atcodes.cpp
diff

Add PETGRFX @-code to send char 142 (enter PETSCII upper/graphics char set)

... when PETSCII terminal in use.

For those sysops using editors that don't automatically or easily add this
character to their SEQ art files when needed.

Modified Files:


src/conio/Common.gmake
diff

src/xpdev/Common.gmake
diff

Add SDL_FRAMEWORK_PATH to rpath.

Apparently, /Library/Frameworks isn't searched by default anymore?

Added Files:


3rdp/build/js-include-headers.patch
diff

Modified Files:


.gitlab-ci.yml
diff

3rdp/build/GNUmakefile
diff

Fix config test for va_copy() on darwin.

Because the appropriate header wasn't included, there was no
prototype.  Not having a prototype is an error in C99, which caused
the test to indicate that there was no va_copy() on darwin.

This in turn caused jsprf.cpp to try to copy a va_list using
assignment.

This is invalid, so the compiler would normally return an error.

Somwhere in here, that error became a clang crash (not trivially
reproducable).

At the end of the day, ancient broken tests in config caused the
darwin Spidermonkey builds to fail.  The new patch fixes up the
configure tests, and darwin Synchronet builds are re-enabled.

Modified Files:


src/conio/cterm.txt
diff

Oh, cterm.txt was wrong w.r.t. APC vs. APS too

Modified Files:


xtrn/termtest/termtest.js
diff

Fix APC/SOS naming.

Thanks Ree!

Modified Files:


src/syncterm/Manual.txt
diff

More manual fiddling.

Modified Files:


src/syncterm/Manual.txt
diff

Remove incorrect escaping.

Modified Files:


.gitlab-ci.yml
diff

clang 16.0.0 crashes when building JS... unhook from builds.

Modified Files:


src/syncterm/Manual.txt
diff

Convert to asciidoc

Modified Files:


src/syncterm/syncterm.man.in
diff

Update manpage

Added Files:


3rdp/build/js-int-main-conf.patch
diff

Modified Files:


3rdp/build/GNUmakefile
diff

Fix up configure for platforms that don't use configure.in

Give simple test code a return type (default int isn't valid in C99)
and make some fallback tools executable.

Modified Files:


src/conio/x_events.c
diff

Fix build when XRandR is available, but Xinerama isn't.

Modified Files:


src/sbbs3/GNUmakefile
diff

Remove elfctl calls... they don't help.

Modified Files:


src/conio/sdl_con.c
diff

Fix build.

Whoops.

Modified Files:


src/conio/sdl_con.c
diff

Update fullscreen and mode on Darwin to match window

This should normalize everything, with the possible exception of
"zoom" (the thing other OSs call maximized).  Ideally, we wouldn't
allow window size changes when "zoomed" if we could detect the state,
but it doesn't look like we can.

Modified Files:


src/conio/GNUmakefile
diff

Apparently ar can't update this when it's fat.

Hopefully this is the only lib like this (maybe the resources?)

Modified Files:


src/conio/sdl_con.c
diff

src/conio/sdlfuncs.c
diff

src/conio/sdlfuncs.h
diff

Use SDL_GetWindowSizeInPixels, and don't resize when maximized

Fixes sourceforge issue 126 (finally!)

Apparently, macOS "maximized" is the same as "fullscreen" in SDL.

Modified Files:


src/syncterm/ssh.c
diff

Destroy ssh_tx_mutex

Modified Files:


src/syncterm/ssh.c
diff

No no, *DESTROY* sftp_tx_mutex

Modified Files:


src/sbbs3/logon.cpp
diff

Always close csts.ini file, even in error path (failure to open dsts.ini)

Fix for CID 509720

Modified Files:


src/sbbs3/scfg/scfgmsg.c
diff

Free ini string list in error path (no sectinos exist)

Fix CID 509721

Modified Files:


src/sbbs3/sbbsecho.c
diff

Fix potential null pointer dereference

strListReadFile() can return NULL upon error

Modified Files:


src/syncterm/ssh.c
diff

Be sure to close ssh_sock regardless of ssh_active

Modified Files:


src/syncterm/ssh.c
diff

Some more ssh_close() cleanup

Make ssh_active only true when ssh_session was set.
Only do ssh cleanup if ssh_active is true.
Initialize channel values to -1 (already done in ssh_connect(), but
doesn't hurt anything).

Modified Files:


src/syncterm/ssh.c
diff

Fix sourceforge issue 136

With ssh_sock initialized to zero, if the connect fails, stdin was
closed, preventing ANSI and curses modes from functioning.

Modified Files:


src/syncterm/bbslist.c
diff

src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Fix up handling of -b option

First, we need to parse it before load_settings() so we can deal
with it there.

Next, we need to keep the one from the config file available so it
is edited from the program settings, and not the command line version

Modified Files:


src/syncterm/syncterm.c
diff

src/xpdev/netwrap.c
diff

Fix some warnings, return false for zero-length strings.

Modified Files:


xtrn/termtest/termtest.js
diff

Send a backspace space backspace after shift in

Keeps the display cleaner when things work and the shift in byte
is displayed.  Should be harmless in cases where shift in is
interpreted per the standards.

Added Files:


src/syncterm/updvers.sh
diff

Add script to update version numbers in various files

Hopefully I'll be able to keep them all wrangled now.

Modified Files:


src/syncterm/syncterm.c
diff

src/syncterm/syncterm.h
diff

Make syncterm_version const

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/term.c
diff

More docs.

It's likely time to find a nice format that can be used to generate
HTML and PDFs and such now.

Modified Files:


src/sbbs3/GNUmakefile
diff

Fix copy/paste error.

Modified Files:


src/sbbs3/GNUmakefile
diff

elfctl doesn't work on shared objects.

Modified Files:


src/sbbs3/GNUmakefile
diff

Looks like we do need both.

Modified Files:


src/sbbs3/GNUmakefile
diff

Call elfctl -e +noprotmax in binaries that do JS

Prevents crashes on modern FreeBSD systems that default to implicit
PROT_MAX in the JS code.
(It's possible that +wxneeded will be needed too.. still experimenting)

Modified Files:


src/xpdev/netwrap.c
diff

Fix Borland build.

Modified Files:


src/syncterm/Manual.txt
diff

src/syncterm/bbslist.c
diff

src/syncterm/conn.h
diff

src/xpdev/netwrap.c
diff

src/xpdev/netwrap.h
diff

Clean up and improve 6e516ae

The first entry I tried adding was "Example..." which was not a
valid hostname, but was copied into the address and looked silly.

Now only copies into address if it's a valid, usable hostname.

Also, add a convenience macro to check if a connection type uses
the network or not.

New functions in netwrap:
bool isValidHostname(const char *str);
bool isValidAddressString(const char *str);
bool isResolvableHostname(const char *str);

We ust the last one (which calls the other two) for this feature now.

Modified Files:


src/xpdev/str_list.c
diff

strListReadFile() now returns NULL on any file read failure

Previously, the partially-read lines would be returned in an allocated
string list. This is a suspected cause of issue #791: even though the file was
successfully opened exclusively (using sopen... SH_DENYRW), it's possible that
Samba had already allowed another client or local process to open the same
file, but is now a denying read (most likely, the first read). As Deuce
pointed out, the xpdev *nix implementation of sopen() locks the region/record
of the entire file. So before this change, strListReadFile() might fail on
the first read, and a function that uses iniFileRead() to modify the contents
of an ini file, might end up writing back the empty list (with added keys),
thus deleting all the existing content of the file.

Also in this change:
- Eliminated the unnecessary local/wrapped str_list_read_file() function.
- Elminate unecessary null-before-free check
- Fixed potential memory leak upon malloc failure (the potentially-allocated
  list wasn't freed).

Modified Files:


src/sbbs3/getstats.c
diff

fread_dstats() will now return false upon file read failure

The file position should always be at the EOF after reading the contents.

This should help detect (log errors) upon potential cause of issue #791.

- use a little easier to read .ini style
- add a NULL argument check to local function write_dstats()
  return false rather than deref the NULL pointer

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

Log an error upon read failure of dsts.ini and don't write changes back

Part of potential fix (or work-around) for issue #791

Modified Files:


src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

Log errors upon any dsts.ini write failures.

Modified Files:


src/sbbs3/userdat.c
diff

user_downloaded_file() now return false upon statistics update failure

Modified Files:


src/sbbs3/getstats.c
diff

Don't update/rewrite dsts.ini when iniReadFile returns NULL

Even if the empty, iniReadFile() should return an empty list (not NULL),
NULL indicates a file read (or unlikely malloc failure) - so don't write back
what we read and return false (result) instead.

Part of likely work-around of issue #791: it's better to not increment stats
upon a file read error than to reset them all to zero.

Modified Files:


src/sbbs3/js_file.c
diff

Add missing NULL pointer check to js_iniReadAll()

iniReadFile() can return NULL upon file read error or malloc error. Let's not
crash if that happens.

Modified Files:


src/sbbs3/writemsg.cpp
diff

Log a file "create" error if process_edited_file() returns a negative value

I discovered that sbbs_t::editfile() (exposed as JS console.editfile) just
silently failed if it couldn't write to the destination file
(e.g. permission denied by OS).

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Don't update displayed stats values if getstats() returns false (failure)

Use byte_estimate_to_str() to display upload/download byte totals (better
support for totals in gibibytes, tebibytes, etc.).

Modified Files:


3rdp/build/GNUmakefile
diff

src/build/Common.gmake
diff

Add support for fat Darwin builds...

Using FAT=1 one the make command-line

Modified Files:


exec/text_sec.js
diff

Add edit option when adding text files that don't already exist

Revisiting this script due to usability issues reported by W5jsn (TUCUMCAR).

Dynamically figure out the file path rather than storing another property
('path') in the list objects (which ends up in the .ini file). The absence of
the path property (when the file didn't exist) could result in script-ending
exceptions.

.ini files are supposed to be open for read/write access (even when just
writing), so open the file in "w+t" mode in write_list().

Clear console.aborted flag before menu listings: hitting Ctrl-C in some
point could display just header and prompt of lists with no contents.

Modified Files:


src/sbbs3/logon.cpp
diff

Clear the Guest user's language (lang) field during logon - revert to default

Modified Files:


src/sbbs3/getstats.c
diff

src/sbbs3/getstats.h
diff

src/sbbs3/logon.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/userdat.c
diff

Store debug information in dsts.ini to help solve cause of issue #791

This should help identify the function(s) used when the corruption occurs.

Modified Files:


src/sbbs3/getstats.c
diff

In debug builds only, backup dsts.ini file when opening for write

Hopefully help to determine cause of issue #791 (when is the apparent
corruption of this file occurring?)

Modified Files:


src/sbbs3/getstats.c
diff

Non-functional changes

iniWriteFile() returns bool, not int.

Removed inapplicable function comment.

Modified Files:


src/sbbs3/uedit/uedit.c
diff

Cosmetic improvements to indication of user status (deleted/inactive)

This should address issue #787

Modified Files:


src/sbbs3/getstats.c
diff

Fix return value of fclose_dstats - not currently checked anywhere

fclose() returns 0 on success.

Modified Files:


src/sbbs3/getstats.c
diff

Fix comment header for putstats() - copy/pasted from getstats()

Modified Files:


src/sbbs3/js_msg_area.c
diff

Use JS_ValueToECMAUint32() instead of JS_ValueToInt32() for scan_ptr prop set

scan_cfg and last_read props too. This gives us use of the entire 32-bit range
of an unsigned int. But does someone actually have a message base with message
numbers in the billions?

This is an attempt to fix isssue #792, but I suspect scan_ptr might instead be
trying to be set to NaN or ... ?

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

DDFileLister: Fix for replacing cursor-right codes to allow finding & replacing
all of them in a string

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'dd_file_lister_replace_cursor_right_improvement' into 'master'

DDFileLister: Fix for replacing cursor-right codes to allow finding & replacing
all of them in a string

See merge request main/sbbs!461

Modified Files:


src/sbbs3/smbutil.c
diff

NUL-terminate the SMB fileidxrec_t.name field, just in case

The terminating NUL is actually part of the index record, but with file
corruption, it's technically possible the NUL could be missing.

Fixes CID 509554

Modified Files:


src/smblib/smbfile.c
diff

NUL-terminate the SMB fileidxrec_t.name field, just in case

The terminating NUL is actually part of the index record, but with file
corruption, it's technically possible the NUL could be missing.
Fixes CID 509552

Use strnicmp() insted of stricmp() in smb_removefile()
Fixes CID 509551

Modified Files:


src/sbbs3/text_defaults.c
diff

Update default CantPostMsg to match text.dat

Modified Files:


exec/load/shell_lib.js
diff

Check for console abort (Ctrl-C) in directory searching for loops

Multiple directory searching functions wouldn't terminate on Ctrl-C

Modified Files:


src/sbbs3/js_filebase.c
diff

Update JSDOC description of update() method

Clarify that this is the method to use to rename a file.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/filedat.h
diff

src/sbbs3/listfile.cpp
diff

Only use liberal file pattern matching in the terminal server listfile funcs

Commit 3a3c889b (2 years ago now) changed loadfiles() to use liberal file
matching (e.g. "syncterm.exe" matched both "syncterm.exe" and
"syncterm_v1.2b.exe").

This could produce surprising results when doing file list querieis/operations
with the FileBase methods via JS (e.g. jsexec utils) and (now that I look at
it), the FTP server too.

So we should not have been doing liberal file matching *everywhere* loadfiles
is used, just where it was a usability issue (due to displayed filenames being
truncated to 12 chars for <=80 column terminals).

Now solved by add/use of new liberal_filepattern() function only in the
built-in file listing methods: sbbs_t::listfiles() and sbbs_t::listfileinfo().

Note: Custom JS file searching/listing scripts may now need their own
work-arounds for this usability issue, if they have it.

Modified Files:


src/sbbs3/listfile.cpp
diff

Use the liberal file matching to continue file listing/searches

If the user didn't supply a wildcard, only a single file (the first file
matching the liberal file pattern) would ever be listed in the file
listing/searches, even when multiple files in the directory matched the
liberal file matching pattern. This is not a new bug.

Modified Files:


exec/updatefiles.js
diff

Remove the always-on force option, replaced with new readdfiles.js

Added Files:


exec/readdfiles.js
diff

New script that just re-adds (updates index position/date-time) files

If you want to "touch" a file in the filebase (so it appears a new again)
this is the script to use to do that.

Modified Files:


exec/nntpservice.js
diff

Re-open closed message base for commands to use selected/open base

Should fix issue #790

Modified Files:


exec/webfileindex.ssjs
diff

Display the file index date-time instead of the file's date-time

Since sorting works on the file index record date-time (date/time added)
it was confusing to display dates that didn't always match the sort order.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: When displaying a file description, remove/replace cursor
movement characters, which can corrupt the display

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch
'dd_file_lister_description_remove_or_replace_cursor_movement_attrs' into
'master'

DDFileLister: When displaying a file description, remove/replace cursor
movement characters, which can corrupt the display

See merge request main/sbbs!460

Modified Files:


src/sbbs3/userdat.c
diff

Delete data/file/*.out directory for new user (if exists)

emailfiles.js puts files here that the user requested to download "via email"
and might not have been successfully delivered and deleted. So clean-up.

Modified Files:


exec/postmsg.js
diff

Add -F option to set file request attribute flag

to force SBBSecho to create a .req file (in FLO-mode), rather than send as
netmail.

For Keyop

Modified Files:


src/sbbs3/js_filebase.c
diff

src/sbbs3/js_msgbase.c
diff

Don't heap allocate argument to MsgBase and FileBase constructors

Nelgin reported a weird error with a failed very large allocation for the
base/code argument to the FileBase constructor. There's no good reason
these strings were heap-allocated in the first place, so just change to
use a stack allocated variable instead. I don't know why this would fix
anything, but at least there's one less heap allocation and potential
for memory leak here.

Fix 2 bugs in js_update_file():
1. missing parenthesis (really?!? Caught by Coverity - sigh) in last
commmit caused attempt/failure/error to remove file after making any
updates. The removing is only supposed to happen when its necessary to
remove and re-add the file to the filebase (e.g. updating extended
description or auxdata).
2. Wrong filename used in 'removing' exception string.

Modified Files:


exec/fileman.js
diff

When renaming a file (using F2 key), need to get all metadata before update

... otherwise, we'll erase the file's extended description or auxdata, if it
has any.

Modified Files:


src/sbbs3/filedat.c
diff

src/sbbs3/js_filebase.c
diff

src/smblib/smbfile.c
diff

src/smblib/smblib.h
diff

Add/use smb_removefile_by_name()

This fixes a filebase corruption issue that could be triggered by using
FileBase.update() to rename a file while also changing the file's auxdata or
extended description: you can't remove a file header that has the new filename
(in the file_t.name field), cause it doesn't exist yet. So we needed an SMBLIB
API function to pass the (original) filename instead. Much like the filedat.c
removefile() function, but without the SMB opening/closing feature.

Modified Files:


src/sbbs3/js_filebase.c
diff

Don't allow FileBase.update() to create a duplicate file

FileBase.update() will now throw an exception if attempting to rename a file
to a filename that already exists in the filebase index.

Prior to this change, one could (via JS methods) rename a file in the base to
create a duplicate filename which would corrupt the base (one index entry and
two header records for the same filename).

Modified Files:


src/smblib/smblib.c
diff

MSVC requires a 0 in the struct initializer

Modified Files:


src/sbbs3/js_file.c
diff

Eliminte weird gcc (12.2) warning in release build (only)

Increasing size of mode[] element by 2 bytes eliminated these GCC warnings
that seem like false-positives to me:

sbbs.h:194:48: warning: writing 1 byte into a region of size 0
[-Wstringop-overflow=]
  194 |
(ret)[JSSTSpos]=(char)JSSTSstrval[JSSTSpos]; \
      |
~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
js_file.c:225:25: note: in expansion of macro ‘JSSTRING_TO_STRBUF’
  225 |                         JSSTRING_TO_STRBUF(cx, str, p->mode,
sizeof(p->mode), NULL);
      |                         ^~~~~~~~~~~~~~~~~~
js_file.c:42:17: note: at offset 5 into destination object ‘mode’ of size 5
   42 |         char    mode[5];
      |                 ^~~~

Similar use of JSSTRING_TO_STRBUF in other files (js_console.cpp, js_archive.c)
(with larger target buffers) does not trigger the same warnings.

Modified Files:


src/smblib/smbdefs.h
diff

fileidexrec_t doesn't need to contain union

This served exactly no purpose (since the idxrec_t existed at the same
offset in both parts of the union). So this was just some weird artifact
from the new filebase development.

Modified Files:


src/smblib/smblib.c
diff

smb_getmsgidx() now reads entire index records from file bases too

chksmb needed this to perform filename checks (index against headers).

Modified Files:


src/sbbs3/chksmb.c
diff

Perform filename checks (index versus header fields) on filebases

I was able to corrupt a filebase using fileman.js, renaming a file
(the filename in the index as viewed with 'smbutil x' did not match
the filename listed with 'smbutil l') - yet, chksmb reported no errors
with the filebase.

Now chksmb will detect that type of corruption.

Modified Files:


src/sbbs3/js_filebase.c
diff

FileBase.update() method throws more exceptions upon error

This will help to determine cause of any file update (e.g. rename)
failures, as reported by Nelgin.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DD file lister: Check for null when getting extended metadata from the DB
(possibly caused by corruption). Also, allow changing the filename when editing
file info/metadata.

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_get_extd_info_null_check_and_allow_edit_filename'
into 'master'

DD file lister: Check for null when getting extended metadata from the DB
(possibly caused by corruption). Also, allow changing the filename when editing
file info/metadata.

See merge request main/sbbs!459

Modified Files:


src/sbbs3/ctrl/ClientFormUnit.cpp
diff

src/sbbs3/ctrl/ClientFormUnit.dfm
diff

src/sbbs3/ctrl/ClientFormUnit.h
diff

Add keyboard shortcuts to Clients list view: Ctrl-A, Ctrl-F and Del

Ctrl-A - Select All
Ctrl-F - Filter IP address
DEL - Close Socket

Also, use Begin/EndUpdate() calls to batch updates to the ListView in Timer
tick (no visible difference, but it's the right thing to do).

I don't know why C++Builder increased the TextHeight value of this form from
13 to 15, but doesn't seem to really matter (or at least, I couldn't tell).

Modified Files:


src/sbbs3/ctrl/MainFormUnit.cpp
diff

Display horizontal splitter in the correct spot.

For who knows how long now, the horizontal splitter that allows the sysop
to control the size of the top 2 panels (server forms), was displayed above
the top panel, not between the top and bottom panel, thus making the panel
heights not controllable. Weird. Change the order of making the controls
visible to insure that the splitter is displayed below the top panel and
on top of the bottom panel.

Also (non-functional changes):
Remove redunant mutex from client_on() - makes no difference.
Use try/catch in client_on() to try to catch VCL exceptions - doesn't catch
the "invalid index" error popups that we see on occasion. <shrug>

Modified Files:


src/sbbs3/ctrl/MainFormUnit.dfm
diff

Change the height of the horizontal splitter to the minimum (1 pixel)

I don't know why this was set so wide (10 pixels), but that did help to easily
see that it was being placed in the wrong spot in the form (between the tool
button bar and the top panel). But we don't need it to be that thick. 1 pixel
is still enough to be able to grab it with the mouse and resize the top/bottom
panels.

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Fix crash due to use after free or double-free

... bug introduced in commit 29a35642160a7f4.

strListMerge() doesn't realloc the strings in the list, so we don't want to
free the strings in this list here.

This is likely the cause of the crash Keyop eluded to in #synchronet.

Modified Files:


exec/nntpservice.js
diff

Close any open message base after input timeout (5 minutes)

As Nelgin pointed out, the nntpservice can leave a message bases open while
a client is idle. Normally, an inactive client would be disconnected after 5
minutes of inactivity, so that wouldn't be much of an issue. However, if
authenticated as a user with the H-exemption, no auto-disconnection after
input timeout would happen. So let's close any open message base for good
measure.

The input/receive timeout probably should be configurable and lowered to
a smaller duration (one minute?). I'll leave that for another commit.

Modified Files:


exec/nntpservice.js
diff

Close an open message base after just 10 seconds of client inactivity

... and log a debug-level log message when doing so.

The current input/receive timeout duration (5 minutes) might be a bit long to
leave a message base open (though, there's no known issue with doing so). For
example, when users read message bases using the terminal server, they can sit
for much longer than 5 minutes reading an open message base.

Modified Files:


src/sbbs3/data_ovl.cpp
diff

src/sbbs3/userdat.c
diff

src/sbbs3/userdat.h
diff

Split-up the opening and writing of msg pointer files, to help debug issue

Reported by Keyop (upon being auto-disconnected overnight):
!ERROR 9 (Bad file descriptor) in data_ovl.cpp line 47 (putmsgptrs) writing
"message pointers" access=0

Unfortunately, the way putmsgptrs() was written, we couldn't tell if this was
an open (data/user/*.subs file) issue or a writing issue.

So create putmsgptrs_fp() and use that from sbbs_t::putmsgptrs(), so we can
log a different error (with more accurate details) if it's a file-open failure
versues a file-write failure.

Modified Files:


exec/websocketservice.js
diff

Fix #782 - websocketservice.js garbles input on Banana Pi running Armbian

Modified Files:


exec/websocketservice.js
diff

Merge branch 'ree/websocketservice-debug' into 'master'

Fix #782 - websocketservice.js garbles input on Banana Pi running Armbian

Closes #782

See merge request main/sbbs!458

Modified Files:


src/sbbs3/un_qwk.cpp
diff

src/sbbs3/un_rep.cpp
diff

Blocked IP addresses in ip-silent.can weren't filtered from QWK and REP pkts

The "from_ip" header field of QWK messages is checked against blocked IP
addresses, but was only checking against IP addresses from ip.can, not any
addresses listed in ip-silent.can. These 2 list files are now merged together
for the purposes of filtering during QWK/REP packet import.

Modified Files:


src/sbbs3/sbbsecho.c
diff

Refactor the function: unpack_bundle()

1. When a 0-length bundle file was encountered or an unpacking error occurred,
   any remaining bundles for the current search day-of-week (e.g. *.SU*) would
   be skipped/ignored. This bug (issue #764, regarding the 0-length file part),
   is fixed by not incrementing the day-of-week index in the main loop, but
   rather only incremeting the index when all bundles for the current
   day-of-week have been processed.
2. The age calculation for 0-byte/length bundle files was incorrect, so all
   0-length  bundle files would always be considered "less than 24-hours old"
   (and thus, never auto-deleted).
   This exacerbated the problem of issue #764 since it would persist until the
   0-length files were manually deleted. Fixed the file age calculation and
   now logging the date/timestamp of the 0-length file as well.
3. Don't do the switch/case/sprintf dance when we're not re-running a glob()
   search.
4. Replace the switch/case statement with an array of week day names/patterns.
5. Ignore (with a warning log message) any sub-directories of the inbound
   directory that happen to match the bundle file search pattern.
6. Use better variable naming.
7. Refer to files with a length of 0 as "0-length" instead of "0-byte" in log
   messages.

Modified Files:


src/sbbs3/chksmb.c
diff

Don't check header fields of deleted messages for control characters

... related to issue #786.

Also, don't check for a message-ID if the message-type does not match the
expected message type ("type mismatch").

Modified Files:


src/sbbs3/smbutil.c
diff

Indicate vote/poll messages and files (with details) when listing msgs/files

Add '-v' (increase verbosity) option, used to display msg dates and timezones
... when using the the 'l' (list messages) command (to view post date/time).
Use '-vv' or '-v -v' to see timezones of messages.

The -v option is now also applicable to the 'v' (view) messages command (now
redundant with the 'V' command).

Features as requested by Nelgin as part of issue #786.

Removed day-of-week from date/times displayed. We don't need that level of
user-friendliness with this tool.
However, we are also displaying 12h/am/pm times. Some sysops probably would
prefer 24hour time, so that should be considered at some point.

Modified Files:


docs/v320_new.txt
diff

More v3.20 changes documented

Modified Files:


src/sbbs3/con_out.cpp
diff

src/sbbs3/main.cpp
diff

src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

src/sbbs3/putnode.cpp
diff

Don't attempt to publish MQTT messages unless/until connected to broker

For cases where an mqtt struct is shared between threads without concurrency
control. I'm making this improvement in light of research into issue #781,
though I don't expect this change to fix the reported issue.

The reported error seems to come from the event thread (publishing node
status upon starting to run the "DAILY" event) when a broker connection was
not successful, however the reporter (Nelgin) may not have had debug-level
logging turned on, so didn't capture the successful broker-connect log
message. I think the broker connection *was* successful and perhaps then
terminated by the broker ("due to protocol error"?).

Modified Files:


src/sbbs3/mqtt.c
diff

src/sbbs3/mqtt.h
diff

Track broker-connected status via Mosquitto connect/disconnect callbacks

I think this might fix issue #781. I suspect that SBBS (the MQTT client) is
being disconnected by the server ("due to protocol error") *after* the
call to mosquitto_connect_bind() is successful. We don't have any correponding
log output for this case, but at least we can track the connection status
accurately using the Mosquitto client callbacks and not try to publish when
we're not connected.

Modified Files:


exec/tickit.js
diff

Strip trailing whitespace off end of values read from .tic files

Fix issue #785

Modified Files:


src/sbbs3/logfile.cpp
diff

src/sbbs3/sbbs.h
diff

Add llprintf() to log a formatted line to the node.log and term server log

There's a whole lotta calls to sprintf() then logline() that could be reduced
with this function.

Modified Files:


ctrl/text.dat
diff

src/sbbs3/email.cpp
diff

src/sbbs3/postmsg.cpp
diff

Log more/better messages when message fails to post (e.g. duplicate detected)

It appears I had the idea to make the CantPost text.dat string a format string
before, but never quite finished that change (e.g. made the change to
email.cpp and text.dat too).

Modified Files:


src/sbbs3/qwktomsg.cpp
diff

Don't use QWK reply message date unless time zone is also specified

For regular user QWK Relpy packet uploads only, if no timezone is specified
(e.g. via @TZ kludge or HEADERS.DAT), then over-ride the message's "posted"
date/time with the current date/time since we're going to set the message's
timezone to the BBS's local timezone as well.

This is a fix for issue #783 reported by Chris Jacobs.

If/when we support user-specified timezones, then this likely would be a
place where we'd want to use the user's timezone.

Modified Files:


src/sbbs3/js_system.c
diff

Create system.tz_offset property; minutes east (+) or west (-) of UTC

From todo list on Vertrauen, not in GitLab (shrug)

Modified Files:


exec/load/dd_lightbar_menu.js
diff

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the
scrollbar in DDLightbarMenu_UpdateScrollbar()

Modified Files:


exec/load/dd_lightbar_menu.js
diff

Merge branch 'dd_lightbar_menu_UpdateScrollbar_RowOutOfRange_Fix' into 'master'

dd_lightbar_menu.js: Fix for out-of-bounds row updates when updating the
scrollbar in DDLightbarMenu_UpdateScrollbar()

See merge request main/sbbs!457

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared
variable error). Found by Amessyroom

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_save_ansi_message_fix' into 'master'

DDMsgReader: Fix for saving an ANSI message to the local BBS PC (undeclared
variable error). Found by Amessyroom

See merge request main/sbbs!456

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

ddfilelister: "Edit" item text on the bottom horizontal menu for
traditional/non-lightbar interface

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

Merge branch 'ddfilelister_bottom_menu_edit_item_text_len' into 'master'

ddfilelister: "Edit" item text on the bottom horizontal menu for
traditional/non-lightbar interface

See merge request main/sbbs!454

Modified Files:


src/sbbs3/prntfile.cpp
diff

Fix NULL pointer deref in random_menu()

When no files with extensions are found, though they matched the glob()
pattern, a NULL pointer deref would result (segfault).

This could happen if the only files matching the pattern had no extenions or
were directories (not files).

Fix for issue #779

Modified Files:


src/sbbs3/getnode.cpp
diff

Don't call utime() on the node.dab file for every read

... this was the cause of some observed unnecessarily high disk/file server
(Samba) utilization, as we call getnodedat() a lot. utime() opens and closes
the file, which was already open - and we're not modifying the file, so
updating the 'modification time' here is wrong anyway.

Disabling this 21-year old bit of logic resulted in a pretty dramatic
reduction in Samba (smbd) CPU utilization on Vertrauen.

If a BBS actually needes this hack (e.g. for NFS compatibility, as Deuce
eluded in the comment), they'd be better off just setting the "Keep Node File
Open" node setting (in SCFG->Nodes) to "No".

Modified Files:


src/sbbs3/userdat.c
diff

Extend (and back-off) the user.tab record lock attempts

I'v been getting errors locking user.tab (for read) for a while (over samba),
so hopefully this helps. The lockuserdat() total timeout duration extends from
about 5 seconds to about 45 seconds (with an incremental back-off).

Implement the same lock-retry logic/limit in putuserdat().

Modified Files:


exec/telgate.js
diff

Add -N option to send blank line after connect

... requested by someone in #synchronet

Modified Files:


exec/init-fidonet.ini
diff

Fix the HobbyNet entry: Zone 954 is not a FidoNet (proper) address

Apparently, Mike Dippel's actual FidoNet address is 3:712/1321.5

Modified Files:


exec/load/diskusage.js
diff

exec/load/filelist_lib.js
diff

exec/load/gettext.js
diff

exec/load/install-3rdp-xtrn.js
diff

exec/load/nodedefs.js
diff

exec/load/presence_lib.js
diff

exec/load/shell_lib.js
diff

exec/load/termdesc.js
diff

exec/load/uifcdefs.js
diff

Remove executable attribute

Modified Files:


exec/addfiles.js
diff

exec/archive.js
diff

exec/badpasswords.js
diff

exec/default.js
diff

exec/delfiles.js
diff

exec/dupefind.js
diff

exec/emailfiles.js
diff

exec/examples/uifc.js
diff

exec/fido-nodelist-syncterm.js
diff

exec/filelist.js
diff

exec/fileman.js
diff

exec/filescancfg.js
diff

exec/hashfile.js
diff

exec/importcfg.js
diff

exec/inventory_archives.js
diff

exec/logon.js
diff

exec/mqtt_spy.js
diff

exec/noyesbar.js
diff

exec/postfile.js
diff

exec/rehashfiles.js
diff

exec/replace_text.js
diff

exec/simple.src
diff

exec/sysavail.js
diff

exec/tempxfer.js
diff

exec/testbuild.js
diff

exec/updatefiles.js
diff

exec/upgrade_to_v320.js
diff

exec/viewimsgs.js
diff

exec/webfileindex.ssjs
diff

exec/yesnobar.js
diff

Remove executable attribute

Modified Files:


src/sbbs3/sexyz.c
diff

src/sbbs3/xmodem.c
diff

src/sbbs3/zmodem.c
diff

src/sbbs3/zmodem.h
diff

Remove executable attribute

Modified Files:


exec/user_settings.js
diff

Defense against TypeError: xtrn_area.editor[thisuser.editor] is undefined

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

DDFileLister: Now supports editing file info (with the E key).

Modified Files:


xtrn/ddfilelister/ddfilelister.js
diff

xtrn/ddfilelister/readme.txt
diff

xtrn/ddfilelister/revision_history.txt
diff

Merge branch 'dd_file_lister_edit_file_info' into 'master'

DDFileLister: Now supports editing file info (with the E key).

See merge request main/sbbs!453

Modified Files:


src/sbbs3/upgrade_to_v319.c
diff

Removed Files:


src/sbbs3/sbbs4defs.h
diff

Eliminate unused file sbbs4defs.h

Modified Files:


src/sbbs3/telgate.cpp
diff

Log warning if sendsocket() fails to send string passed to telgate()

Eliminates GCC warning about not checking return value of write/sendsocket()

Modified Files:


src/sbbs3/telgate.cpp
diff

Fix small memory leak when telgate() was used to proxy for a telnet server

At least 512 bytes per call.

Modified Files:


exec/fido-nodelist-browser.js
diff

Includes swindows with unborked home/end key handling in lightbar. Fixes
problem reported by Nightfox.

Modified Files:


exec/fido-nodelist-browser.js
diff

Temporary fix to restore things on exit pending figuring out why the other way
doesn't work.

Modified Files:


exec/fido-nodelist-browser.js
diff

Restore cursor on exit; which should be happening via js.on_exit anyway but ...
isn't?

Modified Files:


exec/fido-nodelist-browser.js
diff

A faster, better looking, less janky version of the FTN nodelist
browser. Should be feature-equivalent with the old one, though
the navigation is a bit different.

If you don't like it, dig the old one out of git and run it from
some other location.

This is a build of:
https://gitlab.synchro.net/echicken/nodelist-browser
and it will be maintained there for now. I'll try to remember to
update this copy as needed. Do not edit / commit changes to this
file; it's transpiled from TypeScript and not meant to be edited
by hand. Do not read this file if you value your sanity.

Modified Files:


exec/load/sbbsdefs.js
diff

src/sbbs3/sbbsdefs.h
diff

src/sbbs3/telgate.cpp
diff

Add Telnet Gateway "Raw TCP" (TG_RAW) and "Expand Bare-LF to CRLF" TG_EXPANDLF

The expansion of LF to CRLF (with TG_EXPANDLF) is on receive.

For Nelgin

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: Updates to fix new user newscan, depending on the scan_ptr value

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_new_user_scan_ptr_fix' into 'master'

DDMsgReader: Updates to fix new user newscan, depending on the scan_ptr value

See merge request main/sbbs!452

Modified Files:


exec/rlogin.js
diff

exec/telgate.js
diff

Add support for -v (verbose) option and modopts.ini

Don't display remote host name/addr unless -v option is specified or
verbosity=1 is set in modopts.ini.

Allow the displayed messages to be customized or disabled as the sysop wishes
via modopts.ini keys:
- help_msg
- connecting_msg
- failed_connect_msg
(e.g. set to a blank string to disable)

The following settings are also now configurable via modopts.ini:
- quiet (correlates with -q option)
- pause (correlates with -P option)
- clear (correlates with -C option)
- timeout (correlates with -T option)
- verbosity (correlates with -v option)

... a sysop can control the default behavior of all invocations of telgate.js
or rlogin.js via a single file now (modopts.ini).

The rlogin.js module will first look ing for the [rlogin] section in
modopts.ini and if it doesn't exist, then [telgate] section. telgate.js just
looks for the [telgate] section.

For the #synchronet irc crew: Nelgin and Keyop

Modified Files:


src/sbbs3/node.c
diff

Fix usage of "node list <node_num> <node_num> [...]"

Only the last node number specified would be listed before this fix.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Fix CIDs 508283 508284 508285 508286 508287

HANDLE_PENDING() macro returns from the calling function (without freeing
allocated resources), so don't use that here.

Modified Files:


src/sbbs3/telgate.cpp
diff

Fix CID 508288 (STRING_NULL)

I'm not clear why Coverity suddenly thinks that getstr() doesn't
nul-terminate strings, but whatever: NUL-terminate the buf before passing it
to getstr(). <shrug>

Modified Files:


exec/telgate.js
diff

Send CRLF terminated strings with -S option instead of CR-terminated

Telnet requires CRLF or CR/NUL instead of bare CR.

Removed Files:


xtrn/bullshit/bullshit-lib.js
diff

xtrn/bullshit/bullshit.ini
diff

xtrn/bullshit/bullshit.ssjs
diff

xtrn/bullshit/readme.txt
diff

These files no longer needed with new version.

Modified Files:


xtrn/bullshit/999-bullshit.xjs
diff

Basically the same as before, but without the help of bullshit-lib.js.
Untested.

Modified Files:


xtrn/bullshit/bullshit.js
diff

bullshit v4 build as in-place replacement for v3. On first run under the
terminal server, your old bullshit.ini settings will be migrated to
ctrl/modopts.d/bullshit.ini in a slightly different format.

Added Files:


xtrn/bullshit/.babelrc.json
diff

xtrn/bullshit/.devcontainer/devcontainer.json
diff

xtrn/bullshit/.gitignore
diff

xtrn/bullshit/Readme.md
diff

xtrn/bullshit/package-lock.json
diff

xtrn/bullshit/package.json
diff

xtrn/bullshit/src/bullshit.ts
diff

xtrn/bullshit/src/lib/UI.ts
diff

xtrn/bullshit/src/lib/list.ts
diff

xtrn/bullshit/src/lib/options.ts
diff

xtrn/bullshit/tsconfig.json
diff

Bullshit v4 (source & tooling).

This is a rewrite of the Bullshit bulletin lister. Should have all
the same features as v3, but much faster at lightbar navigation
and especially better at scrolling large files. (frame.js has been
replaced here by my new screen management library, 'swindows'.)

Sysops don't need to concern themselves with the files in this
commit; the build generated from these has been placed in the same
location as the old 'bullshit.js' script. Just copy that one to
wherever you normally run this from and it'll take over. Or you
could run Bullshit from the repo if you like to live dangerously.

Modified Files:


exec/tickit.js
diff

Change log level of "already exists" log messages from ERROR to WARNING

Fix issue #773

Modified Files:


src/sbbs3/node.c
diff

Fix the 'node list' command

No longer claim that 'list' is the default action (it's not).

If you want to list nodes, you need to specify the 'list' action.

Fix for issue #772

Modified Files:


exec/telgate.js
diff

Fix the mode passing to bbs.telnet_gate() - never undefined value

bbs.telnet_gate() is not tolerant of receiving an undefined parameter value
(while bbs.rlogin_gate() is), so this messed up the subsequent argument
parsing which caused the strings pushed with the '-s' or '-S' options to
not work.

Fixes issue #774

Modified Files:


exec/rlogin.js
diff

Fixed typo

Modified Files:


exec/telgate.js
diff

Support more command-line options, like -p, -C, -T, -m ala rlogin.js

Includes new feature to optionally send string(s) to remote server after
connecting (for Nelgin).

The -q option addition fixes issue #771.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/telgate.cpp
diff

Add optional array argument to bbs.telnet_gate() and bbs.rlogin_gate()

If an array argument is passed to these methods, the stringified contents of
each array element value will be sent to the remote server after connecting.

This is to support Nelgin's request of sending some strings to a server after
connecting. There's no way to insert pauses between the sent strings or wait
for certain output from the remote - that's beyond this scope/capability.

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to
(for the sysop)

Modified Files:


xtrn/DDMsgReader/DDMsgReader.cfg
diff

xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

Merge branch 'dd_msg_reader_default_save_path_option' into 'master'

DDMsgReader: New msgSaveDir option to specify a default dir to save messages to
(for the sysop)

See merge request main/sbbs!450

Modified Files:


src/sbbs3/ansiterm.cpp
diff

src/sbbs3/getkey.cpp
diff

src/sbbs3/inkey.cpp
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/sbbs.h
diff

Rename sbbs_t::ungetstr() and JS console.ungetstr() to ungetkeys()

... since these methods only feed the keyboard buffer.

Add an optional 'insert' argument to console.ungetkeys() - default is false
(append).

Add a new version of console.ungetstr() which feeds the passed characters
directly to the receive input buffer. Now returns bool indicating success.
Existing scripts (if any) that use console.ungetstr() should continue to work
just fine.

This is anticipation of telgate.js being able to stuff strings (e.g. username,
password) into the input buffer and those chars/keys being passed to the
remote (gatewayed) telnet server. Since the telnet gateway reads directly from
the receive input buffer (ignoring the keyboard buffer), we needed a way to
stuff strings of characters into the receive input buffer directly and that
sort of exposed the weirdness of the existing console.ungetstr() method:
- it didn't return a return value (not indication of failure)
- it didn't support an 'insert' operation (even though the underlying C++
  method does)
- it didn't use the sbbs_t method that already existed for feedding a string
  of characters into the input/keyboard buffer

Modified Files:


src/sbbs3/js_global.c
diff

Global JS exit() function now sets 'exit_code' to 0 by default

Calling exit() causes JS_ExecuteScript() to return false (same return value
as if there's a syntax error) - so if we always set exit_code in exit()
(even when not passed a parameter) and then use that exit code if the property
is defined, then we get the -1 return value from js_execfile() if the script
is terminated prematurely without using exit().

This fixes the issue introduced in the previous commit where scripts that
call exit() - without any parameters, were causing errors to be logged about
scripts (e.g. timed events) returning -1.

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/main.cpp
diff

Fix infinite loop of error msgs/notifications when JS shell has syntax error

js_execfile() now returns -1 when JS_ExecuteScript() return false (failure).

The main command-shell loop will now terminate when js_execfile() returns
anything but 0 (success), similar to how PCMS (Baja-compiled) command-shell
.bin file parse errors are handled.

Modified Files:


src/sbbs3/readmail.cpp
diff

Save/reuse the mail save path/filename as a user property (in data/user/*.ini)

This is a fix for issue #340

Another idea would be to store a history of mail save paths and allow the user
to scroll through them/choose with the up and down arrow keys, but that goes
beyond the original feature request. So this just stores/reuses the last
successfully used path/filename.

Modified Files:


exec/load/shell_lib.js
diff

Prompt to clear the batch download queue if user chooses not to download files

Some users may have unintentionally added files to their batch download queue
and not know how to clear the queue manually, so prompt here for user
friendliness/convenience.

Modified Files:


src/sbbs3/js_bbs.cpp
diff

Make argument to bbs.batch_clear() optional (clear downlaod queue by default)

... as appears to have been the intent

Modified Files:


src/sbbs3/js_internal.c
diff

Fix CID 508259:  Control flow issue  (DEADCODE)

... introduced in commit 54523145

Modified Files:


src/sbbs3/js_msgbase.c
diff

Fix CID 508260:  Null pointer dereference

And really, more importantly, the msg header field_list array length would
always be interpretted as 0-length!

... introduced in commit 54523145

Modified Files:


src/sbbs3/node.c
diff

Display usage help when unrecognized param is detected

Include -pause and -loop options in usage help output.

Don't delay (sleep) one second when looping and -pause option is used.

Flush the output before waiting for key-press (-pause option is used).

This should all address issue #365. Sorry for the long wait.

Modified Files:


ctrl/text.dat
diff

StartXferNow string now contains argument (%s) for the protocol name

This is helpful when auto-starting a download using the user's pre-selected
default download protocol, reminds the user to start the appropriate transfer
protocol on their end (when necessary).

Goes along with the previous commited fix to issue #767

Modified Files:


src/sbbs3/bat_xfer.cpp
diff

src/sbbs3/download.cpp
diff

src/sbbs3/qwk.cpp
diff

src/sbbs3/sbbs.h
diff

src/sbbs3/str.cpp
diff

src/sbbs3/text_defaults.c
diff

Don't display menu of file xfer prots when auto-selecting user's default prot

When a user has a "default download protocol" selected (configured for their
user account), don't display a menu of file transfer protocols when we're
just going to auto-select their default anyway (e.g. when downloading a QWK
packet).

This change also introduces an argument (%s, the protocol name) in the
StartXferNow text.dat string, so that if/when the user forgets which default
download transfer protocol they had selected, they'll be reminded ("oh yeah,
I need start an XMODEM download!").

This fixes issue #767

Modified Files:


src/sbbs3/exec.cpp
diff

src/sbbs3/js_archive.c
diff

src/sbbs3/js_conio.c
diff

src/sbbs3/js_console.cpp
diff

src/sbbs3/js_file.c
diff

src/sbbs3/js_filebase.c
diff

src/sbbs3/js_global.c
diff

src/sbbs3/js_internal.c
diff

src/sbbs3/js_msgbase.c
diff

src/sbbs3/js_socket.c
diff

src/sbbs3/js_system.c
diff

src/sbbs3/main.cpp
diff

src/sbbs3/websrvr.c
diff

Prevent NULL pointer dereference when 'null' object passed to JS functions

As was discovered as part of investigation into issue #769, a JavaScript
could crash SBBS (cause a segfault) due to a NULL pointer dereference when
the script passes 'null' to native JS functions where an object is expected.

The issue raised was with console.gotoxy(), but it turns out that *many*
Synchronet native JS functions would call JSVAL_TO_OBJECT() and then, without
checking for NULL/nullptr, pass its return value to JS api functions such as
JS_GetPrivate, JS_GetProperty, JS_GetClass, JS_ObjectIsFunction,
JS_IsArrayObject, JS_GetArrayLength, JS_DefineProperty, JS_Enumerate, etc.
All of these JS API functions dereference the passed object pointer without
NULL/nullptr checking.

The fix here is to either call JSVAL_IS_NULL() or JSVAL_NULL_OR_VOID() and
if true, not call JSVAL_TO_OBJECT() and/or check the return value for the NULL
value before using as an argument to any other JS API functions.

Modified Files:


src/sbbs3/js_console.cpp
diff

Better invalid argument reporting (null object) from js_gotoxy()

The calling script will still terminate if it does this, but at least the
caller will get a useful JS exception.

Related to fix for issue #769

Modified Files:


src/sbbs3/js_console.cpp
diff

Fix potential null object pointer passed to JS_GetProperty in js_gotoxy()

I'm not sure under what script conditions this could happen, but apparently
Nelgin was able to produce this null pointer deref (and segfault) using
DDMsgReader. This should fix issue #769

Modified Files:


exec/imapservice.js
diff

Fix messages with blank bodies not showing up on iphone

Modified Files:


exec/imapservice.js
diff

Merge branch 'fix_blank_imap_body' into 'master'

Fix messages with blank bodies not showing up on iphone

See merge request main/sbbs!449

Modified Files:


xtrn/DDMsgReader/DDMsgReader.js
diff

xtrn/DDMsgReader/ddmr_cfg.js
diff

xtrn/DDMsgReader/readme.txt
diff

xtrn/DDMsgReader/revision_history.txt
diff

DDMsgReader Fix: Indexed newscan mode for new users now shows the number of new
messages in sub-boards like it's supposed to. Reported by Nelgin.