Synchronet Git Commit Log

This is a log of the 500 most recent pushes to the master branch of the Synchronet Git repository.
If you want to view more pushes/commits, you can by passing ?<number> in URL.
  1. Nigel Reed
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added NEW-ENVIRON. Note the variable is NEW_ENVIRON

  2. Rob Swindell
    Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_new_environ_to_telnet_lib' into 'master' Added NEW-ENVIRON. Note the variable is NEW_ENVIRON See merge request main/sbbs!413

  3. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 02:30:22 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Borland C needs the strlcpy definition too The definition of vsnprintf as _vsnprintf didn't seem to hurt the build (as well, for Borland)

  4. Rob Swindell (on Debian Linux)
    Sat Feb 24 2024 02:05:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    Insure all builds of safe_strerror() write the string to the passed buf The GNU_SOURCE build of this function was (sometimes?) just returning the string and not actually copying it to the passed buf. This is consistent with the GNU manpage on strerror_r(): "This may be either a pointer to a string that the function stores in buf ..." but was inconsistent with all the other build types of this function. Also updated to use strlcpy and write the problematic error number to the default string (if unknown).

  5. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:13:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    Remove new/unused variable: of

  6. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 01:14:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    src/sbbs3/js_socket.h diff
    Report getaddrinfo() failure result in Socket.error and error_str (not errno) As Nelgin pointed out, a Socket.connect() failure for reasons of address/host lookup failure would report a stale/nonsense Socket.error/error_str value. This change required us to query/store the socket API/getaddrinfo error string at the time of failure (for the Socket.error_str property value) rather than converting from number to string at the time the property is read. This does mean that sometimes Socket.error is a errno value and sometimes its a getaddrinfo (EAI_*) error value. Since the EAI_* values are negative, it should be obvious which is which.

  7. Rob Swindell (on Windows 11)
    Sat Feb 24 2024 00:29:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/NodeFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.cpp diff
    src/sbbs3/ctrl/SpyFormUnit.h diff
    Support UTF-8 translation to CP437 and non 80x25 terminals Reads the new(ish) node*/terminal.ini file when it's changed to determine the connected-client's terminal type/dimensions. Now reports the terminal details in the spy form title/caption and if it's UTF-8, does a real-time translation to CP437 (since F. Piette's terminal lib only supports CP437). There is a bug here where if the data read from the RingBuffer is a partial UTF-8 sequence, it isn't decoded correctly. Fix that later (?) if it actually bugs anyone. There's no PETSCII conversion/support added here. I expect to someday replace this entirely (likely with something that uses cterm), so didn't want to invest too much time into this. But at least now spying on non-traditional ANSI-BBS clients isn't so terrible to look at.

  8. Deuce
    Fri Feb 23 2024 21:57:58 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    We need to call uifcbail() after calling show_bbslist()

  9. Deuce
    Fri Feb 23 2024 18:27:29 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/syncterm/ssh.c diff
    Fix some especially silly Coverity "issues" These are regarding initializing variables at the same time as the mutex. Harmless.

  10. Nigel Reed
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Added MSP, MXP, MSDP and a few other protocols

  11. Rob Swindell
    Fri Feb 23 2024 11:35:54 GMT-0800 (PST)
    Modified Files:
    

    exec/load/telnet_lib.js diff
    Merge branch 'add_mud_protocols_to_telnet_lib' into 'master' Added MSP, MXP, MSDP and a few other protocols See merge request main/sbbs!412

  12. Deuce
    Fri Feb 23 2024 06:43:47 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    We don't need headerBufferUsed... it's already tracked readHeaderFixed() already assumes the same header pointer will be passed in next call if the read is incomplete.

  13. Deuce
    Fri Feb 23 2024 06:31:30 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't just drop out the bottom of the function on timeout. If we don't get one of the commands we're waiting for, close the socket and exit instead of returning with the appearance of having received one.

  14. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:39:41 GMT-0800 (PST)
    Modified Files:
    

    exec/irc.js diff
    Don't hang if/when nick is rejected Change wait_for() to no longer loop indefinitely. If nick is rejected (e.g. begins with number), prepend '_' to it. Increment version number to 1.62 Fixes issue #723

  15. Rob Swindell (on Debian Linux)
    Fri Feb 23 2024 00:12:51 GMT-0800 (PST)
    Modified Files:
    

    exec/privatemsg.js diff
    exec/sbbsimsg.js diff
    Some localization support (e.g. 'Q'uit translation to another language) What I haven't really worked out is what if the translated word mnemonic is a duplicate of another, valid command key.

  16. Deucе
    Thu Feb 22 2024 20:57:09 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-sbbs-id-string.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Add "(SBBS)" to the SSH ID string. We've patched this thing enough to have a different identifier.

  17. Deucе
    Thu Feb 22 2024 19:04:40 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-do-debug.patch diff
    Make debug a bit less noisy.

  18. Deucе
    Thu Feb 22 2024 19:04:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Instead of keying on the packet being received, key on buffer empty. This should work exactly the same, but is more correct. It's possible that in the future, packet data could be added to the buffer after receiveBufPos, and we could know that no more is required.

  19. Deucе
    Thu Feb 22 2024 19:06:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Catch when cryptFlushData() says the channel is closed. Also, fix an unlikely race condition. This, combined with the cryptlib patches, fixes various weird SSH hangs resulting from partial reads of the SSH packet headers... a rare event that's very hard to trigger. Special thanks to MeaTLoTioN for reporting this, and running a BBS that manages to trigger it reliably. Check out The Quantum Wormhole and say thanks!

  20. Deucе
    Thu Feb 22 2024 19:09:46 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-fix-ssh-header-read.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Read SSH packet headers into a fixed buffer in the session info Previously, it was read into a local variable, and in the case of a partial read, everything would go to hell and SSH would hang. "Luckily" this was very hard to trigger.

  21. Deucе
    Thu Feb 22 2024 19:40:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    sftp_channel is always -1 here.

  22. Deucе
    Thu Feb 22 2024 19:41:05 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-ssh-service-type-for-channel.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    When the server allows us to open a new channel, use the right type. By default, Cryptlib uses the type of whatever channel happens to be currently selected, so if the server has sent some data, that will be shell. Instead, look up the new channel and use that type info. Ugh.

  23. Deucе
    Thu Feb 22 2024 07:03:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Keep pointers to dll_handle around to solence Coverity issues.

  24. Deucе
    Thu Feb 22 2024 06:55:39 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/datewrap.c diff
    Attempt to silence Coverity warnings about time32_t.

  25. Deucе
    Thu Feb 22 2024 06:31:37 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Use default instead of enum value in warning suppression. This will hopefully keep both Coverity and compilers happy.

  26. Deucе
    Thu Feb 22 2024 06:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Remove do-nothings that Coverity complains do nothing.

  27. Deucе
    Thu Feb 22 2024 06:46:07 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Avoid pasing NULL to strto*() functions. Whill this is perfectly legal and is not a problem, Coverity complains.

  28. Deucе
    Thu Feb 22 2024 06:46:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use SAFECOPY() for no reason. Since old is a strdup() of list->comment, it's known that it will fit, but Coverity doesn't know that.

  29. Deucе
    Thu Feb 22 2024 06:49:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Remove need_copy variable when it won't be used. Fixes Coverity issue.

  30. Deucе
    Thu Feb 22 2024 06:03:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    src/syncterm/term.h diff
    Use shared code for sending login information. The option from the menu (ALT-Z/CTRL-S) was copy/pasted years ago and never updated while the keyboard shortcut (ALT-L) was updated quite a bit. This extracts the ALT-L code into a function and calls it from the menu.

  31. Deucе
    Thu Feb 22 2024 05:35:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix some weirdness around window sizing. This should fix the recent issue when a larger or smaller version is painted inside the window after resize, as well as fix ALT-→ when the current size is not an integer multiple.

  32. Deucе
    Wed Feb 21 2024 12:58:36 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Lower flush count to 3. This is my happy place on the desktop system running xfce4... any higher, and it interferes with how I manage my windows. Hopefully, this value convers the initialization portion perfectly on all systems (hah!).

  33. Deuce
    Wed Feb 21 2024 12:14:50 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Count flushes to disable resize hack. Instead of strictly using "first resize", also count flushes and assume the hack isn't needed after five. Experimentation on my ChromeBook shows 3 to be sufficient, so I'm sing five for now. Odds are that this will still mess with tiling WMs, but I don't use one, so I don't mind yet. I expect this will be better, but likely still not great.

  34. Deucе
    Wed Feb 21 2024 10:53:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Always base scaling on size, and alwayse resize xim. Fixes issue with possible corrupt display when "weird" scaling changes occured.

  35. Deucе
    Wed Feb 21 2024 09:57:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Bugfix and more paranoia in ini*SString() functions. Bugfis: Be sure to terminate value if returning deflt. Paranoia: Terminate value if iniGetString() returns NULL I think the only way to trigger the paranoia is to pass NULL as the default when reading a key that's not present.

  36. Deuce
    Wed Feb 21 2024 09:29:46 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Only count it as the "first resize" if it's not from SendEvent()

  37. Deucе
    Wed Feb 21 2024 09:13:19 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    First attempt to fix "black bars" startup issue. The first time we receive a MapNotify or ConfigureNotify that sets the width and height, resize the window instead of accepting the current window size.

  38. Deucе
    Wed Feb 21 2024 07:46:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Pass user_t as pointer. Silly to pass a 728-byte object as a parameter.

  39. Deucе
    Wed Feb 21 2024 07:23:07 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/conn.c diff
    src/syncterm/conn.h diff
    It appears that in Win64, SOCKET is a long long. No more using the standard int type and having it work. Thanks Microsoft.

  40. Deucе
    Wed Feb 21 2024 07:20:09 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/load.c diff
    Remove apparently unused errno declaration.

  41. Deucе
    Wed Feb 21 2024 07:17:25 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    On Win64, COM_HANDLE is bigger than a long. Use strtoll() to parse number (except when _BORLANDC_ of course)

  42. Deucе
    Wed Feb 21 2024 07:08:45 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpmap.c diff
    On Win64, HFILE and HANDLE are quite different, use CreateFile() OpenFile() returns HFILE and is sus, CreateFile() is more complex, but returns a HANDLE (and is what MSDN suggests I use).

  43. Deucе
    Wed Feb 21 2024 06:36:18 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/sockwrap.c diff
    Fix warning on Win64 build

  44. Deucе
    Wed Feb 21 2024 06:30:09 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Cast away warning... This is why I returned ret. :D

  45. Deucе
    Wed Feb 21 2024 06:06:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    More input thread cleanup. There was an errant lock in there.

  46. Deucе
    Wed Feb 21 2024 05:42:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    And now Coverity gets into the false warning game. Fix incorrect Coverity issue that speculates this may return fval.

  47. Rob Swindell (on Debian Linux)
    Tue Feb 20 2024 23:54:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Allow UTF-8 sequences in message subjects (passing K_UTF8 to getstr) This was the behavior for all string input in SBBS until recently (Commit 55ccda6294f82506), with this change, an exception is being made for message subjects, but the vast majority of other string input is still limited to single-byte (i.e. US-ASCII or CP437) characters. This should fix issue #720

  48. Deuce
    Tue Feb 20 2024 21:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Use max when we have it, only restore size/scaling in fullscreen mode

  49. Deucе
    Tue Feb 20 2024 20:14:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    src/syncterm/COMPILING diff
    Unlock vstatlock for map_window()

  50. Deucе
    Tue Feb 20 2024 19:21:59 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/Common.gmake diff
    Find libarchive in 3rdp

  51. Deucе
    Tue Feb 20 2024 19:03:48 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/sdl2/bin/SDL2.dll diff
    3rdp/win64.release/sdl2/bin/sdl2-config diff
    3rdp/win64.release/sdl2/include/SDL2/SDL.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_atomic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_audio.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_bits.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_blendmode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_clipboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_config.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_cpuinfo.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_egl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_endian.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_error.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_events.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_filesystem.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gamecontroller.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_gesture.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_guid.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_haptic.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hidapi.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_hints.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_joystick.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keyboard.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_keycode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_loadso.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_locale.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_main.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_messagebox.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_metal.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_misc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mouse.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_mutex.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_name.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengl_glext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2ext.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_gl2platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_opengles2_khrplatform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_pixels.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_platform.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_power.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_quit.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rect.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_render.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_revision.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_rwops.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_scancode.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_sensor.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_shape.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_stdinc.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_surface.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_system.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_syswm.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_assert.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_common.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_compare.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_crc32.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_font.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_fuzzer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_harness.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_images.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_log.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_md5.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_memory.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_test_random.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_thread.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_timer.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_touch.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_types.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_version.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_video.h diff
    3rdp/win64.release/sdl2/include/SDL2/SDL_vulkan.h diff
    3rdp/win64.release/sdl2/include/SDL2/begin_code.h diff
    3rdp/win64.release/sdl2/include/SDL2/close_code.h diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config-version.cmake diff
    3rdp/win64.release/sdl2/lib/cmake/SDL2/sdl2-config.cmake diff
    3rdp/win64.release/sdl2/lib/libSDL2.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.dll.a diff
    3rdp/win64.release/sdl2/lib/libSDL2.la diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.a diff
    3rdp/win64.release/sdl2/lib/libSDL2_test.la diff
    3rdp/win64.release/sdl2/lib/libSDL2main.a diff
    3rdp/win64.release/sdl2/lib/libSDL2main.la diff
    3rdp/win64.release/sdl2/lib/pkgconfig/sdl2.pc diff
    3rdp/win64.release/sdl2/share/aclocal/sdl2.m4 diff
    Add SDL2 for Win64

  52. Deucе
    Tue Feb 20 2024 19:00:02 GMT-0800 (PST)
    Added Files:
    

    3rdp/win64.release/libarchive/bin/archive.dll diff
    3rdp/win64.release/libarchive/include/archive.h diff
    3rdp/win64.release/libarchive/include/archive_entry.h diff
    3rdp/win64.release/libarchive/lib/archive.lib diff
    3rdp/win64.release/libarchive/lib/archive_static.lib diff
    Add win64 libarchive

  53. Deucе
    Tue Feb 20 2024 18:43:27 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    src/sbbs3/GNUmakefile diff
    src/sexpots/GNUmakefile diff
    src/xpdev/strwrap.h diff
    Various fixes for 64-bit support

  54. Deucе
    Tue Feb 20 2024 18:34:56 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-add-win64.patch diff
    3rdp/build/cl-fix-mb-w-conv-warnings.patch diff
    Modified Files:

    .gitlab-ci.yml diff
    3rdp/build/GNUmakefile diff
    src/build/Common.gmake diff
    src/conio/Common.gmake diff
    src/conio/GNUmakefile diff
    src/syncterm/GNUmakefile diff
    src/xpdev/Common.gmake diff
    src/xpdev/GNUmakefile diff
    Add support for building 64-bit binaries using mingw32-w64

  55. Deucе
    Tue Feb 20 2024 16:37:41 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    mingw32-w64 does not include ultoa()

  56. Deucе
    Tue Feb 20 2024 16:35:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Unhack mingw32 hack for mingw32-w64

  57. Deucе
    Tue Feb 20 2024 16:24:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add mingw32-w64 build

  58. Deucе
    Tue Feb 20 2024 16:19:34 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Fix (incorrect) warning from gcc12

  59. Deucе
    Tue Feb 20 2024 16:05:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Finish fixing ini*SString(). The first fix was to copy the right value, the second fix was to ensure zero-length strings are terminated.

  60. Deucе
    Tue Feb 20 2024 15:56:16 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Partial fix of iniGetSString() and iniReadSString()

  61. Deucе
    Tue Feb 20 2024 15:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio_win32.c diff
    src/conio/win32cio.c diff
    src/syncterm/syncterm.c diff
    src/xpdev/dirwrap.c diff
    src/xpdev/sockwrap.c diff
    Be explicit in more ANSI/Wide functions. Also, fix macro name collision with GetDiskFreeSpaceEx

  62. Deucе
    Tue Feb 20 2024 15:11:02 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Fix mingw32 some more.

  63. Deucе
    Tue Feb 20 2024 15:01:19 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Fix inverted logic for Mingw32.

  64. Deucе
    Tue Feb 20 2024 14:43:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Whoops, these are for all !_WIN32 and some _WIN32

  65. Deucе
    Tue Feb 20 2024 14:31:28 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    Some fixups to allow mingw-w64 to be used where mingw32 is currently working.

  66. Deucе
    Tue Feb 20 2024 05:56:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move an sftp_state check inside mutex to silence Coverity. There's still outstanding issues in Coverity around sftp_state and sftp_channel that need some deep thought, but this one is trivial.

  67. Deucе
    Tue Feb 20 2024 05:07:52 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniGetSString() that takes the size of the buffer

  68. Deucе
    Tue Feb 20 2024 05:10:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    Use new iniGetSString() for syncterm.lst Prevents buffer overlow with manually edited or corrupted files.

  69. Deucе
    Tue Feb 20 2024 05:21:35 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    Add iniReadSString() as well.

  70. Deucе
    Tue Feb 20 2024 05:21:52 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/fonts.c diff
    src/syncterm/syncterm.c diff
    And use iniReadSString() where appropriate in SyncTERM.

  71. Deucе
    Mon Feb 19 2024 16:26:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Call map_window() to update size hints when resizing the window. This way, WMs that enforce aspect ratio etc, won't get potentially block the update.

  72. Deucе
    Mon Feb 19 2024 10:59:31 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/ssh.c diff
    Fix SSH fingerprinting. A hex nybble is not 8 bits, and C strings need to be termianted.

  73. Deucе
    Mon Feb 19 2024 10:11:12 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Likely fix a bunch of Coverity warnings. This is a very crazy lock/unlock pattern... an extra assignment makes it easier to follow the logic.

  74. Deucе
    Mon Feb 19 2024 09:59:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Expand ssh_mutex over the flushes. This should also resolve a conspiracy Coverity has about two input threads running at the same time.

  75. Deucе
    Mon Feb 19 2024 08:08:49 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Win32 API calls are __stdcall

  76. Deucе
    Mon Feb 19 2024 07:47:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    More fencepost errors in the other direction... This is likely what make the old broken values appear to work.

  77. Deucе
    Mon Feb 19 2024 06:50:08 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    There is something horribly wrong with what sscanf(x, "%2hhx", &cptr) does when compiled with mingw32. Use "anything else" to convert hex to char.

  78. Deucе
    Mon Feb 19 2024 06:06:45 GMT-0800 (PST)
    Modified Files:
    

    src/conio/Common.gmake diff
    Use NEED_BITMAP for no fonts, not X11 | SDL Fixes crash when built without X11 or SDL, but with GDI (not default)

  79. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 23:30:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfgxtrn.c diff
    Display warning dialog when changing cmdshell or xtrn editor's internal codes Changing a command shell or an external editor's internal code will revert the preference of any user's that have selected that shell or editor as their default/preference. A sysop may not realize this, so warn them with lots of detail in the help text if they need it. See issue #721 for details. Also updated the help text for command shell internal codes since it still only mentioned Baja/.bin modules.

  80. Deucе
    Sun Feb 18 2024 18:11:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdlfuncs.c diff
    src/conio/win32gdi.c diff
    Some cleanup, make SDL hyper turbo DPI aware as well.

  81. Deucе
    Sun Feb 18 2024 17:38:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Fix doorway mode. CSI=255h was not entering doorway mode anymore.

  82. Deucе
    Sun Feb 18 2024 14:43:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Fix pervasive fencepost error calculating width and height. Basically everywhere was off by one. Also, fix the get dpi size thingie to correct for window decorations. We never actually use the result of this, but Windows might for outline dragging or something... you can never know.

  83. Rob Swindell (on Windows 11)
    Sun Feb 18 2024 13:01:35 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbsecho.ini diff
    Update lha command-line to match current *nix and Windows releases of lha The extraction destination directory must be specified with the 'w=' option. As Fernando Toledo (@Ragnarok) pointed out: https://gitlab.synchro.net/main/sbbs/-/issues/524#note_4867

  84. Deucе
    Sun Feb 18 2024 12:14:01 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    AdjustWindowRect() can't be used for "High DPI" So do more terrible hackery.

  85. Deucе
    Sun Feb 18 2024 09:46:41 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.rc diff
    Use the last field of the version for release type

  86. Deucе
    Sun Feb 18 2024 09:44:44 GMT-0800 (PST)
    Added Files:
    

    src/syncterm/syncterm.rc diff
    Modified Files:

    src/syncterm/GNUmakefile diff
    Add version info resource.

  87. Deucе
    Sun Feb 18 2024 08:21:51 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.rc diff
    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    None of that worked, use #ifdef __GNUC__ on the manifest. This means ciolib utilities built with MSVC won't have the right manifest information, but the documentation is terrible and I can't figure it out.

  88. Deucе
    Sun Feb 18 2024 08:10:17 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.props diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    That didn't work, shotgun it into the props files.

  89. Deucе
    Sun Feb 18 2024 08:02:42 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Move no manifest from lib to rc. Looks like this was where it messed up first.

  90. Deucе
    Sun Feb 18 2024 07:52:34 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.vcxproj diff
    src/conio/conio_gdi.vcxproj diff
    src/conio/conio_sdl.vcxproj diff
    Slap some more tags in interesting-looking places.

  91. Deucе
    Sun Feb 18 2024 07:44:33 GMT-0800 (PST)
    Modified Files:
    

    src/conio/conio.props diff
    src/conio/conio_gdi.props diff
    src/conio/conio_sdl.props diff
    Hack up some props.

  92. Deucе
    Sun Feb 18 2024 07:30:05 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.manifest diff
    Apparently the MSVC builds also specify trustInfo in manifest. It appears they just set the default values, so try that out.

  93. Deucе
    Sun Feb 18 2024 07:12:37 GMT-0800 (PST)
    Added Files:
    

    src/conio/ciolib.manifest diff
    Modified Files:

    src/conio/GNUmakefile diff
    src/conio/ciolib.rc diff
    src/conio/win32gdi.c diff
    src/syncterm/GNUmakefile diff
    As it turns out, setting high DPI awareness in the process fails. Presumably, "something" is setting it earlier so it can't be set again because reasons. To work around this, add a manifest to ciolib library that asserts the binary is DPI aware and requests Windows not do GDI scaling. Not sure if manifest .o files in a lib are linked in by things, but SyncTERM pulls the .o out and explicitly links it, so this should fix SyncTERM at least.

  94. Deucе
    Sun Feb 18 2024 05:37:16 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Support the third (now preferred) method of setting DPI awareness. We will now try SetProcessDpiAwarenessContext() first, then SetProcessDpiAwareness() second, and finally SetProcessDPIAware() [sic]. Also, "handle" the WM_DPICHANGED event. This may solve problems initializing SyncTERM on systems with two displays that have different DPI settings.

  95. Eric Oulashin
    Sat Feb 17 2024 21:50:33 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js.

  96. Rob Swindell
    Sat Feb 17 2024 22:00:32 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit_Misc.js diff
    exec/slyedcfg.js diff
    Merge branch 'slyedit_isPrintableChar_UTF8' into 'master' SlyEdit: Update for the isPrintableChar() function to allow more for UTF-8 (it's a simplistic function). Also updated the version number in slyedcfg.js. See merge request main/sbbs!411

  97. Deucе
    Sat Feb 17 2024 18:18:27 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/CHANGES diff
    src/syncterm/menu.c diff
    src/syncterm/term.c diff
    Show mouse state in status bar, add ALT-O to toggle remote mouse. This allows easy copy/paste without scrollback hacks on BBSs that insist on taking over the mouse just so you can move the mouse and click a character rather than press one key because it's 3l337..

  98. Deucе
    Sat Feb 17 2024 12:16:12 GMT-0800 (PST)
    Modified Files:
    

    xtrn/sbj/GNUmakefile diff
    Depend on .o file and link it. When using $^, all the auto-dependencies are included in the link command-line, which includes sbj.c and all the .h files, causing the link to fail if dependencies exist.

  99. Deucе
    Sat Feb 17 2024 12:01:56 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_state inside ssh_mutex. This won't matter now since only one thread ever touches it, but when cool stuff happens, it could.

  100. Deucе
    Sat Feb 17 2024 11:45:14 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Move sftp_channel under the ssh_mutex completely.

  101. Deucе
    Sat Feb 17 2024 11:37:44 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Remove crufty code that effectively never does anything.

  102. Deucе
    Sat Feb 17 2024 11:26:39 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/bbslist.c diff
    src/syncterm/syncterm.c diff
    src/syncterm/syncterm.h diff
    src/syncterm/term.c diff
    Store scrollback position before clearing screen at end. This allows ALT-B from dialing directory to show the last seen thing, not the extra blank screen added to the end. Doesn't fix anything, but a huge QoL improvement for people who use ALT-B after disconnecting.

  103. Deucе
    Sat Feb 17 2024 10:35:47 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    For SDL mode, ensure rect matches vstat as well.

  104. Deucе
    Sat Feb 17 2024 10:17:58 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Ensure the rectangle we're scaling to the screen matches the screen size.

  105. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 22:30:01 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Latest patched cryptlib v3.4.7 for Win32 built with MSVC

  106. Deucе
    Fri Feb 16 2024 21:36:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Make ALT-F4 map to CIO_KEY_QUIT in GDI mode. Fixes issue 124 on Sourceforge.

  107. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:14:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Log the auto-detected character set (e.g. UTF-8, CP437, PETSCII, or US-ASCII)

  108. Rob Swindell (on Windows 11)
    Fri Feb 16 2024 18:15:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    New console property: unicode_zerowidth (either 0 or 1) The column-width of UNICODE 'zero-width' character is now autodetected. This property allows one to use/change this autodetected width (normally 0 or 1).

  109. Eric Oulashin
    Fri Feb 16 2024 13:00:56 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out.

  110. Rob Swindell
    Fri Feb 16 2024 13:10:59 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'dd_msg_reader_check_settings_fix' into 'master' DDMsgReader: When checking the user's external editor settings, make sure they actually have an external editor configured, or else DDMsgReader will error out. See merge request main/sbbs!410

  111. Eric Oulashin
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80"

  112. Rob Swindell
    Fri Feb 16 2024 12:06:14 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    Merge branch 'slyedit_settings_UTF8_supported' into 'master' xtrn.ini: For SlyEdit, the "Support UTF-8 Encoding" is now Yes. Also, updated the ARS to "ANSI AND COLS 80" See merge request main/sbbs!408

  113. Eric Oulashin
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu.

  114. Rob Swindell
    Fri Feb 16 2024 11:00:32 GMT-0800 (PST)
    Added Files:
    

    ctrl/slyedit_readme.txt diff
    Modified Files:

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_UTF8_header_items' into 'master' SlyEdit: Header display update for UTF-8. Added 'add graphic char' to DCT menu. See merge request main/sbbs!407

  115. Deucе
    Fri Feb 16 2024 10:21:37 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/Info.plist diff
    Add magic value that may allow using internal GPU on macOS.

  116. Deucе
    Fri Feb 16 2024 10:00:23 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Lower timeouts when closing SSH session. Reduces the time after a forced hangup that you need to wait before returning to the main menu.

  117. Deucе
    Fri Feb 16 2024 02:03:30 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/global/random.js diff
    random() has returned the same result four times in a row at least three times since we enabled the test suite. The odds of that happening *should* be one in a million, but NetBSD managed to fail this time (don't remember previous times, and not sure how to find them). For now, I'll just change this so there's a one in a trillion chance.

  118. Deucе
    Fri Feb 16 2024 01:51:28 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Move saved_scaling inside vstatlock. This shouldn't be necessary, but Coverity thinks it's a good idea, and it's simple enough to do without hurting anything.

  119. Deucе
    Fri Feb 16 2024 01:48:27 GMT-0800 (PST)
    Modified Files:
    

    src/conio/sdl_con.c diff
    src/conio/win32gdi.c diff
    src/conio/x_events.c diff
    Don't allow ciolib_initial_scaling to be less than 1.0 even if you do math to get there.

  120. Deucе
    Fri Feb 16 2024 01:19:25 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix warning.

  121. Deucе
    Fri Feb 16 2024 01:10:49 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Use strtoull() converting a string to a size_t Except on Borland, which presumably doesn't have strtoull().

  122. Deucе
    Fri Feb 16 2024 01:16:12 GMT-0800 (PST)
    Modified Files:
    

    src/conio/curs_cio.c diff
    src/syncterm/ssh.c diff
    Fix obvious errors found by Coverity. A couple were actually serious, most were unimportant.

  123. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:01:43 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    Fix GCC warning about enum cases not covered in switch

  124. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:02:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/readmsgs.cpp diff
    Add missing #include of utf8.h

  125. Rob Swindell (on Debian Linux)
    Thu Feb 15 2024 23:02:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    Use the do/while(0) trick to eliminate warnings w/use of SAEFCOPY_UTF8

  126. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str_util.c diff
    Fixed some lingering FALSE->false conversions

  127. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Lower severity of "Response file path is NULL" log msg from CRIT to WARNING This is not a completely unexpected thing to happen during ungraceful termination

  128. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:50:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Use fnopen() for auto-retry when opening dnsbl_exempt.cfg for append

  129. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 22:52:40 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/atcodes.cpp diff
    src/sbbs3/con_hi.cpp diff
    src/sbbs3/con_out.cpp diff
    src/sbbs3/email.cpp diff
    src/sbbs3/getstr.cpp diff
    src/sbbs3/js_global.c diff
    src/sbbs3/postmsg.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    src/xpdev/unicode.c diff
    src/xpdev/unicode.h diff
    UTF-8 improvements Don't corrupt UTF-8 strings with SAFECOPY() (use new SAFECOPY_UTF8). Some terminals (notably, Windows Terminal) display zero width UNICODE chars as a single column-wide space. <sigh> Auto-detect the zero-width "width" (1 or 0) of the terminal during connection and UTF-8 auto-detection. getstr() works a lot better now with UTF-8 strings with wide chars (e.g. emojis), but likely much more to do.

  130. Eric Oulashin
    Thu Feb 15 2024 20:52:48 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: quotes.txt is now in the correct case for the user's editor. "terminalSupportsUTF8 not defined" error eliminated.

  131. Rob Swindell
    Thu Feb 15 2024 21:50:06 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_quotes_txt_case_and_terminalSupportsUTF8_error_fix' into 'master' DDMsgReader: quotes.txt is now in the correct case for the user's editor. "terminalSupportsUTF8 not defined" error eliminated. See merge request main/sbbs!406

  132. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:21:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    src/xpdev/unicode_defs.h diff
    Better unicode character display-width calculation (in columns) Tested with Windows Terminal Version: 1.18.10301.0 and all codepoints between 0x100 and 0x1FFFF, this change reduces the width mismatches from > 8000 to 349. The "Zero width" mismatches are probably the most important/glaring and will need to be addressed next (since some terminals don't move the cursor for zero width chars, and some do).

  133. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:24:53 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    Create utf8_strlcpy() which does a "safe" truncated-string copy (doesn't leave a partial UTF-8 sequence at the end of the destination string). This calls memcpy() for every char, which may not be performant, but I didn't (yet) do any profiling. Hence, no premature optimization either.

  134. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:29:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/textgen.vcxproj diff
    Clean up some empty/unnecessary tags

  135. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:30:48 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/textgen.c diff
    Don't #include sbbs.h since that includes text.h, which is generated by this Which means that every time textgen was built, it was immediately out of date (and requiring a rebuild).

  136. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:32:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    Log the problem codepoint when reporting error in utf8_encode()

  137. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 21:36:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Fix bug in previous commit to this file I'm surprised this didn't create a warning somewhere: treating char* as a bool!

  138. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 19:24:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    If the quotes.txt file doesn't exist with the right case, try any case (but prefer the proper/configured case, based on config in SCFG). Works around a problem where DDMsgReader always creates QUOTES.TXT (never quotes.txt), but SBBS tries to read in the file with the case it expects. This wouldn't be a problem on case-insensitive file systems (Windows). Resolves the writemsg.cpp error reported by Nelgin

  139. Eric Oulashin
    Thu Feb 15 2024 15:58:35 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Something has gone wrong with the display of borders.. Reverting back to what I know was a good version of dd_lightbar_menu.js (none of the recent changes are significant).

  140. Rob Swindell
    Thu Feb 15 2024 16:25:26 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_revert_to_last_good' into 'master' DDLightbarMenu: Something has gone wrong with the display of borders.. Reverting back to what I know was a good version of dd_lightbar_menu.js (none of the recent changes are significant). See merge request main/sbbs!405

  141. Deucе
    Thu Feb 15 2024 15:35:38 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Re-enabled use of strtold() for long doubles... it is likely ubiquitous now (except for Borland of course, which doesn't count)

  142. Deucе
    Thu Feb 15 2024 15:29:17 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.h diff
    For reasons lost to history, commit 8b95d6 (18 years ago) disabled long long when compiled with MSVC. Re-enable it.

  143. Deucе
    Thu Feb 15 2024 15:02:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ripper.c diff
    Move fiddling with rip.x_max and rip.y_max out of the vstat mutex. Apparently, fiddling with them in there "strongly implies" to Coverity that vstatlock needs to be held to access them, and it's good form to have the lock held for the least span possible.

  144. Deucе
    Thu Feb 15 2024 13:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/link_list.c diff
    Don't hold a mutex while it's destroyed. Found by Coverity. If there's actually another thread using the list when the refcount hits zero, you're going to have a bad time regardless of the lock. Coverity has been pointing this out for a while, but we've been ignoring it as a false positive.

  145. Deucе
    Thu Feb 15 2024 12:15:54 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    src/sftp/sftp_server.c diff
    src/syncterm/term.c diff
    src/xpdev/xpprintf.c diff
    "Fix" low-hanging fruit Coverity issues.

  146. Rob Swindell (on Windows 11)
    Thu Feb 15 2024 11:59:33 GMT-0800 (PST)
    Modified Files:
    

    ctrl/xtrn.ini diff
    Default FSEditor config: UTF-8 enabled, Auto-Quote: None, Native: yes

  147. Deucе
    Wed Feb 14 2024 22:17:34 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    Some cleanup, no functional change.

  148. Deucе
    Wed Feb 14 2024 21:38:07 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Fix pasting in X11 mode... pastebuf should be UTF-8, not ISO-Latin1.

  149. Deucе
    Wed Feb 14 2024 21:38:07 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/newifc_nongen.c diff
    src/newifc/newifc_nongen_after.c diff
    src/newifc/root_window.c diff
    Some more fixins.

  150. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 11:36:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Remove line that was commented-out 14 years ago Commit d1182efc

  151. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 13:19:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/services.c diff
    src/sbbs3/websrvr.c diff
    Recycling servers reverts back to graceful (waiting for clients to disconnect) Commit 63d0772d was initially to address server termination (sisue #236), but expanded in scope to include server recycling (e.g. due to semaphore/config file touch) and that turns out to not be what most sysops want. If you want an immediate/ungraceful recycle, do a restart (shutdown/stop and then start) instead. Immediate/ungraceful server shutdown/termination is still in effect however. No change to the "server pause" feature either, so combining pause with recycle would be effective to prevent *new* client connections while waiting for existing clients to disconnect and allow a recycle to happen.

  152. Rob Swindell (on Windows 11)
    Wed Feb 14 2024 13:49:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_client.c diff
    src/sbbs3/js_system.c diff
    Fix href anchor links in JSDOCS

  153. Rob Swindell (on ChromeOS)
    Wed Feb 14 2024 00:27:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Simplify the child thread wait loop in cleanup()

  154. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 23:35:55 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Set javascript callback "terminated" flag to true when recycling (or terminating) the server. This will allow background JS threads to terminate when recycling, so the server doesn't just hang indefinitelyi when recycling. Add more logging in cleanup() when waiting for children threads to terminate. Also, eliminate the global 'terminate' variable, answering the question: Can this be changed to a if(ws_set!=NULL) check instead? Yes, yes it can.

  155. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 22:41:57 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/newuser.cpp diff
    src/sbbs3/userdat.c diff
    Detect and reject invalid birthdates during new user registration e.g. month and day reversed

  156. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:19:50 GMT-0800 (PST)
    Modified Files:
    

    ctrl/text.de.ini diff
    ctrl/text.es.ini diff
    Just a few [JS] text translations, as examples

  157. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:09:59 GMT-0800 (PST)
    Modified Files:
    

    exec/filescancfg.js diff
    exec/msgscancfg.js diff
    Give the scripts the gettext() treatment For easier customization/localization

  158. Rob Swindell (on Debian Linux)
    Tue Feb 13 2024 21:10:40 GMT-0800 (PST)
    Modified Files:
    

    exec/addfiles.js diff
    Fix typo in help text

  159. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 20:34:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    Improvements to UTF-8 capable external editor support 1. Add an 8th line to MSGINF (for SlyEdit): the character set expected (either "CP437", the default, or "UTF-8") based on the SCFG configuration 2. Don't apply "Soft-CR" (0x8D) stripping/expansion for UTF-8 editors

  160. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 20:36:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgxtrn.c diff
    The "Soft-CR" strip/expansion feature is N/A for UTF-8 editors Updated help text for "Support UTF-8 Encoding" for external editors.

  161. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 18:07:07 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Apparently Borland actually used 'enum text_modes' in conio.h. Follow suit. *This* is the way. Oops.

  162. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 18:03:04 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.h diff
    Change enum text_modes (plural) to enum text_mode (singular) This is the way.

  163. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 17:51:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Need to include ciolib.h for enum text_mode definition

  164. Rob Swindell (on Windows 11)
    Tue Feb 13 2024 17:42:34 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/echocfg.c diff
    src/sbbs3/scfg/scfg.c diff
    Make the default text (video) mode "LCD 80x25" (42), square pixel 80x25 mode This was the auto/default mode before commit c9cf87da If you really want the VGA aspect ratio, use the '-v41' option.

  165. Eric Oulashin
    Tue Feb 13 2024 13:49:03 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: Revert the text item width fill that was committed yesterday, as it seems to write too much in some cases

  166. Rob Swindell
    Tue Feb 13 2024 15:19:43 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_draw_item_fill_revert' into 'master' DDLightbarMenu: Revert the text item width fill that was committed yesterday, as it seems to write too much in some cases See merge request main/sbbs!404

  167. Deucе
    Tue Feb 13 2024 15:11:24 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/newifc_nongen_after.c diff
    src/newifc/root_window.c diff
    Add a dirty bit. dirty = true propogates up, dirty = false propogates down.

  168. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 22:16:12 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Re-enable the SyncTERM-MSVC build job

  169. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 22:07:34 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    include ssh.h to fix MSVC warning about undefined init_crypt

  170. Eric Oulashin
    Mon Feb 12 2024 21:49:58 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    SlyEdit: UTF-8 support in the displayed header and when quoting text and when quoting message text. This also includes a dd_lightbar_menu.js update

  171. Rob Swindell
    Mon Feb 12 2024 21:49:58 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    exec/load/dd_lightbar_menu.js diff
    Merge branch 'SlyEdit_UTF8_in_header_and_quoting' into 'master' SlyEdit: UTF-8 support in the displayed header and when quoting text and when quoting message text. This also includes a dd_lightbar_menu.js update See merge request main/sbbs!403

  172. Deucе
    Mon Feb 12 2024 21:46:58 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/syncterm/CMakeLists.txt diff
    src/syncterm/GNUmakefile diff
    src/syncterm/SyncTERM.vcxproj diff
    src/syncterm/extdeps.mk diff
    src/syncterm/ssh.c diff
    src/syncterm/ssh.h diff
    src/syncterm/syncterm.c diff
    src/syncterm/telnets.c diff
    Removed Files:

    src/syncterm/st_crypt.c diff
    src/syncterm/st_crypt.h diff
    Remove dlopen support. Since we're modifying cryptlib anyway, we can't just dlopen any old cryptlib library. Require linking with the lib. This will break the MSVC build, so disable that for now.

  173. Deucе
    Mon Feb 12 2024 20:36:00 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/st_crypt.h diff
    Nope, can't use C_RET either.

  174. Deucе
    Mon Feb 12 2024 20:09:01 GMT-0800 (PST)
    Added Files:
    

    src/newifc/newifc_nongen_after.c diff
    src/newifc/sizer_cell.c diff
    Modified Files:

    src/newifc/GNUmakefile diff
    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Checkpoint

  175. Deucе
    Mon Feb 12 2024 20:09:01 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/st_crypt.h diff
    Use C_RET for cryptlib symbols. Given how patched up cryptlib is at this point, this is all likely to go away and just use the static lib in the nearish future.

  176. Deucе
    Mon Feb 12 2024 20:23:32 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    If call to GetAttributeString() fails, we have a lot worse problems than err_len containing garbage. Handle the error and mention we didn't get the message. While we're here, check the return value of malloc().

  177. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 19:10:21 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Zero-Iniitalize err_len If call to GetAttributeString() fails, err_len can contain garbage.

  178. Deucе
    Mon Feb 12 2024 14:53:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Don't use i for loop index since it's signed.

  179. Deucе
    Mon Feb 12 2024 14:40:48 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/conn_pty.c diff
    Initialize c_cc in SyncTERM as well.

  180. Deucе
    Mon Feb 12 2024 14:26:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Explicitly initialize c_cc to _POSIX_VDISABLE since we can't know that we're setting all the values anymore. :(

  181. Deucе
    Mon Feb 12 2024 13:56:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn.cpp diff
    Since on at least Debian 12.4, the ttydefaults array is completely wrong, do c_cc the stupid (but POSIXly correct) way with a billion supporting.

  182. Rob Swindell (on Debian Linux)
    Mon Feb 12 2024 10:49:37 GMT-0800 (PST)
    Modified Files:
    

    exec/user_settings.js diff
    Enable raw input mode when prompting for backspace key Since the user we're editing here is not a pointer to the current user, changing the USER_SWAP_DELETE settings before this prompt doesn't prevent the DEL->BS translation from happening. Raw input mode does. Without this change, it would appear the user's backspace key would toggle between sending either ^H or DEL for the backspace key (for terminals that actually send DEL).

  183. Deucе
    Mon Feb 12 2024 10:33:40 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    When backspace sends delete, send CSI 3 ~ for delete.

  184. Rob Swindell (on Windows 11)
    Mon Feb 12 2024 10:27:04 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filedat.c diff
    Resolve warning: enumeration value ‘FILE_SORT_NATURAL’ not handled in switch

  185. Eric Oulashin
    Mon Feb 12 2024 09:47:30 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    SlyEdit readme: Removed extraneous description about UTF-8 support and left it as a simple blurb

  186. Rob Swindell
    Mon Feb 12 2024 10:24:44 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    Merge branch 'slyedit_readme_UTF8_update' into 'master' SlyEdit readme: Removed extraneous description about UTF-8 support and left it as a simple blurb See merge request main/sbbs!401

  187. Deucе
    Mon Feb 12 2024 10:18:59 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/term.c diff
    Actually fall-through like the comment says.

  188. Deucе
    Mon Feb 12 2024 10:12:15 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    src/conio/cterm.h diff
    src/conio/cterm.txt diff
    src/syncterm/term.c diff
    Add support for DECBKM.

  189. Deucе
    Mon Feb 12 2024 09:41:20 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/test.js diff
    More fixins to get error message.

  190. Deucе
    Mon Feb 12 2024 09:33:35 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/chatfuncs.c diff
    Ugh, indentation with spaces. Monster.

  191. Deucе
    Mon Feb 12 2024 09:29:57 GMT-0800 (PST)
    Modified Files:
    

    xtrn/tbd/reroll.c diff
    Fix warning. This line has always been there and never done anything.

  192. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_mqtt.c diff
    Fix heap corruption in Windows builds This bug caused crashes in the Windows build of sbbs when using the ;spy sysop command with MQTT enabled. Memory that is allocated in one DLL (e.g. sbbs.dll) must be freed in that same DLL (e.g. sbbs.dll, not mosquitto.dll). mosquitto_message_free() here frees the msg pointer, but we didn't allocate it in mosquitto.dll in the first place, so that's wrong. The proper mosquitto function to use in this case is mosquitto_message_free_contents().

  193. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    docs/v320_new.txt diff
    More new v3.20 stuff

  194. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 21:47:31 GMT-0800 (PST)
    Modified Files:
    

    node1/node.ini diff
    A couple obsolete keys removed from running SCFG on this

  195. Eric Oulashin
    Sun Feb 11 2024 21:00:10 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much)

  196. Rob Swindell
    Sun Feb 11 2024 21:00:10 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_UTF8_support' into 'master' SlyEdit: UTF-8 support. Also, new feature: Entering a graphic char with Ctrl-G (Ctrl-G was previously the key for general help, which wasn't much) See merge request main/sbbs!400

  197. Rob Swindell (on Debian Linux)
    Sun Feb 11 2024 16:54:49 GMT-0800 (PST)
    Modified Files:
    

    exec/mqtt_spy.js diff
    Support spying node being a UTF-8 terminal console.write() converts CP437->UTF-8, so use write_raw() instead since we're already doing the CP437->UTF-8 conversion here. As reported by Keyop.

  198. Rob Swindell (on Windows 11)
    Sun Feb 11 2024 14:38:18 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.vcxproj diff
    Set release project to use MBCS, not UNICODE (UCS-2). Debug project was already set this way.

  199. Deucе
    Sun Feb 11 2024 14:15:28 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Disable a few more warnings... the rest look useful.

  200. Deucе
    Sun Feb 11 2024 14:17:24 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ooii.c diff
    Since xp_play_sample() no longer takes a const buffer, we need to cast all the const buffers before passing them in and rely on runtime crashes to find bugs rather than compile-time errors. Thanks Microsoft. :D

  201. Deucе
    Sun Feb 11 2024 14:11:15 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/mouse.c diff
    src/conio/win32gdi.c diff
    src/sftp/sftp_attr.c diff
    src/syncterm/bbslist.c diff
    src/syncterm/conn.c diff
    src/syncterm/ssh.c diff
    src/syncterm/telnet_io.c diff
    Disable warnings more places.

  202. Deucе
    Sun Feb 11 2024 14:06:35 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    src/xpdev/xp_dl.c diff
    src/xpdev/xpbeep.c diff
    src/xpdev/xpbeep.h diff
    Resolve more MSVC warnings.

  203. Deucе
    Sun Feb 11 2024 13:56:44 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/conio/cterm.c diff
    src/conio/scale.c diff
    src/conio/sdl_con.c diff
    src/syncterm/ooii.c diff
    src/syncterm/term.c diff
    Disable warnings in more source files.

  204. Deucе
    Sun Feb 11 2024 13:38:03 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Disable MSVC warnings 4244 and 4267. The alternative is to explicitly copy/paste the type everywhere forcing the compiler to do the only thing it could possibly do, and making it painful to change a type later. Honestly, in my opinion, these warnings should just be disabled completely everywhere.

  205. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    Fix macro recusion protection for macros 32-63. Found by MSVC

  206. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    Fix MSVC warning about defined standard C features.

  207. Deucе
    Sat Feb 10 2024 22:25:13 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Actually remove the const the comment says I can't have.

  208. Deucе
    Sat Feb 10 2024 22:27:53 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/filewrap.c diff
    Fix misleading comment

  209. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 22:09:55 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    _MSC_VER is the macro name you're looking for there :-)

  210. Deucе
    Sat Feb 10 2024 21:56:01 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    This value is apparently sometimes an enum, sometimes a macro. Just use the raw value and a comment.

  211. Deucе
    Sat Feb 10 2024 21:48:59 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Fix some warnings. We can't use const protection for the sample buffer because the Win32 API takes non-const buffers. For standard implicit conversions, simply disable the warning where it occurs on purpose. It appears that MSVC builds use the equivilent of -Wconversion (which isn't even part of -Wall).

  212. Rob Swindell (on Debian Linux)
    Sat Feb 10 2024 21:34:39 GMT-0800 (PST)
    Modified Files:
    

    exec/filelist.js diff
    Fix issues with file sorting The case-sensitive/insensitive logic was backwards (-i enabled case-sensitive sorting) The re-sorting by name was always occurring when the -sort option was used. Case-insensitive sorting by numeric properties (e.g. size) didn't work right.

  213. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 21:06:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_filebase.c diff
    src/sbbs3/sbbsdefs.h diff
    src/sbbs3/scfg/scfgxfr2.c diff
    Separate "natural" (no sort) order from "Date ascending" sort order for dirs Since it is possible for someone to change the add/import date of a file after it's been added to the filebase, the natural/unsorted order might not actually be the same as "date ascending", so let the sysop/script-author really re-sort by date ascending if that's what they're trying to do. I think this is addresses the issue that Nightfox and Nelgin were describing in #synchronet.

  214. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 17:12:07 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/userdat.c diff
    nodestatus() print internal code rather than xtrn number, if possible (as a fall back to the full external program name).

  215. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:37:46 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpdev.props diff
    Define HAS_INTTYPES_H (for singled-threaded xpdev) here too

  216. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:38:39 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32cio.c diff
    src/conio/win32gdi.c diff
    Resolve some MSVC warnings by including missing header files

  217. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:39:52 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    Resolve some MSVC warnings

  218. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:41:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mqtt.c diff
    src/sbbs3/putnode.cpp diff
    Resolve off-by-one issue in MQTT node status publishing Make mqtt_putnodedat() use a 1-based node number, like the other putnodedat() functions. The bug (misuse of mqtt_putnodedat) was actually in js_system.c, but fixed the API to match the common expectation.

  219. Rob Swindell (on Windows 11)
    Sat Feb 10 2024 16:42:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/userdat.c diff
    nodestatus() use the user record's curxtrn internal code rather than aux value ... to determine/print the current external progarm being run. This fixes issue #716

  220. Eric Oulashin
    Sat Feb 10 2024 15:09:30 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD File Lister: New sort option in the config file: PER_DIR_CFG, which has Synchronet sort the file list according to the file directory's configuration

  221. Rob Swindell
    Sat Feb 10 2024 15:09:30 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.cfg diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_sort_according_to_dir_config' into 'master' DD File Lister: New sort option in the config file: PER_DIR_CFG, which has Synchronet sort the file list according to the file directory's configuration See merge request main/sbbs!399

  222. Eric Oulashin
    Sat Feb 10 2024 11:23:31 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    DDLightbarMenu: DrawPartial() width check update (previously it wasn't re-drawing the last character of the item text)

  223. Rob Swindell
    Sat Feb 10 2024 13:05:18 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    Merge branch 'dd_lightbar_menu_DrawPartial_width_check_update' into 'master' DDLightbarMenu: DrawPartial() width check update (previously it wasn't re-drawing the last character of the item text) See merge request main/sbbs!398

  224. Deucе
    Fri Feb 09 2024 22:38:06 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/test.js diff
    Log fail_msg, not the out-of-scope e. Hopefully, we'll find out why the random test fails sometimes...

  225. Deucе
    Fri Feb 09 2024 22:26:36 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Final cleanups after wikification

  226. Deucе
    Fri Feb 09 2024 19:12:48 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Some more fixes found from wikifying.

  227. Deucе
    Fri Feb 09 2024 18:35:02 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Fix warnings caused by our patches.

  228. Deucе
    Fri Feb 09 2024 10:35:42 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-read-timeout-every-time.patch diff
    src/sbbs3/websrvr.c diff
    Proper fix for wiki edit failures. The patch that sets the read timeout every time for getData() was flawed, because getData() itself will sometimes set the read timeout for the next call. The patch was intended to ensure that the write timeout never clobbers the read timeout, so now we track if getData() explicitly set the timeout and if it did, we don't reset it.

  229. Deucе
    Fri Feb 09 2024 10:13:16 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Whoops, remove the debug patch again.

  230. Deucе
    Fri Feb 09 2024 10:03:02 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    src/sbbs3/websrvr.c diff
    With TLS, errno isn't set, so logging it is just confusing.

  231. Deucе
    Fri Feb 09 2024 09:05:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Temporary workaround for TLS issue. It appears that if the timing is "just wrong", a large POST can cause TLS to fail. This has shown up as an inability to edit pages in the wiki. This is not a fix however, but simple a workaround until this is root-caused.

  232. Deucе
    Thu Feb 08 2024 23:37:19 GMT-0800 (PST)
    Modified Files:
    

    xtrn/termtest/termtest.js diff
    Add a regression test for bug fixed in previous commit.

  233. Deucе
    Thu Feb 08 2024 23:04:43 GMT-0800 (PST)
    Modified Files:
    

    src/conio/bitmap_con.c diff
    src/conio/cterm.c diff
    Fix crash found by vttest. If DL was passed a parameter equal to or greater than the number of lines from the current line to the last line in the region, it would try to move a negative-sized box up, which resulted in a crash. This fixes that three ways: 1) Do not allow moving boxes with negative X/Y sizes 2) In dellines, clamp the lines to the number that could be deleted 3) Don't move lines up of all rest of the lines are being deleted

  234. Deucе
    Thu Feb 08 2024 15:53:49 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/cl-make-channels-work.patch diff
    Only take the early-out data path required to make SSH channels work for SSH sessions. May fix the issues seen updating wiki pages, may not, but is a less invasive patch either way.

  235. Deucе
    Thu Feb 08 2024 15:50:09 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.txt diff
    Some updates I made while doing a wiki version I can't currently POST.

  236. Deucе
    Thu Feb 08 2024 08:40:25 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpprintf.c diff
    Fix memory leak on realloc failure in xp_aprintf_next() The caller of this function must clobber the passed in pointer, and we're returning NULL meaning we would be overwriting the pointer to the allocation.

  237. Deucе
    Thu Feb 08 2024 01:23:49 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Possible fix warning in xpprintf() about using a pointer after free. If this *does* work, it means that potentially a huge chunk of our error checking hasn't actually worked in release builds or builds that use the FORTIFY option.

  238. Rob Swindell (on Debian Linux)
    Thu Feb 08 2024 00:43:57 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Use -Og for fortified debug builds (rather than -O1)

  239. Deucе
    Wed Feb 07 2024 23:55:41 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Allow FORTIFY=1 to work on RELEASE builds too. At some point, we should consider making it default.

  240. Deucе
    Wed Feb 07 2024 23:16:28 GMT-0800 (PST)
    Modified Files:
    

    src/conio/x_events.c diff
    Bow to GCC harder.

  241. Deucе
    Wed Feb 07 2024 23:13:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Add missing =

  242. Deucе
    Wed Feb 07 2024 23:07:33 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    Silence gcc warning by using blinking bright-red on red if algo is broken.

  243. Deucе
    Wed Feb 07 2024 22:59:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    asprintf() on Linux does not guarantee to set the ptr to NULL on error.

  244. Rob Swindell (on Debian Linux)
    Wed Feb 07 2024 22:30:50 GMT-0800 (PST)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    src/sbbs3/inkey.cpp diff
    src/sbbs3/sbbsdefs.h diff
    inkey() now returns CP437 characters by default K_CP437 changed to K_UTF8 with the inverted logic. If you have code/script that can handle UTF-8 input, then you need to specify K_UTF8 in calls to inkey, getkey, getstr. Or else, you're going to get a CP437 translated version of any non-ASCII (UNICODE) UTF-8 chars, if there's a mapping available. This only impacts UTF-8 terminals. There are just so many places in Synchronet where UTF-8 input could cause problems, it makes sense to translate UTF-8 to CP437 by default and make true UNICODE/UTF-8 handling the exception. Sorry Nightfox, you'll need to remove the K_CP437 detection/use code you just added to SlyEdit.

  245. Rob Swindell (on Debian Linux)
    Wed Feb 07 2024 22:38:00 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    Pass K_UTF8 mode flag to console.inkey() Since this script supports/expects UTF-8 character sequences for UNICODE characters (not a CP437 translated version of mappable chars).

  246. Deucе
    Wed Feb 07 2024 20:37:17 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Add -MP with -MMD This creates a .PHONY target for each file so that if a header is renamed, the impact will be the files that include it being rebuilt instead of the previous behaviour where the build would simply fail and complain that the file doesn't exist.

  247. Eric Oulashin
    Wed Feb 07 2024 19:09:08 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    SlyEdit: Support for entering UTF-8/Unicode characters; using K_CP437 to have Synchronet convert to CP437 internally

  248. Rob Swindell
    Wed Feb 07 2024 19:32:01 GMT-0800 (PST)
    Modified Files:
    

    docs/slyedit_readme.txt diff
    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    Merge branch 'slyedit_K_CP437_text_input' into 'master' SlyEdit: Support for entering UTF-8/Unicode characters; using K_CP437 to have Synchronet convert to CP437 internally See merge request main/sbbs!397

  249. Deucе
    Wed Feb 07 2024 18:12:07 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Group Windows jobs, delete commented out old Linux jobs.

  250. Deucе
    Wed Feb 07 2024 17:51:32 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Do not use -Werror in CI. We don't want CI to die because someone somewhere upgrade a compiler.

  251. Deucе
    Wed Feb 07 2024 17:29:23 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    We're now warning-free... enable -Werror for CI. NOTE: CI does release builds, which means that -Wall is not enabled. WALL=1 could be added if we want that, but it's likely too soon to take that step.

  252. Deucе
    Wed Feb 07 2024 17:24:33 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    UIFC uses ciolib.

  253. Deucе
    Wed Feb 07 2024 17:25:52 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/uifc/GNUmakefile diff
    UIFC does not need libciolib_mt.a to build.

  254. Deucе
    Wed Feb 07 2024 17:15:59 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Fix backslash alignment when 8-position tabs are used.

  255. Deucе
    Wed Feb 07 2024 17:14:32 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Fix typo.

  256. Deucе
    Wed Feb 07 2024 17:12:54 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    One last attempt... cast the whole thing to uint8_t and take a pointer to an element. No way gcc has a clue about what I'm doing then.

  257. Deucе
    Wed Feb 07 2024 17:09:56 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Revert sftp_pkt.c

  258. Deucе
    Wed Feb 07 2024 17:06:40 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Looks like I just need to live with the warning for now. Maybe I'll figure out how to fix it later.

  259. Deucе
    Wed Feb 07 2024 16:59:45 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Can't put a flexible array member in a union... add another anonymous struct layer.

  260. Deucе
    Wed Feb 07 2024 16:58:24 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    Add missing semi-colon.

  261. Deucе
    Wed Feb 07 2024 16:56:39 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_pkt.c diff
    Try an anonymous union containing an anonymouse struct to fix it.

  262. Deucе
    Wed Feb 07 2024 16:50:12 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Get a bit more creative in casting (to shut up gcc)

  263. Deucе
    Wed Feb 07 2024 16:44:30 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp_pkt.c diff
    Attempt to tell gcc I know what I'm doing with a void* cast

  264. Deucе
    Wed Feb 07 2024 16:46:28 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/buildfont.c diff
    Fix warning about another incorrect-sized array.

  265. Deucе
    Wed Feb 07 2024 16:30:41 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    If it needs libsbbs, it needs spidermonkey (except for gtkuserlist?)

  266. Deucе
    Wed Feb 07 2024 16:25:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkuserlist/GNUmakefile diff
    Add CRYPT_CFLAGS back in. :(

  267. Deucе
    Wed Feb 07 2024 16:24:31 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    src/sbbs3/gtkuserlist/gtkuserlist.h diff
    Actually, everything but gtkchat appears to link with libsbbs.so

  268. Deucе
    Wed Feb 07 2024 16:19:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkuserlist/GNUmakefile diff
    src/sbbs3/gtkuserlist/gtkuserlist.h diff
    gtkuserlist doesn't need cryptlib

  269. Deucе
    Wed Feb 07 2024 16:14:51 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkchat/chatfuncs.c diff
    src/sbbs3/gtkchat/main.c diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    They all need no cryptlib it seems

  270. Deucе
    Wed Feb 07 2024 16:10:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    Disable cryptlib in sbbs.h as well (but re-enable it)

  271. Deucе
    Wed Feb 07 2024 16:07:45 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Move noskeeters into the freebsd-amd64 group

  272. Deucе
    Wed Feb 07 2024 16:06:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/gtkmonitor/gtkmonitor.h diff
    And no JS here either.

  273. Deucе
    Wed Feb 07 2024 15:53:05 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Update smoketest depend

  274. Deucе
    Wed Feb 07 2024 15:51:52 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/sbbs3/gtkchat/chatfuncs.c diff
    src/sbbs3/gtkchat/main.c diff
    src/sbbs3/gtkuseredit/events.c diff
    src/sbbs3/gtkuseredit/gtkuseredit.c diff
    Comment-out "classic" Linux builds, "disable Javascript" for sbbs.h in gtk utils

  275. Deucе
    Wed Feb 07 2024 15:47:00 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Add Linux group.

  276. Deucе
    Wed Feb 07 2024 15:37:29 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Group tests by suite, not by OS/Platform

  277. Deucе
    Wed Feb 07 2024 15:30:01 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Put platform in the group name

  278. Deucе
    Wed Feb 07 2024 15:19:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And finally dependencies

  279. Deucе
    Wed Feb 07 2024 15:18:30 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And fix up needs

  280. Deucе
    Wed Feb 07 2024 15:15:22 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    And fix extends

  281. Deucе
    Wed Feb 07 2024 15:14:35 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Attempt using a gitlab feature documented only by regex. :D

  282. Deucе
    Wed Feb 07 2024 14:58:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Fix off_t printf warning.

  283. Deucе
    Wed Feb 07 2024 14:47:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/services.c diff
    Another time_t printf

  284. Deucе
    Wed Feb 07 2024 14:34:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Oh damn, this is an off_t + size_t + 1... talk about the wild west of types! Both long long and long are reasonable for some mixes of platforms. Just punt, cast the whole thing to int64_t, and forget about it.

  285. Deucе
    Wed Feb 07 2024 14:20:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Aha! XP_PRIsize_t is a *size*, not a *type*.

  286. Deucе
    Wed Feb 07 2024 14:11:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Add missing header?

  287. Deucе
    Wed Feb 07 2024 14:00:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    Some more printf formats... mostly off_t but also a size_t and an time_t

  288. Deucе
    Wed Feb 07 2024 13:40:38 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Mostly time_t printfs, but also an odd bit where it's printing a value that's not an off_t as one.

  289. Deucе
    Wed Feb 07 2024 13:23:08 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Add WALL option.

  290. Deucе
    Wed Feb 07 2024 13:15:25 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/GNUmakefile diff
    SyncTERM doesn't use telnet from a DLL.

  291. Deucе
    Wed Feb 07 2024 13:19:11 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/xtrn_sec.cpp diff
    Another time_t printf

  292. Deucе
    Wed Feb 07 2024 12:56:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/pack_qwk.cpp diff
    Another time_t warning... thanks OpenBSD!

  293. Deucе
    Wed Feb 07 2024 13:01:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sexyz.c diff
    src/syncterm/conn.c diff
    ioctlsocket() type stupidity warning.

  294. Deucе
    Wed Feb 07 2024 13:06:41 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/sexpots.c diff
    Silence odd warning... I would expect these to be the same type save const, but apparently they're not. *shrug*

  295. Deucе
    Wed Feb 07 2024 12:20:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpbeep.c diff
    Another Windows warning about constiness.

  296. Deucе
    Wed Feb 07 2024 12:23:17 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    More time_t printf fun.

  297. Deucе
    Wed Feb 07 2024 11:57:11 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32cio.c diff
    Fix mingw32 warning... export variable correctly.

  298. Deucе
    Wed Feb 07 2024 11:55:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Underp.

  299. Deucе
    Wed Feb 07 2024 11:53:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    More format specifier correction.

  300. Deucе
    Wed Feb 07 2024 11:50:25 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Fix raspian warning. &file_count is being passed as a pointer to a size_t.

  301. Deucе
    Wed Feb 07 2024 11:47:49 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/fontutil.c diff
    "Fix" some more warnings. This need to be tested.

  302. Deucе
    Wed Feb 07 2024 11:02:58 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Reverse logic on GCC/Win32 detection for alloca/malloc.h Mingw32 is _WIN32 and GCC, and we need some way to get the free() prototype. :D

  303. Deucе
    Wed Feb 07 2024 10:58:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/filelist.c diff
    Fix OpenBSD warning.

  304. Deucе
    Wed Feb 07 2024 10:55:52 GMT-0800 (PST)
    Modified Files:
    

    src/conio/win32gdi.c diff
    src/syncdraw/syncdraw.c diff
    src/syncdraw/syncdraw.h diff
    More TP arrays

  305. Deucе
    Wed Feb 07 2024 10:37:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Fix more warnings... It looks like we may need a set of PRI?TIME macros for printf()ing a time_t.

  306. Deucе
    Wed Feb 07 2024 10:45:54 GMT-0800 (PST)
    Modified Files:
    

    src/syncdraw/fonts.h diff
    Fix up reading of Turbo Pascal arrays. The last element of these arrays was getting clobbered by the next field because the array sizes are stored in the first element. Fixes warning on NetBSD and Raspian.

  307. Deucе
    Wed Feb 07 2024 10:46:59 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    win32, not Win32

  308. Deucе
    Wed Feb 07 2024 10:21:14 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    Fix reversed logic of previous commit.

  309. Deucе
    Wed Feb 07 2024 10:17:29 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/ini_file.c diff
    No strtoull() for Borland

  310. Deucе
    Wed Feb 07 2024 10:14:55 GMT-0800 (PST)
    Modified Files:
    

    exec/tests/test.js diff
    Log exceptions to stdout as well as log file.

  311. Deucе
    Wed Feb 07 2024 10:03:36 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Disable -fpic for Win32

  312. Deucе
    Wed Feb 07 2024 10:11:26 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.c diff
    src/xpdev/ini_file.c diff
    Fix OpenBSD and NetBSD warnings.

  313. Deucе
    Wed Feb 07 2024 10:00:27 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    src/build/Common.gmake diff
    Add WERROR build option. Also, add a BUILD_ARGS variable so custom pipelines can be ran for the templated job tree.

  314. Deucе
    Wed Feb 07 2024 09:49:52 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Remove unneeded build flags. Just because I use them for SyncTERM releases doesn't mean we want them for CI.

  315. Deucе
    Wed Feb 07 2024 01:34:22 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Eureka!

  316. Deucе
    Wed Feb 07 2024 01:33:47 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Crazyquote

  317. Deucе
    Wed Feb 07 2024 01:32:33 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Extraquote

  318. Deucе
    Wed Feb 07 2024 01:28:54 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Insanityquote?

  319. Deucе
    Wed Feb 07 2024 01:26:06 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Indents?

  320. Deucе
    Wed Feb 07 2024 01:23:57 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Comment flail

  321. Deucе
    Wed Feb 07 2024 01:22:51 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Flailquote

  322. Deucе
    Wed Feb 07 2024 01:19:51 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Unflail

  323. Deucе
    Wed Feb 07 2024 01:14:07 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Flail at the error message

  324. Deucе
    Wed Feb 07 2024 01:07:25 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Quote ifs

  325. Deucе
    Wed Feb 07 2024 00:53:08 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Remove the variables. This double definition just seems confusing and error-prone. Sure, the interpolation form is more verbose and ugly, but at least it's not duplicative.

  326. Deucе
    Wed Feb 07 2024 00:40:36 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Use references for .rules rules instead of copy/paste

  327. Deucе
    Wed Feb 07 2024 00:20:08 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/uifc/targets.mk diff
    Remove uifctest from the all target. This utility is for manual testing, not automated testing, so there's no point in anyone building it as a side-effect. Removing it should also flatten the dependency tree and allow more parallel jobs (there's up to 18 seconds to gain!)

  328. Deucе
    Tue Feb 06 2024 23:54:37 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/targets.mk diff
    Fix uifc makefile recursively calling itself

  329. Deucе
    Tue Feb 06 2024 23:49:34 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    src/sbbs3/scfg/GNUmakefile diff
    Depend on CRYPT_LIB, not CRYPT_DEPS

  330. Deucе
    Tue Feb 06 2024 23:36:25 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/targets.mk diff
    Remove explicit MAKEFLAGS... you can't stop it anyway.

  331. Deucе
    Tue Feb 06 2024 23:19:58 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Put the -d back in to find the last nit...

  332. Deucе
    Tue Feb 06 2024 23:04:38 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/GNUmakefile diff
    uifctest needs $EXEODIR

  333. Deucе
    Tue Feb 06 2024 22:41:08 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/GNUmakefile diff
    src/sftp/targets.mk diff
    Fix SFTP library target

  334. Deucе
    Tue Feb 06 2024 22:49:15 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/GNUmakefile diff
    src/uifc/targets.mk diff
    Clean up uifc build... it was actually recursively calling itself. :(

  335. Deucе
    Tue Feb 06 2024 22:58:36 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    util (apparently) depends on cryptlib.

  336. Deucе
    Tue Feb 06 2024 22:35:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Subvert phony phonies further.

  337. Deucе
    Tue Feb 06 2024 22:19:27 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/GNUmakefile diff
    Subvert non-phony phonies, and order-only some more dirs

  338. Deucе
    Tue Feb 06 2024 21:49:06 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/GNUmakefile diff
    More order-only dirs. This won't help though.

  339. Deucе
    Tue Feb 06 2024 21:49:21 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Make "xpdev" so libxpdev.a isn't considered stale.

  340. Deucе
    Tue Feb 06 2024 21:51:43 GMT-0800 (PST)
    Modified Files:
    

    src/smblib/GNUmakefile diff
    And order-only smblib too.. *sigh*

  341. Deucе
    Tue Feb 06 2024 21:21:42 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Try to get the extract order right to satisfy gmake

  342. Deucе
    Tue Feb 06 2024 21:18:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Pull out the -d

  343. Deucе
    Tue Feb 06 2024 21:04:30 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Use GIT=NO becasue ugh.

  344. Deucе
    Tue Feb 06 2024 20:53:41 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Touch the git info before building.

  345. Deucе
    Tue Feb 06 2024 20:28:15 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Well, that didn't work, move the d somewhere else.

  346. Deucе
    Tue Feb 06 2024 20:03:48 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Slip in the -d to figure out why re-linking is happening.

  347. Deucе
    Tue Feb 06 2024 19:38:55 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    src/sbbs3/scfg/GNUmakefile diff
    src/sbbs3/scfg/targets.mk diff
    src/sbbs3/uedit/GNUmakefile diff
    src/sbbs3/uedit/targets.mk diff
    Make directories order-only so they don't cause re-linking

  348. Deucе
    Tue Feb 06 2024 19:12:14 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/asc2ans.c diff
    windows.h, not Windows.h

  349. Deucе
    Tue Feb 06 2024 19:10:02 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Don't include the .d files in archives.

  350. Deucе
    Tue Feb 06 2024 19:01:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    ans2asc requires XPDEV_LIBS to link against Netapi32.dll for NetWkstaGetInfo()

  351. Deucе
    Tue Feb 06 2024 18:51:29 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Looks like upgradeto* need sbbs.h (and therefore jsversion.h) too. Bump them from standalone-utils

  352. Deucе
    Tue Feb 06 2024 18:47:50 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Actually remove slog from standalone-utils. Derp.

  353. Deucе
    Tue Feb 06 2024 18:46:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Expire artifacts in 30 minutes. Most of these are useless by themselves, so no need to keep them after the build completes.

  354. Deucе
    Tue Feb 06 2024 18:40:25 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Add gitinfo requirement.

  355. Deucе
    Tue Feb 06 2024 18:36:03 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/targets.mk diff
    Looks like slog is the only util that links with libsbbs. Add a standalone-utils .PHONY target to build all the rest before Spidermonkey is done.

  356. Deucе
    Tue Feb 06 2024 18:24:28 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    scfg, uedit, and umonitor need to save object files too or rebuild

  357. Deucе
    Tue Feb 06 2024 18:13:03 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    No point in splitting out utils yet, it depends on libsbbs.

  358. Deucе
    Tue Feb 06 2024 18:02:01 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Some more pipeline fixins.

  359. Deucе
    Tue Feb 06 2024 17:55:57 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Add some gitinfo... likely need more needs though

  360. Deucе
    Tue Feb 06 2024 17:41:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/targets.mk diff
    Add the missing colons

  361. Deucе
    Tue Feb 06 2024 17:39:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/sbbs3/targets.mk diff
    Parallelize stuff that doesn't need JS. The should help with CI times... and I'll be able to see if the libs are worth splitting out too.

  362. Deucе
    Tue Feb 06 2024 13:31:39 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    If the terminal is UTF-8 and the to/subject/from is NOT, xlat to utf-8 at start. This may be the issue Keyop was seeing.

  363. Rob Swindell (on Debian Linux)
    Tue Feb 06 2024 12:38:50 GMT-0800 (PST)
    Modified Files:
    

    exec/load/sbbsdefs.js diff
    Add K_CP437 definition (for use with inkey())

  364. Rob Swindell (on Windows 11)
    Tue Feb 06 2024 12:35:33 GMT-0800 (PST)
    Modified Files:
    

    src/encode/utf8.c diff
    src/encode/utf8.h diff
    Add utf8_decode_firstbyte() for use when all you need is the length (and validity) of the first byte in a UTF-8 sequence.

  365. Rob Swindell (on Windows 11)
    Tue Feb 06 2024 12:35:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/unicode.c diff
    unicode_to_cp437() returns a char, not an enum unicode_codepoint No functional change.

  366. Rob Swindell (on Windows 11)
    Tue Feb 06 2024 12:35:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Ignore remove() return value purposefully in this case. Does this resolve Coverity warning? I don't rember.

  367. Rob Swindell (on Windows 11)
    Tue Feb 06 2024 12:35:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/inkey.cpp diff
    src/sbbs3/sbbsdefs.h diff
    Add K_CP437 mode flag for use with inkey() - translates UTF-8 to CP437 If you're writing, say, a message editor and you don't want to deal with UTF-8 input at all, specify this mode flag to convert any translatable UTF-8 chars (that have CP437 equivalents) to CP437 chars. Non-translatable UTF-8 chars are just ignored (treated the same as a timeout/no-input).

  368. Rob Swindell (on Windows 11)
    Tue Feb 06 2024 12:35:33 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_bbs.cpp diff
    Support optional msg_header argument to bbs.expand_atcodes() For Nightfox's use in DDMsgReader.

  369. Eric Oulashin
    Tue Feb 06 2024 09:50:29 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    Removed Files:

    xtrn/DDMsgReader/dd_lightbar_menu.js diff
    DDMsgReader: UTF8 update for the standard Synchronet message header too. Also, oops, dd_msg_reader.js should only be in exec/load, not xtrn/DDMsgReader.

  370. Rob Swindell
    Tue Feb 06 2024 10:12:56 GMT-0800 (PST)
    Modified Files:
    

    exec/load/dd_lightbar_menu.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    Removed Files:

    xtrn/DDMsgReader/dd_lightbar_menu.js diff
    Merge branch 'dd_msg_reader_standard_hdr_utf8_and_lightbar_menu_file' into 'master' DDMsgReader: UTF8 update for the standard Synchronet message header too. Also, oops, dd_msg_reader.js should only be in exec/load, not xtrn/DDMsgReader. See merge request main/sbbs!396

  371. Deucе
    Tue Feb 06 2024 10:00:05 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Now that fetch is happening, we don't need a clone job

  372. Deucе
    Tue Feb 06 2024 09:52:45 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Switch to GIT_STRATEGY fetch It seems each concurrent task gets a separate workspace.

  373. Deucе
    Tue Feb 06 2024 09:44:40 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Clean 3rdp on checkout. For some reason, weird things happen on netbsd/openbsd

  374. Deucе
    Tue Feb 06 2024 09:20:53 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Fetch instead of clone if possible

  375. Deucе
    Tue Feb 06 2024 09:19:05 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And add the rest of the variables.

  376. Deucе
    Tue Feb 06 2024 09:17:49 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    That wasn't the clone job

  377. Deucе
    Tue Feb 06 2024 09:17:15 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Add a script to the clone job

  378. Deucе
    Tue Feb 06 2024 09:07:41 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Try a single clone

  379. Deucе
    Tue Feb 06 2024 08:33:00 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Static libraries without tests don't need xpdev built.

  380. Deucе
    Tue Feb 06 2024 08:20:16 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    XPDev needs to save OBJ too. ciolib and smblib don't need hash and encode to be built.

  381. Deucе
    Tue Feb 06 2024 08:16:03 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    No js testswuite when no js

  382. Deucе
    Tue Feb 06 2024 08:14:55 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Static library targets depend on the objects

  383. Deucе
    Tue Feb 06 2024 08:04:05 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/uifctest.c diff
    We need to include ciolib.h for CIOLIB_main() hackery

  384. Deucе
    Tue Feb 06 2024 07:59:17 GMT-0800 (PST)
    Modified Files:
    

    src/uifc/GNUmakefile diff
    src/uifc/targets.mk diff
    Remove single-threaded library support It didn't work anyway.

  385. Deucе
    Tue Feb 06 2024 07:47:12 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    NetBSD uses system curses

  386. Deucе
    Tue Feb 06 2024 07:43:21 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    src/conio, not src/ciolib

  387. Deucе
    Tue Feb 06 2024 07:40:57 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    No Javascript means no sbbs rule

  388. Deucе
    Tue Feb 06 2024 07:40:14 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Can't impliuctly inherit rules

  389. Deucе
    Tue Feb 06 2024 07:39:15 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    if/changes rules aren't merged

  390. Deucе
    Tue Feb 06 2024 07:37:51 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Try to pull in rules again.

  391. Deucе
    Tue Feb 06 2024 07:28:30 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    And fix noskeeters

  392. Deucе
    Tue Feb 06 2024 07:27:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    No need to extend if it's in here anyway

  393. Deucе
    Tue Feb 06 2024 07:22:42 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    XBDev doesn't require XPDev

  394. Deucе
    Tue Feb 06 2024 07:22:10 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    And () too

  395. Deucе
    Tue Feb 06 2024 07:21:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Interpolate jobs

  396. Deucе
    Tue Feb 06 2024 07:19:36 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Move templates into include

  397. Deucе
    Tue Feb 06 2024 07:15:03 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    Quote variable values

  398. Deucе
    Tue Feb 06 2024 07:09:21 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Quote stuff

  399. Deucе
    Tue Feb 06 2024 07:07:02 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Pluralize

  400. Deucе
    Tue Feb 06 2024 07:06:11 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci-unix.yml diff
    .gitlab-ci.yml diff
    Put spec in included file

  401. Deucе
    Tue Feb 06 2024 07:04:35 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add defaults even for ones that need to be overwritten For the rules still in the main file

  402. Deucе
    Tue Feb 06 2024 07:03:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Set defaults properly

  403. Deucе
    Tue Feb 06 2024 07:00:47 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add spec

  404. Deucе
    Tue Feb 06 2024 06:55:06 GMT-0800 (PST)
    Modified Files:
    

    src/sexpots/GNUmakefile diff
    src/sexpots/objects.mk diff
    Fix mingw32 build

  405. Deucе
    Tue Feb 06 2024 06:55:32 GMT-0800 (PST)
    Added Files:
    

    .gitlab-ci-unix.yml diff
    Modified Files:

    .gitlab-ci.yml diff
    Use a template for "unix" jobs This also splits up the dependencies better

  406. Deucе
    Mon Feb 05 2024 22:39:06 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Package the right files for cryptlib

  407. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 22:27:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    PATH_MAX (not an MSVC thing) -> MAX_PATH

  408. Deucе
    Mon Feb 05 2024 22:26:58 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Fix 3rdp targets

  409. Deucе
    Mon Feb 05 2024 22:26:58 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Move dependency to the right place

  410. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 22:25:46 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Hm... I didn't think setting LD_LIBRARY_PATH would be needed ... but worth a try here

  411. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 22:18:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/jsexec.c diff
    Resolve full path to specified ctrl directory, before chdir If a relative path to the ctrl directory is specified on the command-line or in the SBBSCTRL environment variable, the loading of ctrl/*.ini would fail after the changing of the working directory. We should probably get replace all use of FULLPATH with _fullpath someday, but for now, I just went with majority-rule.

  412. Deucе
    Mon Feb 05 2024 22:03:36 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Build cryptlib in cryptlib target.

  413. Deucе
    Mon Feb 05 2024 22:00:04 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    My layout isn't the same as the git one. :D

  414. Deucе
    Mon Feb 05 2024 21:58:04 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Fix names

  415. Deucе
    Mon Feb 05 2024 21:57:33 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    No named support

  416. Deucе
    Mon Feb 05 2024 21:56:47 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Fix paths

  417. Deucе
    Mon Feb 05 2024 21:56:14 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Colons

  418. Deucе
    Mon Feb 05 2024 21:55:21 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Split out 3rdp libs

  419. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 21:52:09 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Okay, let's try a simple 0 exit code

  420. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 21:45:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Don't change cwd to ctrl dir when running jsexec smoketest

  421. Deucе
    Mon Feb 05 2024 21:40:15 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add tags for js-testsuite too

  422. Deucе
    Mon Feb 05 2024 21:25:12 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Don't depend on build

  423. Deucе
    Mon Feb 05 2024 21:24:23 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Fix depends

  424. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 21:24:03 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Specify the path to the ctrl directory in jsexec smoketest

  425. Deucе
    Mon Feb 05 2024 21:23:21 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add quotes

  426. Deucе
    Mon Feb 05 2024 21:11:06 GMT-0800 (PST)
    Added Files:
    

    exec/tests/crypt/test.crt diff
    Modified Files:

    exec/tests/test.js diff
    Add missing cert, fix up test.js a bit more since we don't have let.

  427. Deucе
    Mon Feb 05 2024 21:22:13 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add js test suite

  428. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 21:06:58 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Okay, we don't want *all* the artifacts That makes the wildcard path/execution fail

  429. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:51:42 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Try bringing .rules into the test to see if that brings in the build jobs into the pipeline

  430. Deucе
    Mon Feb 05 2024 20:42:44 GMT-0800 (PST)
    Added Files:
    

    exec/tests/crypt/cert.js diff
    exec/tests/crypt/cryptcon.js diff
    exec/tests/file/popen.js diff
    exec/tests/global/alert.js diff
    exec/tests/global/beep.js diff
    exec/tests/global/ctrl.js diff
    exec/tests/global/exit.js diff
    exec/tests/global/exit_subproc.sjs diff
    exec/tests/global/file_getname.js diff
    exec/tests/global/load.js diff
    exec/tests/global/load_background.sjs diff
    exec/tests/global/load_define.sjs diff
    exec/tests/global/load_return.sjs diff
    exec/tests/global/log.js diff
    exec/tests/global/mswait.js diff
    exec/tests/global/printf.js diff
    exec/tests/global/random.js diff
    exec/tests/global/sound.js diff
    exec/tests/global/sound.wav diff
    exec/tests/global/time.js diff
    exec/tests/global/write.js diff
    exec/tests/global/writeln.js diff
    exec/tests/global/yield.js diff
    exec/tests/test.js diff
    Since we're doing JS tests, add the JS test suite. Various bits needed to be hacked up a bit since it was written for a newer JS standard, but it's at least 11 better than 42.

  431. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:35:18 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    According to the gitab docs, specifying dependencies shouldn't be necessary "When dependencies is not defined in a job, all jobs in earlier stages are considered dependent and the job fetches all artifacts from those jobs." So... I'm a little stumped why the artifacts aren't be downloaded for this test.

  432. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:23:42 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Fix dependencies should be an array of strings

  433. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:22:05 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Try 'dependencies' keyword instead of 'needs' <shrug> 'smoketest-jsexec-linux' job needs 'sbbs-linux' job, but 'sbbs-linux' is not in any previous stage

  434. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:16:53 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add a needs clause to the jsexec smoketest job jobs in the 'test' stage are supposed to run only after all jobs in the 'build' stage so I don't understand why this would be needed, but I'm getting pipeline failures with it trying to run this test before building anything. Or maybe its something else (no artifacts?).

  435. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:09:00 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Hm... the single-quotes need to be quoted?

  436. Rob Swindell (on Debian Linux)
    Mon Feb 05 2024 20:06:02 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add simple jsexec smoke test (for linux SBBS build) First attempt at adding tests to the CI pipeline

  437. Eric Oulashin
    Mon Feb 05 2024 18:51:48 GMT-0800 (PST)
    Added Files:
    

    xtrn/DDMsgReader/dd_lightbar_menu.js diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Use the P_UTF8 mode bit when writing UTF8 header information so it looks right on UTF-8 terminals. This also includes a dd_lightbar_menu.js update (for the message list).

  438. Rob Swindell
    Mon Feb 05 2024 19:13:28 GMT-0800 (PST)
    Added Files:
    

    xtrn/DDMsgReader/dd_lightbar_menu.js diff
    Modified Files:

    exec/load/dd_lightbar_menu.js diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_headers_utf8' into 'master' DDMsgReader: Use the P_UTF8 mode bit when writing UTF8 header information so it looks right on UTF-8 terminals. This also includes a dd_lightbar_menu.js update (for the message list). See merge request main/sbbs!394

  439. Deucе
    Mon Feb 05 2024 16:45:53 GMT-0800 (PST)
    Modified Files:
    

    exec/fseditor.js diff
    Fix up UTF-8 support enough so Keyop can enter a £. This removes the -utf8 option and stores the line strings as unicode strings if the terminal supports utf8. A shitty inkey() wrapper and a shitty putc() wrapper were added to deal with this.

  440. Deucе
    Mon Feb 05 2024 10:03:20 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Make libcl depend on GNUmakefile This will trigger more builds of libcl, but at least I won't have to make people touch(1) a patch to do a rebuild. As an aside, cleanall.sh doesn't clean 3rdp, no idea if this is intentional or not.

  441. Deucе
    Mon Feb 05 2024 09:57:35 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Redirect stderr to stdout *after* stdout is /dev/null, not before. Should fix the OpenBSD pipeline.

  442. Deucе
    Mon Feb 05 2024 09:05:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Use --libs instead of -libs

  443. Deucе
    Mon Feb 05 2024 09:46:42 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Rejigger the md5 calc a bit

  444. Deucе
    Mon Feb 05 2024 00:33:23 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/js-disable-shell.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Don't build the JS shell. We don't need it (I hope), and it plays fast and loose with the config options so it won't compile with some sets of them, making it hard to troubleshoot stuff.

  445. Deucе
    Mon Feb 05 2024 00:52:49 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/js-no-rwx-pages.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    src/sbbs3/GNUmakefile diff
    Allow RWX pages on NetBSD and OpenBSD. By default, both NetBSD and OpenBSD will not allow pages to be mapped both writable and executable. On OpenBSD, if the filesystem is mounted with the wxallowed option, this would work, and before v6.0, passing -z wxallowed to the linker would allow it on a per-binary basis. However, since this is not the default, and since the JS engine can use mprotect() to switch between RW and RX, I've decided to enable this instead. This will slow things down, but it will work "out of the box". For NetBSD, the situation is different, you can't switch between RW and RX using mprotect()... instead, you need to use mremap() to get a separate mapping for each set of perms. This does *not* appear to be present in the 1.8.5 source, so we can't do the same fix as OpenBSD. Instead, NetBSD allows paxctl to add an elf note indicating that RWX is needed, and it "just works" (by default).

  446. Rob Swindell (on Debian Linux)
    Sun Feb 04 2024 19:46:28 GMT-0800 (PST)
    Modified Files:
    

    exec/newuser.js diff
    Log new user details (name, email address, age, location) to system/daily log Also include email address in sysop notification. Fix issue #711

  447. Rob Swindell (on Windows 11)
    Sun Feb 04 2024 17:21:12 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were I don't recall this actually being a thing, ever, so certainly no reason to be cleaning these files up during logon. <shrug>

  448. Rob Swindell (on Windows 11)
    Sun Feb 04 2024 18:43:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/netmail.cpp diff
    Move temp file cleanup from sbbs_t::logon() to sbbs_t::init() It's possible for a sysop to allow message creation before logon (e.g. a login matrix mode). Eliminate the use of netmail.msg as a temporary message input file (not sure why this has stuck around for so long).

  449. Rob Swindell (on Windows 11)
    Sun Feb 04 2024 16:49:51 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/writemsg.cpp diff
    Add an optional bool argument to sbbs_t::editfile() and JS console.edit_file() ... to not clean (remove) an existing quotes file (which is removed for for security/privacy reasons). This fixes issue #710 for Nightfox, but he'll need to deal with the security issue in that case.

  450. Deucе
    Sun Feb 04 2024 14:13:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    NetBSD doesn't ship with a .pc file for libarchive (which it does ship with) Le Sigh

  451. Deucе
    Sun Feb 04 2024 14:05:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/GNUmakefile diff
    Use pkg-config for libarchive. Fixes OpenBSD build issue.

  452. Deucе
    Sun Feb 04 2024 13:05:14 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add OpenBSD runner to the pipes

  453. Deucе
    Sun Feb 04 2024 01:08:44 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_rtpool.c diff
    Use pthread once for jsrt initializtion. Does not fix the NetBSD issue, but should be done anyway.

  454. Deucе
    Sun Feb 04 2024 00:52:18 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Use md5 when md5sum doesn't exist

  455. Deucе
    Sat Feb 03 2024 22:40:46 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Use system curses for all targets.

  456. Deucе
    Sat Feb 03 2024 22:33:20 GMT-0800 (PST)
    Modified Files:
    

    .gitlab-ci.yml diff
    Add NetBSD builds to the ole pipeline

  457. Deucе
    Sat Feb 03 2024 21:35:02 GMT-0800 (PST)
    Modified Files:
    

    3rdp/build/GNUmakefile diff
    Some patches for NetBSD

  458. Deucе
    Sat Feb 03 2024 21:35:02 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    src/xpdev/xpbeep.c diff
    Fix some NetBSD warnings

  459. Deucе
    Sat Feb 03 2024 21:35:02 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-netbsd-hmac-symbol.patch diff
    3rdp/build/cl-netbsd-no-getfsstat.patch diff
    src/newifc/sizer.c diff
    Modified Files:

    src/newifc/GNUmakefile diff
    src/newifc/alltests.c diff
    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    A bunch of broken NewIfc stuff, but I want to push, so need to commit it. Also, a couple new patches for a previous commit that I apparently hadn't added.

  460. Deucе
    Sat Feb 03 2024 21:35:02 GMT-0800 (PST)
    Modified Files:
    

    src/conio/curs_cio.c diff
    Use getcchar() so we can still use the NetBSD native curses

  461. Eric Oulashin
    Sat Feb 03 2024 12:50:51 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/slyvote/slyvote.js diff
    Digital Distortion mod refactor: Remove use of backslash() (just append a /); use js.exec_dir instead of the old hack to find the startup directory. No functional change.

  462. Rob Swindell
    Sat Feb 03 2024 12:50:51 GMT-0800 (PST)
    Modified Files:
    

    exec/SlyEdit.js diff
    exec/SlyEdit_DCTStuff.js diff
    exec/SlyEdit_IceStuff.js diff
    exec/SlyEdit_Misc.js diff
    xtrn/DDAreaChoosers/DDFileAreaChooser.js diff
    xtrn/DDAreaChoosers/DDMsgAreaChooser.js diff
    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/gttrivia/gttrivia.js diff
    xtrn/slyvote/slyvote.js diff
    Merge branch 'dd_tools_remove_startup_path_hack_and_backslash_function' into 'master' Digital Distortion mod refactor: Remove use of backslash() (just append a /); use js.exec_dir instead of the old hack to find the startup directory. No functional change. See merge request main/sbbs!393

  463. Eric Oulashin
    Fri Feb 02 2024 19:14:50 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    DD file lister: More checks for pFileList[pIdx] and the 'desc' property when getting the description

  464. Rob Swindell
    Fri Feb 02 2024 19:14:50 GMT-0800 (PST)
    Modified Files:
    

    xtrn/ddfilelister/ddfilelister.js diff
    xtrn/ddfilelister/readme.txt diff
    xtrn/ddfilelister/revision_history.txt diff
    Merge branch 'dd_file_lister_file_info_array_list_item_desc_checks' into 'master' DD file lister: More checks for pFileList[pIdx] and the 'desc' property when getting the description See merge request main/sbbs!392

  465. Eric Oulashin
    Fri Feb 02 2024 16:13:18 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Fix for aborting when editing a personal email message due to sub-board code not being available

  466. Rob Swindell
    Fri Feb 02 2024 16:13:18 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'dd_msg_reader_edit_email_msg_abort_fix' into 'master' DDMsgReader: Fix for aborting when editing a personal email message due to sub-board code not being available See merge request main/sbbs!390

  467. Rob Swindell (on Windows 11)
    Fri Feb 02 2024 00:25:17 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/str.cpp diff
    Fix sbbs_t::trashcan(), broken one month ago Transposed the order of parameters in commit 20dbd40c. Oops.

  468. Deucе
    Wed Jan 31 2024 07:10:14 GMT-0800 (PST)
    Modified Files:
    

    src/conio/ciolib.c diff
    src/conio/ciolib.h diff
    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Add ciolib function to convert RGB colours to legacy attribute This should be made palette-aware as well, but since the current consumer doesn't modify the palette, it's good enough for now.

  469. Nigel Reed
    Tue Jan 30 2024 15:52:19 GMT-0800 (PST)
    Modified Files:
    

    exec/user_settings.js diff
    Fix signature using wrong filename

  470. Rob Swindell
    Tue Jan 30 2024 15:52:19 GMT-0800 (PST)
    Modified Files:
    

    exec/user_settings.js diff
    Merge branch 'fix_usersettings_sig' into 'master' Fix signature using wrong filename See merge request main/sbbs!391

  471. Deucе
    Tue Jan 30 2024 11:02:50 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Add alignment and destruction

  472. Deucе
    Tue Jan 30 2024 06:55:46 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/GNUmakefile diff
    Remove internal_macros.h from makefile too

  473. Deucе
    Tue Jan 30 2024 06:54:36 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/label.c diff
    src/newifc/root_window.c diff
    Removed Files:

    src/newifc/internal_macros.h diff
    Remove internal macros, constify better, etc.

  474. Rob Swindell (on Debian Linux)
    Mon Jan 29 2024 22:32:12 GMT-0800 (PST)
    Modified Files:
    

    docs/index.htm diff
    Removed Files:

    docs/dyndns.txt diff
    Remove dyndns.txt, replaced by https://wiki.synchro.net/module:dyndns

  475. Deucе
    Mon Jan 29 2024 20:11:31 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/alltests.c diff
    src/newifc/genapi.c diff
    src/newifc/internal_macros.h diff
    src/newifc/label.c diff
    src/newifc/root_window.c diff
    src/xpdev/threadwrap.c diff
    src/xpdev/threadwrap.h diff
    This can now render the root and labels. Still a bunch more work to do on labels... sizers come next.

  476. Deucе
    Mon Jan 29 2024 16:35:13 GMT-0800 (PST)
    Added Files:
    

    src/newifc/label.c diff
    Modified Files:

    src/newifc/alltests.c diff
    src/newifc/genapi.c diff
    src/newifc/internal_macros.h diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Add the label thing, actually render some stuff.

  477. Deucе
    Mon Jan 29 2024 11:40:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/services.c diff
    Fix apparent session leak in services. It appears that after successful completion of a JS service, the TLS session is never destroyed. If this fix isn't valid for #707, we should see a bunch of "Destroying a session (...) that's not in sess_list" log messages Thanks Keyop!

  478. Deucе
    Mon Jan 29 2024 11:00:26 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/syncterm.c diff
    Don't include rgbmap.h anymore.

  479. Deucе
    Mon Jan 29 2024 10:52:43 GMT-0800 (PST)
    Modified Files:
    

    src/conio/Common.gmake diff
    src/conio/GNUmakefile diff
    src/conio/bitmap_con.c diff
    src/conio/ciolib.c diff
    src/conio/ciolib.h diff
    src/conio/scale.c diff
    src/conio/scale.h diff
    src/conio/vidmodes.c diff
    src/syncterm/syncterm.c diff
    Save disk space at the expense of CPU usage. Previously, we compiled in a RGB -> YCbCr table and used that for scaling, which added 128MB to the size of binaries that enabled non-integer scaling. The decision was then made to eliminated non-integer scaling support from the Synchronet utilities to save disk space. With the use of the YCoCg-R, we can more efficiently transform between the colour spaces, (about 50% more CPU than using the table), so it's no longer prohibitive to do this in real-time. This should also have the effect of making the Synchronet utilities use the correct aspect ratio for the various screen modes rather than forcing the use of square pixels. I expect DigitalMan will hate that.

  480. Deucе
    Mon Jan 29 2024 10:37:23 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/GNUmakefile diff
    src/newifc/genapi.c diff
    src/newifc/root_window.c diff
    More stuff, really just a checkpoint before I start rendering.

  481. Deucе
    Mon Jan 29 2024 10:35:19 GMT-0800 (PST)
    Modified Files:
    

    src/conio/scale.c diff
    src/conio/xbr.c diff
    Use the YCoCg-R colour space instead of YCbCr. It seems to provide similar perceptual results, and is much faster to transform with RGB. It's still slower than the table lookup, but not crushingly so.

  482. Deucе
    Sun Jan 28 2024 19:37:02 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Add fill and aliases... I think this is ready to start drawing things soon now.

  483. Rob Swindell (on Windows 11)
    Sun Jan 28 2024 13:23:14 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgsub.c diff
    Fix signed/unsigned int compare warning in MSVC Fix a typo in help text.

  484. Rob Swindell (on Windows 11)
    Sun Jan 28 2024 13:23:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgmsg.c diff
    Remember/restore the current lightbar position on the Message Options menu

  485. Deucе
    Sat Jan 27 2024 22:42:50 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Focus, hidden, handlers work, etc. Getting design to completion... just need to figure out how to do pre-defined trees of controls, and I should be able to start work on the actual rendering bits.

  486. Rob Swindell (on Debian Linux)
    Sat Jan 27 2024 17:48:11 GMT-0800 (PST)
    Modified Files:
    

    exec/user_settings.js diff
    Fix error with PETSCII_UPPERLOWER use line 445: Error: can't convert PETSCII_UPPERLOWER to an integer reported by Nelgin

  487. Rob Swindell (on Debian Linux)
    Sat Jan 27 2024 14:32:33 GMT-0800 (PST)
    Modified Files:
    

    exec/chksetup.js diff
    An additional conference (Tech Talk) was recently added to DOVE-Net So increase the expected number of subs in DOVE-Net by one.

  488. Deucе
    Sat Jan 27 2024 01:22:23 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Add initial handlers infrastructure

  489. Deucе
    Fri Jan 26 2024 17:10:33 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    src/newifc/root_window.c diff
    Add min_height and min_width, remove the transparent attribute. It's expected that transparency will be handled by special values.

  490. Deucе
    Fri Jan 26 2024 17:00:10 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/GNUmakefile diff
    src/newifc/genapi.c diff
    src/newifc/internal_macros.h diff
    src/newifc/newifc_nongen.c diff
    src/newifc/root_window.c diff
    Use a single return type for API functions.

  491. Deucе
    Fri Jan 26 2024 11:15:51 GMT-0800 (PST)
    Modified Files:
    

    src/build/Common.gmake diff
    Bump std= to c11 since we use _Atomic (a C11 addition) in threadwrap

  492. Deucе
    Fri Jan 26 2024 10:59:30 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/genwrap.h diff
    Eliminate extra semi-colon

  493. Deucе
    Fri Jan 26 2024 00:44:46 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/genapi.c diff
    Just 'cause it's autogenerated doesn't mean it should be ugly.

  494. Deucе
    Fri Jan 26 2024 00:40:22 GMT-0800 (PST)
    Added Files:
    

    src/newifc/newifc_nongen.c diff
    Modified Files:

    src/newifc/genapi.c diff
    src/newifc/root_window.c diff
    Add globals for pos and child pos/size Start hacking on fit-checking code Add NI_walk_children() to call a callback for each child Move functions that have no generated bits into newifv_nongen.c Call the object set/get function for globals to allow range checking

  495. Deucе
    Thu Jan 25 2024 23:12:12 GMT-0800 (PST)
    Modified Files:
    

    src/newifc/root_window.c diff
    Mark function static

  496. Deucе
    Thu Jan 25 2024 22:01:03 GMT-0800 (PST)
    Added Files:
    

    src/cutest/AllTests.c diff
    src/cutest/CuTest.c diff
    src/cutest/CuTest.h diff
    src/cutest/CuTestTest.c diff
    src/cutest/README.txt diff
    src/cutest/index.html diff
    src/cutest/license.txt diff
    src/cutest/make-tests.sh diff
    src/cutest/style.css diff
    src/newifc/GNUmakefile diff
    src/newifc/alltests.c diff
    src/newifc/genapi.c diff
    src/newifc/internal_macros.h diff
    src/newifc/root_window.c diff
    Initial start for NewIfc Basically, the intent is to do a modern (for C) interface which allows reproducing the look and feel of uifc but without hurting as much. The intent is to support a tree of objects, each of which have an attribute get/set function as their main interface. Various callbacks will be supported for various object types, and positioning will be relative to the "child area" of the parent. The SyncTERM main screen is expected to look something like: root +--frame (dialing directory) | +--list +--frame (settings) | +--list +--textinput (comment) Internally, the code is wildly type-unsafe, but there's an auto-generated API (which is the only thing exported) that is type-safe. This also introduces the CuTest C test suite as an experiment.

  497. Rob Swindell (on Windows 11)
    Thu Jan 25 2024 14:07:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    struct declarations don't need the 'struct' keyword in C++

  498. Rob Swindell (on Windows 11)
    Thu Jan 25 2024 20:56:47 GMT-0800 (PST)
    Modified Files:
    

    docs/v320_new.txt diff
    Updates regarding text.ini and @-code formatting

  499. Rob Swindell (on Windows 11)
    Thu Jan 25 2024 12:43:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Make parse() a member function of struct atcode_format Silly me, this is C++, do the C++ thing No functional change.

  500. Rob Swindell (on Windows 11)
    Thu Jan 25 2024 13:42:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/useredit/MainFormUnit.cpp diff
    src/sbbs3/useredit/MainFormUnit.dfm diff
    Add missing ("newer") QWK settings ... and rearranged them to match SCFG->System->New User Values->QWK Message Packet Settings more closely. uedit (the program) should be updated too.

  501. Rob Swindell (on Windows 11)
    Wed Jan 24 2024 20:14:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/js_bbs.cpp diff
    src/sbbs3/sbbs.h diff
    Support (almost) complete @-code formatting through-out the terminal server - bbs.expand_atcodes() now supports formatting (did not before this) - text.dat/ini strings now support @-code formatting (did not before this) (this fixes issue #697) - bbs.atcode() now supports more complete formatting (only supported -R/-L previously) The -W (wide) formatting code is not supported in these cases since that code currently sends UNICODE sequences directly to UTF-8 terminals, when used.

  502. Rob Swindell (on Windows 11)
    Wed Jan 24 2024 20:32:59 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Fix 4-digit bug in separat_thousand() used for 'T' @-code format modifier I noticed while testing the previous commit that 4 digit values weren't thousands-separated, while larger values were. I'm not sure why this non-zero index check was in this loop, but appears to be a bug.

  503. Rob Swindell (on Windows 11)
    Wed Jan 24 2024 20:39:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    Move separate_thousands() to str_util so it can be used elsewhere, later Seems a useful function to have on hand. Especially now that it's "fixed" (will convert "1234" to "1,234").

  504. Rob Swindell (on Windows 11)
    Wed Jan 24 2024 17:56:31 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/data.cpp diff
    src/sbbs3/sbbs.h diff
    Don't store pointer to stack variable in sbbs_t::event_code sbbs_t::gettimeleft() was storing a pointer to a stack (temporary/local) variable containing a copy of the next exclusive event cfg (including its internal code). This variable, including the internal code, is invalid when it goes out of scope. This change makes the sbbs_t::event_code point to the sbbs_t::cfg.event[]->code (on the heap) instead. The only use of this event_code (outside of the event_thread), appears to be in the JS bbs.event_code property string. So this fixes issue #705. No other observed side effect from this bug. Constified getnexteventtime() while here. No functional impact.

  505. Rob Swindell (on Windows 11)
    Tue Jan 23 2024 18:37:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/writemsg.cpp diff
    When editing a message, pass the proper to/from/subj/area to drop file Fixes issue #704 - not just for JS bbs.edit_msg(), but for all uses of the underlying sbbs_t::editmsg() function. Replaced one specific comparison of subnum == INVALID_SUB with call to is_valid_subnum() just to be consistent. No functional change there.

  506. Rob Swindell (on Windows 11)
    Tue Jan 23 2024 12:13:45 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/load_cfg.c diff
    Fix uninitialized cfg.colors[] element usage caught by Deuce (and Clang?) Conditional jump or move depends on uninitialised value(s) at 0x4AE768D: sbbs_t::backfill(char const*, float, int, int) (con_out.cpp:1445) by 0x4AE7855: sbbs_t::progress(char const*, int, int, int) (con_out.cpp:1467) by 0x4AE91A9: ProgressLoadingMsgPtrs(void*, int, int) (data_ovl.cpp:27) by 0x4C7C577: getmsgptrs (userdat.c:3972) by 0x4AE9144: sbbs_t::getmsgptrs() (data_ovl.cpp:39) by 0x4BF9237: sbbs_t::logon() (logon.cpp:452) by 0x4AC1CE2: sbbs_t::answer() (answer.cpp:636) by 0x4C0FD37: node_thread(void*) (main.cpp:4277) Introduced in commit 48e7520e (when colors was converted from a byte array to a uint array), we weren't memsetting the right number of bytes. Since color is not an array of ints (not bytes), memset (of non-zero values) isn't really the right initialization approach anyway. Now using a for-loop.

  507. Rob Swindell (on Windows 11)
    Mon Jan 22 2024 19:40:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Friendly cryptlib version check failure handling <Deuce> Feel free to not lock the mutex and never free/NULLify that string. <Deuce> Should be nicer for people with separate logs, and a few bytes never hurt anyone.

  508. Rob Swindell (on Windows 11)
    Mon Jan 22 2024 19:40:20 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/mailsrvr.c diff
    If cryptInit() fails, just disable TLS support But continue initializing/running for other non-TLS protocol support.

  509. Deucе
    Mon Jan 22 2024 18:23:58 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Actually, no real reason to close the socket here... let the caller handler it.

  510. Deucе
    Mon Jan 22 2024 18:20:22 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Set client_socket to INVALID_SOCKET after closing.

  511. Rob Swindell (on Windows 11)
    Mon Jan 22 2024 17:40:52 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    Latest patched cryptlib 3.4.7 built with MSVC2022

  512. Rob Swindell (on Windows 11)
    Mon Jan 22 2024 17:41:27 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/AboutBoxFormUnit.cpp diff
    Update copyright date for Cryptlib (apparently, 2022)

  513. Rob Swindell (on Windows 11)
    Mon Jan 22 2024 17:43:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Log the socket descriptor and protocol when getsockname() fails This is a new error that just started cropping up. I suspect it's related to recent SSH changes. This might help a little with context, when it happens again.

  514. Deucе
    Mon Jan 22 2024 16:24:37 GMT-0800 (PST)
    Removed Files:
    

    3rdp/build/random_exit.patch diff
    Remove obsolete patch

  515. Deucе
    Mon Jan 22 2024 14:56:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Mutex-protect access to cryptfail. Totally not sketchy, trust me.

  516. Deucе
    Mon Jan 22 2024 14:34:09 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-add-patches-info.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-do-debug.patch diff
    src/sbbs3/ssl.c diff
    Add cryptlib version check to do_cryptInit() Interestingly, when they fail, Synchronet appears to crash. This is fine.

  517. Rob Swindell (on Windows 11)
    Sun Jan 21 2024 21:46:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/main.cpp diff
    Resolve server_abbrev conflict between terminal and FTP servers These should've been static to begin with, like the other servers. Explains why FTP error message are with "term" as the server.

  518. Deucе
    Sun Jan 21 2024 19:36:46 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-handle-unsupported-pubkey.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    If we receive an auth attempt with an unsupported public key type (such as ec22519), unconditionally fallback to password auth instead of the previous behaviour of diconnecting. Much of the "password then pubkey" mentality is showing in these bits of Cryptlib.

  519. Rob Swindell (on Windows 11)
    Sun Jan 21 2024 15:01:57 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_global.c diff
    Clarify JSDOC kibibytes versus kilobytes

  520. Rob Swindell (on Windows 11)
    Sun Jan 21 2024 15:01:57 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_console.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/writemsg.cpp diff
    Allow override of parameters to console.editfile() For Nightfox and his newsgroup reader thing: The strings that end up in the editor drop file (e.g. MSGINF) can now be passed as optional arguments to consol.editfile() and the underlying C++ API. Allow maxlines (default:10000) to be overridden with an optional consol.editfile() argument too.

  521. Deucе
    Sun Jan 21 2024 14:28:08 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Set size to MAX_PATH+1 when allocating. On Win32, size is explcitly "ignored" when target is NULL, so we should set it to the size of the allocation.

  522. Rob Swindell (on Debian Linux)
    Sun Jan 21 2024 13:48:01 GMT-0800 (PST)
    Modified Files:
    

    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    Latest patched cryptlib 3.4.7 for Windows, built with MSVC++2022

  523. Deucе
    Sun Jan 21 2024 12:15:47 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    More remote closing connection fixups.

  524. Deucе
    Sun Jan 21 2024 12:11:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Fix pubkey-first auth attempts. Previously, once a pubkey was attempted, you could not use a password.

  525. Deucе
    Sun Jan 21 2024 10:49:46 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-double-delete-fine-on-close.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    Fix an assertion in debug builds... When we're closing the socket, always delete channels and don't wait for the remote to confirm.

  526. Deucе
    Sun Jan 21 2024 10:46:11 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    If we get a pop error, and there is no channel, we're done.

  527. Deucе
    Sun Jan 21 2024 10:03:18 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/websrvr.c diff
    CRYPT_TLSOPTION_DISABLE_CERTVERIFY is not valid for servers

  528. Deucе
    Sun Jan 21 2024 09:53:39 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Check sftp_state before ending. Fixes assertion failure on hangup from SSH.

  529. Deucе
    Sun Jan 21 2024 01:24:01 GMT-0800 (PST)
    Modified Files:
    

    src/syncterm/ssh.c diff
    Fix up handling of lost connections. Was spinning at 100% CPU on a lost connection if sftp was active.

  530. Rob Swindell (on Windows 11)
    Sun Jan 21 2024 01:18:05 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.h diff
    src/comio/comio_nix.c diff
    Comment/header block clean-up (e.g. remove CVS references)

  531. Rob Swindell (on Windows 11)
    Sun Jan 21 2024 01:20:06 GMT-0800 (PST)
    Modified Files:
    

    src/comio/comio.h diff
    src/comio/comio_nix.c diff
    src/comio/comio_win32.c diff
    BOOL->bool conversion

  532. Rob Swindell (on Debian Linux)
    Sun Jan 21 2024 01:12:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Address GCC warning in SSH code 328:25: warning: ‘pubkey’ may be used uninitialized

  533. Rob Swindell (on Windows 11)
    Sat Jan 20 2024 23:35:40 GMT-0800 (PST)
    Modified Files:
    

    ctrl/sbbs.ini diff
    Set default value for SSHConnectTimeout

  534. Eric Oulashin
    Sat Jan 20 2024 23:07:40 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.cfg diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    DDMsgReader: Changed rescan hotkey for the indexed menu to Ctrl-R, since Ctrl-S won't work for Wyse terminals (Ctrl-S is for xon/xoff toggling and can't be changed)

  535. Rob Swindell
    Sat Jan 20 2024 23:07:40 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.cfg diff
    xtrn/DDMsgReader/DDMsgReader.js diff
    Merge branch 'ddmr_rescan_sub_boards_hotkey_change_ctrl_R' into 'master' DDMsgReader: Changed rescan hotkey for the indexed menu to Ctrl-R, since Ctrl-S won't work for Wyse terminals (Ctrl-S is for xon/xoff toggling and can't be changed) See merge request main/sbbs!389

  536. Deucе
    Sat Jan 20 2024 22:42:47 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Actually fix warning reported by nelgin.

  537. Deucе
    Sat Jan 20 2024 22:41:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Fix warning reported by nelgin.

  538. Deucе
    Sat Jan 20 2024 22:32:21 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_socket.c diff
    src/sbbs3/js_socket.h diff
    src/sbbs3/services.c diff
    Set the minimum TLS version for the FTP server and TLS services to TLS 1.2. For static services and JS sockets, add a new tls_minver socket property which can be set to use a lower minver (down to the wildly insecure TLS 1.0). TLS 1.0 and 1.1 have been not reccomended since 2015, and deprecated since 2021.

  539. Deucе
    Sat Jan 20 2024 22:15:23 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-Dynamic-linked-static-lib.patch diff
    3rdp/build/cl-SSL-fix.patch diff
    3rdp/build/cl-allow-servercheck-pubkeys.patch diff
    3rdp/build/cl-allow-ssh-2.0-go.patch diff
    3rdp/build/cl-fix-test-select.patch diff
    3rdp/build/cl-make-channels-work.patch diff
    3rdp/build/cl-no-pie.patch diff
    3rdp/build/cl-no-testobjs.patch diff
    3rdp/build/cl-pass-after-pubkey.patch diff
    3rdp/build/cl-read-timeout-every-time.patch diff
    3rdp/build/cl-terminal-params.patch diff
    3rdp/build/cl-thats-not-asm.patch diff
    3rdp/build/cl-use-tls-1.3.patch diff
    3rdp/build/cl-vt-lt-2005-always-defined.patch diff
    3rdp/build/cl-win32-lean-and-mean.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-PAM-noprompts.patch diff
    3rdp/build/cl-add-pubkey-attribute.patch diff
    3rdp/build/cl-allow-none-auth.patch diff
    3rdp/build/cl-allow-pkcs12.patch diff
    3rdp/build/cl-allow-ssh-auth-retries.patch diff
    3rdp/build/cl-clear-GCM-flag.patch diff
    3rdp/build/cl-do-debug.patch diff
    3rdp/build/cl-endian.patch diff
    3rdp/build/cl-fix-ssh-channel-close.patch diff
    3rdp/build/cl-no-odbc.patch diff
    3rdp/build/cl-no-safe-stack.patch diff
    3rdp/build/cl-no-tpm.patch diff
    3rdp/build/cl-noasm-defines.patch diff
    3rdp/build/cl-poll-not-select.patch diff
    3rdp/build/cl-posix-me-gently.patch diff
    3rdp/build/cl-prefer-ECC-harder.patch diff
    3rdp/build/cl-remove-march.patch diff
    3rdp/build/cl-server-term-support.patch diff
    3rdp/build/cl-ssh-list-ctr-modes.patch diff
    3rdp/build/cl-ssl-suite-blocksizes.patch diff
    3rdp/build/cl-vcxproj.patch diff
    3rdp/build/cl-zz-country.patch diff
    3rdp/dist/cryptlib.zip diff
    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/bin/cl32.lib diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    src/conio/SDL_win32_main.c diff
    src/conio/win32cio.c diff
    src/conio/win32gdi.c diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_socket.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/sbbs.version diff
    src/sbbs3/services.c diff
    src/sbbs3/ssl.c diff
    src/sbbs3/ssl.h diff
    src/sbbs3/websrvr.c diff
    src/syncterm/bbslist.c diff
    src/syncterm/bbslist.h diff
    src/syncterm/ssh.c diff
    src/uifc/uifc32.c diff
    src/xpdev/dirwrap.c diff
    src/xpdev/xp_dl.h diff
    src/xpdev/xpbeep.c diff
    Removed Files:

    3rdp/build/cl-DH-key-init.patch diff
    3rdp/build/cl-bn_div.patch diff
    3rdp/build/cl-bn_div2.patch diff
    3rdp/build/cl-check-before-use.patch diff
    3rdp/build/cl-check-cert-dont-modify.patch diff
    3rdp/build/cl-cryptodev.patch diff
    3rdp/build/cl-fix-ECC-RSA.patch diff
    3rdp/build/cl-gcc-non-const-time-val.patch diff
    3rdp/build/cl-getseed64.patch diff
    3rdp/build/cl-learn-numbers.patch diff
    3rdp/build/cl-linux-yield.patch diff
    3rdp/build/cl-more-RSA-ECC-fixes.patch diff
    3rdp/build/cl-no-RSA-suites.patch diff
    3rdp/build/cl-pthread_yield.patch diff
    3rdp/build/cl-random-openbsd.patch diff
    3rdp/build/cl-select-fix.patch diff
    3rdp/build/cl-short-client-name.patch diff
    3rdp/build/cl-ssh-incCtr.patch diff
    3rdp/build/cl-suites.patch diff
    3rdp/build/cl-tls-psk-userfix.patch diff
    3rdp/build/cl-tpm-linux.patch diff
    3rdp/build/cl-uint64_t-redefine.patch diff
    3rdp/build/cl-win32-compile.patch diff
    3rdp/build/cl-win32-compile2.patch diff
    Update cryptlib to 3.4.7

  540. Rob Swindell
    Sat Jan 20 2024 22:15:23 GMT-0800 (PST)
    Added Files:
    

    3rdp/build/cl-Dynamic-linked-static-lib.patch diff
    3rdp/build/cl-SSL-fix.patch diff
    3rdp/build/cl-allow-servercheck-pubkeys.patch diff
    3rdp/build/cl-allow-ssh-2.0-go.patch diff
    3rdp/build/cl-fix-test-select.patch diff
    3rdp/build/cl-make-channels-work.patch diff
    3rdp/build/cl-no-pie.patch diff
    3rdp/build/cl-no-testobjs.patch diff
    3rdp/build/cl-pass-after-pubkey.patch diff
    3rdp/build/cl-read-timeout-every-time.patch diff
    3rdp/build/cl-terminal-params.patch diff
    3rdp/build/cl-thats-not-asm.patch diff
    3rdp/build/cl-use-tls-1.3.patch diff
    3rdp/build/cl-vt-lt-2005-always-defined.patch diff
    3rdp/build/cl-win32-lean-and-mean.patch diff
    Modified Files:

    3rdp/build/GNUmakefile diff
    3rdp/build/cl-PAM-noprompts.patch diff
    3rdp/build/cl-add-pubkey-attribute.patch diff
    3rdp/build/cl-allow-none-auth.patch diff
    3rdp/build/cl-allow-pkcs12.patch diff
    3rdp/build/cl-allow-ssh-auth-retries.patch diff
    3rdp/build/cl-clear-GCM-flag.patch diff
    3rdp/build/cl-do-debug.patch diff
    3rdp/build/cl-endian.patch diff
    3rdp/build/cl-fix-ssh-channel-close.patch diff
    3rdp/build/cl-no-odbc.patch diff
    3rdp/build/cl-no-safe-stack.patch diff
    3rdp/build/cl-no-tpm.patch diff
    3rdp/build/cl-noasm-defines.patch diff
    3rdp/build/cl-poll-not-select.patch diff
    3rdp/build/cl-posix-me-gently.patch diff
    3rdp/build/cl-prefer-ECC-harder.patch diff
    3rdp/build/cl-remove-march.patch diff
    3rdp/build/cl-server-term-support.patch diff
    3rdp/build/cl-ssh-list-ctr-modes.patch diff
    3rdp/build/cl-ssl-suite-blocksizes.patch diff
    3rdp/build/cl-vcxproj.patch diff
    3rdp/build/cl-zz-country.patch diff
    3rdp/dist/cryptlib.zip diff
    3rdp/win32.release/cryptlib/bin/cl32.dll diff
    3rdp/win32.release/cryptlib/bin/cl32.lib diff
    3rdp/win32.release/cryptlib/include/cryptlib.h diff
    src/conio/SDL_win32_main.c diff
    src/conio/win32cio.c diff
    src/conio/win32gdi.c diff
    src/sbbs3/answer.cpp diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_socket.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/sbbs.version diff
    src/sbbs3/services.c diff
    src/sbbs3/ssl.c diff
    src/sbbs3/ssl.h diff
    src/sbbs3/websrvr.c diff
    src/syncterm/bbslist.c diff
    src/syncterm/bbslist.h diff
    src/syncterm/ssh.c diff
    src/uifc/uifc32.c diff
    src/xpdev/dirwrap.c diff
    src/xpdev/xp_dl.h diff
    src/xpdev/xpbeep.c diff
    Removed Files:

    3rdp/build/cl-DH-key-init.patch diff
    3rdp/build/cl-bn_div.patch diff
    3rdp/build/cl-bn_div2.patch diff
    3rdp/build/cl-check-before-use.patch diff
    3rdp/build/cl-check-cert-dont-modify.patch diff
    3rdp/build/cl-cryptodev.patch diff
    3rdp/build/cl-fix-ECC-RSA.patch diff
    3rdp/build/cl-gcc-non-const-time-val.patch diff
    3rdp/build/cl-getseed64.patch diff
    3rdp/build/cl-learn-numbers.patch diff
    3rdp/build/cl-linux-yield.patch diff
    3rdp/build/cl-more-RSA-ECC-fixes.patch diff
    3rdp/build/cl-no-RSA-suites.patch diff
    3rdp/build/cl-pthread_yield.patch diff
    3rdp/build/cl-random-openbsd.patch diff
    3rdp/build/cl-select-fix.patch diff
    3rdp/build/cl-short-client-name.patch diff
    3rdp/build/cl-ssh-incCtr.patch diff
    3rdp/build/cl-suites.patch diff
    3rdp/build/cl-tls-psk-userfix.patch diff
    3rdp/build/cl-tpm-linux.patch diff
    3rdp/build/cl-uint64_t-redefine.patch diff
    3rdp/build/cl-win32-compile.patch diff
    3rdp/build/cl-win32-compile2.patch diff
    Merge branch 'cryptlib-3.4.7' into 'master' Update cryptlib to 3.4.7 See merge request main/sbbs!388

  541. Deucе
    Sat Jan 20 2024 21:19:44 GMT-0800 (PST)
    Added Files:
    

    src/sftp/sftp_server.c diff
    src/sftp/sftp_static.h diff
    Modified Files:

    src/sftp/objects.mk diff
    src/sftp/sftp.h diff
    src/sftp/sftp.vcxproj diff
    src/sftp/sftp_attr.c diff
    src/sftp/sftp_client.c diff
    src/sftp/sftp_pkt.c diff
    Start working on the SFTP server code. The server is a lot thinner, with callbacks for each operation.

  542. Deucе
    Sat Jan 20 2024 21:19:44 GMT-0800 (PST)
    Modified Files:
    

    src/sftp/sftp.h diff
    src/sftp/sftp_server.c diff
    Do not allow NULs in paths. Even on filesystems where you can do it, you shouldn't. Stop it.

  543. Rob Swindell
    Sat Jan 20 2024 20:20:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Remove unnecessary call to DuplicateHandle() in Win32 builds of sbbs_t::init() The client_socket_dup is overwritten after with the return value of accept(), so this was likely a socket/handle leak (since commit 74470573, 17 years ago). Noticed this only after logging a new error in an SSH connection when this call to DuplicateHandle() failed for some reason (WinError 6), but it seems like it's been redundant code for a long time now. So just ace it and possibly fix a resource leak.

  544. Eric Oulashin
    Sat Jan 20 2024 15:40:52 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMsgReader: Updated behavior for indexed menu R (mark all read) when doing a newscan. Ctrl-S does scan refresh in indexed menu. New R "snap-to" option for the indexed menu. Also, command-line options for forcing use of the indexed mode menu when doing a

  545. Rob Swindell
    Sat Jan 20 2024 15:40:52 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'ddmr_indexed_mode_mark_all_read_updates_and_newscan_force_indexed_menu_opts' into 'master' DDMsgReader: Updated behavior for indexed menu R (mark all read) when doing a newscan. Ctrl-S does scan refresh in indexed menu. New R "snap-to" option for the indexed menu. Also, command-line options for forcing use of the indexed mode menu when doing a See merge request main/sbbs!387

  546. Rob Swindell (on Windows 11)
    Sat Jan 20 2024 14:41:57 GMT-0800 (PST)
    Modified Files:
    

    CONTRIBUTING.md diff
    Add C/C++ coding guidelines re boolean and long int types

  547. Rob Swindell (on Windows 11)
    Sat Jan 20 2024 14:29:07 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/dirwrap.c diff
    Fix disksize/space functions for Win32 Broken 11 months ago with commit ae44ab15: the unit argument was ignored (e.g. converting to kibibytes) and the free/total disk size/space checks were reversed. Reported by Max (WESTLINE) via usage of JS properties: system.freediskspace and system.freediskspacek. The JS global functions dir_freespace() and disk_size() were also broken due to this bug.

  548. Rob Swindell (on Windows 11)
    Sat Jan 20 2024 13:23:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/pack_rep.cpp diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfgsave.c diff
    Fix Clang warning reported by Deuce scfgnet.c:1463:25: warning: result of comparison of constant 100000 with expression of type 'uint16_t' (aka 'unsigned short') is always true

  549. Rob Swindell (on Windows 11)
    Sat Jan 20 2024 13:25:43 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.h diff
    Lower the typo to code ratio This fixes ssl.c build for Windows

  550. Deucе
    Sat Jan 20 2024 11:20:03 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.h diff
    Support Windows too I guess.

  551. Deucе
    Sat Jan 20 2024 10:33:10 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    src/xpdev/rwlockwrap.h diff
    Add an ignored version of rwlock_destroy() for use when it there's really no useful way to recover from failure.

  552. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 23:14:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/jsdoor.c diff
    Fix JSDoor build error, broken in BOOL->bool conversion

  553. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 23:10:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbs.h diff
    src/sbbs3/str.cpp diff
    Can't use enum as last arg before varargs apparently This should fix the Clang warning that Deuce reported: str.cpp:131:18: warning: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior

  554. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 22:23:21 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/conwrap.c diff
    src/xpdev/cp437defs.h diff
    src/xpdev/dat_file.h diff
    src/xpdev/gen_defs.h diff
    src/xpdev/haproxy.h diff
    src/xpdev/petdefs.h diff
    src/xpdev/unicode.h diff
    src/xpdev/unicode_defs.h diff
    De-cruft comment headers (e.g. removing CVS references)

  555. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 22:47:24 GMT-0800 (PST)
    Modified Files:
    

    src/conio/cterm.c diff
    src/encode/utf8.c diff
    src/encode/utf8.h diff
    src/sbbs3/ansiterm.cpp diff
    src/sbbs3/bat_xfer.cpp diff
    src/sbbs3/ctrl/MainFormUnit.cpp diff
    src/sbbs3/ctrl/MainFormUnit.h diff
    src/sbbs3/execnet.cpp diff
    src/sbbs3/file.cpp diff
    src/sbbs3/filedat.h diff
    src/sbbs3/findstr.c diff
    src/sbbs3/findstr.h diff
    src/sbbs3/fixsmb.c diff
    src/sbbs3/getctrl.c diff
    src/sbbs3/getctrl.h diff
    src/sbbs3/getmail.c diff
    src/sbbs3/getmail.h diff
    src/sbbs3/getstats.c diff
    src/sbbs3/getstats.h diff
    src/sbbs3/ident.c diff
    src/sbbs3/ident.h diff
    src/sbbs3/js_archive.c diff
    src/sbbs3/js_file.c diff
    src/sbbs3/js_filebase.c diff
    src/sbbs3/js_global.c diff
    src/sbbs3/js_internal.c diff
    src/sbbs3/js_msg_area.c diff
    src/sbbs3/js_msgbase.c diff
    src/sbbs3/js_queue.c diff
    src/sbbs3/js_socket.c diff
    src/sbbs3/js_user.c diff
    src/sbbs3/jsexec.c diff
    src/sbbs3/load_cfg.c diff
    src/sbbs3/load_cfg.h diff
    src/sbbs3/logfile.cpp diff
    src/sbbs3/mailsrvr.h diff
    src/sbbs3/main.cpp diff
    src/sbbs3/mime.c diff
    src/sbbs3/mime.h diff
    src/sbbs3/mqtt.c diff
    src/sbbs3/mqtt.h diff
    src/sbbs3/msg_id.c diff
    src/sbbs3/msg_id.h diff
    src/sbbs3/netmail.cpp diff
    src/sbbs3/newuser.cpp diff
    src/sbbs3/node.c diff
    src/sbbs3/nopen.c diff
    src/sbbs3/nopen.h diff
    src/sbbs3/ntsvcs.c diff
    src/sbbs3/pktdump.c diff
    src/sbbs3/sauce.h diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/sbbs_ini.c diff
    src/sbbs3/sbbs_ini.h diff
    src/sbbs3/sbbscon.c diff
    src/sbbs3/sbbsecho.h diff
    src/sbbs3/scfg/scfg.c diff
    src/sbbs3/scfg/scfg.h diff
    src/sbbs3/scfg/scfgsrvr.c diff
    src/sbbs3/scfgdefs.h diff
    src/sbbs3/scfglib.h diff
    src/sbbs3/scfglib1.c diff
    src/sbbs3/scfglib2.c diff
    src/sbbs3/scfgsave.c diff
    src/sbbs3/scfgsave.h diff
    src/sbbs3/services.c diff
    src/sbbs3/slog.c diff
    src/sbbs3/ssl.h diff
    src/sbbs3/startup.h diff
    src/sbbs3/str_util.c diff
    src/sbbs3/str_util.h diff
    src/sbbs3/telnet.c diff
    src/sbbs3/telnet.h diff
    src/sbbs3/trash.c diff
    src/sbbs3/trash.h diff
    src/sbbs3/umonitor/spyon.c diff
    src/sbbs3/userdat.c diff
    src/sbbs3/userdat.h diff
    src/sbbs3/websrvr.c diff
    src/sbbs3/websrvr.h diff
    src/sbbs3/xtrn.cpp diff
    src/sftp/sftp.h diff
    src/smblib/smbadd.c diff
    src/smblib/smballoc.c diff
    src/smblib/smbdefs.h diff
    src/smblib/smbhash.c diff
    src/smblib/smblib.c diff
    src/smblib/smblib.h diff
    src/smblib/smbtxt.c diff
    src/xpdev/dat_file.c diff
    src/xpdev/dat_file.h diff
    src/xpdev/dirwrap.c diff
    src/xpdev/dirwrap.h diff
    src/xpdev/gen_defs.h diff
    src/xpdev/genwrap.c diff
    src/xpdev/genwrap.h diff
    src/xpdev/ini_file.c diff
    src/xpdev/ini_file.h diff
    src/xpdev/link_list.c diff
    src/xpdev/link_list.h diff
    src/xpdev/msg_queue.c diff
    src/xpdev/msg_queue.h diff
    src/xpdev/multisock.c diff
    src/xpdev/multisock.h diff
    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    src/xpdev/semfile.c diff
    src/xpdev/semfile.h diff
    src/xpdev/sockwrap.c diff
    src/xpdev/sockwrap.h diff
    src/xpdev/str_list.c diff
    src/xpdev/str_list.h diff
    src/xpdev/threadwrap.c diff
    src/xpdev/threadwrap.h diff
    src/xpdev/xpbeep.c diff
    src/xpdev/xpbeep.h diff
    src/xpdev/xpdatetime.c diff
    src/xpdev/xpdatetime.h diff
    The great BOOL->bool conversion in xpdev Still using BOOL where we need Win32 API compatibility. Using JSBool instead of BOOL or bool where it matters. Changed most relevant TRUE/FALSE to true/false too (though it's not as critical). You shouldn't need to #include <stdbool.h> anywhere now - gen_defs.h should do that automatically/correctly based on the language/version/tool. In C23, stdbool.h isn't even needed for bool/true/false definitions (they're keywords), so we don't bother including stdbool.h in that case. Microsoft didn't define __STDC_VERSION__ in their older tool chains (even though they were C99 compatible and had stdbool.h), so we use a _MSC_VER check to know that there's a stdbool.h we should use in that case. For other/old compilers (e.g. Borland C) we #define bool/true/false following the pattern of stdbool.h (doesn't use a typedef). I didn't convert UIFC yet. This addresses issue #698

  556. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 22:47:43 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/msdirent.h diff
    Header comment cleanup

  557. Deucе
    Fri Jan 19 2024 21:19:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    Only tls servers should call destroy_session() TLS clients don't (currently) add a certificate, so there's no need to delete it.

  558. Deucе
    Fri Jan 19 2024 21:15:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/js_socket.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/services.c diff
    src/sbbs3/websrvr.c diff
    Don't call destroy_session() until after add_private_key() Use cryptDestroySession() instead.

  559. Deucе
    Fri Jan 19 2024 20:43:19 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/js_socket.c diff
    Ugh, spaces instead of tabs... so gross.

  560. Deucе
    Fri Jan 19 2024 16:44:00 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Have get_sess_list_entry() verify the correct epoch With this, it's not strictly necessary to clear cert_list in ssl_sync() when the certificate changes, but it's still a good idea to prevent unusable memory from being held onto.

  561. Deucе
    Fri Jan 19 2024 16:49:09 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    May as well make sure internal_do_cryptInit() actually works.

  562. Rob Swindell (on Debian Linux)
    Fri Jan 19 2024 16:29:41 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Fix GCC warnings warning: value computed is not used

  563. Deucе
    Fri Jan 19 2024 16:21:10 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Clean up and push down locks. Now each lock has an easily understandable purpose, and covers the lowest possible amount of code.

  564. Deucе
    Fri Jan 19 2024 13:26:10 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/GNUmakefile diff
    src/xpdev/targets.mk diff
    Borland make doesn't support order-only dependencies.

  565. Rob Swindell (on Windows 11)
    Fri Jan 19 2024 12:23:26 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Remove unused local variable

  566. Deucе
    Fri Jan 19 2024 12:09:35 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Use new rwlock for ssl certificate.

  567. Rob Swindell
    Fri Jan 19 2024 12:09:36 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Merge branch 'use-rwlock' into 'master' Use new rwlock for ssl certificate. See merge request main/sbbs!386

  568. Deucе
    Thu Jan 18 2024 17:00:33 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/GNUmakefile diff
    Add test to end of rwlock

  569. Deucе
    Thu Jan 18 2024 17:03:13 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    Add a pair of condition variables to help avoid spinning. Instead of tight loops with 1ms Sleep()s in them, add events for zero readers and zero writers that we can wait for instead. Unfortunately, since Events aren't interlocked with a critical section like condition variables are with mutexes in pthreads, we can't rely on this for race-free code, so for read locks, we still may spin under write pressure.

  570. Deucе
    Thu Jan 18 2024 16:34:41 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/wraptest.c diff
    Add test to end of rwlock

  571. Deucе
    Thu Jan 18 2024 15:27:01 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Fix rwlocks for Win32 Various bits of broken no longer broken.

  572. Deucе
    Thu Jan 18 2024 14:17:50 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    Fix typo destory -> destroy

  573. Deucе
    Thu Jan 18 2024 09:53:39 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    Re-enable rwlocks for Borland. Since we can't bool anyway, may as well.

  574. Deucе
    Thu Jan 18 2024 09:20:02 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/wraptest.c diff
    Ensure recursive rdlock()s don't deadlock.

  575. Deucе
    Thu Jan 18 2024 09:14:00 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    src/xpdev/wraptest.c diff
    Fix rwlock_unlock() and rwlock_rdlock() recursion. It would be nice to use TLS for the recusrion counter, but on Windows, it looks like TLS in threads created after the object is created is uninitialized, so we would need some kind of thread start hook thingie which just seems like too much work. Instead, rely on the old standby single-linked list to track.

  576. Deucе
    Thu Jan 18 2024 01:18:14 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/sbbs3/ssl.c diff
    src/sftp/sftp_client.c diff
    Don't give names to events. It looks like Windows actually uses the name for matching existing events, so if two events have the same name, they end up being the same object.

  577. Deucе
    Thu Jan 18 2024 00:56:42 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Fix bug (not screaming) in last commit.

  578. Deucе
    Thu Jan 18 2024 00:55:27 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Add return for rwlock_init() windows wrapper.

  579. Deucе
    Thu Jan 18 2024 00:54:35 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Remove some cruft.

  580. Deucе
    Thu Jan 18 2024 00:52:08 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/xpdev_mt.vcxproj diff
    Slip rwlockwrap into vcxproj

  581. Deucе
    Thu Jan 18 2024 00:50:31 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Fix rwlock init

  582. Deucе
    Thu Jan 18 2024 00:48:32 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    Right, xpdev needs to scream BOOL, TRUE and FALSE.

  583. Deucе
    Thu Jan 18 2024 00:44:36 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.h diff
    Include stdbool.h for MingW32

  584. Deucе
    Thu Jan 18 2024 00:40:27 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    Don't do anything (including error) for Borland C

  585. Deucе
    Thu Jan 18 2024 00:37:24 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    src/xpdev/rwlockwrap.h diff
    I guess Win32 still doesn't have stdbool.h

  586. Deucе
    Thu Jan 18 2024 00:35:46 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    We need windows.h, get it from gen_defs.h

  587. Deucе
    Thu Jan 18 2024 00:33:44 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/rwlockwrap.c diff
    Half-assed error handling for unbalanced lock/unlock

  588. Deucе
    Thu Jan 18 2024 00:32:21 GMT-0800 (PST)
    Added Files:
    

    src/xpdev/rwlockwrap.c diff
    Modified Files:

    src/xpdev/objects.mk diff
    src/xpdev/rwlockwrap.h diff
    src/xpdev/wraptest.c diff
    Add rwlock wrappers. Recursive read locks, non-recursive write locks.

  589. Deucе
    Wed Jan 17 2024 22:40:55 GMT-0800 (PST)
    Added Files:
    

    src/xpdev/rwlockwrap.h diff
    Modified Files:

    src/xpdev/targets.mk diff
    src/xpdev/wraptest.c diff
    Add test for rwlocks Currently the "wrapper" is just the POSIX API. We may not need the pthread_rwlock_timed??lock() functions, and even if we do, we like want a different wrapper that takes a ms timeout instead of an absolute time.

  590. Deucе
    Wed Jan 17 2024 18:02:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    src/xpdev/xpevent.c diff
    src/xpdev/xpevent.h diff
    Make CerateEvent() prototype on *nix compatible with Win32 On Win32, the name param is an LPCSTR which apparently is Microsoft talk for const char *. In C we're allowed to do whatever we want, but in C++, this matters more.

  591. Deucе
    Wed Jan 17 2024 17:37:23 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    Whoops, missed this bit. Just running git commit --amend doesn't do -a it seems. :)

  592. Deucе
    Wed Jan 17 2024 17:36:42 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/answer.cpp diff
    src/sbbs3/main.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/ssl.c diff
    Move SSH authentication into answer() This should fix a long-standing issue where someone could connect to the SSH port and do nothing, which would prevent other incoming terminal sessions from being accepted until it times out. Unfortunately, this means that Synchronet can't send any data until authentication is completed, which means useful messages about why you're being disconnected (ie: "Sorry, all terminal nodes are in use or otherwise unavailable.") as well as usless information nobody ever cares about (ie: The IP you're connecting from, that it is resolving your hostname, etc). can no longer be sent to the user.

  593. Rob Swindell (on Windows 11)
    Wed Jan 17 2024 13:31:16 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    second part of commit 0b1b1a6f

  594. Rob Swindell (on Windows 11)
    Tue Jan 16 2024 15:38:32 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/services.c diff
    src/sbbs3/websrvr.c diff
    Fix issue with "Pause Logging" buttons not staying pressed in sbbsctrl-win32 Reported by Max (WESTLINE)... Introduced in commit 63d0772d, since we are now calling the set_state() callback periodically, and in sbbsctrl, it sets/resets the pause button checked (depressed) state in response to this callback (should it?), this was resetting the pause button checked/depressed state peridically (at the configured sem file check interval, default 2 seconds). The fix: if the new server state is the same as the previously set server state, don't call the set_state() callback. I considered this as a potential optimization when I first wrote that commit, but didn't see any obvious downside to calling the set_state() callback redundantly. Now that I see a downside, let's implement this saving/checking of the state to avoid redundant "set" calls.

  595. Rob Swindell (on Windows 11)
    Mon Jan 15 2024 21:12:06 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Fix hungry-matching of "NODEx" @-code The 5th character must be a digit. Prevent future stupidity such as happened with recently added and then fixed NODE_USER @-code.

  596. Rob Swindell (on Windows 11)
    Mon Jan 15 2024 21:13:28 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    If socket is closed while in sess_sendbuf(), don't log a warning message ... with a socket descriptor value of -1.

  597. Rob Swindell (on Windows 11)
    Sun Jan 14 2024 20:10:15 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    Fix the recently-added NODE_USER @-code Since "NODE*" is a match for a node number status (ugh), and this comparison happened before the comparison for "NODE_USER", we'd never hit that condition. Thought I tested this before original commit, but I guess I did not. Oops.

  598. Rob Swindell (on Windows 11)
    Sun Jan 14 2024 19:26:46 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    src/sbbs3/logout.cpp diff
    src/sbbs3/postmsg.cpp diff
    src/sbbs3/putmsg.cpp diff
    src/sbbs3/readmail.cpp diff
    src/sbbs3/readmsgs.cpp diff
    src/sbbs3/sbbs.h diff
    src/sbbs3/str.cpp diff
    src/sbbs3/text.h diff
    src/sbbs3/textgen.c diff
    Don't expand @-codes automatically for all node messages/telegrams saved This recent enhancement (Commit b27bd426) introduced security and usability concerns. So I created (and am now using where requested) a wrapper for formatting text.dat/ini strings which will automaticlaly detect @-code encoded strings and expand/use them *only* (instead of printf %-specifiers). This might impact issue #696 since although unintentionally, it actually was possible to mix @-codes and %-specifier usage in certain (node status) text.dat/ini strings, but that should not be possible now. It's either/or: @-codes or %-specifiers, not both.

  599. Rob Swindell (on Windows 11)
    Fri Jan 12 2024 22:30:56 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/logon.cpp diff
    src/sbbs3/logout.cpp diff
    Allow @-codes in text.dat strings: NodeLoggedOnAtNbps and NodeLoggedOff Note: format specifiers (e.g. %s) cannot be combined with @-codes (use one or the other, not both). Fixes issue #696 If you need additional text strings to support @-codes, you'll have to specify them explicitly in feature request issues.

  600. Rob Swindell (on Windows 11)
    Fri Jan 12 2024 22:32:37 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/atcodes.cpp diff
    New @-code NODE_USER which will expand to UNKNOWN_USER if node is anonymous Needed for exactly reproducing built-in node status string formatting using @-codes (only).

  601. Rob Swindell (on Debian Linux)
    Fri Jan 12 2024 16:56:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ctrl/MainFormUnit.cpp diff
    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/main.cpp diff
    src/sbbs3/mqtt.c diff
    src/sbbs3/server.h diff
    src/sbbs3/services.c diff
    src/sbbs3/startup.h diff
    src/sbbs3/websrvr.c diff
    Check for shutdown and recycle semaphores even while clients are connected We have checks/loops/timeouts waiting for active clients to disconnect and child thread threads to terminate whenever shutting down or recycling already, so this should be safe. This pretty simple change fixes issue #236 (can't terminate server under heavy load). Also as part of this commit, introduced the ability to "pause" a server (prevent it from accepting new connections) with the ctrl/pause semaphore file or via the MQTT server/pause (and resume) topics. This feature is useful when debugging server issues where you don't necessarily want to fully shutdown/terminate the server, but don't want any new connections to be accepted (the listen backlog will fill up with incoming connections though). Unlike a server shutdown, a server pause can be "undone" via MQTT (by publishing a message to the "resume" topic). The "pause" semaphore file is just an "existence" semaphore file - its date/time stamp doesn't matter. If the file exists, the server will enter a paused state (and periodically log messages to that fact) until the semfile is deleted. This server pause feature is not the same as the pause button function in sbbsctrl, which just pauses server log output.

  602. Rob Swindell (on Debian Linux)
    Thu Jan 11 2024 00:31:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Another fix for the read() reutrn value FORTIFY warning that doesn't log an error

  603. Rob Swindell (on Debian Linux)
    Thu Jan 11 2024 00:32:51 GMT-0800 (PST)
    Modified Files:
    

    src/xpdev/semfile.c diff
    If semfile_check() is passed a NULL time_t*, just check for file existence In this case, we don't care what the time stamp on the file is.

  604. Rob Swindell (on Windows 11)
    Tue Jan 09 2024 11:47:30 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Fix MSLT and MSLD response for QWK packet filename in root directory Reusing the variable 'str' here for multiple purposes meant the QWK packet filename was overwritten by the owner name (the system's BBS-ID): ftp> mlsd 229 Entering Extended Passive Mode (|||2001|) 150 Opening ASCII mode data connection for MLSD. Type=file;Perm=r;UNIX.ownername=VERT; 00index Type=cdir;Perm=elc;UNIX.ownername=VERT; / Type=file;Perm=r;UNIX.ownername=VERT; VERT That last file there should have been "VERT.qwk"

  605. Rob Swindell (on Windows 11)
    Tue Jan 09 2024 11:53:13 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Use safe string copying in get_owner_name() via strlcpy()

  606. Rob Swindell (on Windows 11)
    Tue Jan 09 2024 17:04:53 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    Restore ftpalias.cfg support for MLSx commands Support was accidentally removed as part of commit 0d01544d, meaning the ftpalias.cfg wasn't used at all in responses to the MLSx commands as reported by Max (WESTLINE) using Total Commander, FileZilla and Directory opus. The traditional "LIST" commands still worked fine with ftpalias.cfg contents just fine. The reason this code was accidentally removed was due to the errant copy/pasted comparison with startup->html_index_file that did not belong here and made the block appear related to HTML index file generation. It was not. This was just a bug in the initial implementation of MLSx support in commit d4deb4b3. Also included in this commit: - Return the date/size of the user's QWK packet file, if it exists, in MLSx response. - send_mlsx_entry() won't report negative time_t values as file modify dates (flength returns -1 upon failure/file-not-found). - get_owner_name() returns the string, making it easier to use in function calls. There appears to still be some work to do to make the MLSx commands fully compliant with RFC 3659 (e.g. "mlst filename" from ftpalias.cfg should work but does not), but at least FileZilla displays ftpalias.cfg files and directories correctly now.

  607. Deucе
    Tue Jan 09 2024 09:17:52 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    Eliminate LOR introduced in previous commit. Since lock_ssl_cert() is a reader lock, there shouldn't be a whole lot of contention on aquiring it anyway, and we can thundering herd our way out of it when it clears.

  608. Deucе
    Tue Jan 09 2024 09:15:02 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ssl.c diff
    You can't just screw around with a pair of shared linked lists without locking! That's chaos!

  609. Eric Oulashin
    Mon Jan 08 2024 20:02:27 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    DDMR fix for indexed mode reading (not newscan): Showing the first unread message when selecting a sub-board, updating scan pointer, and selecting the next sub-board when done with the current sub-board

  610. Rob Swindell
    Mon Jan 08 2024 20:02:27 GMT-0800 (PST)
    Modified Files:
    

    xtrn/DDMsgReader/DDMsgReader.js diff
    xtrn/DDMsgReader/ddmr_cfg.js diff
    xtrn/DDMsgReader/readme.txt diff
    xtrn/DDMsgReader/revision_history.txt diff
    Merge branch 'ddmr_indexed_read_mode_first_unread_and_scan_ptr' into 'master' DDMR fix for indexed mode reading (not newscan): Showing the first unread message when selecting a sub-board, updating scan pointer, and selecting the next sub-board when done with the current sub-board See merge request main/sbbs!385

  611. Rob Swindell (on Windows 11)
    Sun Jan 07 2024 22:25:39 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/scfg/scfgnode.c diff
    The node_num isn's stored in the node.ini file, so no need to "fix it" This ancient bit of was re-writing node.ini files needlessly

  612. Rob Swindell (on Windows 11)
    Sun Jan 07 2024 20:45:05 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/ftpsrvr.c diff
    src/sbbs3/mailsrvr.c diff
    src/sbbs3/services.c diff
    Log critical error message if/when ssl_sync() fails

  613. Rob Swindell (on Windows 11)
    Sun Jan 07 2024 20:45:40 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/sbbsecho.c diff
    Expand sole-LFs in message text (shouldn't normally be there) Expanded to CRLF or just CR (if strip LFs is enabled). It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.

  614. Rob Swindell (on Windows 11)
    Sun Jan 07 2024 19:19:01 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/websrvr.c diff
    Log an error if ssl_sync() fails, for W6RAY Hopefully help debug why HTTPS isn't working for him

  615. Rob Swindell (on Debian Linux)
    Fri Jan 05 2024 19:13:34 GMT-0800 (PST)
    Modified Files:
    

    exec/newslink.js diff
    Do not log "0 areas" area.length is an object, not an array, so it's length will always be 0

  616. Rob Swindell (on Debian Linux)
    Fri Jan 05 2024 18:46:53 GMT-0800 (PST)
    Modified Files:
    

    exec/newslink.js diff
    Increase the connect timeout from 10 seconds (the default) to 30 seconds Should probably make this a command-line option too, but this will do for now for Ragnarok to test eternal-september with.

  617. Rob Swindell (on Windows 11)
    Thu Jan 04 2024 19:17:54 GMT-0800 (PST)
    Modified Files:
    

    src/sbbs3/main.cpp diff
    Don't log an error if there's QWKnet sub pointer value to be read This partially reverts commit 44c3350f where a bunch of read() and write() return value checking was added.

AuthorCommitsLatest
Nigel Reed3Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
Rob Swindell177Sat Feb 24 2024 02:33:07 GMT-0800 (PST)
Deuce7Fri Feb 23 2024 21:57:58 GMT-0800 (PST)
Deucе409Thu Feb 22 2024 20:57:09 GMT-0800 (PST)
Eric Oulashin21Sat Feb 17 2024 21:50:33 GMT-0800 (PST)

For older commits (in CVS), click here

Dynamically generated in 1769 milliseconds